Commit graph

9556 commits

Author SHA1 Message Date
moneromooo-monero
a67c634f89
blockchain: fix timestamp/difficulty cache getting out of sync
The cache is discarded when a block is popped, but then gets
rebuilt when the difficulty for next block is requested.
While this is all properly locked, it does not take into account
the delay caused by a database transaction being only committed
(and thus its effects made visible to other threads) later on,
which means another thread could request difficulty between
the pop and the commit, which would end up using stale database
view to build the cache, but that cache would not be invalidated
again when the transaction gets committed, which would cause the
cache to not match the new database data.

To fix this, we now keep track of when the cache is invalidated
so we can invalidate it again upon database transaction commit
to ensure it gets calculated again with fresh data next time it
is nedeed.
2020-06-13 15:42:09 +00:00
luigi1111
25419b4bfb
Merge pull request
f50a6c5 version: update name (selsta)
2020-05-21 12:47:48 -05:00
selsta
f50a6c5aed
version: update name 2020-05-21 19:41:04 +02:00
luigi1111
cf4add7899
Merge pull request
ada8172 rpc: lock access to the rpc payment object (moneromooo-monero)
2020-05-21 11:54:52 -05:00
luigi1111
e28d291330
Merge pull request
0d92fe5 rpc: add a sanity limit to a few RPC in restricted mode (moneromooo-monero)
2020-05-21 03:07:04 -05:00
luigi1111
4f6dbcd00e
Merge pull request
438b846 ByteSlice: Fix persisting ptr to std::moved SSO buffer (Doy-lee)
2020-05-21 03:06:15 -05:00
luigi1111
062cf63959
Merge pull request
99d702e cryptonote_core: remove 'We are most likely forked' message (moneromooo-monero)
2020-05-21 03:05:16 -05:00
luigi1111
343acd3025
Merge pull request
c5c8592 [release-v0.16] MMS: New 'config_checksum' subcommand (rbrunner7)
2020-05-21 03:03:45 -05:00
moneromooo-monero
0d92fe5234
rpc: add a sanity limit to a few RPC in restricted mode 2020-05-20 19:18:02 +00:00
moneromooo-monero
ada8172b46
rpc: lock access to the rpc payment object 2020-05-20 18:43:24 +00:00
rbrunner7
c5c85925e2 [release-v0.16] MMS: New 'config_checksum' subcommand 2020-05-20 12:05:21 +02:00
Doyle
438b84690e ByteSlice: Fix persisting ptr to std::moved SSO buffer
The Bug:
1. Construct `byte_slice.portion_` with `epee::span(buffer)` which copies a pointer to the SSO buffer to `byte_slice.portion_`
2. It constructs `byte_slice.storage_` with `std::move(buffer)` (normally this swap pointers, but SSO means a memcpy and clear on the original SSO buffer)
3. `slice.data()` returns a pointer from `slice.portion_` that points to the original SSO cleared buffer, `slice.storage_` has the actual string.
2020-05-20 10:21:21 +10:00
luigi1111
eed8a4e8a6
Merge pull request
f01d529 cryptonote_protocol: reject requests/notifications before handshake (moneromooo-monero)
bbab044 cryptonote_protocol: stricter limit to number of objects requested (moneromooo-monero)
2020-05-19 17:51:03 -05:00
luigi1111
b82af557f5
Merge pull request
cef39dc protocol: move the 'peer claims higher version' warning to debug (moneromooo-monero)
2020-05-19 17:38:34 -05:00
luigi1111
0161cb79a1
Merge pull request
705c78b wallet2: fix multisig data clearing stomping on a vector (moneromooo-monero)
2020-05-19 17:36:58 -05:00
luigi1111
f28026b86f
Merge pull request
4291344 serialization: fix bad rapidjson api usage (moneromooo-monero)
2020-05-19 17:34:17 -05:00
luigi1111
cb75003642
Merge pull request
bb4d95c blockchain: detect and log bad difficulty calculations (moneromooo-monero)
2020-05-19 17:30:37 -05:00
luigi1111
8fb0d7e0b4
Merge pull request
44e3782 protocol: don't drop a connection if we can't get a compatible chain (moneromooo-monero)
2020-05-19 17:29:46 -05:00
luigi1111
3578ce9fb6
Merge pull request
4a9c3a Revert 'simplewallet: noob-friendly help menu' (selsta)
7633ba0 simplewallet: help_advanced -> help (selsta)
2020-05-19 17:26:28 -05:00
luigi1111
f8642bf95c
Merge pull request
7209db8 epee: use memwipe rather than memset for md5 secrets (moneromooo-monero)
2020-05-19 17:13:24 -05:00
luigi1111
da04c5fb48
Merge pull request
f35ced6 build: fix boost 1.73 compatibility (selsta)
2020-05-19 17:11:05 -05:00
luigi1111
278f78e877
Merge pull request
f526977 easylogging++: sanitize log payload (moneromooo-monero)
2020-05-19 17:08:15 -05:00
moneromooo-monero
99d702e28b
cryptonote_core: remove "We are most likely forked" message
It's time based and we don't have forks every 6 months anymore
2020-05-19 16:27:38 +00:00
moneromooo-monero
cef39dc313
protocol: move the "peer claims higher version" warning to debug
Because there's a neverending supply of cunts claiming a wrong
version just to say "look at me" I guess
2020-05-19 16:15:08 +00:00
moneromooo-monero
705c78b797
wallet2: fix multisig data clearing stomping on a vector 2020-05-19 12:24:50 +00:00
moneromooo-monero
4291344f80
serialization: fix bad rapidjson api usage 2020-05-19 12:23:03 +00:00
moneromooo-monero
bbab044c92
cryptonote_protocol: stricter limit to number of objects requested
Reported by xnbya
2020-05-19 10:34:05 +00:00
moneromooo-monero
f01d529bdb
cryptonote_protocol: reject requests/notifications before handshake
Reported by xnbya
2020-05-19 10:34:04 +00:00
moneromooo-monero
f52697729d
easylogging++: sanitize log payload
Some of it might be coming from untrusted sources

Reported by itsunixiknowthis
2020-05-19 10:31:51 +00:00
moneromooo-monero
bb4d95c98f
blockchain: detect and log bad difficulty calculations 2020-05-17 12:45:06 +00:00
moneromooo-monero
44e3782b4d
protocol: don't drop a connection if we can't get a compatible chain
This can now happen if:
- we have a pruned db
- we have not connected to the monero network for a while
- we connect to a node
- that node asks us for history
- we only have a pruned version of the most recent common block

In that case, it's better to not reply but keep the connection alive,
so we can sync off it.
2020-05-16 20:25:29 +00:00
selsta
7633ba059c
simplewallet: help_advanced -> help 2020-05-16 21:27:19 +02:00
selsta
4a9c3aca03
Revert "simplewallet: noob-friendly help menu"
This reverts commit 67b4a19edf.
2020-05-16 21:26:11 +02:00
moneromooo-monero
7209db839c
epee: use memwipe rather than memset for md5 secrets
That's used by HTTP auth now
2020-05-16 18:14:58 +00:00
luigi1111
4987161fa6
Merge pull request
1b48f32 simplewallet: don't complain about incoming payment ids on change (moneromooo-monero)
2020-05-14 16:12:43 -05:00
luigi1111
a67a9fc9c4
Merge pull request
cc40ce1 Fixed bugs for take_slice and byte_stream->byte_slice (vtnerd)
2020-05-14 16:10:59 -05:00
luigi1111
87490c541f
Merge pull request
ab44293 trezor: add new firmware version support (ph4r05)
2020-05-14 16:09:56 -05:00
luigi1111
a763ea7cf8
Merge pull request
82afc5f [release-v0.16]: Update gitian yml files (iDunk5400)
2020-05-14 16:08:54 -05:00
selsta
f35ced6d7f
build: fix boost 1.73 compatibility 2020-05-14 22:57:53 +02:00
moneromooo-monero
1b48f325b8
simplewallet: don't complain about incoming payment ids on change 2020-05-13 23:29:10 +00:00
Lee Clagett
cc40ce1b3f Fixed bugs for take_slice and byte_stream->byte_slice 2020-05-12 19:07:41 -04:00
Dusan Klinec
ab4429346d
trezor: add new firmware version support 2020-05-12 16:31:36 +02:00
iDunk5400
82afc5ff13
[release-v0.16]: Update gitian yml files 2020-05-12 12:34:12 +02:00
luigi1111
309211fd6a
Merge pull request
08a45c5 build: prepare v0.16.0.0 release (selsta)
2020-05-11 16:27:21 -05:00
selsta
08a45c51a0
build: prepare v0.16.0.0 release 2020-05-09 15:23:37 +02:00
luigi1111
77a008f714
Merge pull request
70609d7 cryptonote_core: take out the time based upgrade warning (moneromooo-monero)
2020-05-07 10:44:34 -05:00
luigi1111
4c2f78aeeb
Merge pull request
42e1484 wallet2: fix keys file deserialization exception handling (xiphon)
2020-05-07 10:43:05 -05:00
moneromooo-monero
70609d7681
cryptonote_core: take out the time based upgrade warning
It doesn't really work anymore since we don't have a fork soon
2020-05-06 18:27:23 +00:00
luigi1111
dbba6004f5
Merge pull request
f80ab3e cryptonote_protocol: do not request pruned borromean sig txes (moneromooo-monero)
2020-05-06 12:22:28 -05:00
moneromooo-monero
f80ab3edde
cryptonote_protocol: do not request pruned borromean sig txes
We don't have a function to calculate their weight from a pruned
version (yet).
2020-05-06 12:44:00 +00:00