monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-11-17 16:27:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
8083 commits 9 branches 69 tags 308 MiB
Commit graph

5688 commits

Author SHA1 Message Date
moneromooo-monero
c7c74cafec
simplewallet: mark confirm-missing-payment-id as obsolete 2019-02-14 09:21:22 +00:00
Dusan Klinec
a3973fc95f debug compilation fix: net lib missing common deps 
```
Undefined symbols for architecture x86_64:
  "common_category()", referenced from:
      make_error_code(common_error) in parse.cpp.o
      make_error_code(common_error) in tor_address.cpp.o
  "boost::system::detail::system_category_ncx()", referenced from:
      boost::system::system_category() in parse.cpp.o
      boost::system::system_category() in socks.cpp.o
      boost::system::system_category() in libepee.a(net_utils_base.cpp.o)
  "boost::system::detail::generic_category_ncx()", referenced from:
      boost::system::generic_category() in parse.cpp.o
      boost::system::generic_category() in socks.cpp.o
      boost::system::generic_category() in tor_address.cpp.o
      boost::system::generic_category() in libepee.a(string_tools.cpp.o)
      boost::system::generic_category() in libepee.a(net_utils_base.cpp.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [src/net/libnet.dylib] Error 1
make[2]: *** [src/net/CMakeFiles/net.dir/all] Error 2
```
 2019-02-13 23:37:46 +01:00
Doyle
d2c95ab941 Don't decrypt keys in view only wallets in wallet_keys_unlocker 2019-02-13 15:36:49 +11:00
italocoin
de32dcea1d Human readable message if maximum outputs reached 2019-02-10 09:51:20 -05:00
cslashm
2dbc487ec0 Add support for V10 protocol with BulletProofV2 and short amount. 2019-02-08 17:02:55 +01:00
cslashm
63cc02c08d Fix dummy decryption in debug mode 2019-02-08 17:02:55 +01:00
cslashm
f0e55cebf7 fix log namespace 2019-02-08 17:02:55 +01:00
cslashm
460da140ec New scheme key destination contrfol 
Implies protocol version management.
 2019-02-08 17:02:44 +01:00
moneromooo-monero
49b2a48a46
simplewallet: tell the user to complain to the recipient 
for long payment ids
 2019-02-03 10:34:07 +00:00
moneromooo-monero
529645014c
ringct: fix v1 ecdhInfo serialization 
The change made for v2 broke v1, and we have no way to know which
version we're serializing here. However, since we don't actually
care about space savings in this case, we continue serialiazing
both mask and amount.
 2019-02-03 10:33:10 +00:00
moneromooo-monero
2456945408
epee: add SSL support 
RPC connections now have optional tranparent SSL.

An optional private key and certificate file can be passed,
using the --{rpc,daemon}-ssl-private-key and
--{rpc,daemon}-ssl-certificate options. Those have as
argument a path to a PEM format private private key and
certificate, respectively.
If not given, a temporary self signed certificate will be used.

SSL can be enabled or disabled using --{rpc}-ssl, which
accepts autodetect (default), disabled or enabled.

Access can be restricted to particular certificates using the
--rpc-ssl-allowed-certificates, which takes a list of
paths to PEM encoded certificates. This can allow a wallet to
connect to only the daemon they think they're connected to,
by forcing SSL and listing the paths to the known good
certificates.

To generate long term certificates:

openssl genrsa -out /tmp/KEY 4096
openssl req -new -key /tmp/KEY -out /tmp/REQ
openssl x509 -req -days 999999 -sha256 -in /tmp/REQ -signkey /tmp/KEY -out /tmp/CERT

/tmp/KEY is the private key, and /tmp/CERT is the certificate,
both in PEM format. /tmp/REQ can be removed. Adjust the last
command to set expiration date, etc, as needed. It doesn't
make a whole lot of sense for monero anyway, since most servers
will run with one time temporary self signed certificates anyway.

SSL support is transparent, so all communication is done on the
existing ports, with SSL autodetection. This means you can start
using an SSL daemon now, but you should not enforce SSL yet or
nothing will talk to you.
 2019-02-02 20:05:33 +00:00
moneromooo-monero
45b7df703b
wallet_rpc_server: remove detached short payment ids support 2019-02-02 18:53:14 +00:00
Tom Smeding
fec359a641 cryptonote: Fix enum check in expand_transaction_2 
This was noticed because GCC warned about using an enum value in a
boolean context.
 2019-02-01 16:44:58 +01:00
Tom Smeding
9bf0e53751 cryptonote: Add const-qualifier on comparison functor 
The original code did not compile with GCC 8.2.1 in C++17 mode, since
comparison functions for std::set's must be invocable as const.
 2019-02-01 16:44:56 +01:00
Tom Smeding
5d2fdc2e8c serialization: Use pos_type instead of streampos 
According to [1], the ios_base::streampos member type is deprecated, and
removed in C++17. This type was an alias for pos_type, which this commit
uses instead.

[1]: https://en.cppreference.com/w/cpp/io/ios_base
 2019-02-01 16:44:55 +01:00
moneromooo-monero
6a3608d3d2
cryptonote_protocol_handler: pad tx messages when using tor/i2p 2019-01-30 23:17:45 +00:00
Jethro Grassie
123fc2a25a
i2p: initial support 2019-01-30 13:37:45 -05:00
moneromooo-monero
1c9d5285d1
blockchain_prune: don't prune before v10 
This uses system time since it doesn't see the p2p network,
so is not 100% accurate
 2019-01-30 16:32:14 +00:00
Riccardo Spagni
31bdf7bd11
Merge pull request #4988 
973403bc Adding initial support for broadcasting transactions over Tor (Lee Clagett)
 2019-01-29 16:47:17 +02:00
Riccardo Spagni
227bf1407e
Merge pull request #5104 
dc0b86ab block_queue: fix late sanity check off by one (moneromooo-monero)
 2019-01-29 16:45:47 +02:00
Lee Clagett
973403bc9f Adding initial support for broadcasting transactions over Tor 
- Support for ".onion" in --add-exclusive-node and --add-peer
  - Add --anonymizing-proxy for outbound Tor connections
  - Add --anonymous-inbounds for inbound Tor connections
  - Support for sharing ".onion" addresses over Tor connections
  - Support for broadcasting transactions received over RPC exclusively
    over Tor (else broadcast over public IP when Tor not enabled).
 2019-01-28 23:56:33 +00:00
moneromooo-monero
dc0b86ab4b
block_queue: fix late sanity check off by one 2019-01-28 22:17:43 +00:00
Riccardo Spagni
1e5cd3b35a
Merge pull request #5062 
acfff8d0 rpc: fix internal daemon calls in restricted rpc getting partial data (moneromooo-monero)
 2019-01-28 21:40:11 +02:00
Riccardo Spagni
40bb66cc1e
Merge pull request #5053 
23813c71 blockchain: add --reorg-notify (moneromooo-monero)
f6db59b0 notify: handle arbitrary tags (moneromooo-monero)
ff959216 notify: warn if the spec contains one of '"\ (moneromooo-monero)
13852678 common: set MONERO_DEFAULT_LOG_CATEGORY for notify and spawn (moneromooo-monero)
 2019-01-28 21:35:46 +02:00
moneromooo-monero
acfff8d0ce
rpc: fix internal daemon calls in restricted rpc getting partial data 2019-01-28 19:35:20 +00:00
Riccardo Spagni
23c7663167
Merge pull request #5080 
d294a577 daemon: extend 'print_pl' command, optional filter by type and limit (xiphon)
 2019-01-28 21:34:17 +02:00
Riccardo Spagni
c07c907114
Merge pull request #5074 
b8c5f550 wallet api: don't truncate address in subaddress_account (selsta)
 2019-01-28 21:33:33 +02:00
moneromooo-monero
23813c7160
blockchain: add --reorg-notify 
This will trigger if a reorg is seen. This may be used to do things
like stop automated withdrawals on large reorgs.

%s is replaced by the height at the split point
%h is replaced by the height of the new chain
%n is replaced by the number of new blocks after the reorg
 2019-01-28 19:32:31 +00:00
moneromooo-monero
f6db59b011
notify: handle arbitrary tags 2019-01-28 19:32:28 +00:00
moneromooo-monero
ff95921668
notify: warn if the spec contains one of '"\ 
These aren't processed as a shell does, so this may surprise users
 2019-01-28 19:32:25 +00:00
moneromooo-monero
13852678e1
common: set MONERO_DEFAULT_LOG_CATEGORY for notify and spawn 2019-01-28 19:32:22 +00:00
Riccardo Spagni
4f104a0dc3
Merge pull request #5069 
2112060d wallet2: fix duplicate tx notifications for pool txes (moneromooo-monero)
 2019-01-28 21:32:14 +02:00
Riccardo Spagni
b7719022fd
Merge pull request #5068 
96e35506 wallet2: fix incorrect patch for determining fork rules (moneromooo-monero)
 2019-01-28 21:31:47 +02:00
Riccardo Spagni
f2ca4e3205
Merge pull request #5063 
11227e0b mnemonics: compare canonical words (lowercase) (moneromooo-monero)
 2019-01-28 21:30:26 +02:00
Riccardo Spagni
756ed760f7
Merge pull request #5056 
8258a9e7 wallet: do not check txpool in background mode (moneromooo-monero)
 2019-01-28 21:27:34 +02:00
Riccardo Spagni
77e96d0948
Merge pull request #5055 
6c060e6a device: proper handling of user input (selsta)
 2019-01-28 21:27:10 +02:00
Riccardo Spagni
0c970fde1c
Merge pull request #5054 
93c21644 device_ledger: remove full_name variable (selsta)
 2019-01-28 21:26:44 +02:00
Riccardo Spagni
0daa00e035
Merge pull request #5052 
b6534c40 ringct: remove unused senderPk from ecdhTuple (moneromooo-monero)
7d375981 ringct: the commitment mask is now deterministic (moneromooo-monero)
99d946e6 ringct: encode 8 byte amount, saving 24 bytes per output (moneromooo-monero)
cdc3ccec ringct: save 3 bytes on bulletproof size (moneromooo-monero)
f931e16c add a bulletproof version, new bulletproof type, and rct config (moneromooo-monero)
 2019-01-28 21:24:55 +02:00
moneromooo-monero
1eef056588
performance_tests: better stats, and keep track of timing history 2019-01-28 15:45:37 +00:00
moneromooo-monero
eec792764d
blockchain: fix default genesis block timestamp 2019-01-26 21:39:00 +00:00
moneromooo-monero
b6534c40e6
ringct: remove unused senderPk from ecdhTuple 
This was an early ringct field, which was never used in production
 2019-01-22 23:17:42 +00:00
moneromooo-monero
7d37598158
ringct: the commitment mask is now deterministic 
saves space in the tx and is safe

Found by knaccc
 2019-01-22 23:17:39 +00:00
moneromooo-monero
99d946e619
ringct: encode 8 byte amount, saving 24 bytes per output 
Found by knaccc
 2019-01-22 23:17:31 +00:00
moneromooo-monero
cdc3ccec5f
ringct: save 3 bytes on bulletproof size 
Found by luigi1111
 2019-01-22 23:17:27 +00:00
moneromooo-monero
f931e16c6e
add a bulletproof version, new bulletproof type, and rct config 
This makes it easier to modify the bulletproof format
 2019-01-22 23:17:24 +00:00
moneromooo-monero
b750fb27b0
Pruning 
The blockchain prunes seven eighths of prunable tx data.
This saves about two thirds of the blockchain size, while
keeping the node useful as a sync source for an eighth
of the blockchain.

No other data is currently pruned.

There are three ways to prune a blockchain:

- run monerod with --prune-blockchain
- run "prune_blockchain" in the monerod console
- run the monero-blockchain-prune utility

The first two will prune in place. Due to how LMDB works, this
will not reduce the blockchain size on disk. Instead, it will
mark parts of the file as free, so that future data will use
that free space, causing the file to not grow until free space
grows scarce.

The third way will create a second database, a pruned copy of
the original one. Since this is a new file, this one will be
smaller than the original one.

Once the database is pruned, it will stay pruned as it syncs.
That is, there is no need to use --prune-blockchain again, etc.
 2019-01-22 20:30:51 +00:00
moneromooo-monero
9d58749b85
wallet2: fix hashchain going out of sync on refresh error 2019-01-19 16:47:13 +00:00
moneromooo-monero
1bc5f9fa4b
bulletproofs: speed up vector_power_sum 
found by sarang
 2019-01-19 00:18:34 +00:00
moneromooo-monero
d78addcbc0
db_lmdb: don't unnecessarily cast to double on the way to uint64_t 2019-01-19 00:03:04 +00:00
Riccardo Spagni
4e72384318
Merge pull request #5008 
c6d38718 core: include a dummy encrypted payment id when no payment is used (moneromooo-monero)
b7441c4a core, wallet: remember original text version of destination address (moneromooo-monero)
a9b1c04a crptonote_core: do not error out sending unparsable extra field (moneromooo-monero)
 2019-01-18 19:12:58 +02:00
Riccardo Spagni
5753d71922
Merge pull request #5050 
07cb574c ringct: remove duplicate rv.mixRing = mixRing; in genRctSimple (stoffu)
 2019-01-18 19:02:01 +02:00
Riccardo Spagni
8ba36cf6d4
Merge pull request #5049 
0a29660f message_store: init me field (moneromooo-monero)
 2019-01-18 19:01:23 +02:00
Riccardo Spagni
416b6719bd
Merge pull request #5047 
584126d1 i18n: filter LANG/LC_LANG for valid characters, and handle @ (moneromooo-monero)
 2019-01-18 19:01:02 +02:00
Riccardo Spagni
54eb3318e2
Merge pull request #5048 
a67b77a9 blockchain: don't propagate exception past dtor (moneromooo-monero)
 2019-01-18 19:00:47 +02:00
moneromooo-monero
c6d387184e
core: include a dummy encrypted payment id when no payment is used 
For better transaction uniformity, even though this wastes space.
 2019-01-18 16:58:50 +00:00
moneromooo-monero
b7441c4a32
core, wallet: remember original text version of destination address 2019-01-18 16:58:47 +00:00
moneromooo-monero
a9b1c04acf
crptonote_core: do not error out sending unparsable extra field 
extra is arbitrary, and the user may well want to send custom data
 2019-01-18 16:58:45 +00:00
Riccardo Spagni
13b12973d1
Merge pull request #5037 
51b0625e simplewallet: improve punctuation in user visible string (selsta)
 2019-01-18 09:25:59 +02:00
Riccardo Spagni
aa5b0c7f71
Merge pull request #5028 
464097e5 blockchain_ancestry: allow getting ancestry of a single output (moneromooo-monero)
a6216d1a blockchain_db: allow getting output keys without commitment (moneromooo-monero)
 2019-01-18 09:25:34 +02:00
Riccardo Spagni
f3368acef5
Merge pull request #5020 
1ef79b43 simplewallet: disable long payment ids by default (moneromooo-monero)
 2019-01-18 09:25:18 +02:00
Riccardo Spagni
3c80562861
Merge pull request #5014 
0debe7d7 wallet2: remember which output keys map to which key images (moneromooo-monero)
 2019-01-18 09:24:19 +02:00
Riccardo Spagni
4fb9cfa017
Merge pull request #4971 
15904610 simplewallet: remove extra colon in a few calls to input_secure_line (stoffu)
247dab73 simplewallet: avoid conversion to string in input_secure_line (stoffu)
bf9ef7ad simplewallet: factor yesno hint into input_line (stoffu)
 2019-01-18 09:23:03 +02:00
xiphon
d294a577fa daemon: extend 'print_pl' command, optional filter by type and limit 2019-01-18 01:32:18 +00:00
stoffu
1717e63551
simplewallet: fix help text of rescan_bc to mention the "hard" option 2019-01-18 09:51:44 +09:00
stoffu
1590461005
simplewallet: remove extra colon in a few calls to input_secure_line 2019-01-18 09:48:54 +09:00
stoffu
247dab7304
simplewallet: avoid conversion to string in input_secure_line 2019-01-18 09:48:52 +09:00
stoffu
bf9ef7adb6
simplewallet: factor yesno hint into input_line 2019-01-18 09:48:48 +09:00
moneromooo-monero
464097e592
blockchain_ancestry: allow getting ancestry of a single output 
This involved a reorg of the code, to factor and speedup some bits,
as well as using the cache for all modes, and making both modes
usable in the same run.
 2019-01-16 20:13:12 +00:00
moneromooo-monero
a6216d1ac2
blockchain_db: allow getting output keys without commitment 
Since the commitment has to be calculated for non rct outputs,
it slows down a lot unnecessarily if we don't need it
 2019-01-16 20:13:08 +00:00
moneromooo-monero
1ef79b430f
simplewallet: disable long payment ids by default 
unless --long-payment-id-support is used
 2019-01-16 20:06:04 +00:00
moneromooo-monero
0debe7d7d3
wallet2: remember which output keys map to which key images 
This allows filling in transfer_details when a cold signed tx
gets seen in a block next
 2019-01-16 19:58:13 +00:00
selsta
51b0625e00 simplewallet: improve punctuation in user visible string 2019-01-16 20:45:39 +01:00
Riccardo Spagni
6285c43ffc
Merge pull request #5042 
c1081091 simplewallet: Show new address after going multisig (rbrunner7)
 2019-01-16 21:42:17 +02:00
Riccardo Spagni
8e4c0de46a
Merge pull request #5035 
53fcd159 simplewallet: don't subtract 1 to estimate blockchain height (moneromooo-monero)
 2019-01-16 21:40:56 +02:00
Riccardo Spagni
c84d559fb1
Merge pull request #5034 
13785ec9 wallet api/device: set estimated restore height if none is provided (selsta)
 2019-01-16 21:40:20 +02:00
Riccardo Spagni
dc726f4b3b
Merge pull request #5032 
5ee6f037 blockchain: fix wrong hf version when popping multiple blocks (moneromooo-monero)
634d359a blockchain: use the version passed as parameter, not a new one (moneromooo-monero)
94a375d5 hardfork: remove batch transactions setup (moneromooo-monero)
 2019-01-16 21:40:06 +02:00
Riccardo Spagni
e59813c3d7
Merge pull request #5029 
d1b3990d p2p: don't stop the idle thread when no gray peers are found (moneromooo-monero)
 2019-01-16 21:39:19 +02:00
Riccardo Spagni
3eb96fa512
Merge pull request #5027 
9092fc4b wallet: do not display daemon controlled text if untrusted (moneromooo-monero)
 2019-01-16 21:38:15 +02:00
Riccardo Spagni
17878369f9
Merge pull request #5019 
65ce387c daemon: add a +hex option to print_block (moneromooo-monero)
 2019-01-16 21:36:08 +02:00
Riccardo Spagni
46fcae717a
Merge pull request #5018 
8bd71677 simplewallet: remove ability to transfer with detached short payment ids (moneromooo-monero)
 2019-01-16 21:35:48 +02:00
Riccardo Spagni
a80978e699
Merge pull request #5015 
6f2081f8 cryptonote_core: revert extra_tx_map (moneromooo-monero)
 2019-01-16 21:32:14 +02:00
Riccardo Spagni
00090aae7f
Merge pull request #5012 
d7354c78 wallet_rpc_server: add all field to export_key_images (moneromooo-monero)
 2019-01-16 21:31:40 +02:00
Riccardo Spagni
f8a10bcc07
Merge pull request #5009 
5e10dee3 simplewallet: fix show_transfers colouring, and add red for failed (moneromooo-monero)
 2019-01-16 21:30:52 +02:00
Riccardo Spagni
0673ed54cf
Merge pull request #5006 
7c58421c blockchain_blackball: make log file name consistent with executable (stoffu)
 2019-01-16 19:29:29 +02:00
Riccardo Spagni
e0c107ee51
Merge pull request #5004 
de9dcdd1 wallet2: finalize_multisig now rejects non N-1/N multisig wallets (moneromooo-monero)
 2019-01-16 19:28:51 +02:00
Riccardo Spagni
3e9bb9626a
Merge pull request #5001 
a5ffc2d5 Remove boost::lexical_cast for uuid and unused uuid function (Lee Clagett)
 2019-01-16 19:27:13 +02:00
Riccardo Spagni
8e04070d9d
Merge pull request #4995 
99765b21 Remove unused hash in export_key_images (doy-lee)
 2019-01-16 19:08:48 +02:00
Riccardo Spagni
47213e2519
Merge pull request #4994 
c5e0539c device/trezor: store tx_prefix_hash in tx key aux (Dusan Klinec)
 2019-01-16 19:08:13 +02:00
Riccardo Spagni
1f71bfc8d0
Merge pull request #4993 
b8342dd5 blockchain: fix block rate check for empty blockchains (moneromooo-monero)
 2019-01-16 19:07:55 +02:00
Riccardo Spagni
538043bdcd
Merge pull request #4987 
841a6acd wallet2: fix accessing unwound stack on exception (moneromooo-monero)
 2019-01-16 19:07:13 +02:00
Riccardo Spagni
8bfce660a5
Merge pull request #4986 
d24c325c daemon: print human friendly timestamp too (moneromooo-monero)
 2019-01-16 19:06:53 +02:00
Riccardo Spagni
63b5c933ef
Merge pull request #4985 
808a1f1e wallet2: cut down on the number of useless derivation threads (moneromooo-monero)
 2019-01-16 19:06:31 +02:00
Riccardo Spagni
9d57ee9ff6
Merge pull request #4984 
008647d7 blockchain_db: speedup tx output gathering (moneromooo-monero)
 2019-01-16 19:06:07 +02:00
Riccardo Spagni
cb996d15c5
Merge pull request #4981 
60b35c91 Add --restore-date param (Howard Chu)
 2019-01-16 19:05:31 +02:00
Riccardo Spagni
a193f1e236
Merge pull request #4980 
219548f2 Sync hashchain bug fixed (naughtyfox)
 2019-01-16 19:05:09 +02:00
Riccardo Spagni
b565115c84
Merge pull request #4979 
611db08a Wallet: Initialize members without default ctor. (Tadeas Moravec)
 2019-01-16 19:04:45 +02:00
Riccardo Spagni
846362842c
Merge pull request #4976 
85665003 epee: better network buffer data structure (moneromooo-monero)
 2019-01-16 19:04:22 +02:00
Riccardo Spagni
c07969d0d1
Merge pull request #4973 
aaafa8a9 ringct: avoid repeated point conversion (moneromooo-monero)
 2019-01-16 19:03:45 +02:00
selsta
b8c5f550c1
wallet api: don't truncate address in subaddress_account 
Same behaviour as subaddress.cpp now.
 2019-01-15 22:19:50 +01:00
moneromooo-monero
96e35506e9
wallet2: fix incorrect patch for determining fork rules 
Half of the patch was correct, but half was introducing another bug,
where a wallet asking for a fork that the daemon does not know about
yet would decide to use those rules.
 2019-01-13 14:48:16 +00:00
moneromooo-monero
2112060d03
wallet2: fix duplicate tx notifications for pool txes 2019-01-13 14:47:42 +00:00
moneromooo-monero
11227e0ba2
mnemonics: compare canonical words (lowercase) 2019-01-11 16:45:48 +00:00
selsta
6c060e6aaa
device: proper handling of user input 
(1) If the user denies something on the Ledger,
    a proper error message is now shown.
(2) Ledger doesn't time out anymore while waiting
    on user input.
(3) Lower the timeout to 2 seconds, this is enough for
    normal Ledger <-> System communication.
 2019-01-09 15:45:06 +01:00
moneromooo-monero
8258a9e7a9
wallet: do not check txpool in background mode 
This avoids the constant message about needed to run refresh
to enter a password.
Also mention the txpool when asking for the password if the
reason is a pool tx.
 2019-01-09 11:21:39 +00:00
selsta
93c2164434
device_ledger: remove full_name variable 
This variable was never set, resulting in the
device name always showing as "disconnected".
 2019-01-09 05:33:49 +01:00
moneromooo-monero
584126d15b
i18n: filter LANG/LC_LANG for valid characters, and handle @ 
If there are more valid characters, add them in, I did not find
an actual list.
 2019-01-08 16:03:30 +00:00
stoffu
07cb574ca4
ringct: remove duplicate rv.mixRing = mixRing; in genRctSimple 2019-01-08 11:51:35 +09:00
Riccardo Spagni
094b0c4d00
Merge pull request #5045 
050ee521 wallet_api: fix usage of LOG_ERROR (moneromooo-monero)
 2019-01-07 21:27:34 +02:00
Riccardo Spagni
4902b2ad3d
Merge pull request #5016 
434a147b blocks: fix checkpoint code generation on OpenBSD (moneromooo-monero)
 2019-01-07 21:27:14 +02:00
Riccardo Spagni
53fba1455c
Merge pull request #5007 
68f095f0 message_store: fix error message adding const char * with offset (moneromooo-monero)
 2019-01-07 21:26:52 +02:00
moneromooo-monero
0a29660f5c
message_store: init me field 
Coverity 190651
 2019-01-07 16:41:34 +00:00
moneromooo-monero
a67b77a9eb
blockchain: don't propagate exception past dtor 
Coverity 190660
 2019-01-07 16:32:50 +00:00
moneromooo-monero
050ee52162
wallet_api: fix usage of LOG_ERROR 2019-01-07 11:57:10 +00:00
moneroexamples
ec68cf822f Make get_output_key method const 
get_output_key method is commonly used when working with txs and their key images. Because the method is not const, passing blockchain object though const& or pointers to const is not possible in this context. This is especially problematic in external projects (e.g., projects in moneroexamples) that use monero C++ api to operate on the blockchain and txs.

Thus, having get_output_key method will simplify moving blockchain object around through const references and pointers to const objects.
 2019-01-07 05:53:14 +08:00
Riccardo Spagni
b67eb481a7
Merge pull request #4956 
2d7b0236 wallet2: clear all payments on soft rescan_bc (moneromooo-monero)
 2019-01-06 20:40:06 +02:00
Riccardo Spagni
be625a95af
Merge pull request #4954 
93c59b29 perf_timer: check allowed categories before logging (moneromooo-monero)
6a507dab perf_timer: add a way to get and reset the current time (moneromooo-monero)
c1581a5b perf_timer: only log to file (moneromooo-monero)
 2019-01-06 20:39:29 +02:00
Riccardo Spagni
577a8f5c84
Merge pull request #4952 
570dd369 p2p: use vector instead of list for peer lists (moneromooo-monero)
 2019-01-06 20:39:07 +02:00
Riccardo Spagni
13b006137c
Merge pull request #4949 
5464725a protocol: change standby mode to not wait sleeping (moneromooo-monero)
85807dfb add a once_a_time_milliseconds class (moneromooo-monero)
 2019-01-06 20:37:51 +02:00
Riccardo Spagni
ad1eb3338c
Merge pull request #4938 
a13eb0a1 epee: speed up string matching a bit (moneromooo-monero)
3a3858dc epee: avoid string allocation when parsing a pod from string (moneromooo-monero)
 2019-01-06 20:36:46 +02:00
rbrunner7
c108109102 simplewallet: Show new address after going multisig 2019-01-04 16:33:02 +01:00
selsta
13785ec96b
wallet api/device: set estimated restore height if none is provided 2019-01-02 11:25:49 +01:00
moneromooo-monero
53fcd15953
simplewallet: don't subtract 1 to estimate blockchain height 
in case it returns 0, and other uses don't, plus it's a estimation anyway.
 2019-01-02 00:55:19 +00:00
moneromooo-monero
5ee6f03742
blockchain: fix wrong hf version when popping multiple blocks 
Since we keep track of the hf version in the db, we pick it up
from there instead of doing the full reorg call, which is quite
expensive
 2019-01-01 18:28:01 +00:00
moneromooo-monero
634d359a84
blockchain: use the version passed as parameter, not a new one 2019-01-01 18:28:01 +00:00
moneromooo-monero
94a375d559
hardfork: remove batch transactions setup 
This is now default, so it spares us the warnings
 2019-01-01 18:28:01 +00:00
moneromooo-monero
5dc590cbdb
wallet2: speedup output tracking 
It can get heavy for large wallets
 2018-12-31 23:57:54 +00:00
moneromooo-monero
db3f2a91fa
wallet: optionally keep track of owned outputs uses 2018-12-31 23:57:51 +00:00
luigi1111
e344d93ce7
Merge pull request #4960 
b56b5b5 ignore child process when exec (jtgrassie)
 2018-12-31 16:32:12 -06:00
luigi1111
53760ee044
Merge pull request #4957 
0e2f5cb perf_timer: make all logs Info level (moneromooo-monero)
 2018-12-31 16:30:47 -06:00
luigi1111
1aaa82cb1a
Merge pull request #4955 
25e5a85 singleton: fix missing *this return value in operator= (monermooo-monero)
 2018-12-31 16:28:49 -06:00
luigi1111
61c0083105
Merge pull request #4953 
dbbb3ce cryptonote: don't serialize for blob size if already known (moneromooo-monero)
 2018-12-31 16:26:22 -06:00
luigi1111
a872a2a41a
Merge pull request #4948 
1d892ec simplewallet: donate command validate amount (selsta)
 2018-12-31 16:10:30 -06:00
luigi1111
69e8567c0e
Merge pull request #4946 
6644b9b blockchain_db: remove a couple unused functions (moneromooo-monero)
ce594f5 blockchain_db: allocate known size vector only once (moneromooo-monero)
8332698 db_lmdb: inline check_open, it's trivial and called everywhere (moneromooo-monero)
5511563 db_lmdb: avoid pointless division (moneromooo-monero)
d1efe3d cryptonote: set tx hash on newly parsed txes when known (moneromooo-monero)
9cc68a2 tx_pool: add a few std::move where it can make a difference (moneromooo-monero)
 2018-12-31 16:06:50 -06:00
luigi1111
9c2d671397
Merge pull request #4945 
e37154a build: protobuf dependency fixes, libusb build (ph4r05)
 2018-12-31 15:53:59 -06:00
luigi1111
6e4e228461
Merge pull request #4944 
1505dd3 util: set MONERO_DEFAULT_LOG_CATEGORY (moneromooo-monero)
db57374 util: use fcntl instead of flock, for compatibility (moneromooo-monero)
 2018-12-31 15:52:17 -06:00
luigi1111
c7af379d29
Merge pull request #4940 
9e64a71 blockchain: call deinit in dtor (moneromooo-monero)
 2018-12-31 15:44:49 -06:00
luigi1111
3adac4ee2b
Merge pull request #4929 
5a76933 Add glibc back compat code (TheCharlatan)
 2018-12-31 15:31:01 -06:00
luigi1111
6d3caaff70
Merge pull request #4928 
affff94 blockchain: fix race between two external mining threads (moneromooo-monero)
 2018-12-31 15:28:25 -06:00
luigi1111
a7ff63ec77
Merge pull request #4898 
e6f026e Simplewallet: Unify usage messages. (tmoravec)
 2018-12-31 15:15:46 -06:00
luigi1111
c93c638199
Merge pull request #4864 
707c2f8 Remove -Werror (moneromooo-monero)
 2018-12-31 15:13:59 -06:00
moneromooo-monero
d1b3990d40
p2p: don't stop the idle thread when no gray peers are found 2018-12-30 19:32:38 +00:00
moneromooo-monero
9092fc4bfd
wallet: do not display daemon controlled text if untrusted 2018-12-30 01:32:57 +00:00
moneromooo-monero
8bd716777e
simplewallet: remove ability to transfer with detached short payment ids 
It seemed like a good idea at the time
 2018-12-27 00:45:04 +00:00
moneromooo-monero
65ce387c93
daemon: add a +hex option to print_block 2018-12-26 17:55:28 +00:00
moneromooo-monero
d24c325c7d
daemon: print human friendly timestamp too 2018-12-26 14:01:18 +00:00
moneromooo-monero
434a147b57
blocks: fix checkpoint code generation on OpenBSD 
Its od outputs small decimals with leading 0, which means octal in C
 2018-12-25 19:11:39 +00:00
moneromooo-monero
6f2081f867
cryptonote_core: revert extra_tx_map 
While the lookups are faster, the zeroCommit calls have to be
done again when storing the new outputs in the db, which ends
up making the whole thing slower after all, and the ways this
can be cached aren't very nice code wise, so let's forget it
since the gains aren't very large anyway.
 2018-12-25 15:19:41 +00:00
moneromooo-monero
d7354c7864
wallet_rpc_server: add all field to export_key_images 
To use if you want all key images, not just the ones for
recently imported outputs
 2018-12-24 13:00:29 +00:00
Tadeas Moravec
e6f026e530
Simplewallet: Unify usage messages. 
Help messages describe the commands usage. When users run the command
with wrong arguments, it usually helpfully offers the usage, too.
Unfortunately, these two usage messages were duplicated in the code and
started to get out of sync.

Fixing with constant strings.
 2018-12-23 20:12:50 +00:00
moneromooo-monero
85665003a7
epee: better network buffer data structure 
avoids pointless allocs and memcpy
 2018-12-23 16:46:07 +00:00
moneromooo-monero
5e10dee3ea
simplewallet: fix show_transfers colouring, and add red for failed 
Also add the type back, as it was somehow weirdly split into
two different fields, one being a union...
 2018-12-23 15:15:55 +00:00
Lee Clagett
a5ffc2d5ad Remove boost::lexical_cast for uuid and unused uuid function 2018-12-23 11:11:30 +00:00
moneromooo-monero
68f095f059
message_store: fix error message adding const char * with offset 2018-12-22 15:52:10 +00:00
stoffu
7c58421c79
blockchain_blackball: make log file name consistent with executable 2018-12-22 14:46:35 +09:00
moneromooo-monero
de9dcdd179
wallet2: finalize_multisig now rejects non N-1/N multisig wallets 2018-12-21 23:41:16 +00:00
doy-lee
99765b218e Remove unused hash in export_key_images 2018-12-19 14:45:13 +11:00
Dusan Klinec
c5e0539cb5
device/trezor: store tx_prefix_hash in tx key aux 
- tx_prefix_hash is required in the key derivation for decryption of the tx keys
 2018-12-18 22:20:18 +01:00
moneromooo-monero
b8342dd52c
blockchain: fix block rate check for empty blockchains 2018-12-18 18:47:54 +00:00
Dusan Klinec
e37154a879
build: protobuf dependency fixes, libusb build 
- docker protobuf dependencies, cross-compilation
- device/trezor protobuf build fixes, try_compile
- libusb built under all platforms, used by trezor for direct connect
 2018-12-18 16:50:19 +01:00
moneromooo-monero
008647d7eb
blockchain_db: speedup tx output gathering 
We know all the data we'll want for getblocks.bin is contiguous
 2018-12-18 11:55:21 +00:00
moneromooo-monero
808a1f1e8a
wallet2: cut down on the number of useless derivation threads 2018-12-16 18:31:10 +00:00
moneromooo-monero
841a6acda2
wallet2: fix accessing unwound stack on exception 2018-12-16 18:30:02 +00:00
Howard Chu
60b35c91b9
Add --restore-date param 
Estimate restore height from given date
Check date format early, error out early if invalid
 2018-12-14 19:11:35 +00:00
naughtyfox
219548f299 Sync hashchain bug fixed 2018-12-14 17:42:11 +03:00
Tadeas Moravec
611db08a00
Wallet: Initialize members without default ctor. 
Found by Coverity (188336 in Anonimal's Coverity account).
 2018-12-14 13:45:41 +00:00
rbrunner7
1ebcd7b9b0 MMS (Multisig Messaging System): Initial version 2018-12-12 21:49:20 +01:00
moneromooo-monero
aaafa8a946
ringct: avoid repeated point conversion 2018-12-12 12:48:10 +00:00
Riccardo Spagni
6bc0c7e685
Merge pull request #4927 
6456cb41 Bulletproof: Initialize members in default construtor. (Tadeas Moravec)
 2018-12-12 12:01:31 +02:00
Riccardo Spagni
5e9225e637
Merge pull request #4925 
ab783b17 easylogging++: ensure logger is initialized before main (moneromooo-monero)
9b69a0ae daemon: print monero version at startup when calling a detached daemon (moneromooo-monero)
4d71d463 mlocker: remove early page size log (moneromooo-monero)
 2018-12-12 12:01:18 +02:00
Riccardo Spagni
51874e5a40
Merge pull request #4924 
0c5dd316 cryptonote: add a set_null for transaction_prefix (moneromooo-monero)
 2018-12-12 12:00:50 +02:00
Riccardo Spagni
fe3c8c9682
Merge pull request #4923 
aba9a9c2 daemon: stop miner before we bring the whole thing down (moneromooo-monero)
 2018-12-12 12:00:37 +02:00
Riccardo Spagni
e9aa886d9e
Merge pull request #4921 
ac665418 ringct: fix dummy bulletproofs on ledger in fake mode (moneromooo-monero)
 2018-12-12 11:59:56 +02:00
Riccardo Spagni
e19a205ff4
Merge pull request #4920 
e98ae34e core: fix adding new pre-hoh block when a tx is already in the pool (moneromooo-monero)
 2018-12-12 11:59:43 +02:00
Riccardo Spagni
83684ea515
Merge pull request #4909 
756684bb blockchain: avoid unnecessary DB lookups when syncing (moneromooo-monero)
 2018-12-12 11:59:25 +02:00
Riccardo Spagni
4556f0e2b8
Merge pull request #4908 
5ca4994c rpc: speed up the common get_output_distribution case while syncing (moneromooo-monero)
 2018-12-12 11:59:04 +02:00
Riccardo Spagni
0fccc78e39
Merge pull request #4903 
dc1c1252 add command pop_blocks (Jason Wong)
 2018-12-12 11:58:37 +02:00
Riccardo Spagni
d855f9bb92
Merge pull request #4901 
a48f2dab blockchain_prune_known_spent_data: blackball file is now optional (moneromooo-monero)
17b45725 Outputs where all amounts are known spent can now be pruned (moneromooo-monero)
 2018-12-12 11:57:31 +02:00
Riccardo Spagni
85262ca8cd
Merge pull request #4899 
2be31b4c blockchain_blackball: spot when all outputs of an amount are spent (moneromooo-monero)
 2018-12-12 11:56:21 +02:00
Riccardo Spagni
c73ac91af8
Merge pull request #4897 
9b5efad2 simplewallet: enable donation on testnet/stagenet for easier testing (stoffu)
 2018-12-12 11:55:13 +02:00
Riccardo Spagni
0b31baf6e4
Merge pull request #4839 
d71f89e2 device/trezor: device/trezor: correct device initialization, status check (Dusan Klinec)
65b9bca7 device/trezor: python2 compatibility - bundle dependencies (Dusan Klinec)
9cf636af device/trezor: ask for KI sync on first refresh (Dusan Klinec)
d21dad70 device: enable to use multiple independent device wallets (Dusan Klinec)
318cc784 device/trezor: passphrase entry on host (Dusan Klinec)
 2018-12-12 11:53:42 +02:00
Riccardo Spagni
dde1e69723
Merge pull request #4787 
3dba7f25 protocol: option to pad transaction relay to the next kB (moneromooo-monero)
 2018-12-12 11:53:10 +02:00
Jethro Grassie
b56b5b52eb
ignore child process when exec 2018-12-08 20:52:54 -05:00
moneromooo-monero
0e2f5cb5fc
perf_timer: make all logs Info level 
and make them not default at log level 1
 2018-12-08 10:53:09 +00:00
moneromooo-monero
2d7b0236eb
wallet2: clear all payments on soft rescan_bc 
They'll get duplicated otherwise
 2018-12-08 10:39:54 +00:00
moneromooo-monero
3a3858dc90
epee: avoid string allocation when parsing a pod from string 2018-12-08 02:00:34 +00:00
moneromooo-monero
25e5a8539c
singleton: fix missing *this return value in operator= 
while there, disable both operator= and copy ctor, since they
are not supposed to be around for a singleton
 2018-12-07 16:56:59 +00:00
moneromooo-monero
93c59b29a8
perf_timer: check allowed categories before logging 2018-12-07 14:23:47 +00:00
moneromooo-monero
6a507dab6f
perf_timer: add a way to get and reset the current time 2018-12-07 14:23:47 +00:00
moneromooo-monero
c1581a5bb8
perf_timer: only log to file 2018-12-07 14:23:47 +00:00
moneromooo-monero
dbbb3ce9d8
cryptonote: don't serialize for blob size if already known 2018-12-07 14:07:26 +00:00
moneromooo-monero
570dd3690e
p2p: use vector instead of list for peer lists 2018-12-07 13:20:34 +00:00
moneromooo-monero
5464725a29
protocol: change standby mode to not wait sleeping 2018-12-07 12:53:11 +00:00
selsta
1d892ec881
simplewallet: donate command validate amount 2018-12-07 13:43:21 +01:00
moneromooo-monero
db5737413e
util: use fcntl instead of flock, for compatibility 
in particular with NFS
 2018-12-06 12:59:29 +00:00
moneromooo-monero
9cc68a2f74
tx_pool: add a few std::move where it can make a difference 2018-12-05 21:13:37 +00:00
moneromooo-monero
d1efe3d91c
cryptonote: set tx hash on newly parsed txes when known 2018-12-05 21:13:29 +00:00
moneromooo-monero
5511563e92
db_lmdb: avoid pointless division 2018-12-05 21:13:24 +00:00
moneromooo-monero
833269834d
db_lmdb: inline check_open, it's trivial and called everywhere 2018-12-05 21:13:21 +00:00
moneromooo-monero
ce594f5af7
blockchain_db: allocate known size vector only once 2018-12-05 21:13:18 +00:00
moneromooo-monero
6644b9b7b7
blockchain_db: remove a couple unused functions 2018-12-05 21:13:13 +00:00
moneromooo-monero
1505dd38c9
util: set MONERO_DEFAULT_LOG_CATEGORY 
Otherwise it'd end up with whatever was included last
 2018-12-05 14:53:30 +00:00
moneromooo-monero
9e64a71e7d
blockchain: call deinit in dtor 
This ensures the io service that runs in another thread cannot
access data after it's deleted
 2018-12-05 00:13:28 +00:00
Dusan Klinec
d71f89e2a2
device/trezor: device/trezor: correct device initialization, status check 
- checks if the device is in the correct usable state
- implements check for the v2.0.9 firmware which does not support payment IDs
- simple transacttion check, payment id fmt consistency
- minor fixes, refactoring, webusb session counting fix
 2018-12-04 20:12:03 +01:00
Dusan Klinec
65b9bca70e
device/trezor: python2 compatibility - bundle dependencies 2018-12-04 18:38:18 +01:00
Dusan Klinec
9cf636af69
device/trezor: ask for KI sync on first refresh 
When doing a first refresh on HW-token based wallet KI sync is required if money were received. Received money may indicate wallet was already used before the restore I.e., some transaction could have been already sent from the wallet. The spent UTXO would not be detected as spent which could lead to double spending errors on submitting a new transaction.

Thus if the wallet is HW-token based with the cold signing protocol and the first refresh detected received money the user is asked to perform the key image sync.
 2018-12-04 18:38:17 +01:00
Dusan Klinec
d21dad70dd
device: enable to use multiple independent device wallets 
- adds a new option `--hw-device-deriv-path` to the simple wallet. Enables to specify wallet derivation path / wallet code (path avoided so it can be misinterpreted as a file path).
- devices can use different derivation mechanisms. Trezor uses standard SLIP-10 mechanism with fixed SLIP-44 prefix for Monero
- Trezor: when empty, the default derivation mechanism is used with 44'/128'/0'. When entered the derivation path is 44'/128'/PATH.
- Trezor: the path is always taken as elements are hardened (1<<31 bit turned on)
 2018-12-04 18:38:16 +01:00
Riccardo Spagni
7e957c162a
Merge pull request #4879 
243f010e rpc: mask values that are nobody else's business in restricted RPC (moneromooo-monero)
 2018-12-04 17:34:57 +02:00
Riccardo Spagni
5ed45acaec
Merge pull request #4906 
506472e0 protocol: fix use after free when dropping a connection (moneromooo-monero)
 2018-12-04 17:33:53 +02:00
Riccardo Spagni
81418cb281
Merge pull request #4894 
aee7a4e3 wallet_rpc_server: do not use RPC data if the call failed (moneromooo-monero)
1a0733e5 windows_service: fix memory leak (moneromooo-monero)
0dac3c64 unit_tests: do not rethrow a copy of an exception (moneromooo-monero)
5d9915ab cryptonote: fix get_unit for non default settings (moneromooo-monero)
d4f50cb1 remove some unused code (moneromooo-monero)
61163971 a few minor (but easy) performance tweaks (moneromooo-monero)
30023074 tests: slow_memmem now returns size_t (moneromooo-monero)
 2018-12-04 17:33:19 +02:00
Riccardo Spagni
6d1c2a9304
Merge pull request #4892 
c28e3d2d rctOps: add braces to suppress warnings (stoffu)
 2018-12-04 17:32:42 +02:00
moneromooo-monero
243f010edc
rpc: mask values that are nobody else's business in restricted RPC 2018-12-04 15:32:21 +00:00
Riccardo Spagni
0e0777e4d1
Merge pull request #4888 
b0d9d605 cn_deserialize: allow parsing partially valid tx extra (moneromooo-monero)
 2018-12-04 17:31:43 +02:00
Riccardo Spagni
6e74aa9a6c
Merge pull request #4885 
b5573fc2 wallet2: resume processing when tx extra is partially broken (stoffu)
 2018-12-04 17:31:27 +02:00
Riccardo Spagni
1bebe99496
Merge pull request #4884 
56e616e8 wallet2: add n_vouts to capture list (moneromooo-monero)
 2018-12-04 17:31:15 +02:00
Riccardo Spagni
302fd80826
Merge pull request #4882 
6bfcc573 scoped_message_writer: protect all std::cout usage from readline (moneromooo-monero)
 2018-12-04 17:30:30 +02:00
Riccardo Spagni
e799fc87ae
Merge pull request #4866 
9c923bad epee: fix network packet header field endianness (moneromooo-monero)
ec1a62b5 move int-util.h to epee (moneromooo-monero)
 2018-12-04 17:30:11 +02:00
Riccardo Spagni
d4a0fb2b89
Merge pull request #4880 
96e6b439 blockchain_stats: don't use gmtime_r on Windows (moneromooo-monero)
 2018-12-04 17:29:46 +02:00
Riccardo Spagni
e282e9fa40
Merge pull request #4878 
517f25ef rpc: add version to get_info (Jethro Grassie)
 2018-12-04 17:28:24 +02:00
Riccardo Spagni
868630c1db
Merge pull request #4877 
c25260f5 protocol: fix incorrect tx hash in log (moneromooo-monero)
 2018-12-04 17:16:52 +02:00
moneromooo-monero
ec1a62b50d
move int-util.h to epee 2018-12-04 15:14:29 +00:00
Riccardo Spagni
a605c0da08
Merge pull request #4872 
fc99f177 lmdb: fix gcc 7.3.0 'implicit-fallthrough' warning (xiphon)
 2018-12-04 17:13:21 +02:00
Riccardo Spagni
e7d30780de
Merge pull request #4869 
60f36386 Avoid unnecessary temp block and copy ctor (moneromooo-monero)
 2018-12-04 17:12:47 +02:00
Riccardo Spagni
eba668c6ad
Merge pull request #4862 
3998a937 Enhance help text for print_ring. (Tadeas Moravec)
3900fb77 Enhance help text for incoming_transfers. (Tadeas Moravec)
 2018-12-04 17:09:40 +02:00
Riccardo Spagni
11d86f6008
Merge pull request #4859 
6f2497bc Don't cache nettype in core_rpc_server use m_core (doy-lee)
 2018-12-04 17:09:21 +02:00
Riccardo Spagni
c00ac446fd
Merge pull request #4854 
bd98e99c Removed a lot of unnecessary includes (Martijn Otto)
 2018-12-04 17:08:42 +02:00
Riccardo Spagni
398f7076bb
Merge pull request #4853 
2b3595d0 various: do not propagate exception through dtor (moneromooo-monero)
 2018-12-04 17:07:51 +02:00
Riccardo Spagni
94288d7d1d
Merge pull request #4845 
6732fc7f Fix issue 4793 - M/N multisig transaction signature (naughtyfox)
 2018-12-04 17:06:04 +02:00
TheCharlatan
5a76933903 Add glibc back compat code 
To ensure that the binaries compiled by gitian run across many linux
distributions, enforce 2.17 as the minimum libc version supported.
 2018-12-04 02:21:06 +01:00
moneromooo-monero
affff949f9
blockchain: fix race between two external mining threads 2018-12-02 13:08:41 +00:00
Tadeas Moravec
6456cb415a
Bulletproof: Initialize members in default construtor. 
Fixing a build warning on g++ 7.3.0
 2018-12-01 13:03:32 +00:00
moneromooo-monero
9b69a0ae01
daemon: print monero version at startup when calling a detached daemon 
So people who want a timstamp get a timestamp
 2018-11-30 17:55:16 +00:00
moneromooo-monero
0c5dd3161b
cryptonote: add a set_null for transaction_prefix 
Since it's all inline, I suspect the compiler will merge the
duplicate stores anyway.
 2018-11-30 15:11:43 +00:00
moneromooo-monero
aba9a9c277
daemon: stop miner before we bring the whole thing down 
This avoids the miner erroring out trying to submit blocks
to a core that's already shut down (and avoids pegging
the CPU while we're busy shutting down).
 2018-11-30 15:10:25 +00:00
moneromooo-monero
ac665418f0
ringct: fix dummy bulletproofs on ledger in fake mode 
Ledger does some basic checks on them
 2018-11-30 13:33:29 +00:00
Dusan Klinec
318cc78457
device/trezor: passphrase entry on host 
- simple device callback object added. Device can request passphrase/PIN entry via the callback or notify user some action is required
- callback is routed to wallet2, which routes the callback to i_wallet_callback so CLI or GUI wallets can support passphrase entry for HW tokens
- wallet: device open needs wallet callback first - passphrase protected device needs wallet callback so user can enter passphrase
 2018-11-29 04:33:41 +01:00
Jason Wong
dc1c12528d add command pop_blocks 
add new public method to Blockchain and update according to code review

update after review: better lock/unlock, try catch and coding style
 2018-11-28 12:20:28 +01:00
moneromooo-monero
a48f2dab00
blockchain_prune_known_spent_data: blackball file is now optional 
If not present, the tool will scan the blockchain, since scanning
for this is fairly fast.
 2018-11-27 15:45:47 +00:00
moneromooo-monero
17b45725af
Outputs where all amounts are known spent can now be pruned 
Only for pre rct for obvious reasons.

Note: DO NOT use a known spent list which includes outputs
which are not known spent. If the list includes any output
that's just strongly thought to be spent, but not provably
so, you risk finding yourself unable to sync past the point
where that output is spent.

I estimate only 200 MB saved on current mainnet though,
unless the new blackballing rule unearths a good amount of
large-amount-set extra spent outs.
 2018-11-27 15:45:42 +00:00
moneromooo-monero
756684bb28
blockchain: avoid unnecessary DB lookups when syncing 
Some of the inputs for block in a span will be from other earlier
blocks in that span. Keep track of those outputs so we don't have
to look them up again after those early blocks are added to the
blockchain.
 2018-11-27 14:03:06 +00:00
moneromooo-monero
5ca4994c9c
rpc: speed up the common get_output_distribution case while syncing 2018-11-27 14:01:40 +00:00
moneromooo-monero
e98ae34e4b
core: fix adding new pre-hoh block when a tx is already in the pool 2018-11-26 23:45:01 +00:00
stoffu
0e2a5d75de
simplewallet: use is_transfer_unlocked instead of is_tx_spendtime_unlocked for show_transfers 
Followup on #4728
 2018-11-27 07:50:16 +09:00
Riccardo Spagni
58ce16d4d9
Merge pull request #4821 
fc98f7a0 rpc: speedup get_outs.bin (moneromooo-monero)
 2018-11-26 21:51:27 +02:00
moneromooo-monero
fc98f7a0a1
rpc: speedup get_outs.bin 2018-11-26 18:56:23 +00:00
Riccardo Spagni
3e2abc9eaa
Merge pull request #4834 
2c7195d8 bulletproofs: avoid std::vector allocations for slice (moneromooo-monero)
 2018-11-26 20:30:15 +02:00
Riccardo Spagni
4a64303d71
Merge pull request #4831 
c5ee14ae json_archive: initialize inner_array_size in ctor (moneromooo-monero)
 2018-11-26 20:29:06 +02:00
Riccardo Spagni
c4fd8ce97e
Merge pull request #4830 
dffec258 db_lmdb: error out if the db needs migration in read only mode (moneromooo-monero)
 2018-11-26 20:28:49 +02:00
Riccardo Spagni
eccb9b08c4
Merge pull request #4825 
b9b307d1 rpc: speedup get_output_distribution (moneromooo-monero)
 2018-11-26 20:28:02 +02:00
Riccardo Spagni
b37ce24cdd
Merge pull request #4824 
2ffe53d9 device/trezor: webusb transport added, cmake fixes (Dusan Klinec)
 2018-11-26 20:27:29 +02:00
Riccardo Spagni
cc1ea0b651
Merge pull request #4816 
1a4d1603 wallet2: remove redundant chacha key generation in store_keys (stoffu)
 2018-11-26 20:25:39 +02:00
moneromooo-monero
506472e0c6
protocol: fix use after free when dropping a connection 2018-11-26 17:19:25 +00:00
Dusan Klinec
2ffe53d9e6
device/trezor: webusb transport added, cmake fixes 
- webusb transport based on libusb added. Provides direct access to Trezor via USB, no need for Trezor bridge.
- trezor protocol message handler improved, no recursion used. Ready for upcoming integration tests.
- libusb (for docker) bumped from v1.0.9 to v1.0.22, newer version required for webusb transport, for device enumeration.
- cmake improvements and fixes. Cmake Trezor checks are moved to a dedicated CheckTrezor.cmake file. In case of a problem Trezor is excluded from build.
- ifdefs made consistent to Ledger.
- UDP Transport enumeration disabled by default in release mode
 2018-11-25 11:57:19 +01:00
moneromooo-monero
2be31b4c9c
blockchain_blackball: spot when all outputs of an amount are spent 2018-11-24 11:07:15 +00:00
stoffu
9b5efad294
simplewallet: enable donation on testnet/stagenet for easier testing 2018-11-24 08:25:38 +09:00
moneromooo-monero
aee7a4e364
wallet_rpc_server: do not use RPC data if the call failed 
Found by codacy.com
 2018-11-23 15:38:00 +00:00
moneromooo-monero
1a0733e534
windows_service: fix memory leak 
Found by codacy.com
 2018-11-23 15:38:00 +00:00
moneromooo-monero
5d9915ab9e
cryptonote: fix get_unit for non default settings 
Found by codacy.com
 2018-11-23 15:37:39 +00:00
moneromooo-monero
d4f50cb109
remove some unused code 
Found by codacy.com
 2018-11-23 15:37:36 +00:00
moneromooo-monero
611639710d
a few minor (but easy) performance tweaks 
Found by codacy.com
 2018-11-23 15:36:48 +00:00
moneromooo-monero
3002307418
tests: slow_memmem now returns size_t 
Makes more sense than uint64_t for an offset, and agrees with
the %zu used to print results.

Found by codacy.com
 2018-11-23 15:36:48 +00:00
stoffu
c28e3d2dae
rctOps: add braces to suppress warnings 2018-11-23 12:28:04 +09:00
moneromooo-monero
b0d9d6051f
cn_deserialize: allow parsing partially valid tx extra 2018-11-22 11:15:57 +00:00
stoffu
b5573fc231
wallet2: resume processing when tx extra is partially broken 
Motivated by https://monero.stackexchange.com/questions/10483

Some exchanges appear to have customized the wallet software
in an inappropriate way, making the tx extra field partially
unreadable. PR #3716 changed the wallet behavior disallowing
such partially valid tx extra.

An example tx reported by the user is
e87c675a85f34ecac58a8846613d25062f1813e1023c552b705afad32b972c38
where the normal tx pubkey appears again with the aditional
tx pubkeys tag `04` which is inappropriate.
 2018-11-22 14:51:35 +09:00
moneromooo-monero
56e616e855
wallet2: add n_vouts to capture list 2018-11-22 01:45:45 +00:00
Jethro Grassie
517f25efd1
rpc: add version to get_info 2018-11-21 12:56:34 -05:00
moneromooo-monero
6bfcc57395
scoped_message_writer: protect all std::cout usage from readline 2018-11-21 12:48:43 +00:00
moneromooo-monero
96e6b43970
blockchain_stats: don't use gmtime_r on Windows 
In some cases, it doesn't like it (I don't know the details).

Factor into a new epee function
 2018-11-21 00:50:53 +00:00
moneromooo-monero
c25260f51c
protocol: fix incorrect tx hash in log 2018-11-20 18:35:58 +00:00
naughtyfox
6732fc7fde Fix issue 4793 - M/N multisig transaction signature 2018-11-20 16:50:41 +03:00
moneromooo-monero
b9b307d11a
rpc: speedup get_output_distribution 
and decrease the amount of data carried around
 2018-11-20 10:11:25 +00:00
Riccardo Spagni
84dd674cd0
Merge pull request #4781 
2a48c2a2 slow-hash: some more big endian fixes (xiphon)
b39fdf8e slow-hash: fix for big endian (moneromooo-monero)
 2018-11-20 12:34:41 +09:00
xiphon
fc99f177f3 lmdb: fix gcc 7.3.0 'implicit-fallthrough' warning 2018-11-19 22:36:10 +00:00
moneromooo-monero
60f36386e4
Avoid unnecessary temp block and copy ctor 
block already has a default ctor, and the extra object
churn due to its innards (vectors, etc) is pointless.
 2018-11-19 17:57:17 +00:00
moneromooo-monero
707c2f836b
Remove -Werror 
It is an annoying piece of garbage
 2018-11-17 13:15:03 +00:00
moneromooo-monero
31d80027b5
tests: add unit tests for get_output_distribution 2018-11-16 19:21:45 +00:00
Tadeas Moravec
3998a937e5
Enhance help text for print_ring. 2018-11-16 15:15:35 +00:00
Tadeas Moravec
3900fb779f
Enhance help text for incoming_transfers. 2018-11-16 14:53:31 +00:00
moneromooo-monero
0936dae8a4
blockchain: remove "0 is height" shortcut from get_output_distribution 
This prevents asking for just 0, and the RPC layer already does this
 2018-11-16 10:03:02 +00:00
moneromooo-monero
872c7eb26a
Revert "blockchain: simplify output distribution code" 
This reverts commit b2bb9312a7.
 2018-11-16 10:02:59 +00:00
xiphon
2a48c2a286
slow-hash: some more big endian fixes 2018-11-16 09:58:41 +00:00
moneromooo-monero
b39fdf8ebe
slow-hash: fix for big endian 2018-11-16 09:58:38 +00:00
Riccardo Spagni
c37c70f459
Merge pull request #4806 
ac23b10f blockchain: fix innocuous difficulty cache inconsistency (moneromooo-monero)
3b14d972 blockchain: use uint64_t for block height, not size_t (moneromooo-monero)
 2018-11-16 11:16:49 +02:00
Riccardo Spagni
0295055bcb
Merge pull request #4805 
6a1062f5 bulletproofs: reserve vector memory when known in advance (moneromooo-monero)
 2018-11-16 11:16:12 +02:00
Riccardo Spagni
cec336ecbc
Merge pull request #4804 
00907c39 rct: speedup commit a little (moneromooo-monero)
 2018-11-16 11:15:56 +02:00
Riccardo Spagni
056abf980e
Merge pull request #4801 
7ae36e91 wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed (stoffu)
 2018-11-16 11:13:09 +02:00
Riccardo Spagni
3a40d94998
Merge pull request #4800 
79b4dae6 simplewallet: slightly adjust wording when printing multisig seed (stoffu)
 2018-11-16 11:12:43 +02:00
Riccardo Spagni
45f597c564
Merge pull request #4799 
f4988454 perf_timer: remove stray debug addition (moneromooo-monero)
 2018-11-16 11:12:09 +02:00
Riccardo Spagni
46f989bc49
Merge pull request #4795 
5d7c2316 rct: add a zeroCommit cache for common pre-rct case (moneromooo-monero)
 2018-11-16 11:11:10 +02:00
Riccardo Spagni
f9c60736b8
Merge pull request #4794 
e198b06e Fix: out_of_hashchain_bounds_error in refresh (Hasan Pekdemir)
 2018-11-16 11:10:20 +02:00
Riccardo Spagni
40bb7a304a
Merge pull request #4792 
5d4f3df8 simplewallet: reorganize SCOPED_WALLET_UNLOCK a bit more (stoffu)
 2018-11-16 11:09:41 +02:00
Riccardo Spagni
86395e5bd6
Merge pull request #4791 
5878fe95 simplewallet: don't skip asking for password when watch-only (stoffu)
 2018-11-16 11:08:34 +02:00
Riccardo Spagni
9aff9a5372
Merge pull request #4790 
177a9d76 wallet: warn if lockable memory limit is too low (moneromooo-monero)
 2018-11-16 11:08:07 +02:00
Riccardo Spagni
20bf9b93dd
Merge pull request #4789 
0afdb00b wallet2: fix print_ring printing double entries for transactions (moneromooo-monero)
 2018-11-16 11:07:40 +02:00
Riccardo Spagni
c8cc65f30a
Merge pull request #4788 
8f3963d2 wallet2: demote a few uninteresting recurring logs to TRACE (moneromooo-monero)
 2018-11-16 11:07:21 +02:00
Riccardo Spagni
279a0a4d8a
Merge pull request #4786 
c22e85fe simplewallet: remove redundant messages on daemon connection failure (stoffu)
 2018-11-16 11:06:32 +02:00
Riccardo Spagni
4561119846
Merge pull request #4784 
1c04c21d wallet_rpc_server: include additional tx keys in sign_transfer response (stoffu)
 2018-11-16 11:05:31 +02:00
Riccardo Spagni
140defd89f
Merge pull request #4778 
71eb32a9 dns_utils: do not exit if DNS records are corrupt (moneromooo-monero)
 2018-11-16 11:02:28 +02:00
Riccardo Spagni
b1ba96e159
Merge pull request #4777 
c17a1d43 daemon: use msg_writer, not cout, to display information (moneromooo-monero)
 2018-11-16 11:01:33 +02:00
Riccardo Spagni
46d0dc2808
Merge pull request #4776 
03fc731b p2p: less frequent incoming connections check (moneromooo-monero)
14a5c206 p2p: tone down "no incoming connections" warning to info if in peers is 0 (moneromooo-monero)
 2018-11-16 11:01:19 +02:00
Riccardo Spagni
d7bac99f6f
Merge pull request #4770 
2bd46065 Expose limit-rate defaults from command line help (RaskaRuby)
 2018-11-16 10:59:38 +02:00
Riccardo Spagni
9827958f5e
Merge pull request #4768 
cf552c75 tx_pool: allow take_tx to work without m_txs_by_fee_and_receive_time (moneromooo-monero)
 2018-11-16 10:59:25 +02:00
Riccardo Spagni
e90ee7548c
Merge pull request #4765 
09dbd9cb tx_pool: fix comment about transaction_prefix (moneromooo-monero)
 2018-11-16 10:58:42 +02:00
Riccardo Spagni
95d96d139d
Merge pull request #4764 
1598f01c wallet2: use padded bulletproofs for multisig signing (stoffu)
 2018-11-16 10:58:29 +02:00
Riccardo Spagni
1910aab5f4
Merge pull request #4236 
a9357141 Add new command "export_transfers" to save transfers to csv (sachaaaaa)
 2018-11-16 10:57:43 +02:00
doy-lee
6f2497bc7a Don't cache nettype in core_rpc_server use m_core 
This can go out of sync with m_core's nettype if you run in fakechain
mode since entering fakechain mode is done through code not the command
line and core_rpc_server only looks at the command line to figure out
the nettype.
 2018-11-16 15:32:05 +11:00
moneromooo-monero
c5ee14ae6e
json_archive: initialize inner_array_size in ctor 
Coverity 136581
 2018-11-15 16:33:51 +00:00
Martijn Otto
bd98e99c80
Removed a lot of unnecessary includes 2018-11-15 17:29:34 +01:00
moneromooo-monero
2b3595d0fe
various: do not propagate exception through dtor 
Coverity 189689, 189690, 189692, 189695
 2018-11-15 15:53:21 +00:00
stoffu
79b4dae66f
simplewallet: slightly adjust wording when printing multisig seed 2018-11-15 23:51:19 +09:00
Riccardo Spagni
0cc3fc3756
Merge pull request #4769 
5808530f blockchain: remove unused output_scan_worker parameter (moneromooo-monero)
1426209a blockchain: don't run threads if we have just one function to run (moneromooo-monero)
6f7a5fd4 db_lmdb: slight speedup getting array data from the blockchain (moneromooo-monero)
99fbe100 db_lmdb: save some string copies for readonly db keys/values (moneromooo-monero)
bf31447e tx_pool: speed up take_tx for transactions from blocks (moneromooo-monero)
4f005a77 tx_pool: remove unnecessary get_transaction_hash (moneromooo-monero)
593ef598 perf_timer: call reserve on new timer array (moneromooo-monero)
6ecc99ad core: avoid unnecessary tx/blob conversions (moneromooo-monero)
00cc1a16 unit_tests: notify test special case for the usual weirdo (moneromooo-monero)
 2018-11-14 21:35:03 +02:00
Riccardo Spagni
33ad6fb4c1
Merge pull request #4761 
6e1282b6 wallet2: fix off by one in output picking (moneromooo-monero)
 2018-11-14 21:34:51 +02:00
Riccardo Spagni
92c5a892b5
Merge pull request #4757 
db24a2e5 hash: fix hash_permutation on big endian (moneromooo-monero)
 2018-11-14 21:34:09 +02:00
Riccardo Spagni
8ba3f89b44
Merge pull request #4755 
42d8d508 crypto: fix AES encryption on big endian (xiphon)
 2018-11-14 21:33:38 +02:00
Riccardo Spagni
59e8a4c306
Merge pull request #4753 
157054b8 hardfork: initialize current_fork_index in ctor (moneromooo-monero)
2362baf7 network_throttle: initialize m_last_sample_time in ctor (moneromooo-monero)
d9400f69 serializtion: add missing mainnet and stagenet fields for 0mq (moneromooo-monero)
cbe0122b wallet2: initialize amount to 0 in tx_scan_info_t ctor (moneromooo-monero)
 2018-11-14 21:33:02 +02:00
Riccardo Spagni
23fc891555
Merge pull request #4750 
e61062b6 use current height - 1 for top block height in err msgs (cryptochangements34)
 2018-11-14 21:32:21 +02:00
Riccardo Spagni
ff347c98a1
Merge pull request #4747 
dad5bbfd return message in stop_mining if mining never started (cryptochangements34)
 2018-11-14 21:32:10 +02:00
Riccardo Spagni
dd42b642ee
Merge pull request #4746 
f3019efe wallet-rpc: add on_restore_deterministic RPC call. (Hasan Pekdemir)
 2018-11-14 21:31:08 +02:00
Riccardo Spagni
2312aacf18
Merge pull request #4847 
6d3311ac libwallet_api_tests: add missing dependency on Boost Locale and ICU (stoffu)
f0459abb cmake: move Boost_LOCALE_LIBRARY out of ICU_LIBRARIES (stoffu)
 2018-11-14 21:30:19 +02:00
stoffu
f0459abbb9
cmake: move Boost_LOCALE_LIBRARY out of ICU_LIBRARIES 2018-11-15 00:18:31 +09:00
xiphon
d01bdaca12 common: fix base58 gcc -Werror=implicit-fallthrough 2018-11-13 12:15:18 +00:00
sachaaaaa
a93571410e Add new command "export_transfers" to save transfers to csv 2018-11-12 12:03:11 +11:00
moneromooo-monero
2c7195d80c
bulletproofs: avoid std::vector allocations for slice 2018-11-09 19:58:11 +00:00
moneromooo-monero
dffec2587f
db_lmdb: error out if the db needs migration in read only mode 2018-11-09 09:39:22 +00:00
Riccardo Spagni
8534f71eed
Merge pull request #4814 
840bf155 build: fix Ubuntu 16.04 (GCC 5.4.0) compilation (xiphon)
 2018-11-07 15:02:56 +02:00
stoffu
ba2055a220
api/wallet: fix compile errors made in #4720 2018-11-07 15:12:24 +09:00
stoffu
1a4d160311
wallet2: remove redundant chacha key generation in store_keys 2018-11-07 10:47:10 +09:00
xiphon
840bf155a0 build: fix Ubuntu 16.04 (GCC 5.4.0) compilation 2018-11-06 21:45:00 +00:00
Riccardo Spagni
a9e03ebc6a
Merge pull request #4809 
1fd017cf Fix build of monero-gui by adding device_trezor to wallet_merged (buricl)
 2018-11-06 21:35:08 +02:00
Riccardo Spagni
148ac1a898
Merge pull request #4744 
b3e8677c cryptonote: use logging functions for errors, not std::cout (moneromooo-monero)
 2018-11-06 21:33:52 +02:00
Riccardo Spagni
a369a13928
Merge pull request #4743 
9335d5a2 wallet2: save ring in the ringdb once a tx is created (moneromooo-monero)
 2018-11-06 21:33:22 +02:00
Riccardo Spagni
da26bc92e9
Merge pull request #4742 
0a95cdaa blockchain_utilities: fix logs and cout output colliding (moneromooo-monero)
 2018-11-06 21:32:54 +02:00
Riccardo Spagni
d210d6fb45
Merge pull request #4738 
107f3398 wallet2: fix ring reuse breaking when using histogram (moneromooo-monero)
 2018-11-06 21:31:32 +02:00
Riccardo Spagni
299d75b209
Merge pull request #4735 
73e504c1 rpc: adjust ring size error message now that too high is also possible (moneromooo-monero)
a5ca7f4f core: fix unmixable special case allowing ring size below 11 (moneromooo-monero)
 2018-11-06 21:31:14 +02:00
Riccardo Spagni
0991aa8964
Merge pull request #4733 
b3067962 cryptonote_core: avoid gratuitous recalculations in check_block_rate() (xiphon)
 2018-11-06 21:30:52 +02:00
Riccardo Spagni
164ba3ef1c
Merge pull request #4731 
f26ce08c wallet: add a non destructive blockchain rescan (moneromooo-monero)
 2018-11-06 21:30:12 +02:00
moneromooo-monero
3dba7f252e
protocol: option to pad transaction relay to the next kB 
To help protect one's privacy from traffic volume analysis
for people using Tor or I2P. This will really fly once we
relay txes on a timer rather than on demand, though.

Off by default for now since it's wasteful and doesn't bring
anything until I2P's in.
 2018-11-06 15:47:05 +00:00
Riccardo Spagni
b789f7e10d
Merge pull request #4729 
e86af52e wallet2: rewrite keys file in a safer manner (Nathan Dorfman)
 2018-11-06 15:09:45 +02:00
Riccardo Spagni
1667d41064
Merge pull request #4728 
1f35de23 simplewallet: display locked/unlocked state in show_transfers (moneromooo-monero)
 2018-11-06 14:54:17 +02:00
Riccardo Spagni
b60078d1b3
Merge pull request #4726 
91eaea9c mnemonics: fix words_to_bytes on big endian (moneromooo-monero)
 2018-11-06 14:53:40 +02:00
Riccardo Spagni
236c0dd48c
Merge pull request #4720 
5f614ba9 simplewallet: print the number of show/all transfers (moneromooo-monero)
8d71b2b1 wallet2: only export necessary outputs and key images (moneromooo-monero)
769ae42a wallet2: faster output and key image import/export (moneromooo-monero)
 2018-11-06 14:52:24 +02:00
Riccardo Spagni
267b5d8807
Merge pull request #4711 
c4fbfd78 Small function declaration cleanup in slow-hash.c (Pol Mauri)
 2018-11-06 14:51:23 +02:00
Riccardo Spagni
cb4d5c2d4b
Merge pull request #4707 
97cad7e9 db_lmdb: log which output was not found in get_output_key (moneromooo-monero)
 2018-11-06 14:50:08 +02:00
buricl
1fd017cf77 Fix build of monero-gui by adding device_trezor to wallet_merged 2018-11-06 00:17:22 +01:00
moneromooo-monero
6e1282b600
wallet2: fix off by one in output picking 
and take into account wallet level minimum spend age
 2018-11-05 20:13:00 +00:00
moneromooo-monero
ac23b10f15
blockchain: fix innocuous difficulty cache inconsistency 
This inconsistent state would not actually be used in practice
 2018-11-05 14:47:52 +00:00
moneromooo-monero
3b14d9727b
blockchain: use uint64_t for block height, not size_t 
for consistency
 2018-11-05 14:47:48 +00:00
moneromooo-monero
6a1062f560
bulletproofs: reserve vector memory when known in advance 2018-11-05 14:32:32 +00:00
moneromooo-monero
00907c3987
rct: speedup commit a little 
saves a conversion, and uses a double scalarmult instead of
two scalarmults
 2018-11-05 14:25:11 +00:00
stoffu
7ae36e91f6
wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed 
Followup on #4653
 2018-11-05 12:13:15 +09:00
moneromooo-monero
f49884543c
perf_timer: remove stray debug addition 2018-11-05 00:34:16 +00:00