monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2025-03-28 01:58:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

wallet2: resume processing when tx extra is partially broken

Browse source 
Motivated by https://monero.stackexchange.com/questions/10483

Some exchanges appear to have customized the wallet software
in an inappropriate way, making the tx extra field partially
unreadable. PR  changed the wallet behavior disallowing
such partially valid tx extra.

An example tx reported by the user is
e87c675a85f34ecac58a8846613d25062f1813e1023c552b705afad32b972c38
where the normal tx pubkey appears again with the aditional
tx pubkeys tag `04` which is inappropriate.
This commit is contained in:
stoffu 2018-11-22 14:45:52 +09:00
parent 84dd674cd0
commit b5573fc231
No known key found for this signature in database
GPG key ID: 41DAB8343A9EC012
1 changed files with 2 additions and 2 deletions

4
src/wallet/wallet2.cpp
View file

@ -1362,8 +1362,8 @@ void wallet2::cache_tx_data(const cryptonote::transaction& tx, const crypto::has
{
// Extra may only be partially parsed, it's OK if tx_extra_fields contains public key
LOG_PRINT_L0("Transaction extra has unsupported format: " << txid);
tx_cache_data.tx_extra_fields.clear();
return;
if (tx_cache_data.tx_extra_fields.empty())
return;
}
// Don't try to extract tx public key if tx has no ouputs