Misc comments

processor/ethereum/TODO/old_processor.rs

@@ -53,20 +53,6 @@ TODO
     }
   }
 
-  #[cfg(test)]
-  async fn get_block_number(&self, id: &<Self::Block as Block<Self>>::Id) -> usize {
-    self
-      .provider
-      .get_block(B256::from(*id).into(), BlockTransactionsKind::Hashes)
-      .await
-      .unwrap()
-      .unwrap()
-      .header
-      .number
-      .try_into()
-      .unwrap()
-  }
-
   #[cfg(test)]
   async fn get_transaction_by_eventuality(
     &self,

processor/ethereum/deployer/contracts/Deployer.sol

@@ -31,6 +31,9 @@ pragma solidity ^0.8.26;
   The alternative would be to have a council publish the Serai key on-Ethereum,
   with Serai verifying the published result. This would introduce a DoS risk in
   the council not publishing the correct key/not publishing any key.
+
+  This design does not work with designs expecting initialization (which may require re-deploying
+  the same code until the initialization successfully goes through, without being sniped).
 */
 
 contract Deployer {

processor/monero/src/scheduler.rs

@@ -88,7 +88,6 @@ async fn signable_transaction(
         // It is a reused value (with later code), but that's not an issue. Just an oddity
         &mut ChaCha20Rng::from_seed(id),
         &rpc.rpc,
-        // TODO: Have Decoys take RctType
         match rct_type {
           RctType::ClsagBulletproof => 11,
           RctType::ClsagBulletproofPlus => 16,

processor/scanner/src/lib.rs

@@ -260,6 +260,7 @@ impl<S: ScannerFeed> SchedulerUpdate<S> {
 pub type KeyScopedEventualities<S> = HashMap<Vec<u8>, Vec<EventualityFor<S>>>;
 
 /// The object responsible for accumulating outputs and planning new transactions.
+// TODO: Move this to Scheduler primitives
 pub trait Scheduler<S: ScannerFeed>: 'static + Send {
   /// An error encountered when handling updates/payments.
   ///