diff --git a/processor/ethereum/TODO/old_processor.rs b/processor/ethereum/TODO/old_processor.rs index 50250c43..a7e85a5c 100644 --- a/processor/ethereum/TODO/old_processor.rs +++ b/processor/ethereum/TODO/old_processor.rs @@ -53,20 +53,6 @@ TODO } } - #[cfg(test)] - async fn get_block_number(&self, id: &>::Id) -> usize { - self - .provider - .get_block(B256::from(*id).into(), BlockTransactionsKind::Hashes) - .await - .unwrap() - .unwrap() - .header - .number - .try_into() - .unwrap() - } - #[cfg(test)] async fn get_transaction_by_eventuality( &self, diff --git a/processor/ethereum/deployer/contracts/Deployer.sol b/processor/ethereum/deployer/contracts/Deployer.sol index 2d4904e4..a7dac1d3 100644 --- a/processor/ethereum/deployer/contracts/Deployer.sol +++ b/processor/ethereum/deployer/contracts/Deployer.sol @@ -31,6 +31,9 @@ pragma solidity ^0.8.26; The alternative would be to have a council publish the Serai key on-Ethereum, with Serai verifying the published result. This would introduce a DoS risk in the council not publishing the correct key/not publishing any key. + + This design does not work with designs expecting initialization (which may require re-deploying + the same code until the initialization successfully goes through, without being sniped). */ contract Deployer { diff --git a/processor/monero/src/scheduler.rs b/processor/monero/src/scheduler.rs index 667840f6..489db810 100644 --- a/processor/monero/src/scheduler.rs +++ b/processor/monero/src/scheduler.rs @@ -88,7 +88,6 @@ async fn signable_transaction( // It is a reused value (with later code), but that's not an issue. Just an oddity &mut ChaCha20Rng::from_seed(id), &rpc.rpc, - // TODO: Have Decoys take RctType match rct_type { RctType::ClsagBulletproof => 11, RctType::ClsagBulletproofPlus => 16, diff --git a/processor/scanner/src/lib.rs b/processor/scanner/src/lib.rs index 6db07989..5046753c 100644 --- a/processor/scanner/src/lib.rs +++ b/processor/scanner/src/lib.rs @@ -260,6 +260,7 @@ impl SchedulerUpdate { pub type KeyScopedEventualities = HashMap, Vec>>; /// The object responsible for accumulating outputs and planning new transactions. +// TODO: Move this to Scheduler primitives pub trait Scheduler: 'static + Send { /// An error encountered when handling updates/payments. ///