Commit graph

9588 commits

Author SHA1 Message Date
moneromooo-monero
c02d7621a4
epee: guard against exceptions in RPC handlers 2020-07-30 22:51:56 +00:00
moneromooo-monero
0678fc1f97
blockchain: guard against exceptions in add_new_block/children
Reporter requested credit to be given to Decred
2020-07-30 22:51:51 +00:00
luigi1111
a498a1b4ce
Merge pull request #6672
fa199f2 build: prepare v0.16.0.1 release (selsta)
2020-06-23 13:57:23 -05:00
luigi1111
4627b0f3e2
Merge pull request #6681
19bb72d add trezor support to sweep_single (ph4r05)
2020-06-22 14:27:12 -05:00
luigi1111
829cbfd700
Merge pull request #6678
cc19397 updates: mac gui .tar.bz2 -> .dmg (selsta)
2020-06-22 14:26:08 -05:00
luigi1111
efe1bfe7a1
Merge pull request #6676
8eaf0e1 epee: fix array underflow in unicode parsing (moneromooo-monero)
2020-06-22 14:25:19 -05:00
luigi1111
cd9acb3a5b
Merge pull request #6671
bca61e4 tx_pool: mine stem txes in fake chain mode (moneromooo-monero)
2020-06-22 14:23:41 -05:00
luigi1111
b0a470d18f
Merge pull request #6665
94befec fix typo in pick_preferred_rct_inputs (Parean)
2020-06-22 14:22:42 -05:00
luigi1111
fcac8f5aff
Merge pull request #6651
a67c634 blockchain: fix timestamp/difficulty cache getting out of sync (moneromooo-monero)
2020-06-22 14:21:16 -05:00
Dusan Klinec
19bb72d020
add trezor support to sweep_single 2020-06-22 10:59:32 +02:00
selsta
cc19397b48
updates: mac gui .tar.bz2 -> .dmg 2020-06-22 02:53:46 +02:00
moneromooo-monero
8eaf0e189f
epee: fix array underflow in unicode parsing
Reported by minerscan

Also independently found by OSS-Fuzz just recently
2020-06-21 18:23:03 +00:00
selsta
fa199f20af
build: prepare v0.16.0.1 release 2020-06-21 16:41:46 +02:00
moneromooo-monero
bca61e4fa6
tx_pool: mine stem txes in fake chain mode
This fixes the functional tests, since txes would not be mined
after being sent to the daemon (they'd be waiting for the
dandelion timeout first)
2020-06-20 15:44:23 +00:00
luigi1111
f0ada2f22b
Merge pull request #6648
3b390fb Fix D++ block template check (vtnerd)
2020-06-19 16:10:12 -05:00
luigi1111
8a850ed742
Merge pull request #6646
b7812d1 blockchain: fix total_height in getblocks.bin response (moneromooo-monero)
2020-06-19 16:09:28 -05:00
luigi1111
44e3875190
Merge pull request #6645
0a19785 rpc: fix loading rpc payment data from file (moneromooo-monero)
2020-06-19 16:07:45 -05:00
luigi1111
d825252b7d
Merge pull request #6644
0569e63 rpc: fix comparison of seconds vs microseconds (moneromooo-monero)
2020-06-19 16:06:33 -05:00
luigi1111
1336992a5b
Merge pull request #6643
23df29d functional_tests: add simple relay_tx test (moneromooo-monero)
e306834 rpc: fix relay_tx error return mixup (moneromooo-monero)
2020-06-19 16:05:03 -05:00
luigi1111
e78387936e
Merge pull request #6642
96b7697 daemon: remove time based 'update needed' status string (moneromooo-monero)
2020-06-19 16:01:37 -05:00
luigi1111
8e0435876c
Merge pull request #6641
5285ecc rpc: don't display invalid json errors on default log level (moneromooo-monero)
2020-06-19 16:00:43 -05:00
luigi1111
79f4af310e
Merge pull request #6594
4e6d587 Fix incorrect lenght of command INS_PREFIX_HASH (grydz)
2020-06-19 15:59:50 -05:00
moneromooo-monero
a67c634f89
blockchain: fix timestamp/difficulty cache getting out of sync
The cache is discarded when a block is popped, but then gets
rebuilt when the difficulty for next block is requested.
While this is all properly locked, it does not take into account
the delay caused by a database transaction being only committed
(and thus its effects made visible to other threads) later on,
which means another thread could request difficulty between
the pop and the commit, which would end up using stale database
view to build the cache, but that cache would not be invalidated
again when the transaction gets committed, which would cause the
cache to not match the new database data.

To fix this, we now keep track of when the cache is invalidated
so we can invalidate it again upon database transaction commit
to ensure it gets calculated again with fresh data next time it
is nedeed.
2020-06-13 15:42:09 +00:00
Lee Clagett
3b390fba9c Fix D++ block template check 2020-06-12 22:42:17 -04:00
moneromooo-monero
b7812d1674
blockchain: fix total_height in getblocks.bin response 2020-06-11 12:51:06 +00:00
moneromooo-monero
0a19785e99
rpc: fix loading rpc payment data from file
Got broken after making one of those micro optimizations requested on review..
2020-06-11 12:49:58 +00:00
moneromooo-monero
0569e635cf
rpc: fix comparison of seconds vs microseconds 2020-06-11 12:48:48 +00:00
moneromooo-monero
23df29d8d6
functional_tests: add simple relay_tx test 2020-06-11 12:47:29 +00:00
moneromooo-monero
e3068346ee
rpc: fix relay_tx error return mixup 2020-06-11 12:47:28 +00:00
moneromooo-monero
96b7697177
daemon: remove time based "update needed" status string 2020-06-11 12:44:57 +00:00
moneromooo-monero
5285ecc3d6
rpc: don't display invalid json errors on default log level
It's not something the user needs to know, and will display
attacker controlled data
2020-06-11 12:43:13 +00:00
François Colas
4e6d587275 Fix incorrect lenght of command INS_PREFIX_HASH
buffer_send[4] (LC) is an unsigned char, len should not
exceed 254 (255 - 1 for the option).
2020-05-27 17:07:48 +02:00
Denis Smirnov
94befecb05 fix typo in pick_preferred_rct_inputs 2020-05-25 03:39:54 +07:00
luigi1111
25419b4bfb
Merge pull request #6579
f50a6c5 version: update name (selsta)
2020-05-21 12:47:48 -05:00
selsta
f50a6c5aed
version: update name 2020-05-21 19:41:04 +02:00
luigi1111
cf4add7899
Merge pull request #6575
ada8172 rpc: lock access to the rpc payment object (moneromooo-monero)
2020-05-21 11:54:52 -05:00
luigi1111
e28d291330
Merge pull request #6577
0d92fe5 rpc: add a sanity limit to a few RPC in restricted mode (moneromooo-monero)
2020-05-21 03:07:04 -05:00
luigi1111
4f6dbcd00e
Merge pull request #6572
438b846 ByteSlice: Fix persisting ptr to std::moved SSO buffer (Doy-lee)
2020-05-21 03:06:15 -05:00
luigi1111
062cf63959
Merge pull request #6569
99d702e cryptonote_core: remove 'We are most likely forked' message (moneromooo-monero)
2020-05-21 03:05:16 -05:00
luigi1111
343acd3025
Merge pull request #6548
c5c8592 [release-v0.16] MMS: New 'config_checksum' subcommand (rbrunner7)
2020-05-21 03:03:45 -05:00
moneromooo-monero
0d92fe5234
rpc: add a sanity limit to a few RPC in restricted mode 2020-05-20 19:18:02 +00:00
moneromooo-monero
ada8172b46
rpc: lock access to the rpc payment object 2020-05-20 18:43:24 +00:00
rbrunner7
c5c85925e2 [release-v0.16] MMS: New 'config_checksum' subcommand 2020-05-20 12:05:21 +02:00
Doyle
438b84690e ByteSlice: Fix persisting ptr to std::moved SSO buffer
The Bug:
1. Construct `byte_slice.portion_` with `epee::span(buffer)` which copies a pointer to the SSO buffer to `byte_slice.portion_`
2. It constructs `byte_slice.storage_` with `std::move(buffer)` (normally this swap pointers, but SSO means a memcpy and clear on the original SSO buffer)
3. `slice.data()` returns a pointer from `slice.portion_` that points to the original SSO cleared buffer, `slice.storage_` has the actual string.
2020-05-20 10:21:21 +10:00
luigi1111
eed8a4e8a6
Merge pull request #6554
f01d529 cryptonote_protocol: reject requests/notifications before handshake (moneromooo-monero)
bbab044 cryptonote_protocol: stricter limit to number of objects requested (moneromooo-monero)
2020-05-19 17:51:03 -05:00
luigi1111
b82af557f5
Merge pull request #6567
cef39dc protocol: move the 'peer claims higher version' warning to debug (moneromooo-monero)
2020-05-19 17:38:34 -05:00
luigi1111
0161cb79a1
Merge pull request #6562
705c78b wallet2: fix multisig data clearing stomping on a vector (moneromooo-monero)
2020-05-19 17:36:58 -05:00
luigi1111
f28026b86f
Merge pull request #6560
4291344 serialization: fix bad rapidjson api usage (moneromooo-monero)
2020-05-19 17:34:17 -05:00
luigi1111
cb75003642
Merge pull request #6545
bb4d95c blockchain: detect and log bad difficulty calculations (moneromooo-monero)
2020-05-19 17:30:37 -05:00
luigi1111
8fb0d7e0b4
Merge pull request #6543
44e3782 protocol: don't drop a connection if we can't get a compatible chain (moneromooo-monero)
2020-05-19 17:29:46 -05:00