monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-11-19 02:21:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
5897 commits 9 branches 69 tags 309 MiB
Commit graph

4127 commits

Author SHA1 Message Date
moneromooo-monero
4f45f9da40
simplewallet: factor out tx exceptions 2017-12-18 15:56:36 +00:00
moneromooo-monero
24f584d90d
cryptonote_core: remove unused functions with off by one bugs 2017-12-18 15:16:06 +00:00
moneromooo-monero
b1634aa3e8
blockchain: don't leave dangling pointers in this 2017-12-18 15:16:03 +00:00
moneromooo-monero
8e60b81c48
cryptonote_core: fix db leak on error 2017-12-18 15:16:00 +00:00
moneromooo-monero
b51dc56687
use const refs in for loops for non tiny types 2017-12-18 15:15:54 +00:00
moneromooo-monero
b49ddc766d
check accessing an element past the end of a container 2017-12-18 15:15:49 +00:00
moneromooo-monero
2305bf260d
check return value for generate_key_derivation and derive_public_key 2017-12-18 15:15:46 +00:00
moneromooo-monero
a4240d9ffc
catch const exceptions 2017-12-18 15:15:43 +00:00
moneromooo-monero
45a1c4c088
add empty container sanity checks when using front() and back() 2017-12-18 15:15:40 +00:00
moneromooo-monero
b4524892fb
rpc: guard against json parsing a non object 2017-12-18 15:15:32 +00:00
moneromooo-monero
061789b5dd
checkpoints: trap failure to load JSON checkpoints 2017-12-18 15:15:23 +00:00
moneromooo-monero
ba2fefb9a4
checkpoints: pass std::string by const ref, not const value 2017-12-18 15:15:19 +00:00
moneromooo-monero
d753d716a6
fix a few leaks by throwing objects, not newed pointers to objects 2017-12-18 15:15:13 +00:00
moneromooo-monero
fe568db83d
p2p: use size_t for arbitrary counters instead of uint8_t 2017-12-18 15:15:10 +00:00
moneromooo-monero
46d6fa35c9
cryptonote_protocol: sanity check chain hashes from peer 2017-12-18 15:15:07 +00:00
moneromooo-monero
25584f8639
cryptonote_protocol: print peer versions when unexpected 
also avoid integer underflow on zero height
 2017-12-18 15:15:05 +00:00
moneromooo-monero
490a5d41ca
rpc: do not try to use an invalid txid in relay_tx 2017-12-18 15:15:01 +00:00
stoffu
a921764162
wallet-rpc: added receiving address to res of get(_bulk)_payments; selective addresses for getaddress 2017-12-18 10:22:34 +09:00
stoffu
6b5bd129b4
Account tagging 2017-12-18 10:21:47 +09:00
Riccardo Spagni
1cc7451130
Merge pull request #2134 
ceabc4f9 change the N-1/N multisig second message signer for auth (moneromooo-monero)
55c2845d core_tests: multisig test now tests multiple inputs (moneromooo-monero)
98db7ee4 wallet: factor multisig info parsing (moneromooo-monero)
31a97e76 wallet: use raw encrypted data in multisig import/export RPC (moneromooo-monero)
2fa707d1 wallet: add multisig sign/submit RPC (moneromooo-monero)
e36f5b60 Match surae's recommendation to derive multisig keys (moneromooo-monero)
a36c261d wallet2: fix slow multisig unit tests with subaddress patch (moneromooo-monero)
fa569712 make multisig work with subaddresses (moneromooo-monero)
dffa0dce simplewallet: add export_raw_multisig command (moneromooo-monero)
7f4c220b simplewallet: add multisig to wallet type in wallet_info output (moneromooo-monero)
26529038 wallet: guard against partly initialized multisig wallet (moneromooo-monero)
66e34e85 add multisig core test and factor multisig building blocks (moneromooo-monero)
f4eda44c N-1/N multisig (moneromooo-monero)
cd64c799 multisig address generation RPC (moneromooo-monero)
fff871a4 gen_multisig: generates multisig wallets if participants trust each other (moneromooo-monero)
95a21a79 wallet2: allow empty wallet filename to avoid saving data (moneromooo-monero)
b84b3565 tests: add multisig unit tests (moneromooo-monero)
4c313324 Add N/N multisig tx generation and signing (moneromooo-monero)
6d219a92 wallet: add multisig key generation (moneromooo-monero)
 2017-12-17 21:05:16 +02:00
moneromooo-monero
d9b137f161
cryptonote_core: fix blockchain init call after prototype change 2017-12-17 18:47:46 +00:00
xmr-eric
e20e489a64 Better definite article use 2017-12-17 12:33:43 -05:00
moneromooo-monero
ceabc4f92b
change the N-1/N multisig second message signer for auth 2017-12-17 16:12:50 +00:00
moneromooo-monero
98db7ee467
wallet: factor multisig info parsing 2017-12-17 16:12:44 +00:00
moneromooo-monero
31a97e761e
wallet: use raw encrypted data in multisig import/export RPC 2017-12-17 16:12:41 +00:00
moneromooo-monero
2fa707d1a5
wallet: add multisig sign/submit RPC 2017-12-17 16:12:35 +00:00
moneromooo-monero
e36f5b6021
Match surae's recommendation to derive multisig keys 2017-12-17 16:12:32 +00:00
moneromooo-monero
a36c261d7a
wallet2: fix slow multisig unit tests with subaddress patch 
While there, move the wallet2 ctor to the cpp file as it's a huge
amount of init list now, and remove an unused one.
 2017-12-17 16:12:30 +00:00
moneromooo-monero
fa5697127f
make multisig work with subaddresses 
Thanks to kenshi84 for help getting this work
 2017-12-17 16:12:27 +00:00
moneromooo-monero
dffa0dceaf
simplewallet: add export_raw_multisig command 
It exports raw transactions, so they may be used by other tools,
for instance to be relayed to the network externally.
 2017-12-17 16:12:24 +00:00
moneromooo-monero
7f4c220b70
simplewallet: add multisig to wallet type in wallet_info output 2017-12-17 16:12:21 +00:00
moneromooo-monero
265290388b
wallet: guard against partly initialized multisig wallet 2017-12-17 16:12:18 +00:00
moneromooo-monero
66e34e85b1
add multisig core test and factor multisig building blocks 2017-12-17 16:12:15 +00:00
moneromooo-monero
f4eda44ce3
N-1/N multisig 2017-12-17 16:12:12 +00:00
moneromooo-monero
cd64c7990c
multisig address generation RPC 2017-12-17 16:12:09 +00:00
moneromooo-monero
fff871a455
gen_multisig: generates multisig wallets if participants trust each other 2017-12-17 16:12:06 +00:00
moneromooo-monero
95a21a793d
wallet2: allow empty wallet filename to avoid saving data 
Useful to speed tests up and avoid unnecessary leftover files
 2017-12-17 16:12:03 +00:00
moneromooo-monero
4c313324b1
Add N/N multisig tx generation and signing 
Scheme by luigi1111:

    Multisig for RingCT on Monero

    2 of 2

    User A (coordinator):
    Spendkey b,B
    Viewkey a,A (shared)

    User B:
    Spendkey c,C
    Viewkey a,A (shared)

    Public Address: C+B, A

    Both have their own watch only wallet via C+B, a

    A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants)

    A and B watch for incoming outputs

    B creates "half" key images for discovered output D:
    I2_D = (Hs(aR)+c) * Hp(D)

    B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D),
    and sending the pubkeys with I2_D.

    A also creates "half" key images:
    I1_D = (Hs(aR)+b) * Hp(D)

    Then I_D = I1_D + I2_D

    Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction).

    A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D
    to his own generated ones where they are needed (secret row L, R).

    At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r,
    which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo).

    B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well).

    B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D
    to his cache, allowing him to verify spent status as well.

    NOTE:
    A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively.
    Otherwise, trickery like the following becomes possible:
    A creates viewkey a,A, spendkey b,B, and sends a,A,B to B.
    B creates a fake key C = zG - B. B sends C back to A.
    The combined spendkey C+B then equals zG, allowing B to spend funds at any time!
    The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature).

    2 of 3

    User A (coordinator)
    Shared viewkey a,A
    "spendkey" j,J

    User B
    "spendkey" k,K

    User C
    "spendkey" m,M

    A collects K and M from B and C
    B collects J and M from A and C
    C collects J and K from A and B

    A computes N = nG, n = Hs(jK)
    A computes O = oG, o = Hs(jM)

    B anc C compute P = pG, p = Hs(kM) || Hs(mK)
    B and C can also compute N and O respectively if they wish to be able to coordinate

    Address: N+O+P, A

    The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other
    needed part of the signature/key images from either of the other two.

    Alternatively, if secure communication exists between parties:
    A gives j to B
    B gives k to C
    C gives m to A

    Address: J+K+M, A

    3 of 3

    Identical to 2 of 2, except the coordinator must collect the key images from both of the others.
    The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it
    or send it back to A.

    N-1 of N

    Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around
    (using either the secure or insecure method).
    For example (ignoring viewkey so letters line up):
    [4 of 5]
    User: spendkey
    A: a
    B: b
    C: c
    D: d
    E: e

    a -> B, b -> C, c -> D, d -> E, e -> A

    Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with
    the transaction so the signers know if they should use 1 or both keys.
    Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each.
    Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning:
    1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image)
    2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator
    must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use.

    You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might
    also be straightforward enough to support with minimal changes from N-1 format.
    You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc.

The process is somewhat cumbersome:

To create a N/N multisig wallet:

 - each participant creates a normal wallet
 - each participant runs "prepare_multisig", and sends the resulting string to every other participant
 - each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N)

As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent:

 - each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant
 - each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants

Then, a transaction may be initiated:

 - one of the participants runs "transfer ADDRESS AMOUNT"
 - this partly signed transaction will be written to the "multisig_monero_tx" file
 - the initiator sends this file to another participant
 - that other participant runs "sign_multisig multisig_monero_tx"
 - the resulting transaction is written to the "multisig_monero_tx" file again
 - if the threshold was not reached, the file must be sent to another participant, until enough have signed
 - the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network
 2017-12-17 16:11:57 +00:00
moneromooo-monero
6d219a9250
wallet: add multisig key generation 
Scheme by luigi1111
 2017-12-17 16:11:53 +00:00
moneromooo-monero
1a686bf8cc
daemon: print num txes in print_bc 2017-12-17 12:55:40 +00:00
Riccardo Spagni
a3a8343051
Merge pull request #2857 
7193b89f Scrub keys from memory just before scope end. (moneromooo-monero)
 2017-12-17 13:00:11 +02:00
Riccardo Spagni
066fd7aced
Merge pull request #2877 
43f5269f Wallets now do not depend on the daemon rpc lib (moneromooo-monero)
bb89ae8b move connection_basic and network_throttle from src/p2p to epee (moneromooo-monero)
4abf25f3 cryptonote_core does not depend on p2p anymore (moneromooo-monero)
 2017-12-17 12:59:44 +02:00
moneromooo-monero
9e07ccf1f5
daemon: remove some superfluous includes 2017-12-17 10:28:39 +00:00
moneromooo-monero
43f5269f84
Wallets now do not depend on the daemon rpc lib 
The shared RPC code is now moved off into a separate lib
 2017-12-16 23:28:59 +00:00
moneromooo-monero
bb89ae8b20
move connection_basic and network_throttle from src/p2p to epee 
These even had the epee namespace.
This fixes some ugly circular dependencies.
 2017-12-16 23:28:43 +00:00
moneromooo-monero
4abf25f3c9
cryptonote_core does not depend on p2p anymore 
As a followon side effect, this makes a lot of inline code
included only in particular cpp files (and instanciated
when necessary.
 2017-12-16 23:28:38 +00:00
moneromooo-monero
09ce03d612
move includes around to lessen overall load 2017-12-16 22:46:38 +00:00
moneromooo-monero
7193b89fe5 Scrub keys from memory just before scope end. 
Partially implements #74.

Securely erases keys from memory after they are no longer needed. Might have a
performance impact, which I haven't measured (perf measurements aren't
generally reliable on laptops).

Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod
functions. Using overloads + SFINAE instead generalizes it so other types can
be marked as scrubbed without adding more boilerplate.
 2017-12-16 15:40:33 -07:00
Riccardo Spagni
8da24c2a57
Merge pull request #2878 
abebe392 rpc: add offline state in info rpc (moneromooo-monero)
7696e849 core: make --offline also disable DNS lookups (moneromooo-monero)
 2017-12-16 23:27:00 +02:00
Riccardo Spagni
b88f0879b5
Merge pull request #2873 
1c838552 Simplewallet.cpp: Fewer pleases in seed NOTE (xmr-eric)
3f18c642 Fix password capitalization mismatch (xmr-eric)
 2017-12-16 23:25:43 +02:00
Riccardo Spagni
7998ffc26b
Merge pull request #2871 
2b0a32f8 Small cleanup of daemon synchronization output (xmr-eric)
 2017-12-16 23:25:02 +02:00
Riccardo Spagni
9b511d3e93
Merge pull request #2866 
cf5f6236 Corrections in rate limiting / trottle code, especially in 'out' direction (rbrunner7)
 2017-12-16 23:24:41 +02:00
Riccardo Spagni
87158dca68
Merge pull request #2885 
a1e3670b catch wallet decrypt false positive (Riccardo Spagni)
 2017-12-16 23:24:16 +02:00
Riccardo Spagni
6c0953b15a
Merge pull request #2860 
3dffe71b new wipeable_string class to replace std::string passphrases (moneromooo-monero)
7a2a5741 utils: initialize easylogging++ in on_startup (moneromooo-monero)
54950829 use memwipe in a few relevant places (moneromooo-monero)
000666ff add a memwipe function (moneromooo-monero)
 2017-12-16 23:19:27 +02:00
Riccardo Spagni
ce951ef560
Merge pull request #2856 
009eed17 rpc: increase the max number of outs one can request (moneromooo-monero)
 2017-12-16 23:15:43 +02:00
Riccardo Spagni
9045ff56fc
Merge pull request #2551 
3af19c80 set_node command, allows setting node without restart (Tobias Hoffmann)
 2017-12-16 23:12:44 +02:00
moneromooo-monero
d0d38dc8e6
wallet2: print tx size in bytes and kB 
Helpful now that tx sizes are smaller
 2017-12-16 18:40:21 +00:00
moneromooo-monero
aaae94f00b
wallet2: reinstate the single preferred output selection 
Removing it nullified the min-outputs-{count,value} system,
and will not increase the number of attempted transactions
in the general case.
 2017-12-16 12:31:03 +00:00
Guillaume LE VAILLANT
db2bc96512 Embed the translation files in the binary 
If a translation file exists in a "translations" directory located in
the same directory as the binary, it is used in priority (this can be
useful when working on translations as you don't have to recompile the
whole program all the time), and if no such file is found the embedded
translation file is used (if it exists).
 2017-12-15 18:44:01 +01:00
moneromooo-monero
043494924b
wallet2: error out in get_seed if the language is invalid 2017-12-15 11:01:14 +00:00
moneromooo-monero
ae55bacd8c
resumption support for updates using range requests 2017-12-15 10:46:23 +00:00
moneromooo-monero
d28c388f88
p2p: stop net server before closing starting connections 
This fixes a hang on exit due to race where a connection adds
itself to the server after the starting connections are closed,
but before the net server marks itself as stopped.
 2017-12-15 10:31:12 +00:00
moneromooo-monero
a1d44f2746
updates: use https for updates 2017-12-14 13:33:06 +00:00
moneromooo-monero
472a93c83a
download: SSL suport 2017-12-14 09:12:58 +00:00
moneromooo-monero
f5bc7f1855
simplewallet: fix default unspent_outputs output with subaddresses 
If no subaddress index is given, consider all of them
 2017-12-13 10:09:42 +00:00
Riccardo Spagni
319163d276
Merge pull request #2913 
b927f0b1 cryptonote_protocol: fix corner case looping asking for same block hashes (moneromooo-monero)
 2017-12-12 17:48:29 +02:00
moneromooo-monero
46eaaae79b
ringct: always use outPk.mask to decode amounts 2017-12-09 18:02:55 +00:00
Riccardo Spagni
2b5abb8269
Merge pull request #2903 
8d4469a0 ringct: do not include bulletproof commitments in signed message (moneromooo-monero)
 2017-12-09 19:05:56 +02:00
moneromooo-monero
8d4469a0ac
ringct: do not include bulletproof commitments in signed message 
Those are not serialized, but are restored from the outPk masks,
so depending on what tries to validate the tx, those commitments
may or may not be filled with valid data at the time. The outPk
masks are already hashed as part of the rctSigBase field.
 2017-12-09 15:30:15 +00:00
moneromooo-monero
1741fb5f2b
node_rpc_proxy: remove unused local and time call 2017-12-09 11:28:18 +00:00
moneromooo-monero
ead48f7d92
core: fix input ordering from v7 2017-12-09 11:24:38 +00:00
Dmitriy Plekhanov
b60f48f0e3
return subaddress in get_bulk_payments 2017-12-08 18:45:53 +03:00
moneromooo-monero
c83d0b3ee2
add bulletproofs from v7 on testnet 2017-12-08 13:50:45 +00:00
moneromooo-monero
8620ef0a0d
bulletproofs: switch H/G in Pedersen commitments to match rct 
Changes from sarang
 2017-12-08 13:48:18 +00:00
moneromooo-monero
d58835b2f6
integrate bulletproofs into monero 2017-12-08 13:48:15 +00:00
moneromooo-monero
90b8d9f271
add bulletproofs to the build, with basic unit tests 
Based on Java code from Sarang Noether
 2017-12-08 13:41:13 +00:00
moneromooo-monero
fe1202646c
perf_timer: add non scoped start/stop timer defines 2017-12-07 19:23:14 +00:00
moneromooo-monero
ada4291469
add a version of ge_double_scalarmult_precomp_vartime with A precomp 2017-12-07 19:23:10 +00:00
moneromooo-monero
d43eef6def
ringct: add a version of addKeys which returns the result 2017-12-07 19:23:08 +00:00
luigi1111
7ff07928ad
sc_mul and sc_muladd 2017-12-07 19:23:05 +00:00
moneromooo-monero
3f24e90149
wallet2: don't write a .new file when not needed 2017-12-07 12:07:18 +00:00
moneromooo-monero
83b0f9e6c5
version: add -master to master version 
This makes master versions play better with automated update checks
 2017-12-07 10:33:12 +00:00
moneromooo-monero
493f7d0974
util: allow non numeric version parts 2017-12-07 10:32:48 +00:00
Tobias Hoffmann
3af19c8011 set_node command, allows setting node without restart 2017-12-06 18:16:50 +01:00
moneromooo-monero
ca18ff644b
wallet2: detect spends in txes without a valid public tx key 2017-12-06 15:55:06 +00:00
moneromooo-monero
6afcd8e37d
cn_deserialize: print tx extra fields in partly decoded tx extra 2017-12-06 15:54:17 +00:00
Riccardo Spagni
a1e3670b33
catch wallet decrypt false positive 2017-12-04 11:07:32 +02:00
moneromooo-monero
b927f0b17e
cryptonote_protocol: fix corner case looping asking for same block hashes 2017-12-03 13:05:10 +00:00
Riccardo Spagni
3052dab81d
Merge pull request #2836 
23b6f685 RPC: allow binding of restricted port in addition to core port (Tim L)
 2017-12-02 09:26:15 +02:00
Riccardo Spagni
81fb832082
Merge pull request #2833 
b0426d4c Fixes #759 Add sanity check on restore height (Cifrado)
 2017-12-02 09:25:53 +02:00
Riccardo Spagni
63f0031965
Merge pull request #2853 
c0ae52c0 simplewallet: prevent (wrong) integrated adresses on accounts > 0 (moneromooo-monero)
 2017-12-02 09:24:53 +02:00
Riccardo Spagni
301279709d
Merge pull request #2850 
d875a9ff wallet2: detect multiple outputs from a tx to different subaddresses (moneromooo-monero)
 2017-12-02 09:24:25 +02:00
Riccardo Spagni
57ac2c2642
Merge pull request #2840 
f9fad186 blockchain_db: sanity check on tx/hash vector sizes (flozilla)
 2017-12-02 09:23:36 +02:00
Riccardo Spagni
ed8fc8ac1c
Merge pull request #2838 
310b790a make connection_id a string in RPC (moneromooo-monero)
 2017-12-02 09:23:22 +02:00
Riccardo Spagni
1fec38e736
Merge pull request #2832 
287dde63 Added command descriptions (Cifrado)
 2017-12-02 09:22:43 +02:00
Riccardo Spagni
0bf4d6deea
Merge pull request #2828 
6cbe7bcd wallet2: check generate_key_derivation return value (moneromooo-monero)
 2017-12-02 09:21:55 +02:00
moneromooo-monero
abebe392c7
rpc: add offline state in info rpc 2017-11-30 15:44:01 +00:00
moneromooo-monero
7696e84952
core: make --offline also disable DNS lookups 2017-11-30 15:35:52 +00:00
rbrunner7
cf5f623616 Corrections in rate limiting / trottle code, especially in 'out' direction 
Deleted 3 out of 4 calls to method connection_basic::sleep_before_packet
that were erroneous / superfluous, which enabled the elimination of a
"fudge" factor of 2.1 in connection_basic::set_rate_up_limit;
also ended the multiplying of limit values and numbers of bytes
transferred by 1024 before handing them over to the global throttle
objects
 2017-11-28 21:18:01 +01:00
xmr-eric
1c838552ed Simplewallet.cpp: Fewer pleases in seed NOTE 
Monero.ts: Fewer pleases in seed NOTE

Monero_it.ts: Fewer pleases in seed NOTE

Monero_fr.ts: Fewer pleases in seed NOTE
 2017-11-28 11:41:26 -05:00
xmr-eric
3f18c642fc
Fix password capitalization mismatch 2017-11-28 11:15:50 -05:00
moneromooo-monero
3dffe71b72
new wipeable_string class to replace std::string passphrases 2017-11-27 22:25:57 +00:00
moneromooo-monero
7a2a574118
utils: initialize easylogging++ in on_startup 
It will be reinitialized later once we know about log file
and other command line configuration
 2017-11-27 22:15:40 +00:00
moneromooo-monero
549508296d
use memwipe in a few relevant places 2017-11-27 22:15:37 +00:00
moneromooo-monero
000666ff78
add a memwipe function 
It's meant to avoid being optimized out

memory_cleanse lifted from bitcoin
 2017-11-27 22:15:34 +00:00
xmr-eric
2b0a32f8af Small cleanup of daemon synchronization output 
Add period to second sentence
 2017-11-27 16:37:20 -05:00
Riccardo Spagni
51e7645836
Merge pull request #2839 
0b08bf39 fixed common/util.cpp to link against libressl (ston1th)
 2017-11-27 22:43:01 +02:00
Cifrado
287dde63d8 Added command descriptions 2017-11-26 10:37:37 +01:00
Riccardo Spagni
8a8c918dc3
Merge pull request #2827 
fdf0acbf Tools, daemonizer: fix building on Windows (iDunk5400)
 2017-11-25 19:54:14 +02:00
Riccardo Spagni
ac261d0d87
Merge pull request #2825 
ac5cd865 simplewallet: fix typo in incoming monero message (moneromooo-monero)
 2017-11-25 19:53:58 +02:00
Riccardo Spagni
2e54e7ff0b
Merge pull request #2824 
51895fd7 split wallet and wallet_api (moneromooo-monero)
 2017-11-25 19:53:35 +02:00
Riccardo Spagni
4c90d638bc
Merge pull request #2823 
0d149f70 Add out-of-bound exceptions and handle them in RPC (Michał Sałaban)
 2017-11-25 19:53:12 +02:00
Riccardo Spagni
a7211b5a07
Merge pull request #2822 
93c33985 simplewallet: translate ring size 0 to mixin 0 (default values) (moneromooo-monero)
 2017-11-25 19:52:52 +02:00
Riccardo Spagni
fbfdaae06f
Merge pull request #2807 
61712384 daemon & simplewallet: don't set max-concurrency when unspecified (stoffu)
 2017-11-25 19:51:52 +02:00
Riccardo Spagni
82375f7de7
Merge pull request #2806 
da706b61 Fix false GCC warning '‘*((void*)& subaddr_account +4)’ may be used unitialized' (binaryFate)
 2017-11-25 19:51:28 +02:00
Riccardo Spagni
df032aac69
Merge pull request #2800 
0b726be7 wallet2: minimize the number of construct_tx calls (moneromooo-monero)
9d505d26 wallet2: cleanup some debug logs (moneromooo-monero)
 2017-11-25 19:50:58 +02:00
Riccardo Spagni
1de386111f
Merge pull request #2797 
7e387fb1 wallet2: only add a dummy 0 output if there's one output otherwise (moneromooo-monero)
 2017-11-25 19:50:21 +02:00
Riccardo Spagni
eefd6a7878
Merge pull request #2796 
b42ee213 Wallet: update ring size in outdated error msgs with set_default_ring_size (binaryFate)
 2017-11-25 19:49:48 +02:00
Riccardo Spagni
7dc58410e5
Merge pull request #2784 
54a4c1cb cryptonote: do not overwrite const data (moneromooo-monero)
 2017-11-25 19:49:22 +02:00
Riccardo Spagni
539f511eb1
Merge pull request #2368 
b0b7e0f0 Spend proof without txkey (stoffu)
 2017-11-25 19:48:56 +02:00
Riccardo Spagni
ed2fc4a1ff
Merge pull request #2794 
43f27c7d core: warn when free disk space is low (moneromooo-monero)
 2017-11-25 19:48:33 +02:00
Riccardo Spagni
29b0bb8952
Merge pull request #2792 
47c0948a Implement missing miner functions on FreeBSD (Vasil Dimov)
fdb5bd16 Remove unused variables and fix typos in comments (Vasil Dimov)
 2017-11-25 19:47:49 +02:00
Riccardo Spagni
d80a3e5c38
Merge pull request #2788 
9739da1e wallet_rpc_server: new relay_tx command (moneromooo-monero)
01dc8297 wallet: transfer RPC can now return tx metadata (pending_tx) (moneromooo-monero)
83fa9047 serialization: add std::set and std::unordered_set serialization (moneromooo-monero)
 2017-11-25 19:47:05 +02:00
Riccardo Spagni
5eb825b876
Merge pull request #2785 
2d1ccc1b mnemonics: support for arbitrary (if multiple of 4 bytes) length data (moneromooo-monero)
 2017-11-25 19:46:52 +02:00
moneromooo-monero
9739da1e84
wallet_rpc_server: new relay_tx command 
It takes a full tx+metadata hex string as input
 2017-11-24 14:03:55 +00:00
moneromooo-monero
01dc829784
wallet: transfer RPC can now return tx metadata (pending_tx) 2017-11-24 14:03:52 +00:00
moneromooo-monero
83fa9047d8
serialization: add std::set and std::unordered_set serialization 2017-11-24 13:45:48 +00:00
moneromooo-monero
009eed17f1
rpc: increase the max number of outs one can request 
It's getting hit too easily
 2017-11-23 19:15:45 +00:00
moneromooo-monero
c0ae52c081
simplewallet: prevent (wrong) integrated adresses on accounts > 0 2017-11-22 16:20:11 +00:00
moneromooo-monero
54a4c1cbf7
cryptonote: do not overwrite const data 2017-11-22 11:17:22 +00:00
moneromooo-monero
d875a9ff90
wallet2: detect multiple outputs from a tx to different subaddresses 2017-11-21 23:22:15 +00:00
stoffu
b0b7e0f09a
Spend proof without txkey 2017-11-21 16:49:16 +09:00
stoffu
be1c01298a
fix for tx proof: use exception instead of error_str when signature gen failed 2017-11-21 16:48:22 +09:00
Riccardo Spagni
49ce59462a
Merge pull request #2783 
416a7933 Print msg upon success for commands that were silent (binaryFate)
 2017-11-20 12:09:02 +09:00
Riccardo Spagni
8d9e4920fc
Merge pull request #2768 
ef941855 Wallet RPC: Add prompt-for-password flag (Tim L)
 2017-11-20 12:08:31 +09:00
ston1th
0b08bf3968 fixed common/util.cpp to link against libressl 2017-11-18 19:02:09 +01:00
stoffu
998777ecd7
Tx proof (revised): 
- refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp
- allow an arbitrary message to be signed together with txid
- introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion
- wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof
- wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof
- get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string
 2017-11-18 20:44:27 +09:00
moneromooo-monero
310b790a64
make connection_id a string in RPC 
It's sent as JSON, so raw binary is not appropriate
 2017-11-18 00:13:07 +00:00
Tim L
23b6f685de RPC: allow binding of restricted port in addition to core port 2017-11-17 16:23:41 -05:00
Cifrado
b0426d4cf2 Fixes #759 Add sanity check on restore height 2017-11-17 08:35:59 +01:00
moneromooo-monero
51895fd7df
split wallet and wallet_api 
This speeds up building a lot when wallet2.h (or something it
includes) changes, since all the API includes wallet2.h
 2017-11-16 12:10:29 +00:00
moneromooo-monero
6cbe7bcdd2
wallet2: check generate_key_derivation return value 2017-11-16 10:31:47 +00:00
stoffu
6171238416
daemon & simplewallet: don't set max-concurrency when unspecified 2017-11-16 08:03:25 +09:00
iDunk5400
fdf0acbf97
Tools, daemonizer: fix building on Windows 2017-11-15 23:12:02 +01:00
Tim L
ef941855ae Wallet RPC: Add prompt-for-password flag 2017-11-15 13:21:55 -05:00
moneromooo-monero
0b726be703
wallet2: minimize the number of construct_tx calls 2017-11-15 18:01:35 +00:00
moneromooo-monero
9d505d26b8
wallet2: cleanup some debug logs 2017-11-15 18:01:32 +00:00
moneromooo-monero
ac5cd865b2
simplewallet: fix typo in incoming monero message 2017-11-15 17:52:37 +00:00
Michał Sałaban
0d149f708f Add out-of-bound exceptions and handle them in RPC 2017-11-15 16:35:14 +01:00
moneromooo-monero
93c3398503 simplewallet: translate ring size 0 to mixin 0 (default values) 
Avoids turning it to a huge number
 2017-11-15 15:07:10 +00:00
stoffu
c4587e83f8
simplewallet: wrong ns for input_line in sweep_single (fix #2634) 2017-11-15 20:45:58 +09:00
flozilla
f9fad18608
blockchain_db: sanity check on tx/hash vector sizes 
It could trip on a corrupt/crafted file if the user has disabled
input verification.
 2017-11-15 10:02:23 +00:00
Riccardo Spagni
cd070874bf
Merge pull request #2778 
c957795b fix output_stream_header memory leak (MaxXor)
 2017-11-15 11:40:38 +02:00
Riccardo Spagni
3abd6f1fd0
Merge pull request #2773 
ffe5b857 Correct totals computation (Michał Sałaban)
 2017-11-15 11:24:08 +02:00
Riccardo Spagni
c9a410e394
Merge pull request #2772 
5d92c7cc wallet2: typo fix in error message (moneromooo-monero)
 2017-11-15 11:23:22 +02:00
Riccardo Spagni
5c2dfe157b
Merge pull request #2771 
e3e838d0 kaccak: remove unused return value (moneromooo-monero)
4877aca2 keccak: some paranoid "can't happen" checks (moneromooo-monero)
 2017-11-15 11:22:56 +02:00
Riccardo Spagni
0d4d628805
Merge pull request #2634 
b738f4b5 wallet: add sweep_single command (stoffu)
 2017-11-15 11:17:01 +02:00
Riccardo Spagni
39bc39b86e
Merge pull request #2628 
7cb303a4 wallet2: simplify incoming tx processing code (moneromooo-monero)
 2017-11-15 11:14:58 +02:00
stoffu
b738f4b59d
wallet: add sweep_single command 2017-11-15 17:51:54 +09:00
stoffu
a17b8233da
wallet2 bugfix: loading old m_unconfirmed_payments 2017-11-15 17:30:49 +09:00
Howard Chu
987eb662bf
More missed readline dependencies thru scoped_message_writer 2017-11-14 22:43:52 +00:00
Howard Chu
29cee4ec4f
Fix 383ff4f689 
Missed a crypto::null_pkey in PR#2629
 2017-11-14 20:36:21 +00:00
Howard Chu
b85e82bf6a
Fix e89994e98f 
Missed an input_line() change
 2017-11-14 20:34:32 +00:00
Howard Chu
95e784ad00
Fix 437421ce42 
Missing an error argument for an exception
 2017-11-14 20:29:05 +00:00
Riccardo Spagni
86a35eeed2
Merge pull request #2789 
b0416f07 checkpoints: add a testnet checkpoint at 1000000 (moneromooo-monero)
 2017-11-14 22:17:07 +02:00
Riccardo Spagni
0c4df51bbb
Merge pull request #2765 
fc85d7a9 simplewallet: fix in show_transfer passing wrong arg to wallet2::get_payments etc (stoffu)
 2017-11-14 22:16:37 +02:00
anonimal
a3ea62f209 CMake: include RPC when building GUI deps 2017-11-14 19:45:58 +00:00
Riccardo Spagni
10a237783a
Merge pull request #2692 
0f2c2d4c rpc: remove obsolete busy core checks (moneromooo-monero)
 2017-11-14 21:32:33 +02:00
Riccardo Spagni
815e158bdf
Merge pull request #2739 
99f398a2 wallet2: avoid growing the short history when refreshing in a loop (moneromooo-monero)
 2017-11-14 21:32:13 +02:00
Riccardo Spagni
edebe4e3b6
Merge pull request #2736 
0d9c0db9 Do not build against epee_readline if it was not built (Howard Chu)
178014c9 split off readline code into epee_readline (moneromooo-monero)
a9e14a19 link against readline only for monerod and wallet-wallet-{rpc,cli} (moneromooo-monero)
437421ce wallet: move some scoped_message_writer calls from the libs (moneromooo-monero)
e89994e9 wallet: rejig to avoid prompting in wallet2 (moneromooo-monero)
ec5135e5 move input_line from command_line to simplewallet (moneromooo-monero)
082db75f move cryptonote command line options to cryptonote_core (moneromooo-monero)
 2017-11-14 21:31:51 +02:00
Riccardo Spagni
922aaf4e2a
Merge pull request #2644 
a17efcb0 make this build on SunOS/Solaris (Pavel Maryanov)
 2017-11-14 21:31:09 +02:00
Riccardo Spagni
41a8bf4f4c
Merge pull request #2636 
ad03f778 simplewallet: factor transfer related exception handling (moneromooo-monero)
 2017-11-14 21:30:25 +02:00
Riccardo Spagni
5de492be40
Merge pull request #2629 
383ff4f6 remove "using namespace std" from headers (moneromooo-monero)
 2017-11-14 21:29:49 +02:00
moneromooo-monero
0f2c2d4c34
rpc: remove obsolete busy core checks 2017-11-14 17:15:19 +00:00
moneromooo-monero
99f398a25e
wallet2: avoid growing the short history when refreshing in a loop 2017-11-14 17:09:11 +00:00
Howard Chu
0d9c0db996
Do not build against epee_readline if it was not built 2017-11-14 17:06:37 +00:00
moneromooo-monero
178014c995
split off readline code into epee_readline 2017-11-14 17:06:35 +00:00
moneromooo-monero
a9e14a19dc
link against readline only for monerod and wallet-wallet-{rpc,cli} 2017-11-14 17:06:32 +00:00
moneromooo-monero
437421ce42
wallet: move some scoped_message_writer calls from the libs 2017-11-14 17:06:29 +00:00
moneromooo-monero
e89994e98f
wallet: rejig to avoid prompting in wallet2 
wallet2 is a library, and should not prompt for stdin. Instead,
pass a function so simplewallet can prompt on stdin, and a GUI
might display a window, etc.
 2017-11-14 17:06:26 +00:00
moneromooo-monero
ec5135e5b7
move input_line from command_line to simplewallet 
It was only used there, and this removes one part of the common
dependency on libreadline
 2017-11-14 17:06:23 +00:00
moneromooo-monero
082db75f28
move cryptonote command line options to cryptonote_core 
Those have no reason to be in a generic module
 2017-11-14 17:06:19 +00:00
Pavel Maryanov
a17efcb039
make this build on SunOS/Solaris 2017-11-14 17:03:48 +00:00
moneromooo-monero
ad03f77856
simplewallet: factor transfer related exception handling 
This ensures they don't go out of sync when adding/changing them,
and makes the code easier to deal with.
 2017-11-14 17:00:39 +00:00
moneromooo-monero
383ff4f689
remove "using namespace std" from headers 
It's nasty, and actually breaks on Solaris, where if.h fails to
build due to:

  struct map *if_memmap;
 2017-11-14 16:56:10 +00:00
stoffu
fc85d7a998
simplewallet: fix in show_transfer passing wrong arg to wallet2::get_payments etc 2017-11-15 00:25:17 +09:00
Riccardo Spagni
f48aeab5c4
Merge pull request #2756 
0bf09154 Fix file permission issue (Tim L)
 2017-11-14 16:02:28 +02:00
Riccardo Spagni
910218b14e
Merge pull request #2755 
d70515fc Used declared default refresh status as default rather than it's current value (Maxime THIEBAUT)
 2017-11-14 15:57:25 +02:00
Riccardo Spagni
a2241e8151
Merge pull request #2753 
fa514082 RPC: get_info add rpc_connections_count (Tim L)
 2017-11-14 15:54:33 +02:00
Riccardo Spagni
68d5952f6a
Merge pull request #2752 
68c01782 updates: add a special case for "install-" build tags on windows (moneromooo-monero)
 2017-11-14 15:49:53 +02:00
Riccardo Spagni
95c34e17cd
Merge pull request #2750 
424852a6 Fix 'sweep_all' command when called with no args (Leon Klingele)
 2017-11-14 15:49:15 +02:00
Riccardo Spagni
a2b427b1bf
Merge pull request #2749 
f732e723 Disguise password length in prompt (Leon Klingele)
 2017-11-14 15:35:47 +02:00
Riccardo Spagni
1e874186b3
Merge pull request #2747 
37e1fd94 simplewallet: mark the active account in print_accounts (moneromooo-monero)
 2017-11-14 15:32:29 +02:00
Riccardo Spagni
55603627c9
Merge pull request #2745 
6cf33446 Remove wallet dependency on p2p (moneromooo-monero)
 2017-11-14 15:31:40 +02:00
Riccardo Spagni
0d0ce8c21e
Merge pull request #2742 
7c7d3672 Increase LMDB maxreaders if large number of threads in use (Howard Chu)
6738753b Use max_concurrency as-is (Howard Chu)
 2017-11-14 15:30:03 +02:00
Riccardo Spagni
e0e6e375bb
Merge pull request #2738 
4a17f0c2 rpc: add performance timers (moneromooo-monero)
 2017-11-14 15:28:47 +02:00
Riccardo Spagni
e759c78a17
Merge pull request #2735 
a524b750 rpc: added miner_tx_hash to resp of getblock (stoffu)
 2017-11-14 15:27:51 +02:00
Riccardo Spagni
29d77e5686
Merge pull request #2727 
9d6c6c5d wallet2: do not bother downloading block hashes below last checkpoint (moneromooo-monero)
 2017-11-14 15:21:58 +02:00
moneromooo-monero
7cb303a44b
wallet2: simplify incoming tx processing code 2017-11-14 13:20:51 +00:00
Riccardo Spagni
25b97ee937
Merge pull request #2624 
2677ade5 simplewallet: forbid 0 ring size (moneromooo-monero)
da8b60cb simplewallet: reject attempts to use too low mixin early (moneromooo-monero)
 2017-11-14 15:20:45 +02:00
Riccardo Spagni
cdab85db41
Merge pull request #2701 
867b67c4 Wallet API: override update subdir when built from src (Jaquee)
 2017-11-14 15:15:25 +02:00
Riccardo Spagni
2458ff1a6d
Merge pull request #2697 
d269bff2 wallet2: use a vector, not a list, for selected_transfers (moneromooo-monero)
 2017-11-14 15:14:07 +02:00
Riccardo Spagni
8df6b010eb
Merge pull request #2696 
937e7f8a Initialize openssl on startup (moneromooo-monero)
 2017-11-14 15:13:44 +02:00
moneromooo-monero
2677ade502
simplewallet: forbid 0 ring size 
It'd be interpreted as a huge one (~0 fake outs)
 2017-11-14 13:12:42 +00:00
moneromooo-monero
da8b60cbbf
simplewallet: reject attempts to use too low mixin early 
This yields a clear error message rather then some possibly
confusing more technical errors down the line
 2017-11-14 13:12:39 +00:00
Riccardo Spagni
6172248acf
Merge pull request #2685 
1ff638e9 protocol: drop connections which don't handshake after some time (moneromooo-monero)
 2017-11-14 15:04:40 +02:00
Riccardo Spagni
f4fded6fcf
Merge pull request #2683 
105425b7 simplewallet: reject invalid argument for boolean parameter (stoffu)
 2017-11-14 15:04:15 +02:00
Riccardo Spagni
f1ca1f35d1
Merge pull request #2682 
8ddcf1e7 simplewallet: remove XMR mentions (moneromooo-monero)
 2017-11-14 15:03:15 +02:00
Riccardo Spagni
48ff10f77f
Merge pull request #2681 
ec48e8d8 core: do not forbid txes without destination (moneromooo-monero)
523084bc core: don't add empty additional pub keys field to extra (moneromooo-monero)
 2017-11-14 15:02:55 +02:00
Riccardo Spagni
256a1d9ead
Merge pull request #2675 
00cc1fdd subaddress: remove unneeded scalarmultBase (kenshi84)
 2017-11-14 15:02:14 +02:00
Riccardo Spagni
2ddb894607
Merge pull request #2661 
ac4018a7 wallet2: workaround for lightwallet before supporting subaddress (followup #2656) (kenshi84)
 2017-11-14 15:01:25 +02:00
Riccardo Spagni
474e02ccde
Merge pull request #2651 
118a1bed rpc: make get_coinbase_tx_sum a restricted RPC (moneromooo-monero)
 2017-11-14 15:00:39 +02:00
Riccardo Spagni
395025bb23
Merge pull request #2633 
ad96c478 wallet-cli: added --generate-from-spend-key option (stoffu)
 2017-11-14 14:56:07 +02:00
Riccardo Spagni
f26e7a84a6
Merge pull request #2620 
6bd4dac6 util: ignore SIGPIPE (moneromooo-monero)
 2017-11-14 14:54:42 +02:00
Riccardo Spagni
9317c9c57e
Merge pull request #2617 
7dbf76d0 Fix an object lifetime bug in net load tests (moneromooo-monero)
 2017-11-14 14:54:05 +02:00
Riccardo Spagni
fd0740e5e7
Merge pull request #2615 
10013e94 Protect node privacy by proper filtering in restricted-mode RPC answers (binaryFate)
 2017-11-14 14:53:10 +02:00
Riccardo Spagni
3fff292dc1
Merge pull request #2509 
ccf53a56 track double spending in the txpool (moneromooo-monero)
 2017-11-14 14:50:03 +02:00
moneromooo-monero
43f27c7d43
core: warn when free disk space is low 2017-11-14 10:21:34 +00:00
binaryFate
da706b6102 Fix false GCC warning '‘*((void*)& subaddr_account +4)’ may be used unitialized' 2017-11-14 09:45:43 +01:00
stoffu
105425b7f6
simplewallet: reject invalid argument for boolean parameter 2017-11-14 16:33:17 +09:00
stoffu
a524b7508e
rpc: added miner_tx_hash to resp of getblock 2017-11-14 16:31:46 +09:00
stoffu
ad96c478b1
wallet-cli: added --generate-from-spend-key option 2017-11-14 16:30:59 +09:00
moneromooo-monero
d269bff2ab
wallet2: use a vector, not a list, for selected_transfers 
Friendlier on memory/speed, we know in advance the max amount
of items, which are small and constant size, and there's a lot
of list walking involved.
 2017-11-13 19:36:18 +00:00
moneromooo-monero
7e387fb1ad
wallet2: only add a dummy 0 output if there's one output otherwise 2017-11-13 14:08:10 +00:00
binaryFate
b42ee213e8 Wallet: update ring size in outdated error msgs with set_default_ring_size 2017-11-13 09:53:18 +01:00
Vasil Dimov
47c0948ab0
Implement missing miner functions on FreeBSD 
cryptonote::miner::get_system_times(): Fetch the system's total and
idle time using sysctl kern.cp_time.

cryptonote::miner::get_process_time(): Use the same implementation as
Linux and OSX, the times(3) function conforms to POSIX.1 and is
available on FreeBSD.

cryptonote::miner::on_battery_power(): Try to fetch the battery status
using sysctl hw.acpi.acline. If that fails (if ACPI is not enabled on
the system), then try querying /dev/apm.
 2017-11-11 16:27:19 +02:00
Vasil Dimov
fdb5bd161d
Remove unused variables and fix typos in comments 2017-11-11 16:17:19 +02:00
moneromooo-monero
e3e838d0cf
kaccak: remove unused return value 2017-11-11 11:20:48 +00:00
moneromooo-monero
b0416f070e
checkpoints: add a testnet checkpoint at 1000000 
Makes working on testnet a lot easier (much less I/O when loading
and saving wallets, and exercises the hashchain code before any
changes are merged)
 2017-11-11 11:16:48 +00:00
binaryFate
416a793326 Print msg upon success for commands that were silent 2017-11-10 09:42:40 +01:00
Riccardo Spagni
af448d3883
Merge pull request #2694 
11e0deef cmake: add dep of version lib on version.cpp (redfish)
35340259 .gitignore: do not ignore cmake source files (redfish)
 2017-11-09 18:22:25 +02:00
moneromooo-monero
2d1ccc1b88
mnemonics: support for arbitrary (if multiple of 4 bytes) length data 2017-11-09 10:58:10 +00:00
MaxXor
c957795bfa fix output_stream_header memory leak 2017-11-08 19:59:09 +01:00
binaryFate
10013e9434 Protect node privacy by proper filtering in restricted-mode RPC answers 
This patch allows to filter out sensitive information for queries that rely on the pool state, when running in restricted mode.
This filtering is only applied to data sent back to RPC queries. Results of inline commands typed locally in the daemon are not affected.
In practice, when running with `--restricted-rpc`:
* get_transaction_pool will list relayed transactions with the fields "last relayed time" and "received time" set to zero.
* get_transaction_pool will not list transaction that have do_not_relay set to true, and will not list key images that are used only for such transactions
* get_transaction_pool_hashes.bin will not list such transaction
* get_transaction_pool_stats will not count such transactions in any of the aggregated values that are computed

The implementation does not make filtering the default, so developers should be mindful of this if they add new RPC functionality.
Fixes #2590.
 2017-11-08 13:07:07 +01:00
Michał Sałaban
ffe5b857e1 Correct totals computation 2017-11-08 12:09:50 +01:00
Tim L
fa51408272 RPC: get_info add rpc_connections_count 2017-11-07 16:34:49 -05:00
moneromooo-monero
5d92c7ccf6
wallet2: typo fix in error message 2017-11-07 14:04:40 +00:00
moneromooo-monero
4877aca2b6
keccak: some paranoid "can't happen" checks 2017-11-07 14:02:37 +00:00
stoffu
37c3792b00
wallet2 bugfix: supply missing subaddr_account arg to balance() and unlocked balance() 2017-11-06 10:15:38 +09:00
moneromooo-monero
ccf53a566c
track double spending in the txpool 
Transactions in the txpool are marked when another transaction
is seen double spending one or more of its inputs.
This is then exposed wherever appropriate.

Note that being marked with this "double spend seen" flag does
NOT mean this transaction IS a double spend and will never be
mined: it just means that the network has seen at least another
transaction spending at least one of the same inputs, so care
should be taken to wait for a few confirmations before acting
upon that transaction (ie, mostly of use for merchants wanting
to accept unconfirmed transactions).
 2017-11-06 00:05:44 +00:00
Riccardo Spagni
3dd31d33fa
Merge pull request #2605 
b370ef54 Wallet: Descriptions through new commands 'set_description', 'get_description' (rbrunner7)
 2017-11-06 01:56:06 +02:00
Riccardo Spagni
f960ef9454
Merge pull request #2595 
8041b4e9 wallet-cli: allow priority argument for sweep_all and donate (stoffu)
 2017-11-06 01:55:15 +02:00
Riccardo Spagni
7452359d8f
Merge pull request #2591 
93ad1f87 Fix #2559: more flexible print_tx daemon command (binaryFate)
 2017-11-06 01:54:48 +02:00
Riccardo Spagni
32b083d8bd
Merge pull request #2546 
b2d416f2 Distinguish "not enough money" and "not enough unlocked money" (binaryFate)
 2017-11-06 01:53:43 +02:00
Riccardo Spagni
4022a0a57e
Merge pull request #2729 
161401dd Fix JSON-RPC response object over ZMQ (Lee Clagett)
 2017-11-06 01:42:55 +02:00
stoffu
8041b4e901
wallet-cli: allow priority argument for sweep_all and donate 2017-11-04 12:11:04 +09:00
Tim L
0bf0915446 Fix file permission issue 
This branch fixes a file permission issue introduced by 69c37200aa
 2017-11-03 11:27:50 -04:00
Maxime THIEBAUT
d70515fca4 Used declared default refresh status as default rather than it's current value 2017-11-03 16:15:02 +01:00
Riccardo Spagni
13a84caa22
Merge pull request #2662 
88ebfd64 core_tests: fix for subaddress patch (kenshi84)
e373a203 performance_tests: add master spend pubkey to subaddress hashtable (kenshi84)
 2017-11-03 11:58:06 +02:00
moneromooo-monero
68c0178220
updates: add a special case for "install-" build tags on windows 
Those will have a ".exe" file extension, not .zip.
 2017-11-03 09:45:08 +00:00
Leon Klingele
424852a627
Fix 'sweep_all' command when called with no args 
Executing 'sweep_all' with no arguments segfaulted before.
 2017-11-03 04:52:26 +01:00
Leon Klingele
f732e723b7
Disguise password length in prompt 2017-11-03 04:04:54 +01:00
moneromooo-monero
37e1fd94d5
simplewallet: mark the active account in print_accounts 2017-11-02 23:46:12 +00:00
Howard Chu
7c7d36725a
Increase LMDB maxreaders if large number of threads in use 2017-11-02 16:33:48 +00:00
Howard Chu
6738753b30
Use max_concurrency as-is 
Don't try to 2nd guess user
 2017-11-02 16:33:48 +00:00
moneromooo-monero
6cf3344605
Remove wallet dependency on p2p 2017-11-02 16:13:24 +00:00
Riccardo Spagni
32b46c594b
Merge pull request #2703 
d0463312 fix libwallet api test after api change (Jaquee)
a46c1eed Wallet2: Don't throw when subaddress label doesn't exist (Jaquee)
086b7db2 Wallet API: default values for account and subaddr index (Jaquee)
 2017-11-01 11:24:54 +02:00
Riccardo Spagni
1648c1d466
Merge pull request #2659 
52c13810 blockchain_utilities: Add monero-blockchain-{ex,im}port binaries to default install targets (Bertrand Jacquin)
 2017-10-31 20:42:48 +02:00
Riccardo Spagni
54463b33b3
Merge pull request #2723 
69c37200 RPC Add cross origin resource sharing support (Tim L)
 2017-10-31 20:38:38 +02:00
Riccardo Spagni
5ef9c69ef5
Merge pull request #2711 
fab3b722 Add more specific RPC error codes (Michał Sałaban)
 2017-10-31 20:35:41 +02:00
Riccardo Spagni
00270dd279
Merge pull request #2737 
935f7462 blockchain: do not lock the blockchain lock for simple DB getters (moneromooo-monero)
 2017-10-31 20:34:22 +02:00
Riccardo Spagni
c97fbb0176
Merge pull request #2718 
626e8078 wallet2: fix show_transfers missing multiple incoming outputs (moneromooo-monero)
 2017-10-31 20:33:44 +02:00
Riccardo Spagni
3fe07603e4
Merge pull request #2705 
44f14638 wallet2: fix tx size estimator for large number of inputs (moneromooo-monero)
 2017-10-31 20:33:19 +02:00
Riccardo Spagni
75ad92c82c
Merge pull request #2702 
f946bb7b fixed an LMDB issue on OpenBSD (#2699) which leads to a crash in monerod (ston1th)
 2017-10-31 20:31:42 +02:00
Riccardo Spagni
784f7b07f0
Merge pull request #2660 
4dd05a2f subaddress: change prefix so that it starts with 8 (kenshi84)
 2017-10-31 20:28:00 +02:00
moneromooo-monero
9d6c6c5dec
wallet2: do not bother downloading block hashes below last checkpoint 2017-10-31 10:29:54 +00:00
Tim L
69c37200aa RPC Add cross origin resource sharing support 2017-10-30 13:55:56 -04:00
moneromooo-monero
4a17f0c2c7
rpc: add performance timers 
Enable with perf:DEBUG
 2017-10-30 09:39:36 +00:00
moneromooo-monero
935f746249
blockchain: do not lock the blockchain lock for simple DB getters 
It is safe in those cases, though might return slightly out of date
information if another thread is busy modifying the blockchain,
but it avoids potentially lengthy delays just to get things like
the current blockchain height.
 2017-10-30 08:23:40 +00:00
Jaquee
a46c1eed8c Wallet2: Don't throw when subaddress label doesn't exist 2017-10-29 15:26:22 +01:00
Jaquee
867b67c4fd Wallet API: override update subdir when built from src 2017-10-29 15:17:31 +01:00
Lee Clagett
161401ddca Fix JSON-RPC response object over ZMQ 2017-10-26 17:25:14 -04:00
ston1th
f946bb7be6 fixed an LMDB issue on OpenBSD (#2699) which leads to a crash in monerod 2017-10-26 17:16:06 +02:00
moneromooo-monero
626e80780b
wallet2: fix show_transfers missing multiple incoming outputs 2017-10-23 14:38:07 +01:00
moneromooo-monero
ca87cbd852
wallet2: fix subaddress fields serialization 
When loading an older wallet cache, they wouldn't be initialized,
leading them to have random(ish) values, and so assigned to some
random subaddress.
 2017-10-23 11:53:49 +01:00
Michał Sałaban
fab3b7221b Add more specific RPC error codes 2017-10-23 04:27:02 +02:00
moneromooo-monero
44f1463867
wallet2: fix tx size estimator for large number of inputs 2017-10-22 19:46:07 +01:00
moneromooo-monero
1ff638e927
protocol: drop connections which don't handshake after some time 2017-10-22 19:45:30 +01:00
Jaquee
086b7db2c7 Wallet API: default values for account and subaddr index 2017-10-22 18:15:23 +02:00
moneromooo-monero
937e7f8aa6
Initialize openssl on startup 2017-10-21 10:17:18 +01:00
redfish
11e0deef31 cmake: add dep of version lib on version.cpp 
Also, move cmake source files into cmake/ to keep them together.
 2017-10-20 22:07:34 -04:00
moneromooo-monero
8ddcf1e714
simplewallet: remove XMR mentions 
They are actually wrong if the wallet is setup in a different
denomination, and it's incursion of extrinsic lingo where monero
fits perfectly in the first place.
 2017-10-19 13:10:29 +01:00
moneromooo-monero
ec48e8d81d
core: do not forbid txes without destination 
This was spuriously forbidden in the recent subaddress patch,
which isn't inherently incompatible with these.
 2017-10-19 09:11:12 +01:00
moneromooo-monero
523084bc79
core: don't add empty additional pub keys field to extra 
Saves a couple bytes per tx
 2017-10-19 09:11:10 +01:00
kenshi84
00cc1fdd22
subaddress: remove unneeded scalarmultBase 2017-10-18 08:46:00 +09:00
kenshi84
88ebfd646a
core_tests: fix for subaddress patch 2017-10-17 22:29:01 +09:00
rbrunner7
b370ef54b9 Wallet: Descriptions through new commands 'set_description', 'get_description' 2017-10-16 22:24:09 +02:00
binaryFate
b2d416f211 Distinguish "not enough money" and "not enough unlocked money" 
Fix #1530
 2017-10-16 15:14:09 +02:00
kenshi84
ac4018a7e6
wallet2: workaround for lightwallet before supporting subaddress (followup #2656) 2017-10-16 12:03:09 +09:00
kenshi84
4dd05a2f9b
subaddress: change prefix so that it starts with 8 2017-10-16 10:35:59 +09:00
Bertrand Jacquin
52c1381049
blockchain_utilities: Add monero-blockchain-{ex,im}port binaries to 
default install targets

Binaries available to download on https://getmonero.org/downloads/ as
embedding monerod, monero-wallet-{cli,rpc} and
monero-blockchain-{ex,im}port.

This change synchronise download results with a manual build from
source
 2017-10-15 22:19:38 +01:00
Vasil Dimov
4d35ad7603
Fix compiler warnings with Clang 6.0.0. 
monero/src/cryptonote_protocol/block_queue.cpp:208:44: error:
      suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
  static const boost::uuids::uuid uuid0 = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                           {                                          }

monero/src/wallet/wallet_rpc_server.cpp:1895:43: error:
      lambda capture 'wal' is not used [-Werror,-Wunused-lambda-capture]
  tools::signal_handler::install([&wrpc, &wal](int) {
                                          ^

monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:40: error:
      lambda capture 'arg' is not used [-Werror,-Wunused-lambda-capture]
    m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
                                       ^

monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:46: error:
      lambda capture 'fluffy_arg' is not used [-Werror,-Wunused-lambda-capture]
    m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
                                             ^

monero/src/blockchain_utilities/blockchain_export.cpp:181:3: error:
      bool literal returned from 'main' [-Werror,-Wmain]
  CHECK_AND_ASSERT_MES(r, false, "Failed to initialize source blockchain storage");
  ^                       ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
      expanded from macro 'CHECK_AND_ASSERT_MES'
  ...fail_ret_val, message)   do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
                                                                  ^      ~~~~~~~~~~~~
monero/src/blockchain_utilities/blockchain_export.cpp:195:3: error:
      bool literal returned from 'main' [-Werror,-Wmain]
  CHECK_AND_ASSERT_MES(r, false, "Failed to export blockchain raw data");
  ^                       ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
      expanded from macro 'CHECK_AND_ASSERT_MES'
  ...fail_ret_val, message)   do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
                                                                  ^      ~~~~~~~~~~~~
 2017-10-15 22:02:24 +03:00
Riccardo Spagni
97c11caf07 Merge pull request #2656 
3492de01 fix lightwallet and subaddresses conflict (Jaquee)
329f149e remove reference to cryptonote::null_hash (Jaquee)
 2017-10-15 19:32:18 +02:00
Jaquee
3492de010b fix lightwallet and subaddresses conflict 2017-10-15 19:19:40 +02:00
Jaquee
329f149e95 remove reference to cryptonote::null_hash 2017-10-15 19:19:40 +02:00
Riccardo Spagni
b293ad9a1a
Merge pull request #2640 
22b51e06 db_lmdb: include chain height when failing to find an output key (moneromooo-monero)
5db433b3 blockchain: avoid exceptions in output verification (moneromooo-monero)
 2017-10-15 18:59:45 +02:00
Riccardo Spagni
344c01c712
Merge pull request #2638 
529a6a4a core: guard against a mined block not finding all txes in the pool (moneromooo-monero)
 2017-10-15 18:58:57 +02:00
Riccardo Spagni
845afb5191
Merge pull request #2613 
2051f89f cmake: build tests last (redfish)
 2017-10-15 18:58:31 +02:00
Riccardo Spagni
73f0c16743
Merge pull request #2606 
4090e8c6 simplewallet: add get/set for refresh-from-height (moneromooo-monero)
 2017-10-15 18:51:11 +02:00
Riccardo Spagni
d5ab55b8d7
Merge pull request #2604 
0a872798 protocol: kick idle peers by dropping them (moneromooo-monero)
 2017-10-15 18:50:32 +02:00
Riccardo Spagni
f1bee553b1
Merge pull request #2602 
bc1b9333 frob level 1 logs a bit for consistency (moneromooo-monero)
 2017-10-15 18:49:48 +02:00
Riccardo Spagni
f484b162db
Merge pull request #2599 
b776c725 daemon: use @N syntax to output_histogram for specific amounts (moneromooo-monero)
 2017-10-15 18:48:19 +02:00
Riccardo Spagni
e50bf5f811
Merge pull request #2597 
c4136134 miner: always update block template when starting (moneromooo-monero)
 2017-10-15 18:47:43 +02:00
Riccardo Spagni
5c3275ddbe
Merge pull request #2596 
06fb9bcf wallet2: fix refresh height calc for new wallets (moneromooo-monero)
 2017-10-15 18:47:16 +02:00
Riccardo Spagni
71253c1dcd
Merge pull request #2592 
dc19659d Remove network_address_base which has been merged with ipv4_network_address in 8b006877 (Michał Sałaban)
2183ade0 Don't try to create wallet-dir when it's not given, don't crash if wallet-dir already exists. (Michał Sałaban)
 2017-10-15 18:39:13 +02:00
Riccardo Spagni
1280ba4f5b
Merge pull request #2589 
8f0cea63 add a command_line function to check for defaulted options (moneromooo-monero)
 2017-10-15 18:38:46 +02:00
Riccardo Spagni
3eac7ab94f
Merge pull request #2587 
cba34494 rpc: out_peers now works again (moneromooo-monero)
 2017-10-15 18:38:12 +02:00
Riccardo Spagni
50f0c1f0e0
Merge pull request #2586 
7b8d3ec6 wallet-cli: add --do-not-relay option (stoffu)
 2017-10-15 18:37:38 +02:00
Riccardo Spagni
1740f0a13e
Merge pull request #2583 
27fdaaa4 Fix building with -DARCH=default -DNO_AES=ON (moneromooo-monero)
 2017-10-15 18:37:14 +02:00
Riccardo Spagni
147ecb6b7a
Merge pull request #2573 
7e7acdc3 daemon: catch out of range exceptions too when calling stoll/stoi (moneromooo-monero)
 2017-10-15 18:34:48 +02:00
Riccardo Spagni
1e577e8fbf
Merge pull request #2571 
8028dde7 block_queue: use boost::uuids::nil_uuid where appropriate (moneromooo-monero)
 2017-10-15 18:34:26 +02:00
Riccardo Spagni
27ed7419bb
Merge pull request #2570 
f139a6ca wallet2: fix backlog being off by 1 (moneromooo-monero)
 2017-10-15 18:33:51 +02:00
Riccardo Spagni
1039b5e813
Merge pull request #2569 
b5b4abb8 simplewallet: fix setting default-ring-size to 0 (moneromooo-monero)
 2017-10-15 18:32:41 +02:00
Riccardo Spagni
c45f3ac4d9
Merge pull request #2568 
7130cf0c Add tools::on_startup, and warn about glibc 2.25 bug if found (moneromooo-monero)
 2017-10-15 18:32:09 +02:00
Riccardo Spagni
2babd2e0a3
Merge pull request #2567 
54940d8c blockchain_import: remove a few commented out obsolete lines (moneromooo-monero)
 2017-10-15 18:29:18 +02:00
Riccardo Spagni
1c546e0d81
Merge pull request #2565 
452d4fae tests: fix hashchain unit tests (moneromooo-monero)
 2017-10-15 18:27:08 +02:00
Riccardo Spagni
960886aa04
Merge pull request #2109 
97c2e449 wallet2+API: use separate callbacks for lightwallets (Jaquee)
d9261867 walletAPI: correct confirmations in txHistory for unsynced wallets (Jaquee)
9442b043 walletAPI: lightwallet exceptions (Jaquee)
fc922934 walletAPI: add lightwallet login() and importWalletRequest() (Jaquee)
79207743 walletAPI: init() lightwallet and SSL support (Jaquee)
dde5a1fc walletAPI: add tx unlock_time (Jaquee)
bba5cbed wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2 (Jaquee)
7a482f30 wallet2: create_transactions_2 lightwallet support (Jaquee)
ce61b818 wallet2: get_outs lightwallet support (Jaquee)
1197cb71 wallet2: commit_tx() lightwallet support (Jaquee)
43b57804 wallet2: refactor is_tx_spendtime_unlocked() (Jaquee)
32e2b003 wallet2: add lightwallet exceptions to common functions (Jaquee)
2e692fc0 wallet2: refresh() lightwallet support (Jaquee)
f44d156c my/openmonero API functions (Jaquee)
288d3c75 wallet2: add remove_obsolete_pool_txs() (Jaquee)
2c6aad7e wallet2: add on_pool_tx_removed callback (Jaquee)
ff7c30aa wallet2: light wallet member variables (Jaquee)
e2a276cb wallet2: add ssl option to init() (Jaquee)
a13540be add string_tools::validate_hex() (Jaquee)
fd773d88 refactor cryptonote_basic::add_tx_pub_key_to_extra (Jaquee)
8bfa6c2d lightwallet rpc server commands (Jaquee)
76961ddc Serializer: string to integer conversion for MyMonero compatibility (Jaquee)
1cf940f2 epee http_client SSL support (Jaquee)
eec10137 CMakeLists.txt - Add openssl include dir (Jaquee)
 2017-10-15 18:25:08 +02:00
Jaquee
97c2e449ce wallet2+API: use separate callbacks for lightwallets 2017-10-15 17:58:28 +02:00
Jaquee
d92618675b walletAPI: correct confirmations in txHistory for unsynced wallets 2017-10-15 17:58:28 +02:00
Jaquee
9442b04302 walletAPI: lightwallet exceptions 2017-10-15 17:57:45 +02:00
Jaquee
fc9229342d walletAPI: add lightwallet login() and importWalletRequest() 2017-10-15 17:57:43 +02:00
Jaquee
79207743b8 walletAPI: init() lightwallet and SSL support 2017-10-15 17:56:35 +02:00
Jaquee
dde5a1fc36 walletAPI: add tx unlock_time 2017-10-15 17:54:17 +02:00
Jaquee
bba5cbed8f wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2 2017-10-15 17:54:14 +02:00
Jaquee
7a482f302b wallet2: create_transactions_2 lightwallet support 2017-10-15 17:51:20 +02:00
Jaquee
ce61b8189b wallet2: get_outs lightwallet support 2017-10-15 17:50:03 +02:00
Jaquee
1197cb71e9 wallet2: commit_tx() lightwallet support 2017-10-15 17:48:45 +02:00
Jaquee
43b57804f8 wallet2: refactor is_tx_spendtime_unlocked() 2017-10-15 17:48:45 +02:00
Jaquee
32e2b0030e wallet2: add lightwallet exceptions to common functions 2017-10-15 17:48:41 +02:00
Jaquee
2e692fc05a wallet2: refresh() lightwallet support 2017-10-15 17:42:50 +02:00
Jaquee
f44d156cbd my/openmonero API functions 2017-10-15 17:42:29 +02:00
Jaquee
288d3c75c3 wallet2: add remove_obsolete_pool_txs() 2017-10-15 17:39:54 +02:00
Jaquee
2c6aad7ea7 wallet2: add on_pool_tx_removed callback 2017-10-15 17:35:15 +02:00
Jaquee
ff7c30aadc wallet2: light wallet member variables 2017-10-15 17:35:08 +02:00
Riccardo Spagni
56ea442fd3
Merge pull request #2555 
a4b4651c dns_utils: allow an optional DNS server IP in DNS_PUBLIC (moneromooo-monero)
 2017-10-15 17:33:09 +02:00
Riccardo Spagni
d316b3d266
Merge pull request #2554 
d74336d5 wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr (stoffu)
 2017-10-15 17:32:30 +02:00
Jaquee
e2a276cbb5 wallet2: add ssl option to init() 2017-10-15 17:32:13 +02:00
Jaquee
fd773d88cd refactor cryptonote_basic::add_tx_pub_key_to_extra 2017-10-15 17:32:09 +02:00
Riccardo Spagni
d8bc28cc36
Merge pull request #2552 
69ce33f2 core: fix failure to sync when a tx is already in the pool (moneromooo-monero)
 2017-10-15 17:31:37 +02:00
Riccardo Spagni
62629541a5
Merge pull request #2550 
735fafec simplewallet: allow 1/yes/y as well as true for start_mining options (moneromooo-monero)
 2017-10-15 17:31:14 +02:00
Riccardo Spagni
ce1016254a
Merge pull request #2549 
bf2d9113 simplewallet: fix --restore-from-height being ignored (moneromooo-monero)
 2017-10-15 17:30:53 +02:00
Jaquee
8bfa6c2d9f lightwallet rpc server commands 2017-10-15 17:30:23 +02:00
Riccardo Spagni
5df4ecbb83
Merge pull request #2528 
551a8ea6 mnemonics: new Lojban word list (Wei Tang)
 2017-10-15 17:27:58 +02:00
Riccardo Spagni
5ea20d6944
Merge pull request #2469 
7adceee6 precomputed block hashes are now in blocks of N (currently 256) (moneromooo-monero)
 2017-10-15 17:23:50 +02:00
moneromooo-monero
118a1bed28
rpc: make get_coinbase_tx_sum a restricted RPC 
It's pretty slow and I/O intensive
 2017-10-14 09:49:24 +01:00
moneromooo-monero
7130cf0c61
Add tools::on_startup, and warn about glibc 2.25 bug if found 
https://sourceware.org/bugzilla/show_bug.cgi?id=21778
 2017-10-14 09:12:28 +01:00
moneromooo-monero
22b51e0672
db_lmdb: include chain height when failing to find an output key 
To help debugging logs.
 2017-10-12 13:28:28 +01:00
moneromooo-monero
5db433b3f7
blockchain: avoid exceptions in output verification 
This can happen if we get a bad tx, so let's not spam the log.
 2017-10-12 13:27:20 +01:00
moneromooo-monero
529a6a4af8
core: guard against a mined block not finding all txes in the pool 
This can happen for several reasons, but mainly if another block
was received, which took that tx off the pool.
 2017-10-11 13:00:49 +01:00
moneromooo-monero
a4b4651cb0
dns_utils: allow an optional DNS server IP in DNS_PUBLIC 
tcp://a.b.c.d
 2017-10-10 12:29:05 +01:00
moneromooo-monero
6bd4dac6e2
util: ignore SIGPIPE 
In practice, this seems to cause monero-wallet-rpc to exit
when ^C quits whatever its output is piped into (such as tee),
but it saves, while it did not before.
 2017-10-09 21:46:01 +01:00
moneromooo-monero
7dbf76d0da
Fix an object lifetime bug in net load tests 
The commands handler must not be destroyed before the config
object, or we'll be accessing freed memory.

An earlier attempt at using boost::shared_ptr to control object
lifetime turned out to be very invasive, though would be a
better solution in theory.
 2017-10-09 16:46:42 +01:00
redfish
2051f89fbe cmake: build tests last 
Keep -Werror for src, contrib and do not pass it for tests/
 2017-10-08 20:47:50 -04:00
binaryFate
93ad1f8723 Fix #2559: more flexible print_tx daemon command 2017-10-08 22:35:35 +02:00
moneromooo-monero
4090e8c6e5
simplewallet: add get/set for refresh-from-height 2017-10-08 10:14:44 +01:00
moneromooo-monero
0a872798bc
protocol: kick idle peers by dropping them 
This is safer, as we don't risk break expectations (eg, requesting
block hashes and then receiving a late set of blocks). Dropping a
connection means another will be attempted in a fresh state.

Also bump the kick timeout to 5 minutes, to ensure we only kick
really idle peers.
 2017-10-07 20:29:11 +01:00
moneromooo-monero
bc1b93333e
frob level 1 logs a bit for consistency 
Level 1 logs map to INFO, so setting log level to 1 should
show these. Demote some stuff to DEBUG to avoid spam, though.
 2017-10-07 20:03:42 +01:00
Michał Sałaban
dc19659d16 Remove network_address_base which has been merged with ipv4_network_address in 8b006877 2017-10-07 19:29:30 +02:00
moneromooo-monero
b776c72568
daemon: use @N syntax to output_histogram for specific amounts 
Makes debugging tx verification easier
 2017-10-07 16:45:54 +01:00
moneromooo-monero
c413613416
miner: always update block template when starting 
This fixes using the previous address when starting mining,
then stopping and restarting with a different address
 2017-10-07 11:32:36 +01:00
moneromooo-monero
06fb9bcfcc
wallet2: fix refresh height calc for new wallets 2017-10-07 11:21:11 +01:00
kenshi84
53ad5a0f42
Subaddresses 2017-10-07 13:06:21 +09:00
stoffu
7b8d3ec6ba
wallet-cli: add --do-not-relay option 2017-10-07 12:46:09 +09:00
stoffu
d74336d5c9
wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr 2017-10-07 12:45:32 +09:00
Michał Sałaban
2183ade0c4 Don't try to create wallet-dir when it's not given, don't crash if wallet-dir already exists. 2017-10-07 02:04:33 +02:00
Riccardo Spagni
86e9de588c
Merge pull request #2548 
7d4ef258 rpc: fix getting txpool transactions (moneromooo-monero)
 2017-10-06 23:00:43 +04:00
Riccardo Spagni
09ccd07bbc
Merge pull request #2542 
180a848c wallet2: Missing underflow check on low heights (landergate)
 2017-10-06 23:00:24 +04:00
Riccardo Spagni
e8a7291d12
Merge pull request #2541 
15e62581 connection_context: initialize m_callback_request_count to 0 (moneromooo-monero)
5fa199c6 copyable_atomic: add a ctor with initial value (moneromooo-monero)
 2017-10-06 22:58:54 +04:00
Riccardo Spagni
2ff832c576
Merge pull request #2540 
71c7f8d0 core: fix logging the one time public key on error (moneromooo-monero)
 2017-10-06 22:58:20 +04:00
Riccardo Spagni
fb7dcb6ec0
Merge pull request #2539 
93ed9321 cmake: add libversion and libcheckpoints to libwallet_merged (redfish)
 2017-10-06 22:57:20 +04:00
Riccardo Spagni
4a20a5b5ea
Merge pull request #2537 
269a2a01 blockchain: fix off by one getting blocks (moneromooo-monero)
 2017-10-06 22:56:17 +04:00
Riccardo Spagni
478b14b565
Merge pull request #2534 
4e115a3a core: remove out sorting from v7 rules (moneromooo-monero)
 2017-10-06 22:55:00 +04:00
Riccardo Spagni
6cf36b4e96
Merge pull request #2530 
cbc5508b construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly (stoffu)
 2017-10-06 22:54:19 +04:00
Riccardo Spagni
1c044b162c
Merge pull request #2529 
bd937139 wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper (stoffu)
 2017-10-06 22:53:28 +04:00
Riccardo Spagni
c58ec8cdc1
Merge pull request #2468 
986d03d4 simplewallet: allow to set threshold before warning about tx backlog (selsta)
 2017-10-06 22:50:41 +04:00
moneromooo-monero
8f0cea6355
add a command_line function to check for defaulted options 2017-10-06 10:56:18 +01:00
moneromooo-monero
27fdaaa409
Fix building with -DARCH=default -DNO_AES=ON 2017-10-06 08:47:03 +01:00
moneromooo-monero
cba3449415
rpc: out_peers now works again 2017-10-06 08:40:14 +01:00
Lee Clagett
8b00687735 Upgrades to epee::net_utils::network_address 
- internal nullptr checks
  - prevent modifications to network_address (shallow copy issues)
  - automagically works with any type containing interface functions
  - removed fnv1a hashing
  - ipv4_network_address now flattened with no base class
 2017-10-05 11:57:09 -04:00
moneromooo-monero
7e7acdc32b
daemon: catch out of range exceptions too when calling stoll/stoi 
And any other exception, just to be safe
 2017-10-03 17:36:44 +01:00
moneromooo-monero
8028dde7a6
block_queue: use boost::uuids::nil_uuid where appropriate 2017-10-03 11:55:45 +01:00
moneromooo-monero
f139a6cad0
wallet2: fix backlog being off by 1 
We don't want to count "partly filled" blocks in this case
 2017-10-03 11:49:46 +01:00
moneromooo-monero
b5b4abb8a6
simplewallet: fix setting default-ring-size to 0 
It'd be set to the current wallet default instead
 2017-10-03 11:45:02 +01:00
moneromooo-monero
54940d8ca4
blockchain_import: remove a few commented out obsolete lines 2017-10-03 09:15:57 +01:00
moneromooo-monero
452d4fae39
tests: fix hashchain unit tests 
and relax the not-empty safety check to stay more intuitiuve
 2017-10-03 00:51:53 +01:00
stoffu
bd9371395e
wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper 2017-10-03 08:13:00 +09:00
stoffu
cbc5508b15
construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly 2017-10-03 08:12:28 +09:00
Riccardo Spagni
5f430cedd8
Merge pull request #2515 
c34093db simplewallet: add privacy warning when using an untrusted demon (moneromooo-monero)
 2017-10-02 23:30:20 +04:00
Riccardo Spagni
87d0516f7d
Merge pull request #2513 
309290d1 Source updates are in a source subdirectory (moneromooo-monero)
 2017-10-02 23:29:25 +04:00
Riccardo Spagni
3bab2676ec
Merge pull request #2512 
792ba4f0 Log categories can now be added to and removed from (moneromooo-monero)
48f92eb6 easylogging++: add categories getter (moneromooo-monero)
f35afe62 epee: factor log level/categories setting (moneromooo-monero)
 2017-10-02 23:28:59 +04:00
Riccardo Spagni
db45291c8d
Merge pull request #2506 
c3de19ed json_object: add missing do_not_relay to tx_in_pool serialization (moneromooo-monero)
 2017-10-02 23:27:21 +04:00
selsta
986d03d4b2 simplewallet: allow to set threshold before warning about tx backlog 2017-10-02 21:23:33 +02:00
Riccardo Spagni
abe24f4429
Merge pull request #2504 
f182acdd dns_utils: query DNS records in parallel (moneromooo-monero)
 2017-10-02 23:21:10 +04:00
Riccardo Spagni
737717c111
Merge pull request #2491 
d5a9edf2 wallet2: fix exception on split txes (moneromooo-monero)
5c5b0fd0 wallet2: print unused indices on a single line (moneromooo-monero)
 2017-10-02 23:17:57 +04:00
Riccardo Spagni
3bf20a77f2
Merge pull request #2470 
2e59f6ea rpc: add new RPCs to get and set limits (MaxXor)
 2017-10-02 23:15:22 +04:00
moneromooo-monero
37c12119ab
wallet2: fix hash chain trimming when the inner chain becomes empty 
It'd prevent further syncing. Recovery of empty hash chains is
automatic, but requires a running daemon
 2017-10-02 12:52:22 +01:00
moneromooo-monero
69ce33f217
core: fix failure to sync when a tx is already in the pool 2017-09-29 21:34:10 +01:00
moneromooo-monero
735fafecb0
simplewallet: allow 1/yes/y as well as true for start_mining options 
Also mention those options in the start_mining help line
 2017-09-29 19:17:25 +01:00
moneromooo-monero
bf2d911365
simplewallet: fix --restore-from-height being ignored 2017-09-29 19:06:14 +01:00
moneromooo-monero
7d4ef25800
rpc: fix getting txpool transactions 2017-09-29 16:29:26 +01:00
moneromooo-monero
4e115a3a4c
core: remove out sorting from v7 rules 
and restore random shuffle of outputs

This turned out to have a flaw (sort order depends on output
index), and this doesn't really bring much anyway
 2017-09-27 12:42:08 +01:00
landergate
180a848cbe wallet2: Missing underflow check on low heights 
Lack of it results in `m_refresh_from_block_height` being < 0 (18446744...) on low heights, which blocks `process_new_blockchain_entry` and never process coins on heights less than blocks_per_month.
Follow-up to #2258
 2017-09-27 14:17:48 +03:00
moneromooo-monero
15e6258136
connection_context: initialize m_callback_request_count to 0 2017-09-27 11:43:12 +01:00
moneromooo-monero
71c7f8d0dc
core: fix logging the one time public key on error 2017-09-27 11:40:05 +01:00
redfish
93ed932143 cmake: add libversion and libcheckpoints to libwallet_merged 
Needed to link monero-core Qt wallet.
 2017-09-27 00:57:02 -04:00
moneromooo-monero
269a2a01ef
blockchain: fix off by one getting blocks 2017-09-27 00:31:49 +01:00
Riccardo Spagni
5f7cddeb53
Merge pull request #2533 
97cdd4c9 core: undo output sorting (moneromooo-monero)
 2017-09-26 15:59:32 +02:00
moneromooo-monero
97cdd4c92f
core: undo output sorting 
It looks like it may be buggy
 2017-09-26 13:23:31 +01:00
Wei Tang
551a8ea60e mnemonics: new Lojban word list 
Word list authored by: sorpaas
Sources:
  lo gimste jo'u lo ma'oste (http://guskant.github.io/lojbo/gismu-cmavo.html)
  N-grams of Lojban corpus (https://mw.lojban.org/papri/N-grams_of_Lojban_corpus)
 2017-09-26 06:42:17 +08:00
Riccardo Spagni
21c2c08041
Merge pull request #2527 
ba6907f6 core: fix creation of v1 txes (moneromooo-monero)
 2017-09-25 23:29:32 +02:00
moneromooo-monero
ba6907f661
core: fix creation of v1 txes 2017-09-25 22:27:30 +01:00
Riccardo Spagni
0c5730b101
Merge pull request #2526 
db215ecd checkpoints: add missing CMakeLists.txt (moneromooo-monero)
 2017-09-25 22:46:46 +02:00
moneromooo-monero
db215ecdb6
checkpoints: add missing CMakeLists.txt 2017-09-25 21:44:53 +01:00
moneromooo-monero
36c3465b98
wallet2: do not keep block hashes below last checkpoint 
This saves a lot of space and load/save time for wallet caches
 2017-09-25 21:16:40 +01:00
moneromooo-monero
cdbbe99c82
checkpoints: add a token checkpoint on testnet (the genesis block) 2017-09-25 21:16:35 +01:00
moneromooo-monero
493fad8053
serialization: add deque serialization 2017-09-25 21:16:32 +01:00
moneromooo-monero
fa54b20584
fix typo in basic and core CMakeLists.txt 2017-09-25 21:16:29 +01:00
moneromooo-monero
5d65a75b69
move checkpoints in a separate library 2017-09-25 21:16:26 +01:00
Riccardo Spagni
85f4b600d2
Merge pull request #2466 
bc429e9c daemon: make this build with boost 1.61 (moneromooo-monero)
 2017-09-25 21:06:47 +02:00
Riccardo Spagni
0d52b1392f
Merge pull request #2525 
8e0670c6 version: fix link to new version strings (moneromooo-monero)
 2017-09-25 20:14:18 +02:00
moneromooo-monero
8e0670c684
version: fix link to new version strings 
p2p uses it, and the cpp file needs to know the symbols should
be public
 2017-09-25 19:01:56 +01:00
moneromooo-monero
2ec928badb
wallet2: simplify tx processing a bit 2017-09-25 18:35:51 +01:00
moneromooo-monero
740e6533a5
wallet2: factor some of the tx scanning code 2017-09-25 16:11:28 +01:00
Riccardo Spagni
74c4f1a563
Merge pull request #2460 
3487d810 cryptonote_protocol: fix needless chain hashes downloads (moneromooo-monero)
 2017-09-25 17:01:53 +02:00
Riccardo Spagni
13be8115e4
Merge pull request #2458 
7f2f6ee1 protocol: remove hop count on block propagation (moneromooo-monero)
 2017-09-25 17:00:47 +02:00
Riccardo Spagni
e5a2cdbfad
Merge pull request #2457 
d2d8a41c Use actual batch size for resize estimates (Howard Chu)
 2017-09-25 16:57:07 +02:00
Riccardo Spagni
32bbe62120
Merge pull request #2456 
91def9a5 daemon, wallet: add --max-log-file-size option (selsta)
 2017-09-25 16:54:08 +02:00
Riccardo Spagni
0e74777071
Merge pull request #2452 
0aaaca29 tx_pool: set the "invalid input" bit when check_tx_inputs fails (moneromooo-monero)
9236823b simplewallet: print tx rejection reason where it was missing (moneromooo-monero)
3dee3301 core_rpc_server: print tx rejection reason at L0 too (moneromooo-monero)
 2017-09-25 16:53:07 +02:00
Riccardo Spagni
c2346c6c59
Merge pull request #2424 
28b72b6e tx_pool: pre-init tvc.m_verifivation_failed before processing (moneromooo-monero)
50a629b2 core_tests: catch (impossible in practice) tx extra api failure (moneromooo-monero)
fee15ef1 wallet2: catch failure to parse address (moneromooo-monero)
1399e26d net_peerlist: remove dead code (moneromooo-monero)
50e09698 tx_pool: guard against failure getting tx hash (moneromooo-monero)
54cc209a wallet_rpc_server: catch failure to create directory (moneromooo-monero)
3e55099c wallet_rpc_server: init m_vm to NULL in ctor (moneromooo-monero)
7d0dde5e wallet_args: remove redundant default value for --log-file (moneromooo-monero)
ed4a3350 wallet2: catch failure to save keys file (moneromooo-monero)
44434c8a wallet2_api: check whether dynamic_cast returns NULL (moneromooo-monero)
92f2f687 core: check return value from parse_hexstr_to_binbuff (moneromooo-monero)
5475692e wallet2_api: remove an unused, uninitialized, field (moneromooo-monero)
a7ba3de1 libwallet_api_tests: initialize newblock_triggered on reset (moneromooo-monero)
b2763ace wallet2_api: init error code to "no error" in the ctor (moneromooo-monero)
b5faac53 get_blockchain_top now returns void (moneromooo-monero)
2e44d8f2 wallet_rpc_server: guard against exceptions (moneromooo-monero)
4230876b simplewallet: guard against I/O exceptions (moneromooo-monero)
06c1e057 daemon: initialize decode_as_json in RPC request (moneromooo-monero)
11f71af5 http_base: init size_t in http_request_info ctor (moneromooo-monero)
 2017-09-25 16:52:27 +02:00
Riccardo Spagni
5953724f69
Merge pull request #2443 
ffe27127 wallet_rpc_server: fix index for newly added address book entry (moneromooo-monero)
 2017-09-25 16:51:07 +02:00
Riccardo Spagni
b911130a46
Merge pull request #2442 
e29282d2 build: auto update version info without manually deleting version.h (stoffu)
 2017-09-25 16:50:35 +02:00
Riccardo Spagni
08ada1fa8b
Merge pull request #2440 
6137a0b9 blockchain: reject unsorted ins and outs from v7 (moneromooo-monero)
16afab90 core: sort ins and outs key key image and public key, respectively (moneromooo-monero)
0c36b9f9 common: add apply_permutation file and function (moneromooo-monero)
 2017-09-25 16:49:01 +02:00
moneromooo-monero
28b72b6ecc
tx_pool: pre-init tvc.m_verifivation_failed before processing 
CID 175316
 2017-09-25 15:48:59 +01:00
moneromooo-monero
fee15ef1a9
wallet2: catch failure to parse address 
CID 175297
 2017-09-25 15:48:48 +01:00
moneromooo-monero
1399e26d7e
net_peerlist: remove dead code 
CID 175290
 2017-09-25 15:48:45 +01:00
moneromooo-monero
50e096987b
tx_pool: guard against failure getting tx hash 
Should be impossible in practice, but easy change

CID 175282
 2017-09-25 15:48:42 +01:00
moneromooo-monero
54cc209a5e
wallet_rpc_server: catch failure to create directory 
CID 175281
 2017-09-25 15:48:39 +01:00
moneromooo-monero
3e55099cb2
wallet_rpc_server: init m_vm to NULL in ctor 
CID 175279
 2017-09-25 15:48:36 +01:00
moneromooo-monero
7d0dde5eb5
wallet_args: remove redundant default value for --log-file 
CID 175265
 2017-09-25 15:48:33 +01:00
moneromooo-monero
ed4a33502d
wallet2: catch failure to save keys file 
CID 161848
 2017-09-25 15:48:30 +01:00
moneromooo-monero
44434c8a37
wallet2_api: check whether dynamic_cast returns NULL 
CID 161844
 2017-09-25 15:48:27 +01:00
moneromooo-monero
92f2f687b9
core: check return value from parse_hexstr_to_binbuff 2017-09-25 15:48:24 +01:00
moneromooo-monero
5475692ed5
wallet2_api: remove an unused, uninitialized, field 
Silences CID 161874
 2017-09-25 15:48:21 +01:00
moneromooo-monero
b2763ace06
wallet2_api: init error code to "no error" in the ctor 
CID 161872
 2017-09-25 15:48:16 +01:00
moneromooo-monero
b5faac5304
get_blockchain_top now returns void 
It was always returning true, and could not be foreseen to
usefully return errors in the future. This silences CID 162652
as well as saves some checking code in a few places.
 2017-09-25 15:48:13 +01:00
moneromooo-monero
2e44d8f23c
wallet_rpc_server: guard against exceptions 
CID 175305
 2017-09-25 15:48:10 +01:00
moneromooo-monero
4230876b31
simplewallet: guard against I/O exceptions 
CID 175308
 2017-09-25 15:48:06 +01:00
moneromooo-monero
06c1e05735
daemon: initialize decode_as_json in RPC request 
CID 161886
 2017-09-25 15:48:03 +01:00
Riccardo Spagni
174f2fb4da
Merge pull request #2428 
054054c9 p2p: disable gray list housekeeping when an exclusive node is given (moneromooo-monero)
 2017-09-25 16:46:26 +02:00
Riccardo Spagni
c2e46edca2
Merge pull request #2398 
e0592e87 dns_utils: remove a few obsolete things (moneromooo-monero)
 2017-09-25 16:44:37 +02:00
Riccardo Spagni
ce37967dd2
Merge pull request #2386 
a15e8583 wallet2: guard against daemon sending txes in the wrong order (moneromooo-monero)
8fe5f609 rpc: order transactions in the order they were requested (moneromooo-monero)
 2017-09-25 16:40:54 +02:00
Riccardo Spagni
216395d43e
Merge pull request #2379 
9c83f806 Do not create file when RPC user/pass is given and use file locking (Lee Clagett)
 2017-09-25 16:40:35 +02:00
Riccardo Spagni
ec0e144e90
Merge pull request #2377 
b5cbdce8 wallet2: correctly handle in/out payments for view-only wallet (stoffu)
 2017-09-25 16:40:16 +02:00
Riccardo Spagni
44ad32fd4a
Merge pull request #2357 
58015df4 Fix getblocktemplate RPC returning wrong reserved_offset (Guillaume LE VAILLANT)
 2017-09-25 16:39:01 +02:00
Riccardo Spagni
40d213154b
Merge pull request #2289 
6ee1116d store is optional during close and defaults to true; except during descruction (m2049r)
 2017-09-25 16:38:14 +02:00
Riccardo Spagni
c6306e75e7
Merge pull request #2257 
651baaec wallet: add encrypted seed functionality (moneromooo-monero)
 2017-09-25 16:37:17 +02:00
m2049r
6ee1116d75 store is optional during close and defaults to true; except during descruction 2017-09-23 00:52:09 +02:00
moneromooo-monero
c34093db58
simplewallet: add privacy warning when using an untrusted demon 2017-09-22 22:19:22 +01:00
moneromooo-monero
309290d1c7
Source updates are in a source subdirectory 
rather than in the same directory as the prebuilt versions
 2017-09-22 21:48:19 +01:00
moneromooo-monero
792ba4f0fe
Log categories can now be added to and removed from 
Also, set_log without parameters now prints the log categories
 2017-09-22 18:08:14 +01:00
moneromooo-monero
c3de19edd6
json_object: add missing do_not_relay to tx_in_pool serialization 2017-09-21 13:37:30 +01:00
Riccardo Spagni
1f9058187c
Merge pull request #2496 
3b8b4be5 tx_pool: drop invalid txes from the pool on startup (moneromooo-monero)
 2017-09-21 12:07:35 +02:00
Riccardo Spagni
8cc9b0e739
Merge pull request #2492 
e457aa51 blockchain: fix crash checking pre-validated txids (moneromooo-monero)
 2017-09-21 12:07:22 +02:00
Riccardo Spagni
bd85a47a29
Merge pull request #2477 
9aeae7a2 db_lmdb: fix use of uninitialized key in for_blocks_range (moneromooo-monero)
 2017-09-21 12:07:08 +02:00
Riccardo Spagni
0f071848a1
Merge pull request #2479 
58908295 Fixes static_assert on arm and ppc builds (Lee Clagett)
 2017-09-21 11:50:34 +02:00
moneromooo-monero
f182acdd36
dns_utils: query DNS records in parallel 2017-09-21 09:23:08 +01:00
Riccardo Spagni
48512acda9
Merge pull request #2324 
c09aa94d daemon: indicate whether  the spent key image is mined or unconfirmed (stoffu)
 2017-09-21 10:12:24 +02:00
Riccardo Spagni
07312a7d6e
Merge pull request #2302 
ef005f5e p2p: add a couple early outs when the stop signal is received (moneromooo-monero)
80d361c7 abstract_tcp_server2: improve tracking/cancelling of early connections (moneromooo-monero)
 2017-09-21 10:11:33 +02:00
stoffu
e29282d208
build: auto update version info without manually deleting version.h 2017-09-21 07:47:37 +09:00
stoffu
c09aa94d34
daemon: indicate whether the spent key image is mined or unconfirmed 2017-09-21 07:46:44 +09:00
stoffu
b5cbdce8a6
wallet2: correctly handle in/out payments for view-only wallet 2017-09-21 07:46:19 +09:00
Riccardo Spagni
a6403846ef
Merge pull request #2441 
fee3c3ed Update wallet2.cpp for misspelling (Matthew Campassi)
 2017-09-20 21:41:33 +02:00
Riccardo Spagni
786a4ae9ea
Merge pull request #2429 
55b91d86 wallet: fix --help and --version erroring out (moneromooo-monero)
 2017-09-20 21:41:09 +02:00
Riccardo Spagni
10d60d2524
Merge pull request #2414 
ea016330 updated clarification bc_dyn_stats (Matthew Campassi)
5aa2f24b clarification bc_dyn_stats (Matthew Campassi)
 2017-09-20 21:37:55 +02:00
Riccardo Spagni
8f1f43163a
Merge pull request #2412 
81fb2f53 Silence more stupid gcc warnings (Howard Chu)
 2017-09-20 21:37:40 +02:00
Riccardo Spagni
8711c355fc
Merge pull request #2410 
20256b7c Fix AC power supply detection on Linux (Guillaume LE VAILLANT)
 2017-09-20 21:36:09 +02:00
Riccardo Spagni
72207fd27a
Merge pull request #2381 
840aed1c monero-wallet-cli: New command 'wallet_info' improved (rbrunner7)
9bdd985c monero-wallet-cli: New command 'wallet_info' (rbrunner7)
 2017-09-20 21:34:48 +02:00
Riccardo Spagni
75563db6e3
Merge pull request #2376 
e3680b69 Rename m_listenning_port to m_listening_port (MaxXor)
a1ea475f Delete UPnP port mapping on exit (MaxXor)
 2017-09-20 21:33:21 +02:00
moneromooo-monero
3b8b4be5cb
tx_pool: drop invalid txes from the pool on startup 
instead of just failing

This is a workaround for bad tx blobs being inserted in the
pool for unknown reasons
 2017-09-20 18:55:16 +01:00
moneromooo-monero
e457aa51f4
blockchain: fix crash checking pre-validated txids 2017-09-20 10:46:13 +01:00
moneromooo-monero
d5a9edf27a
wallet2: fix exception on split txes 2017-09-20 10:35:15 +01:00
moneromooo-monero
5c5b0fd048
wallet2: print unused indices on a single line 
Decreases log spam massively on large wallets
 2017-09-20 10:34:45 +01:00
Lee Clagett
5890829552 Fixes static_assert on arm and ppc builds 2017-09-19 10:57:01 -04:00
moneromooo-monero
9aeae7a224
db_lmdb: fix use of uninitialized key in for_blocks_range 2017-09-19 14:11:24 +01:00
MaxXor
2e59f6ea50 rpc: add new RPCs to get and set limits 2017-09-19 10:30:55 +02:00
moneromooo-monero
7adceee634
precomputed block hashes are now in blocks of N (currently 256) 
This shaves a lot of space off binaries
 2017-09-18 16:29:00 +01:00
Riccardo Spagni
1a73843cec
Merge pull request #2446 
6d0ca7d1 Tweak concurrency limits (Howard Chu)
510d0d47 Use a threadpool (Howard Chu)
 2017-09-18 13:19:26 +02:00
Riccardo Spagni
69e039aa19
Merge pull request #2023 
f761dbae Remove 1.25x multiplier from tx_pool (Nano Akron)
 2017-09-18 13:11:57 +02:00
Riccardo Spagni
591e53445b
Merge pull request #2044 
0299cb77 Fix various oversights/bugs in ZMQ RPC server code (Thomas Winget)
77986023 json serialization for rpc-relevant monero types (Thomas Winget)
5c1e08fe Refactor some things into more composable (smaller) functions (Thomas Winget)
9ac2ad07 DRY refactoring (Thomas Winget)
 2017-09-18 13:08:16 +02:00
moneromooo-monero
bc429e9c6d
daemon: make this build with boost 1.61 2017-09-18 11:24:49 +01:00
moneromooo-monero
6137a0b94d
blockchain: reject unsorted ins and outs from v7 
This ensures no information is leaked by the ordering
 2017-09-18 11:23:15 +01:00
Howard Chu
d2d8a41c47
Use actual batch size for resize estimates 
And optimize import startup:

Remember start_height position during initial count_blocks pass
to avoid having to reread entire file again to arrive at start_height
 2017-09-17 22:08:40 +01:00
moneromooo-monero
3487d81034
cryptonote_protocol: fix needless chain hashes downloads 
The last known hash was calculated incorrectly, causing
further chain hash downloads to restart from the current
chain. When the block queue has close to 10k blocks waiting,
this causes frequent downloads of 10k more hashes, but
with only the last few hashes actually being useful.
 2017-09-17 14:13:59 +01:00
moneromooo-monero
7f2f6ee1c9
protocol: remove hop count on block propagation 
It is unused, as it was apparently a future optimization,
and it leaks some information (though since pools publish
thei blocks they find, that amount seems small).
 2017-09-17 10:26:12 +01:00
selsta
91def9a59b daemon, wallet: add --max-log-file-size option 2017-09-17 04:42:45 +02:00
moneromooo-monero
0aaaca29a2
tx_pool: set the "invalid input" bit when check_tx_inputs fails 2017-09-16 11:27:52 +01:00
moneromooo-monero
9236823bf4
simplewallet: print tx rejection reason where it was missing 2017-09-16 10:33:42 +01:00
moneromooo-monero
3dee3301ba
core_rpc_server: print tx rejection reason at L0 too 2017-09-16 10:32:42 +01:00
Howard Chu
6d0ca7d11f
Tweak concurrency limits 
Create capacity for 2x max, but lie about it
 2017-09-15 00:28:48 +01:00
Howard Chu
510d0d4753
Use a threadpool 
Instead of constantly creating and destroying threads
 2017-09-14 21:42:48 +01:00
Nano Akron
f761dbaeaf Remove 1.25x multiplier from tx_pool 2017-09-14 21:26:19 +01:00
Riccardo Spagni
7abdba0a5c
Merge pull request #2438 
9443eec1 core: guard against exceptions in tx verification worker threads (moneromooo-monero)
 2017-09-14 18:31:46 +02:00
Riccardo Spagni
e0382a8da2
Merge pull request #2417 
a9845cc3 rpc: get_txpool_backlog is now unrestricted (moneromooo-monero)
 2017-09-14 18:26:30 +02:00
Riccardo Spagni
3399c2a257
Merge pull request #2404 
e5238adf update checkpoint hashes (Riccardo Spagni)
d4f56bdf update hardcoded checkpoints (Riccardo Spagni)
ed730511 update checkpoints.dat (Riccardo Spagni)
 2017-09-14 18:25:43 +02:00
Riccardo Spagni
718820cd96
Merge pull request #2396 
dbfef643 tx_pool: catch exceptions in LockedTXN dtor (moneromooo-monero)
 2017-09-14 18:25:28 +02:00
Riccardo Spagni
4c07297dc6
Merge pull request #2392 
6ac61100 Add a --fluffy-blocks option to relay blocks as fluffy blocks (moneromooo-monero)
 2017-09-14 18:25:15 +02:00
moneromooo-monero
ffe2712726
wallet_rpc_server: fix index for newly added address book entry 2017-09-13 11:02:06 +01:00
moneromooo-monero
16afab900d
core: sort ins and outs key key image and public key, respectively 
This avoids leaking some small amount of information
 2017-09-13 09:25:05 +01:00
moneromooo-monero
0c36b9f931
common: add apply_permutation file and function 
This algorithm is adapted from Raymond Chen's code:
https://blogs.msdn.microsoft.com/oldnewthing/20170109-00/?p=95145
 2017-09-13 09:25:01 +01:00
Matthew Campassi
fee3c3ed1e Update wallet2.cpp for misspelling 
Misspelling in wallet2.cpp
 2017-09-12 16:11:45 -05:00
moneromooo-monero
651baaec46
wallet: add encrypted seed functionality 
This uses luigi1111's CN_Add method.
See https://xmr.llcoins.net for details.
 2017-09-12 13:56:01 +01:00
moneromooo-monero
9443eec10f
core: guard against exceptions in tx verification worker threads 2017-09-12 12:07:10 +01:00
moneromooo-monero
a15e858302
wallet2: guard against daemon sending txes in the wrong order 2017-09-11 16:48:28 +01:00
moneromooo-monero
8fe5f609d1
rpc: order transactions in the order they were requested 2017-09-11 16:48:25 +01:00
moneromooo-monero
55b91d8605
wallet: fix --help and --version erroring out 2017-09-10 14:12:32 +01:00
moneromooo-monero
054054c92f
p2p: disable gray list housekeeping when an exclusive node is given 
Exclusive nodes may be used for privacy reasons, and thus we don't
want to connect to other nodes, even for checking connectivity.

See https://github.com/monero-project/monero/issues/2346
 2017-09-10 13:11:42 +01:00
moneromooo-monero
a9845cc344
rpc: get_txpool_backlog is now unrestricted 2017-09-08 23:47:11 +01:00
Matthew Campassi
ea01633024 updated clarification bc_dyn_stats 
updated clarification of required parameter for bc_dyn_stats
 2017-09-08 11:31:58 -05:00
Matthew Campassi
5aa2f24b2a clarification bc_dyn_stats 
clarification of required parameter for bc_dyn_stats
 2017-09-08 11:03:16 -05:00
Howard Chu
81fb2f5347
Silence more stupid gcc warnings 2017-09-08 11:36:49 +01:00
Guillaume LE VAILLANT
20256b7c04 Fix AC power supply detection on Linux 
The /sys/class/power_supply/*/present file usually does not exist for
AC power supplies.
 2017-09-08 11:07:56 +02:00
Riccardo Spagni
e5238adfb3
update checkpoint hashes 2017-09-06 17:32:48 +02:00
Riccardo Spagni
d4f56bdf09
update hardcoded checkpoints 2017-09-06 09:18:46 +02:00
Riccardo Spagni
ed730511dc
update checkpoints.dat 2017-09-06 09:18:40 +02:00
Thomas Winget
0299cb77ca
Fix various oversights/bugs in ZMQ RPC server code 
- Add some RPC commands (and touch up a couple others)
- some bounds checking
- some better pointer management
- const correctness and error handling

-- Thanks @vtnerd for type help with serialization and CMake changes
 2017-09-05 12:20:40 -04:00
Thomas Winget
77986023c3
json serialization for rpc-relevant monero types 
Structured {de-,}serialization methods for (many new) types
which are used for requests or responses in the RPC.

New types include RPC requests and responses, and structs which compose
types within those.

# Conflicts:
#	src/cryptonote_core/blockchain.cpp
 2017-09-05 12:20:27 -04:00
Thomas Winget
5c1e08fe80
Refactor some things into more composable (smaller) functions 
This commit refactors some of the rpc-related functions in the
Blockchain class to be more composable.  This change was made
in order to make implementing the new zmq rpc easier without
trampling on the old rpc.

New functions:
  Blockchain::get_num_mature_outputs
  Blockchain::get_random_outputs
  Blockchain::get_output_key
  Blockchain::get_output_key_mask_unlocked

  Blockchain::find_blockchain_supplement (overload)

functions which previously had this functionality inline now call these
functions as necessary.
 2017-09-05 12:17:32 -04:00
moneromooo-monero
dbfef643ed
tx_pool: catch exceptions in LockedTXN dtor 
This might prevent some calls to terminate when the LockedTXN
dtor is called as part of stack unwinding caused by another
exception in the first place.
 2017-09-04 10:18:38 +01:00
moneromooo-monero
e0592e87d8
dns_utils: remove a few obsolete things 2017-09-04 10:04:31 +01:00
moneromooo-monero
6ac61100a1
Add a --fluffy-blocks option to relay blocks as fluffy blocks 
Defaults to off, but fluffy blocks are forced enabled on testnet
 2017-09-03 11:11:11 +01:00
Howard Chu
1181848748
Use latest height for fork date estimate 2017-09-02 11:44:12 +01:00
Riccardo Spagni
02e5dcd2fa
Merge pull request #2384 
4e0e4e99 blockchain_import: warn for chunks over 500000, not 100000 (moneromooo-monero)
5b29e87f blockchain_import: properly cleanup core/db on exit (moneromooo-monero)
e167c4d9 blockchain_import: do not error out on truncated files (moneromooo-monero)
 2017-09-02 11:32:46 +02:00
Riccardo Spagni
c919ca4f1d
Merge pull request #2374 
e72e625e tx_pool: wrap tx meta updates in a LockedTXN (moneromooo-monero)
 2017-09-02 11:31:19 +02:00
Riccardo Spagni
1e57e48342
Merge pull request #2372 
c867357a cryptonote_protocol: error handling on cleanup_handle_incoming_blocks (moneromooo-monero)
ce901fcb Fix blockchain_import wedge on exception in cleanup_handle_incoming_blocks (moneromooo-monero)
84fa015e core: guard against exceptions in handle_incoming_{block,tx} (moneromooo-monero)
 2017-09-02 11:30:57 +02:00
Riccardo Spagni
ee1a766861
Merge pull request #2370 
3d19ab70 Revert "Cleanup test impact of moving blockchain_db_types()" (Howard Chu)
a95e460c move db specific options to BlockchainDB (moneromooo-monero)
 2017-09-02 11:30:38 +02:00
Riccardo Spagni
eb8dac52df
Merge pull request #2364 
63d8dddc cryptonote_protocol: remove old spans when received as old blocks (moneromooo-monero)
 2017-09-02 11:30:21 +02:00
Riccardo Spagni
e19b68b005
Merge pull request #2362 
adce8ae4 simplewallet: new "fee" command to display fee information (moneromooo-monero)
 2017-09-02 11:30:07 +02:00
Riccardo Spagni
2560948f69
Merge pull request #2342 
2e338ca5 wallet2: account for huge testnet reorgs for estimating height (moneromooo-monero)
 2017-09-02 11:29:53 +02:00
Riccardo Spagni
5551fcf60b
Merge pull request #2329 
e3c4395a p2p: init hashes after deserializing a network address (moneromooo-monero)
 2017-09-02 11:29:40 +02:00
Riccardo Spagni
eec3527e33
Merge pull request #2316 
0c6c3eb3 Silence stupid fallthru warning in gcc 7 (Howard Chu)
 2017-09-02 11:29:11 +02:00
Riccardo Spagni
79a0defad7
Merge pull request #2310 
ea996f91 clarification of parameters for print_coinbase_tx_sum (Matthew Campassi)
 2017-09-02 11:28:41 +02:00
Riccardo Spagni
10da3051c2
Merge pull request #2309 
d58700e0 WalletAPI: only allow trusted daemon when importing key images (Jaquee)
8a9bbd26 WalletAPI: copy wallet data when creating a view only wallet (Jaquee)
d27fe32e wallet2: export/import wallet data functions (Jaquee)
225a25f3 import_key_images - allow importing without being connected to daemon (Jaquee)
 2017-09-02 11:28:25 +02:00
moneromooo-monero
4e0e4e9942
blockchain_import: warn for chunks over 500000, not 100000 
We have a lot of 350000 byte blocks now.
 2017-09-01 22:48:33 +01:00
moneromooo-monero
5b29e87f85
blockchain_import: properly cleanup core/db on exit 2017-09-01 11:59:24 +01:00
moneromooo-monero
e167c4d9a1
blockchain_import: do not error out on truncated files 
This will happen often when downloading from a live file
 2017-09-01 11:58:51 +01:00
MaxXor
e3680b6936 Rename m_listenning_port to m_listening_port 2017-09-01 09:50:22 +02:00
rbrunner7
840aed1cf3 monero-wallet-cli: New command 'wallet_info' improved 2017-08-31 18:01:15 +02:00
Thomas Winget
9ac2ad0744
DRY refactoring 2017-08-31 07:48:27 -04:00
rbrunner7
9bdd985cee monero-wallet-cli: New command 'wallet_info' 2017-08-31 10:11:20 +02:00
Lee Clagett
9c83f8063d Do not create file when RPC user/pass is given and use file locking 2017-08-30 17:39:59 -04:00