MasFlam
1104b59c5b
Update help for set command in simplewallet
...
Add help for max-reorg-depth and load-deprecated-formats options
2023-07-01 12:01:07 +02:00
jeffro256
e8cac61f4b
core_rpc_server: return ID of submitted block
2023-06-30 15:31:35 -05:00
lukas
d6f86e58a6
Avoid nullptr dereference when constructing Blockchain and tx_memory_pool
2023-06-30 20:27:05 +02:00
koe
16d17f6707
add crypto/generators for direct access to canonical fixed generators
2023-06-28 09:52:27 -05:00
Jeffro256
a668312cfa
wallet: remove CLI code for non default ring sizes
2023-06-27 20:18:21 +02:00
ComputeryPony
1c20198280
Fixup error message.
...
Looks like the extra MWARNING was supposed to be guarded by the if statement.
2023-06-27 12:56:35 -05:00
luigi1111
0a1eaf26f9
Merge pull request #8884
...
eeda4a8f868768
2023-06-27 11:48:27 -05:00
luigi1111
0fbe21e9e9
Merge pull request #8862
...
9f80797
2023-06-27 11:44:58 -05:00
luigi1111
b86a620b4d
Merge pull request #8855
...
bb83eb1
2023-06-27 11:41:57 -05:00
luigi1111
1153246b8a
Merge pull request #8848
...
6b8dfb8
2023-06-27 11:39:33 -05:00
luigi1111
794f59b8bd
Merge pull request #8844
...
7206ef8
2023-06-27 11:37:54 -05:00
luigi1111
1df7260bd3
Merge pull request #8839
...
24d56c5
2023-06-27 11:36:29 -05:00
luigi1111
a897325fcd
Merge pull request #8832
...
092e964
2023-06-27 11:35:22 -05:00
luigi1111
3d9f378ed4
Merge pull request #8804
...
ca6c42a#8452 (OrvilleRed)
2023-06-27 11:33:45 -05:00
luigi1111
570fd364aa
Merge pull request #8772
...
87e2a64
2023-06-27 11:31:27 -05:00
luigi1111
57c58fd5bd
Merge pull request #8703
...
c90c1c3
2023-06-27 11:28:24 -05:00
luigi1111
9480525dd2
Merge pull request #8661
...
f50b9e3e5aa058c60b11f73298733d60475acfaaed
2023-06-27 11:27:03 -05:00
luigi1111
e752b609fc
Merge pull request #8660
...
2a7435ebc3cec4
2023-06-27 11:25:52 -05:00
jeffro256
2a2cf03764
blockchain_db: add clarification to get_block_already_generated_coins
2023-06-21 22:08:22 +02:00
j-berman
e6b86af931
wallet2: fix rescanning tx via scan_tx
...
- Detach & re-process txs >= lowest scan height
- ensures that if a user calls scan_tx(tx1) after scanning tx2,
the wallet correctly processes tx1 and tx2
- if a user provides a tx with a height higher than the wallet's
last scanned height, the wallet will scan starting from that tx's
height
- scan_tx requires trusted daemon iff need to re-process existing
txs: in addition to querying a daemon for txids, if a user
provides a txid of a tx with height *lower* than any *already*
scanned txs in the wallet, then the wallet will also query the
daemon for all the *higher* txs as well. This is likely
unexpected behavior to a caller, and so to protect a caller from
revealing txid's to an untrusted daemon in an unexpected way,
require the daemon be trusted.
2023-06-15 02:21:29 -07:00
jeffro256
369a5a8f9a
wallet: respect frozen key images in multisig wallets
...
Before this change, if a multisig peer asked you to sign a transaction with a frozen enote, the wallet will do it without any error or warning. This change makes it
so that wallets will refuse to sign multisig transactions with frozen enotes.
Disclaimer: This PR was generously funded by @LocalMonero.
2023-06-12 16:47:28 -05:00
Lee Clagett
2608b241c8
Add CLSAG serialization to ZMQ code
2023-06-10 11:55:48 -04:00
Crypto City
c138a28f51
wallet2: take ignored-by-value outputs into account in balance
2023-06-10 06:41:17 +00:00
SChernykh
c589e1549b
Speed up perf_timer init on x86
...
All Monero binaries have 1 second startup delay because of this code. This is especially noticeable and affects UX in Monero GUI wallet with local node where it often starts another monerod instance to run commands and query node status.
2023-06-08 07:56:05 +02:00
moneromooo-monero
9f80797086
protocol: drop peers sending duplicate txes
2023-06-07 06:56:21 +00:00
jeffro256
7206ef8ab8
cryptonote_basic: fix amount overflow detection on 32-bit systems
...
On systems where `ULONG_MAX` != `ULLONG_MAX` (e.g. most 32-bit systems), the `round_money_up` function will not correctly detect overflows.
2023-06-02 22:14:26 -05:00
jeffro256
a6639df9e4
wallet_rpc_server: dedup transfer RPC responses
2023-06-02 01:07:30 -05:00
Crypto City
eeda4a8497
wallet2: do not lose exception in current thread on refresh
2023-05-30 17:08:05 +00:00
Crypto City
f8687684e3
wallet2: fix missing exceptions from failing wallet refresh
2023-05-30 16:57:48 +00:00
j-berman
a8d2a58190
wallet2: ensure transfers and sweeps use same fee calc logic
...
Ensures both transfers and sweeps use a fee that's calculated
from the tx's weight. Using different logic could theoretically
enable distinguishability between the two types of txs. We don't
want that.
2023-05-27 07:27:54 -07:00
tobtoht
bb83eb151a
daemon: remove --fluffy-blocks
2023-05-12 17:39:38 +02:00
tobtoht
6ff87ef89f
net: tor_address: remove support for v2 onion addresses
2023-05-12 17:09:54 +02:00
Crypto City
d391ac0f7e
blockchain: ensure base fee cannot reach 0
...
reported by sech1
2023-05-11 13:47:57 +00:00
tobtoht
6b8dfb8fb9
daemon: remove os-version
2023-05-10 23:15:03 +02:00
tobtoht
c32befe4f8
fix missing <cstdint> includes
2023-05-06 18:13:18 +02:00
Crypto City
503c3e06df
core: do not force sync the db when finding a block in regtest mode
...
for a slight performance boost in functional tests
2023-05-05 18:11:57 +00:00
moneromooo-monero
24d56c5975
bump lmdb sync threshold for performance
...
Force sync every 100k blocks instead of every 1k blocks. Bumping this
value is reported to make a big difference in sync performance, eg:
https://github.com/monero-project/monero/issues/8189
2023-05-05 18:07:44 +00:00
SChernykh
092e964a87
Fixed RandomX initialization when mining from scratch
2023-04-27 16:31:21 +02:00
luigi1111
a2e8d1d427
Merge pull request #8760
...
1698cb1
2023-04-26 14:02:25 -04:00
tobtoht
1698cb1f84
remove defunct light wallet code
2023-04-25 21:22:10 +02:00
Jeffrey Ryan
408079661d
serialization: remove unused function dump_json
2023-04-25 11:39:55 -05:00
luigi1111
1c9686cb45
Merge pull request #8724
...
d2a591d
2023-04-25 12:36:11 -04:00
luigi1111
0d9e790311
Merge pull request #8802
...
eb0e405
2023-04-25 11:26:20 -04:00
luigi1111
d44350fb7f
Merge pull request #8798
...
f383fd3
2023-04-25 11:25:29 -04:00
luigi1111
df2eb0da0a
Merge pull request #8796
...
7a4a03d
2023-04-25 11:24:15 -04:00
luigi1111
b2d603e61f
Merge pull request #8789
...
df9aa6b
2023-04-25 11:22:50 -04:00
luigi1111
0db1b4503e
Merge pull request #8788
...
c61d33e
2023-04-25 11:22:11 -04:00
luigi1111
b442d5d4c1
Merge pull request #8780
...
4e16559
2023-04-25 11:21:48 -04:00
luigi1111
5387018ade
Merge pull request #8771
...
2eaa523
2023-04-25 11:21:22 -04:00
luigi1111
8172e4d8ad
Merge pull request #8765
...
630906c
2023-04-25 11:20:12 -04:00
luigi1111
83100b6cbe
Merge pull request #8764
...
b13ddb9
2023-04-25 11:19:38 -04:00
Jeffrey Ryan
d2a591d7c6
wallet, simplewallet: Drop support for mine-to-use RPC system
...
Using post-PR wallet with pre-PR node will generate error message specific to this PR and not generic "command failed" mesages.
2023-04-25 10:18:20 -05:00
luigi1111
8b617064d4
Merge pull request #8748
...
11a8360
2023-04-25 11:17:56 -04:00
luigi1111
4931462d1d
Merge pull request #8730
...
9e09093
2023-04-25 11:17:22 -04:00
luigi1111
aa5382c470
Merge pull request #8716
...
9c7d28b
2023-04-25 11:13:44 -04:00
luigi1111
9bf06ea75d
Merge pull request #8698
...
5b4fea7
2023-04-25 11:12:56 -04:00
luigi1111
af88341272
Merge pull request #8694
...
d89e7a2
2023-04-25 11:11:08 -04:00
luigi1111
ecf0d01aa2
Merge pull request #8679
...
b986421
2023-04-25 11:10:27 -04:00
almalh
87e2a64327
Allow option 'non-interactive' in monerod config file
2023-04-15 18:28:12 -04:00
Guillaume Le Vaillant
c90c1c3fe1
Show IPv6 addresses in connection list
2023-04-14 13:34:30 +02:00
jeffro256
eb0e4052b7
gamma picker: relax constructor requirements and test for selecting outputs from first spendable block
2023-04-02 20:06:09 -05:00
luigi1111
44ac52f929
Merge pull request #8810
...
d594981
2023-04-02 20:45:13 -04:00
luigi1111
5f2bbf78a0
Merge pull request #8808
...
caa7561
2023-04-02 20:44:18 -04:00
luigi1111
441373b9ef
Merge pull request #8794
...
85a4558
2023-04-02 20:43:32 -04:00
Crypto City
85a45587f2
wallet2: fix infinite loop in fake out selection
...
The gamma picker and the caller code did not quite agree on the
number of rct outputs available for use - by one block - which
caused an infinite loop if the picker could never pick outputs
from that block but already had picked all other outputs from
previous blocks.
Also change the range to select from using code from UkoeHB.
2023-03-30 14:44:36 +00:00
jeffro256
caa7561705
cryptonote core/protocol: don't drop peers for soft offenses
...
Also: txs with tx_extra which is too large will not get published to ZMQ
Co-authored-by: SChernykh <sergey.v.chernykh@gmail.com>
2023-03-29 02:05:43 -05:00
SChernykh
d59498101c
Fixed deadlock and crash when syncing with full dataset on Windows
...
It's not allowed to use WaitForSingleObject with _beginthread, because the thread closes its own handle before exiting.
So the wait function will either wait on an invalid handle, or on a different handle used by something else.
Or, if it starts waiting before the thread exits, the behavior is undefined according to MS: "If this handle is closed while the wait is still pending, the function's behavior is undefined."
In my test sync I observed threads getting stuck infinitely on WaitForSingleObject, and then rx_set_main_seedhash spamming new threads when RandomX seed changes again. Eventually the system ran out of resources, and monerod aborted with "Couldn't start RandomX seed thread" message.
This PR fixes it by using `_beginthreadex` instead and explicitly closing the handle when it's safe.
2023-03-29 08:43:47 +02:00
OrvilleRed
ca6c42a8e1
Message about DNS_PUBLIC to help users with issue #8452
2023-03-27 00:36:40 -04:00
luigi1111
abe74fda35
Merge pull request #8770
...
d7a81ccd84a0d7
2023-03-24 22:54:32 -04:00
jeffro256
f383fd3cd0
wallet2: make m_process_pool_txs local to refresh method
2023-03-21 19:18:48 -05:00
moneromooo-monero
7a4a03d9d3
wallet2: do not commit transactions more than once
...
Fixes #8793
2023-03-21 21:05:53 +00:00
Jeffro256
df9aa6bb04
epee: remove dead code in net_helper
2023-03-19 12:51:27 -05:00
Crypto City
c61d33e24c
wallet2: fix outdated wallet check
...
it was mistaking the number of forks in the fork table for
the last fork, and assuming the table was including every
single fork
2023-03-19 17:43:37 +00:00
luigi1111
f307621678
Merge pull request #8775
...
1b27fcd
2023-03-18 18:21:02 -04:00
luigi1111
76dd14dfb1
Merge pull request #8733
...
3771641
2023-03-18 18:18:13 -04:00
luigi1111
55fddad446
Merge pull request #8707
...
7159f92
2023-03-18 18:17:05 -04:00
luigi1111
a511202222
Merge pull request #8076
...
c4af33e9752116
2023-03-18 17:58:27 -04:00
Jeffrey Ryan
7159f92a57
verRctNonSemanticsSimpleCached: fix fragility
2023-03-17 18:45:35 -05:00
jeffro256
4e16559053
rpc: give reason when sending non-hex raw tx
2023-03-17 18:18:06 -05:00
Francois Beutin
1b27fcdf77
device: Add ledger Stax device id to device detection
2023-03-14 10:31:20 +01:00
koe
2eaa523af1
cryptonote::transaction_prefix: fix IDE parsing error
2023-03-09 15:18:21 -06:00
moneromooo-monero
d7a81ccba1
p2p: do not log to global when re-blocking a subnet
2023-03-09 17:17:59 +00:00
j-berman
c4af33eded
Enforce restricted # pool txs served via RPC + optimize chunked reqs
...
- `/getblocks.bin` respects the `RESTRICTED_TX_COUNT` (=100) when
returning pool txs via a restricted RPC daemon.
- A restricted RPC daemon includes a max of `RESTRICTED_TX_COUNT` txs
in the `added_pool_txs` field, and returns any remaining pool hashes
in the `remaining_added_pool_txids` field. The client then requests
the remaining txs via `/gettransactions` in chunks.
- `/gettransactions` no longer does expensive no-ops for ALL pool txs
if the client requests a subset of pool txs. Instead it searches for
the txs the client explicitly requests.
- Reset `m_pool_info_query_time` when a user:
(1) rescans the chain (so the wallet re-requests the whole pool)
(2) changes the daemon their wallets points to (a new daemon would
have a different view of the pool)
- `/getblocks.bin` respects the `req.prune` field when returning
pool txs.
- Pool extension fields in response to `/getblocks.bin` are optional
with default 0'd values.
2023-03-07 20:35:45 +01:00
tobtoht
630906ce5b
cryptonote_basic: remove unused struct
2023-03-06 15:15:00 +01:00
almalh
b13ddb9a16
Handle case where a command line flag is not allowed in the config file
2023-03-05 20:32:40 -05:00
moneromooo-monero
d84a0d7430
p2p: avoid spam blocking ipv4 addresses in a blocked subnet
2023-03-01 16:56:56 +00:00
tevador
3771641fc5
Add a size limit for tx_extra in tx pool
2023-02-26 10:26:53 +01:00
moneromooo-monero
11a836074d
simplewallet: print fully qualified filename for new wallets
...
from time to time, some people don't realize their wallets get
created in their current working directory
2023-02-24 10:22:48 +00:00
luigi1111
3f696f144c
Merge pull request #8720
...
d8a844869153e8
2023-02-15 10:42:59 -05:00
koe
2a7435e026
variant: add mutable unwrap and visitation
2023-02-12 13:00:53 -06:00
luigi1111
cd82b4fed0
Merge pull request #8712
...
cb756b6
2023-02-06 12:36:39 -05:00
luigi1111
5fae6d63a8
Merge pull request #8705
...
b247f98b27a171
2023-02-06 12:35:37 -05:00
luigi1111
889951e7c5
Merge pull request #8700
...
3461a19
2023-02-06 12:34:41 -05:00
luigi1111
2521f0e238
Merge pull request #8697
...
e91f35e
2023-02-06 12:33:03 -05:00
luigi1111
672eedf9c2
Merge pull request #8691
...
934b798
2023-02-06 12:24:17 -05:00
moneromooo-monero
9e09093a8d
wallet_rpc_server: allow creating more than 64 addresses at once
...
it's too low a limit (at least one person mentioned having to
call create_address in a loop due to it)
2023-02-03 16:57:48 +00:00
koe
bc3cec4634
add variant class with cleaner interface than boost::variant<>
2023-01-30 22:03:35 -06:00
selsta
d8a84489d2
p2p: add plowsof seed nodes
2023-01-27 14:15:31 +01:00
selsta
69153e870d
p2p: remove offline seed nodes
2023-01-27 14:06:45 +01:00
Crypto City
9c7d28b8ed
wallet2: add on_reorg callback
2023-01-19 17:34:45 +00:00
Howard Chu
cb756b6094
blockchain-stats: print any remaining data at end of loop
...
Fix #8711
2023-01-17 17:20:18 +00:00
SChernykh
b247f985db
Demote large pages warning to mdebug
2023-01-17 18:13:07 +01:00
mj-xmr
5b4fea72cf
Copyright: Update to 2023
...
Co-authored-by: plowsof <plowsof@protonmail.com>
extra files
2023-01-16 13:00:18 +01:00
SChernykh
b27a17110d
RandomX: print VM allocation warnings only once
2023-01-11 19:15:11 +01:00
luigi1111
50aa0e8b7f
Merge pull request #8675
...
1a568de
2023-01-11 12:27:40 -05:00
luigi1111
75d80d431a
Merge pull request #8686
...
7a3a593
2023-01-11 12:13:48 -05:00
luigi1111
ac87d8dac9
Merge pull request #8682
...
96677ff
2023-01-11 12:12:57 -05:00
luigi1111
451ff7bd91
Merge pull request #8677
...
fe8522cdab7d01
2023-01-11 12:10:02 -05:00
luigi1111
3854cc04be
Merge pull request #8663
...
b1bce85
2023-01-11 11:45:40 -05:00
luigi1111
9489586add
Merge pull request #8648
...
8687da6
2023-01-11 11:41:11 -05:00
luigi1111
b363eebd52
Merge pull request #8643
...
faaf2af
2023-01-11 11:39:42 -05:00
luigi1111
ac8580c1f5
Merge pull request #8640
...
1a3ae18
2023-01-11 11:38:38 -05:00
SChernykh
dab7d01dc0
Refactored rx-slow-hash.c
...
- Straight-forward call interface: `void rx_slow_hash(const char *seedhash, const void *data, size_t length, char *result_hash)`
- Consensus chain seed hash is now updated by calling `rx_set_main_seedhash` whenever a block is added/removed or a reorg happens
- `rx_slow_hash` will compute correct hash no matter if `rx_set_main_seedhash` was called or not (the only difference is performance)
- New environment variable `MONERO_RANDOMX_FULL_MEM` to force use the full dataset for PoW verification (faster block verification)
- When dataset is used for PoW verification, dataset updates don't stall other threads (verification is done in light mode then)
- When mining is running, PoW checks now also use dataset for faster verification
2023-01-09 07:43:07 +01:00
koe
b1bce857c9
miscellaneous crypto updates
2023-01-03 16:50:08 -06:00
selsta
3461a19940
daemonizer: don't uninstall windows service on exit
2023-01-03 03:45:43 +01:00
e91f35e030
win-service: enable auto startup
2023-01-02 05:18:48 +00:00
moneromooo-monero
d89e7a239d
util: make GMT timestamps explicit for clarity
...
For privacy reasons, time functions use GMT, to avoid logs leaking
timezones. It'd make more sense to use localtime for wallet output
(which are not logged by default), but that adds inconsistencies
which can also be confusing. So add a Z suffix for now to make it
clear these are not local time.
2023-01-01 10:38:13 +00:00
moneromooo-monero
934b798c74
rpc: do not misidentify coinbase txes as pruned
2023-01-01 09:30:59 +00:00
rbrunner7
9752116ed3
wallet2, RPC: Optimize RPC calls for periodic refresh from 3 down to 1 call
2022-12-30 13:50:22 +01:00
koe
f50b9e3803
revisions
2022-12-29 17:39:34 -06:00
koe
e5aa058a8d
vtnerd review comments
2022-12-24 19:15:27 -06:00
Jeffrey Ryan
7a3a593a77
common: move boost_serialization_helper.h out and cleanup includes
2022-12-22 12:18:02 -06:00
SChernykh
1a568deacb
Cache successful verRctNonSemanticsSimple calls
2022-12-20 22:16:39 +01:00
koe
c60b11f3da
add compare_func() method so user-defined comparison functions are easier to use
2022-12-19 15:50:16 -06:00
selsta
96677fffcd
common: add missing includes
2022-12-18 18:30:08 +01:00
koe
73298734d6
adjust is_sorted_and_unique()
2022-12-18 10:18:46 -06:00
koe
b986421b4f
adjust multiexp pippenger_cached_data for better reusability
2022-12-16 11:48:57 -06:00
koe
3d60475753
comment updates
2022-12-15 13:04:34 -06:00
koe
acfaaeda7a
add container helpers
2022-12-01 17:25:26 -06:00
luigi1111
7275a4d23b
Merge pull request #8627
...
a7bf3af
2022-12-01 01:10:20 -06:00
luigi1111
2f168da7f7
Merge pull request #8618
...
1114e7e
2022-12-01 01:08:53 -06:00
luigi1111
179a87afae
Merge pull request #8616
...
cac5083
2022-12-01 01:08:11 -06:00
luigi1111
1cfe69c7f1
Merge pull request #8610
...
97b86a0
2022-12-01 01:05:14 -06:00
luigi1111
32a1cd1bf1
Merge pull request #8503
...
d06202d
2022-12-01 01:00:15 -06:00
Jeffrey Ryan
8687da6276
common: DNSResolver can handle hostnames without dot characters
...
Unrelated, but similar code-wise to #8643 . There is a check in `DNSResolver` which automatically fails to resolve hostnames which do not contain the `.` character. This PR removes that check.
2022-11-21 15:54:23 -06:00
Jeffrey Ryan
faaf2af43b
p2p: fix exclusive node DNS resolution for certain hosts
...
Fixes #8633 . The function `append_net_address` did not parse hostname + port addresses (e.g. `bar:29080`) correctly if the hostname did not contain a `'.'` character.
@vtnerd comments 1
clear up 2nd conditional statement
2022-11-17 18:55:09 -06:00
Dusan Klinec
1114e7eed7
fix(trezor-tests): fix trezor tests build, fix integrated addr test
...
- fix integrated address test, it was not testing integrated address suport
- fix trezor test build as dependent classes were changed
- add a friend test class for Monero::WalletImpl to support wallet api tests
When using wallet_api in tests, synthetic chain is used. Without being able to set `allow_mismatched_daemon_version` in the underlying wallet, we are not able to use a synthetic chain with the tests
2022-11-17 12:12:23 +01:00
j-berman
1a3ae18ef9
p2p: fix back ping to discover healthy peers to connect to
2022-11-14 16:54:45 -08:00
luigi1111
8672553e3d
Merge pull request #8529
...
09d69b6
2022-10-28 00:47:55 -04:00
luigi1111
f41c68648c
Merge pull request #8527
...
e988530
2022-10-28 00:47:26 -04:00
luigi1111
2ab0732d1a
Merge pull request #8525
...
501db2c
2022-10-28 00:46:50 -04:00
luigi1111
45ffdc26a6
Merge pull request #8517
...
6f0fb76
2022-10-28 00:46:19 -04:00
luigi1111
9f5c7209a0
Merge pull request #8355
...
23fde155bb2369
2022-10-28 00:44:59 -04:00
Lee Clagett
a7bf3aff2c
Fix dandelion++ fluff/stem bug with local txes
2022-10-25 16:09:55 -04:00
j-berman
cac5083427
wallet2: fix create view-only wallet from existing wallet
2022-10-18 13:48:43 -05:00
selsta
97b86a014c
wallet_api: take priority into account when estimating fee
2022-10-13 03:35:19 +02:00
luigi1111
fc907a9570
Merge pull request #8587
...
8e7c7af
2022-09-26 15:00:35 -05:00
luigi1111
e44bf0b060
Merge pull request #8586
...
e9ce347
2022-09-26 14:59:43 -05:00
luigi1111
239d210a18
Merge pull request #8576
...
28f25c0
2022-09-26 14:50:56 -05:00
luigi1111
0a10a4f870
Merge pull request #8329
...
4b0785f
2022-09-26 14:46:06 -05:00
