monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-11-19 10:31:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
4390 commits 9 branches 69 tags 309 MiB
Commit graph

3023 commits

Author SHA1 Message Date
Riccardo Spagni
d2059dfab2
Merge pull request #1737 
69ab14d9 More robust battery status handling. (Dion Ahmetaj)
 2017-02-21 11:16:08 +02:00
Riccardo Spagni
d596722dfa
Merge pull request #1749 
5a3b1e98 wallet2: fix failure to send (relatedness check in wrong case) (moneromooo-monero)
 2017-02-21 11:15:40 +02:00
moneromooo-monero
a5a0a3c894
core: updates can now be downloaded (and SHA256 hash checked) 2017-02-20 22:58:37 +00:00
moneromooo-monero
216f062eb8
util: add a SHA256 function 2017-02-20 22:58:33 +00:00
moneromooo-monero
d282cfcc46
core: test key images against validity domain 2017-02-20 22:58:25 +00:00
moneromooo-monero
f640512c53
Optionally query moneropulse DNS records to check for updates 
It just checks and prints a message if there is a new version
for now.
 2017-02-20 22:58:16 +00:00
moneromooo-monero
e3cae4ae2e
core: display any fork warning at startup too 
This is a good time for the operator to be around and see it
 2017-02-20 22:58:12 +00:00
moneromooo-monero
969ad710ba
dns_utils: fix first checked DNS entry being ignored 2017-02-20 22:58:08 +00:00
moneromooo-monero
08c3f38031
util: add a vercmp function to compare version numbers 
It is simple, supports simple x.y.z type numeric versions,
and does not attempt any kind of validation
 2017-02-20 22:58:04 +00:00
moneromooo-monero
e8a7525ceb
dns_utils: factor TXT record loading code from checkpoint code 2017-02-20 22:57:57 +00:00
Riccardo Spagni
5892f653c7
Merge pull request #1729 
9925edcb rpc: fix some RPC calls not returning OK status when needed (moneromooo-monero)
 2017-02-21 00:52:12 +02:00
Riccardo Spagni
ba633d33a8
Merge pull request #1732 
83ec209f simplewallet: validate hex input size (moneromooo-monero)
 2017-02-21 00:51:46 +02:00
Riccardo Spagni
675434ffab
Merge pull request #1748 
bed2d9f2 Get rid of directory lock (Howard Chu)
2e913676 Handle map resizes from other processes (Howard Chu)
bf1348b7 Can't cache num_txs or num_outputs either (Howard Chu)
dc53e9ee Add a few read txns to streamline (Howard Chu)
 2017-02-21 00:51:13 +02:00
moneromooo-monero
c32830937c
tx_pool: revert template filling changes 
They are not ready yet
 2017-02-20 22:43:37 +00:00
moneromooo-monero
5a3b1e983c
wallet2: fix failure to send (relatedness check in wrong case) 
A relatedness check was meant to be done in the case of adding
an extra output if just one was enough. This was mistakenly
added to the "preferred output" case.
 2017-02-19 09:31:54 +00:00
Howard Chu
bed2d9f231
Get rid of directory lock 
We don't need it any more. Fixes issue #1633
 2017-02-18 22:22:24 +00:00
Howard Chu
2e9136767e
Handle map resizes from other processes 2017-02-18 22:22:24 +00:00
Howard Chu
bf1348b7e2
Can't cache num_txs or num_outputs either 
Same reason as 3ff54bdd7a
 2017-02-18 21:01:24 +00:00
Howard Chu
dc53e9eef2
Add a few read txns to streamline 
Slight perf gain, but mainly to reduce spam at loglevel 3
 2017-02-18 21:01:24 +00:00
moneromooo-monero
26bd7aac03
wallet_api: fix logging init via api 2017-02-18 20:44:23 +00:00
Dion Ahmetaj
69ab14d91e More robust battery status handling. 
Added an extra path to check for linux power supply status.
Added ignore battery option. If set to true, then when we can't figure out
the power status, we'll assume the system is plugged in.
 2017-02-16 14:35:01 -05:00
Dion Ahmetaj
a493c0b196 BACKGROUND_MINING_MINER_MONITOR_INVERVAL_IN_SECONDS was odr-used, so required a definition. 
Instead of adding a declaration to cpp file, I changed it to non odr-used.
 2017-02-15 11:15:12 -05:00
Howard Chu
424b76a4e5
Fix spurious synchronization status msgs 
Only update target height if it's actually greater than the current target.
Only display "synchronized" when current height equals target.
 2017-02-15 14:41:42 +00:00
moneromooo-monero
83ec209f42
simplewallet: validate hex input size 2017-02-14 19:45:46 +00:00
moneromooo-monero
a427235e30
core: add a missing newline on a string to be logged 2017-02-14 19:14:41 +00:00
moneromooo-monero
c488eca5e8
hardfork: tone down some logs 2017-02-14 18:56:39 +00:00
moneromooo-monero
9925edcb1e
rpc: fix some RPC calls not returning OK status when needed 2017-02-13 23:50:10 +00:00
moneromooo-monero
b560ed4ac6
daemon: silence spurious warning about uninitialized variable 
Also fixes a leak
 2017-02-13 22:39:25 +00:00
NanoAkron
67693415ff
Fix compiler error about nested externs in slow_hash.c by moving declarations 2017-02-13 22:35:43 +00:00
moneromooo-monero
0288310e3b
blockchain_db: add "raw" blobdata getters for block and transaction 
This speeds up operations such as serving blocks to syncing peers
 2017-02-13 21:11:37 +00:00
moneromooo-monero
53f040445f
cryptonote_protocol: tweaks to the syncing speedup 
- only pause mining once we've got the lock (in practice, it'll
  already be paused by another thread if we can't get the lock
  at once though)
- do not call prepare_handle_incoming_blocks when we dismissed
  all the blocks, it only causes cleanup_handle_incoming_blocks
  to complain afterwards
 2017-02-13 19:36:31 +00:00
moneromooo-monero
cca95c1c7a
blockchain_db: do not throw on expected partial results getting keys 
When scanning for outputs used in a set of incoming blocks,
we expect that some of the inputs in their transactions will
not be found in the blockchain, as they could be in previous
blocks in that set. Those outputs will be scanned there at
a later point. In this case, we add a flag to control wehther
an output not being found is expected or not.
 2017-02-13 19:05:30 +00:00
moneromooo-monero
d43fde8a9b
network_throttle: demote spammy logs to TRACE 2017-02-13 16:54:45 +00:00
Riccardo Spagni
6e78915061
Merge pull request #1718 
882db8e9 tools: log to the correct file (moneromooo-monero)
142e5e1e tools: set requested log level (moneromooo-monero)
 2017-02-12 23:28:56 +02:00
Riccardo Spagni
e246dd1443
Merge pull request #1717 
8bdc86be protocol: speed up sync by minimizing duplicate work (moneromooo-monero)
61dfa310 epee: fix some log macros not printing context nicely (moneromooo-monero)
 2017-02-12 23:28:38 +02:00
Riccardo Spagni
f4e2539a32
Merge pull request #1715 
8ec2a8d2 net_node: fix spurious warning about using uninitialized data (moneromooo-monero)
 2017-02-12 23:27:08 +02:00
Riccardo Spagni
92fe31fd44
Merge pull request #1714 
5adcb5a4 tx_pool: add a debug message when adding a tx to the pool (moneromooo-monero)
9faef1f8 cryptonote_protocol: misc fluffy block fixes (moneromooo-monero)
 2017-02-12 23:26:02 +02:00
Riccardo Spagni
4e7bcad58f
Merge pull request #1713 
422ecc98 Fixup choice of easylogging++ vs libunwind stack trace code (moneromooo-monero)
 2017-02-12 23:25:42 +02:00
Riccardo Spagni
b0e992237e
Merge pull request #1712 
3b6839cc mlog: move log level changes to global level (moneromooo-monero)
38a1b9c9 rpc: fix daemon mixed style set_log 2,category:level (moneromooo-monero)
28d0b11f mlog: s/Mew/New/ in log (moneromooo-monero)
 2017-02-12 23:25:07 +02:00
Riccardo Spagni
b1df7f114d
Merge pull request #1711 
cf2e75eb daemon: fix crash on exit when mining (moneromooo-monero)
 2017-02-12 23:24:49 +02:00
Riccardo Spagni
47687399fb
Merge pull request #1709 
b2ac939e Fix GUI building after libcryptonote_core was split (#1626) (iDunk5400)
 2017-02-12 23:24:19 +02:00
Riccardo Spagni
6a261fa1bc
Merge pull request #1708 
f2986ccf db_lmdb: fix bad height saved in tx data (moneromooo-monero)
 2017-02-12 23:23:46 +02:00
moneromooo-monero
882db8e9d9
tools: log to the correct file 2017-02-12 19:39:59 +00:00
moneromooo-monero
142e5e1eb4
tools: set requested log level 
also move a couple logs from INFO to DEBUG
 2017-02-12 18:48:39 +00:00
moneromooo-monero
8bdc86beb4
protocol: speed up sync by minimizing duplicate work 
In particular, the prepare_handle_incoming_blocks call
is pretty lengthy, and entirely pointless in the common
case where several different connections will prepare
the exact same blocks.
 2017-02-12 17:17:30 +00:00
moneromooo-monero
8ec2a8d2b0
net_node: fix spurious warning about using uninitialized data 
This is only used to load, not save
 2017-02-12 14:06:36 +00:00
moneromooo-monero
422ecc98e4
Fixup choice of easylogging++ vs libunwind stack trace code 2017-02-12 13:59:21 +00:00
moneromooo-monero
5adcb5a48c
tx_pool: add a debug message when adding a tx to the pool 2017-02-12 12:33:48 +00:00
moneromooo-monero
9faef1f83a
cryptonote_protocol: misc fluffy block fixes 
- fix wrong block being used when a new block is received between
  a node elaying a fluffy block and sending a new fluffy block
  with txes a peer did not have
- misc a neverending ping pong requesting the same missing txids
  when a new block is received in the meantime, causing the top
  block to not be the one we need
- send the original fluffy block message block height when sending
  a new fluffy block, not the current top height, which might
  have been updated since
- avoid sending back the whole block blob when asking for txes,
  send only the hash instead
- plus misc cleanup and additional debugging logs
 2017-02-12 12:33:45 +00:00
moneromooo-monero
38a1b9c956
rpc: fix daemon mixed style set_log 2,category:level 2017-02-12 11:37:09 +00:00
moneromooo-monero
cf2e75ebb3
daemon: fix crash on exit when mining 
When exiting while the miner is running, finding a block after
the p2p layer has been shutdown will cause a crash as the now
uninitialized p2p layer is asked to relay the found block to
any peers.
 2017-02-12 11:09:21 +00:00
iDunk5400
b2ac939eb3
Fix GUI building after libcryptonote_core was split (#1626) 2017-02-11 17:00:55 +01:00
moneromooo-monero
f2986ccfc1
db_lmdb: fix bad height saved in tx data 
The recent change to not keep separate track of the blockchain
height caused the reported height to jump early in the lmdb
transaction (when the block data is added to the blocks table),
rather than at the end, after everything succeeded. Since the
block data is added before the transaction data, this caused
the transaction data to be saved with a height one more than
its expected value.

Fix this by saving the block data last. This should have no
side effects.
 2017-02-11 10:16:18 +00:00
Dion Ahmetaj
ad95e65028 Added a note about smart mining to status command. Fixed up a bug where I was resetting bg mining enabled instead of started. Upped the miner threshold. Also moved setting of enabled on start above miner thread creation since starting with true, then stopping, then starting with false resulted in race condition. 2017-02-10 18:07:43 -05:00
Dion Ahmetaj
e4dfd2fb63 Changed ac_line_status to on_battery_power. 2017-02-10 18:07:42 -05:00
Dion Ahmetaj
23c73269ca Use defined directive to silence pre-proc warnings. 2017-02-10 18:07:41 -05:00
Dion Ahmetaj
d2c7d0f6b0 Cleaned up some logging. Thanks to moneromooo for help. 2017-02-10 18:07:41 -05:00
Dion Ahmetaj
68652cd94d Added some //TODO comments pertaining to returning enums instead of bools in order to be better able to handle failure states. 2017-02-10 18:07:41 -05:00
Dion Ahmetaj
0b1045ed7d Moved around checking of AC power in order to bail quicker to sleep if not plugged in. 2017-02-10 18:07:40 -05:00
Dion Ahmetaj
2937fdbbbf Moved setting of previous process times to block where background mining is started, and added an explicit sleep in that block to wait for some mining to occur. 2017-02-10 18:07:40 -05:00
Dion Ahmetaj
21a1e0252f Set background mining started bool to false on bg thread start. If mining::stop then mining::start, idle logic is re-run instead of starting immediately (if it was running before stop). 2017-02-10 18:07:39 -05:00
Dion Ahmetaj
345ed4823c Background/smart mining. If a users' computer is plugged into a power 
source, and CPU has been idle for some time, then begin mining to some
threshold (don't destroy the users' CPU).

This patch only supports windows and linux (I've only tested on Win64 and
Ubuntu).

The variables currently default to pretty conservative values (i.e. 20%
CPU mining threshold).
 2017-02-10 18:07:39 -05:00
Riccardo Spagni
cb54eeaa31
Merge pull request #1698 
9459f331 simplewallet: print error when address is wrong (kenshi84)
 2017-02-11 00:54:30 +02:00
Riccardo Spagni
eacf2124b6 Merge pull request #1689 
ce7fcbb4 Add server auth to monerod, and client auth to wallet-cli and wallet-rpc (Lee Clagett)
 2017-02-11 00:35:25 +02:00
Miguel Herranz
8277e67f11 Add anchor connections 
Based on https://eprint.iacr.org/2015/263.pdf 4. Anchor connections.

Peer list serialisation version bumped to 5.
 2017-02-10 23:28:54 +01:00
Riccardo Spagni
9296960081
Merge pull request #1686 
bceaf4b7 wallet2: fix transactions not considering rct inputs (moneromooo-monero)
 2017-02-11 00:22:17 +02:00
Riccardo Spagni
9781ecaa70
Merge pull request #1685 
7549116e Wallet API: Easylogger wrapper for gui (Jaquee)
 2017-02-11 00:21:51 +02:00
Riccardo Spagni
4feaa790e2
Merge pull request #1680 
db0a5392 Clarify in/out connections for users (NanoAkron)
 2017-02-11 00:21:12 +02:00
kenshi84
9459f33178 simplewallet: print error when address is wrong 2017-02-08 23:04:48 +09:00
kenshi84
8027ce0c75 extract some basic code from libcryptonote_core into libcryptonote_basic 2017-02-08 22:45:15 +09:00
Riccardo Spagni
99ee3fd17e
Merge pull request #1679 
4efc926d Wallet API: Catch error from tools::is_local_address (Jaquee)
 2017-02-08 12:53:57 +02:00
Riccardo Spagni
d30b64f457
Merge pull request #1674 
92978b2c common: fix link error on at least one platform (no clue which one) (moneromooo-monero)
 2017-02-08 12:51:11 +02:00
moneromooo-monero
bceaf4b788
wallet2: fix transactions not considering rct inputs 
I broke this very recently in 2bf029be17
and didn't notice in time
 2017-02-06 20:20:22 +00:00
Lee Clagett
ce7fcbb4ae Add server auth to monerod, and client auth to wallet-cli and wallet-rpc 2017-02-06 01:15:41 -05:00
Jaquee
7549116ec3
Wallet API: Easylogger wrapper for gui 2017-02-05 20:12:01 +01:00
kenshi84
bab1e9a397 bugfix: infinite recursion in get_account_address_from_str_or_url 2017-02-05 23:20:16 +09:00
NanoAkron
db0a5392a5
Clarify in/out connections for users 2017-02-05 11:15:51 +00:00
moneromooo-monero
92978b2c0f
common: fix link error on at least one platform (no clue which one) 
Bug and fix reported by tdprime
 2017-02-05 10:55:55 +00:00
Jaquee
4efc926d28
Wallet API: Catch error from tools::is_local_address 2017-02-05 11:08:05 +01:00
Jaquee
0cc50bdd11 GUI: Improved refresh performance 2017-02-04 23:25:05 +01:00
Jaquee
805625b541 wallet api: Remove initAsync() and don't start refresh automatically on init 2017-02-04 23:25:03 +01:00
Jaquee
031b060af0 wallet2::init() - disconnect before init if connected 
Makes it possible for GUI to reinit with new daemon without closing and reopening wallet.
 2017-02-04 23:10:20 +01:00
Riccardo Spagni
e56bf442c3
Merge pull request #1669 
4f5b130d wallet_rpc_server: add address book RPC calls (moneromooo-monero)
 2017-02-04 17:28:53 +02:00
Riccardo Spagni
5da4650cba
Merge pull request #1671 
cd34fc65 Use easylogging++'s stack trace facility where possible (moneromooo-monero)
 2017-02-04 17:27:54 +02:00
Riccardo Spagni
c3c281e699
Merge pull request #1666 
03ff3639 Fix missing parentheses (Miguel Herranz)
 2017-02-04 17:26:19 +02:00
Riccardo Spagni
bcb7b0a9af
Merge pull request #1665 
34719071 simplewallet: cleanup (moneromooo-monero)
a9a9b64b simplewallet: fix build (unqualified type not in current scope) (moneromooo-monero)
 2017-02-04 17:21:11 +02:00
Riccardo Spagni
eb21389953
Merge pull request #1664 
b5cb8861 core: fix integrated addresses breaking with auto zero change (moneromooo-monero)
 2017-02-04 17:20:02 +02:00
Riccardo Spagni
31cf4e7362
Merge pull request #1640 
f97526e6 simplewallet: option to always ask password for any crytical operations (kenshi84)
 2017-02-04 17:18:38 +02:00
moneromooo-monero
cd34fc655d
Use easylogging++'s stack trace facility where possible 
This avoids using libunwind, which often causes trouble.
 2017-02-04 12:33:03 +00:00
moneromooo-monero
4f5b130de9
wallet_rpc_server: add address book RPC calls 2017-02-04 11:40:49 +00:00
kenshi84
f97526e641 simplewallet: option to always ask password for any crytical operations 2017-02-03 09:38:12 +09:00
Miguel Herranz
03ff363982 Fix missing parentheses 2017-02-02 22:05:31 +01:00
moneromooo-monero
3471907160
simplewallet: cleanup 
Remove empty static function which was refactored, as well as
leftover exception testing code.
 2017-02-02 20:56:53 +00:00
moneromooo-monero
a9a9b64b13
simplewallet: fix build (unqualified type not in current scope) 2017-02-02 20:56:31 +00:00
moneromooo-monero
b5cb8861c7
core: fix integrated addresses breaking with auto zero change 
Zero change is sent to a random address, which confuses the code
which determines which key to use to encrypt the payment id.
Ignore zero amounts for this purpose, so the payment id gets
encrypted with the real destination's key.
 2017-02-02 20:53:12 +00:00
Riccardo Spagni
b01990124e
Merge pull request #1663 
bbcc3a12 Add missing include (Miguel Herranz)
 2017-02-02 22:41:58 +02:00
Riccardo Spagni
fcb299b4ae
Merge pull request #1641 
ca94d0a4 Separate data per P2P port (Miguel Herranz)
 2017-02-02 22:41:28 +02:00
Riccardo Spagni
f4fe39ca92
Merge pull request #1654 
084aef70 Added days uptime to the status message (NanoAkron)
 2017-02-02 21:38:15 +02:00
Riccardo Spagni
58c87786ae
Merge pull request #1652 
fba9332d Changed console output for transaction from L0 to L1 (NanoAkron)
 2017-02-02 21:36:56 +02:00
Riccardo Spagni
011c5a8a7c
Merge pull request #1647 
2bf029be wallet2: fix corner case failing to send a second output (moneromooo-monero)
 2017-02-02 21:35:31 +02:00
Riccardo Spagni
3aa008e4c6
Merge pull request #1646 
95f3e193 Update and use blockchain data files defines (Miguel Herranz)
 2017-02-02 21:34:31 +02:00
Riccardo Spagni
10b625079b
Merge pull request #1645 
9bd9906e Factor is_address_local code into a tools function (moneromooo-monero)
 2017-02-02 21:27:45 +02:00
Riccardo Spagni
614400e5af
Merge pull request #1643 
69d2ad39 wallet_rpc_server: fix logs going to the wrong file (moneromooo-monero)
 2017-02-02 21:26:56 +02:00
Riccardo Spagni
c3eff820be
Merge pull request #1642 
3ae79a59 core: set missing verifivation_failed flag when rejecting a tx (moneromooo-monero)
ea6549e9 core_tests: decrease trace level from trace to debug (moneromooo-monero)
 2017-02-02 21:25:30 +02:00
Riccardo Spagni
ab2b3480b2
Merge pull request #1639 
48aa9cf0 Add change_password for simplewallet (Ashley Perpetual)
 2017-02-02 21:22:30 +02:00
Riccardo Spagni
72aa788a0e
Merge pull request #1636 
cc1462e0 Add concurrency check to rpc mining to ensure not too many threads. number of cores times 4 or 257. (Ashley Perpetual)
 2017-02-02 21:12:13 +02:00
Miguel Herranz
bbcc3a125f Add missing include 
Fails to build without it.
 2017-02-02 19:54:17 +01:00
Riccardo Spagni
5bb95fc613
Merge pull request #1634 
99f58437 Fix invalid + of std::string and int (Timothy D. Prime)
 2017-02-02 19:43:05 +02:00
Riccardo Spagni
a6f61b8419
Merge pull request #1631 
58e82506 Blockfill - Sort tx pool correctly (Alexis Enston)
5f7a8741 Blockfill - Take TX fees into account properly (Alexis Enston)
4ecab0d8 Consider empty block when filling with TXs (Alexis Enston)
 2017-02-02 19:41:25 +02:00
Riccardo Spagni
5fb3f97a55
Merge pull request #1629 
c02e1cb9 Updates to epee HTTP client code   - http_simple_client now uses std::chrono for timeouts   - http_simple_client accepts timeouts per connect / invoke call   - shortened names of epee http invoke functions   - invoke command functions only take relative path, connection     is not automatically performed (Lee Clagett)
 2017-02-02 19:32:01 +02:00
Riccardo Spagni
10bf54bfc9
Merge pull request #1628 
66665003 Clear feedback to user when daemon has stopped successfully (NanoAkron)
 2017-02-02 18:44:41 +02:00
Riccardo Spagni
ca2e2c2453 Merge pull request #1627 
55a8e982 moved get_account_address_from_str_or_url from libcommon to libcryptonote_core (kenshi84)
 2017-02-02 18:24:08 +02:00
Riccardo Spagni
cc03036e3e
Merge pull request #1624 
a39cd745 rpc: fix bc_dyn_stats not setting grace blocks (moneromooo-monero)
 2017-02-02 18:20:07 +02:00
Riccardo Spagni
f9e60dcd55
Merge pull request #1617 
0644eed7 Remove boost/foreach.cpp includes (Miguel Herranz)
36dd3e23 Replace BOOST_REVERSE_FOREACH with ranged for (Miguel Herranz)
629e3101 Replace BOOST_FOREACH with C++11 ranged for (Miguel Herranz)
 2017-02-02 18:16:39 +02:00
NanoAkron
084aef700b
Added days uptime to the status message 
Also broke down the time calculations for legibility
 2017-01-31 09:49:32 +00:00
luigi1111
1cb5905e71
Merge pull request #1637 
6b14576 Fix clang build failure, caused by mixing C and C++ (tdprime)
 2017-01-30 17:55:52 -06:00
luigi1111
3cef7fbbb6
Merge pull request 1635 
774a213 Wallet API: Create wallet from keys (Jaqueeee)
 2017-01-30 17:09:38 -06:00
Jaquee
774a21394a
Wallet API: Create wallet from keys 2017-01-30 23:28:09 +01:00
NanoAkron
fba9332de8
Changed console output for transaction from L0 to L1 2017-01-30 03:24:51 +00:00
moneromooo-monero
8c8482ac98
wallet_rpc_server: fix short payment id validation in transfer 2017-01-29 16:10:20 +00:00
Ashley Perpetual
48aa9cf035 Add change_password for simplewallet 2017-01-29 03:04:17 +08:00
moneromooo-monero
2bf029be17
wallet2: fix corner case failing to send a second output 
If a rct transaction can be made with just one input, a second
output will be added. This output will be the smallest amount
output available. However, if this output is a non rct output
with less available fake outs than requested, the transaction
will be rejected. We now check the histogram to only consider
outputs with enough available fake outs in the first place.
 2017-01-28 15:07:15 +00:00
moneromooo-monero
9bd9906e8f
Factor is_address_local code into a tools function 2017-01-28 14:57:47 +00:00
Miguel Herranz
95f3e193f0 Update and use blockchain data files defines 2017-01-28 15:55:14 +01:00
Miguel Herranz
ca94d0a43c Separate data per P2P port 
poolstate.bin and p2pstate.bin are stored in .bitmonero/ if the default
P2P port is being used.

If another port is used both files are stored in
.bitmonero/PORTNUMBER/.
 2017-01-28 14:16:06 +01:00
moneromooo-monero
69d2ad3967
wallet_rpc_server: fix logs going to the wrong file 2017-01-28 11:37:21 +00:00
moneromooo-monero
3ae79a59e4
core: set missing verifivation_failed flag when rejecting a tx 
This fixes two core rct tests
 2017-01-28 09:43:41 +00:00
Ashley Perpetual
cc1462e0b7 Add concurrency check to rpc mining to ensure not too many threads. number of cores times 4 or 257. 2017-01-28 05:59:56 +08:00
luigi1111
4629ead8c5
Merge pull request #1618 2017-01-27 11:33:26 -06:00
Timothy D. Prime
6b145763f7 Fix clang build failure, caused by mixing C and C++ 
Easily fixed by moving a C++ header out of 'extern "C" {...}'.

When building with CC=clang CXX=clang++ make,
[ 21%] Building CXX object src/ringct/CMakeFiles/obj_ringct.dir/rctTypes.cpp.o
In file included from /home/tdprime/bitmonero/src/ringct/rctTypes.cpp:31:
In file included from /home/tdprime/bitmonero/src/ringct/rctTypes.h:43:
In file included from /home/tdprime/bitmonero/src/crypto/generic-ops.h:34:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/cstring💯3: error: conflicting types for 'memchr'
  memchr(void* __s, int __c, size_t __n)
    ^
	/usr/include/string.h:92:14: note: previous declaration is here
	extern void *memchr (const void *__s, int __c, size_t __n)
	             ^
... and 4 more similar errors
 2017-01-26 17:30:00 -08:00
Timothy D. Prime
99f584376e Fix invalid + of std::string and int 
These warnings were emitted by clang++, and they are real bugs.
src/rpc/core_rpc_server.cpp:208:58: warning: adding 'uint64_t'
      (aka 'unsigned long') to a string does not append to the string
      [-Wstring-plus-int]
        res.status = "Error retrieving block at height " + height;
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
The obvious intent is achieved by using std::to_string().
 2017-01-26 10:11:37 -08:00
Lee Clagett
c02e1cb943 Updates to epee HTTP client code 
- http_simple_client now uses std::chrono for timeouts
  - http_simple_client accepts timeouts per connect / invoke call
  - shortened names of epee http invoke functions
  - invoke command functions only take relative path, connection
    is not automatically performed
 2017-01-25 15:39:32 -05:00
Alexis Enston
58e825060e Blockfill - Sort tx pool correctly 2017-01-25 12:06:19 +00:00
Alexis Enston
5f7a8741b9 Blockfill - Take TX fees into account properly 2017-01-25 11:59:25 +00:00
Alexis Enston
4ecab0d80c Consider empty block when filling with TXs 2017-01-25 11:59:15 +00:00
NanoAkron
66665003bd
Clear feedback to user when daemon has stopped successfully 2017-01-25 00:37:23 +00:00
kenshi84
55a8e982c0 moved get_account_address_from_str_or_url from libcommon to libcryptonote_core 2017-01-24 20:31:03 +09:00
moneromooo-monero
a39cd745c9
rpc: fix bc_dyn_stats not setting grace blocks 
This caused a random value to be used, and the resulting
incorrect fee when it wasn't 0.
 2017-01-23 19:28:00 +00:00
Riccardo Spagni
ad91ffe7e5
Merge pull request #1622 
8141973e Remove unreachable returns (Miguel Herranz)
 2017-01-23 08:11:24 -05:00
Riccardo Spagni
6f39ba5909
Merge pull request #1621 
feed6175 fixed typo: monero-wallet-cli,log (kenshi84)
 2017-01-23 08:11:02 -05:00
Miguel Herranz
8141973e00 Remove unreachable returns 
CATCH_ENTRY_L0 already returns the second value.
 2017-01-23 11:29:34 +01:00
kenshi84
feed6175ea fixed typo: monero-wallet-cli,log 2017-01-23 11:44:06 +09:00
NanoAkron
98357db400
Update log messages to reflect fact we no longer need to type exit to save database before quitting 2017-01-23 01:21:26 +00:00
Miguel Herranz
0644eed772 Remove boost/foreach.cpp includes 2017-01-22 23:31:34 +01:00
=
e92c4fff1a
Wallet api: testnet getter 2017-01-22 23:02:01 +01:00
Miguel Herranz
36dd3e238f Replace BOOST_REVERSE_FOREACH with ranged for 2017-01-22 21:47:39 +01:00
Miguel Herranz
629e3101ab Replace BOOST_FOREACH with C++11 ranged for 2017-01-22 21:38:10 +01:00
moneromooo-monero
8028b5324e
protocol: log received messages in a separate category 
Makes it easier to log just what's going on on P2P
 2017-01-22 16:54:10 +00:00
Riccardo Spagni
9c06a7fd04
Merge pull request #1615 
f0989893 core: cache tx hashes of failing semantics txes (moneromooo-monero)
 2017-01-22 11:51:53 -05:00
Riccardo Spagni
17247b23bf
Merge pull request #1612 
20f71527 wallet2: fix sending a rct tx with a single output available (moneromooo-monero)
 2017-01-22 11:49:20 -05:00
Riccardo Spagni
a3de797e57
Merge pull request #1610 
b70ab128 rpc: fix orphan_status when getting blocks (moneromooo-monero)
 2017-01-22 11:48:39 -05:00
Riccardo Spagni
add98edfc3
Merge pull request #1609 
4cdf0a35 p2p: always recreate a new peer id on startup (moneromooo-monero)
 2017-01-22 11:47:43 -05:00
Riccardo Spagni
f798a2ab85
Merge pull request #1606 
f8b97aef p2p: show ban/unban logs by default again (moneromooo-monero)
 2017-01-22 11:43:11 -05:00
Riccardo Spagni
ee45b7a6db
Merge pull request #1605 
7c3f79cb core: early out in handle_incoming_tx if already in pool or blockchain (moneromooo-monero)
6cc7d261 ringct: reorder a bit to check quicker tests first (moneromooo-monero)
 2017-01-22 11:42:15 -05:00
Riccardo Spagni
e12f073f65
Merge pull request #1604 
a854cec3 Make stack trace show up in log file with default settings (moneromooo-monero)
 2017-01-22 11:41:38 -05:00
moneromooo-monero
f098989396
core: cache tx hashes of failing semantics txes 2017-01-22 16:13:31 +00:00
moneromooo-monero
20f7152769
wallet2: fix sending a rct tx with a single output available 
This would have tried to send a second output to make the tx
look like the 2/2 ideal, but it would not fail to find one
because picking an output from preferred_inputs priority list
did not remove it from the unused tranfer/dust outputs, so
it would try to send the same output twice.

While there, I also added a check to avoid sending a second
input if it's related to the first. Better 1/2 than linking
inputs, I think.
 2017-01-22 15:16:45 +00:00
moneromooo-monero
b70ab128fc
rpc: fix orphan_status when getting blocks 
It was always set to false, even for orphan blocks
 2017-01-22 12:20:55 +00:00
moneromooo-monero
4cdf0a35c9
p2p: always recreate a new peer id on startup 
This prevents easy fingerprinting when you change IPs, and
will be a must when kovri gets used.
 2017-01-22 11:37:55 +00:00
moneromooo-monero
f8b97aef34
p2p: show ban/unban logs by default again 2017-01-21 21:19:21 +00:00
moneromooo-monero
7c3f79cb9f
core: early out in handle_incoming_tx if already in pool or blockchain 2017-01-21 20:30:10 +00:00
moneromooo-monero
6cc7d26140
ringct: reorder a bit to check quicker tests first 2017-01-21 20:29:22 +00:00
moneromooo-monero
a854cec3ba
Make stack trace show up in log file with default settings 2017-01-21 20:28:18 +00:00
Miguel Herranz
1c4d65c011 Rename method to get_random_gray_peer 2017-01-21 13:04:49 +01:00
Miguel Herranz
03a54ee0c9 Fix logging that broke after rebasing 2017-01-21 11:22:04 +01:00
Miguel Herranz
6bdd3a59b5 Use set_peer_just_seen to keep last_seen updated 2017-01-21 10:11:32 +01:00
Miguel Herranz
82dbeedd1b Add gray peer list housekeeping system 
A random peer from the gray peer list is selected and a connection is
made to check if the peer is alive.

If the connection and handshake are successful the peer is promoted to
the white peer list, in case of failure the peer is evicted from the
gray peer list.

The connection is closed after the check in either case.
 2017-01-21 10:09:38 +01:00
Riccardo Spagni
39aaea8e62
Merge pull request #1599 
17246d05 wallet: print exception message on get_random_outs_error (moneromooo-monero)
 2017-01-20 21:00:01 -05:00
Riccardo Spagni
3db3a6ee1a
Merge pull request #1593 
cbcdf8ad Honor depth in get_peerlist_head method (Miguel Herranz)
 2017-01-20 20:59:09 -05:00
Riccardo Spagni
4bcd284c76
Merge pull request #1592 
78d560a9 simplewallet: use MAKE_CORE_RPC_VERSION(1,4) instead of 0x10004 (kenshi84)
 2017-01-20 20:58:55 -05:00
Riccardo Spagni
d5fbba45e8
Merge pull request #1589 
87c658f8 wallet2_api: add API to set log categories (moneromooo-monero)
 2017-01-20 20:58:39 -05:00
Riccardo Spagni
8698dd36f2
Merge pull request #1587 
843769f8 Tweak some msg loglevels (Howard Chu)
 2017-01-20 20:56:47 -05:00
Riccardo Spagni
d10425025a
Merge pull request #1572 
0e0e6c5f Reduce to one connection per IP (Miguel Herranz)
3f269e98 Limit incoming connections from the same IP (Miguel Herranz)
 2017-01-20 20:54:04 -05:00
moneromooo-monero
17246d051d
wallet: print exception message on get_random_outs_error 2017-01-20 18:01:13 +00:00
Miguel Herranz
cbcdf8ad35 Honor depth in get_peerlist_head method 
The method returned depth + 2 because:

- push_back was executed before the condition.
- > instead of >= causing one more iteration.
 2017-01-18 21:41:52 +01:00
kenshi84
78d560a933 simplewallet: use MAKE_CORE_RPC_VERSION(1,4) instead of 0x10004 2017-01-18 16:11:18 +09:00
moneromooo-monero
87c658f83b
wallet2_api: add API to set log categories 2017-01-16 21:14:44 +00:00
Howard Chu
843769f88f
Tweak some msg loglevels 2017-01-16 20:42:59 +00:00
Miguel Herranz
0e0e6c5f39 Reduce to one connection per IP 2017-01-16 18:16:32 +01:00
Riccardo Spagni
71ac698b78
Merge pull request #1585 
a480bf6b fixups in logging init calls, and add missing net context in a log (moneromooo-monero)
 2017-01-16 08:41:33 -05:00
Riccardo Spagni
deb6728bc3
Merge pull request #1584 
990e08f0 Fix PR#1506, off by one in chain height (Howard Chu)
 2017-01-16 08:41:15 -05:00
moneromooo-monero
a480bf6b14
fixups in logging init calls, and add missing net context in a log 2017-01-16 10:45:59 +00:00
Howard Chu
990e08f090
Fix PR#1506, off by one in chain height 2017-01-16 10:00:06 +00:00
moneromooo-monero
693c190881
wallet: add a node RPC cache layer for simple RPC calls 
Mostly getinfo and get_hard_fork_info, which are called
pretty often. This speeds up transfers as a bonus.
 2017-01-16 08:59:15 +00:00
moneromooo-monero
d86ae2bec6
wallet2: reuse fake outs when adjusting fee on transfer 
This avoids indirectly leaking the real output to the daemon,
and is faster.

This will still happen for more complex cases, especially
when cancelling a tx and "re-rolling" it.
 2017-01-16 08:59:08 +00:00
moneromooo-monero
64da0983d5
core: don't try to deserialize an empty extra to remove a field 2017-01-16 08:59:02 +00:00
Riccardo Spagni
ab69d5b367
Merge pull request #1569 
16b8b66a specify restore height by YYYY-MM-DD format (kenshi84)
 2017-01-15 20:32:57 -05:00
kenshi84
16b8b66adc specify restore height by YYYY-MM-DD format 2017-01-16 10:00:28 +09:00
moneromooo-monero
5833d66f65
Change logging to easylogging++ 
This replaces the epee and data_loggers logging systems with
a single one, and also adds filename:line and explicit severity
levels. Categories may be defined, and logging severity set
by category (or set of categories). epee style 0-4 log level
maps to a sensible severity configuration. Log files now also
rotate when reaching 100 MB.

To select which logs to output, use the MONERO_LOGS environment
variable, with a comma separated list of categories (globs are
supported), with their requested severity level after a colon.
If a log matches more than one such setting, the last one in
the configuration string applies. A few examples:

This one is (mostly) silent, only outputting fatal errors:

MONERO_LOGS=*:FATAL

This one is very verbose:

MONERO_LOGS=*:TRACE

This one is totally silent (logwise):

MONERO_LOGS=""

This one outputs all errors and warnings, except for the
"verify" category, which prints just fatal errors (the verify
category is used for logs about incoming transactions and
blocks, and it is expected that some/many will fail to verify,
hence we don't want the spam):

MONERO_LOGS=*:WARNING,verify:FATAL

Log levels are, in decreasing order of priority:
FATAL, ERROR, WARNING, INFO, DEBUG, TRACE

Subcategories may be added using prefixes and globs. This
example will output net.p2p logs at the TRACE level, but all
other net* logs only at INFO:

MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE

Logs which are intended for the user (which Monero was using
a lot through epee, but really isn't a nice way to go things)
should use the "global" category. There are a few helper macros
for using this category, eg: MGINFO("this shows up by default")
or MGINFO_RED("this is red"), to try to keep a similar look
and feel for now.

Existing epee log macros still exist, and map to the new log
levels, but since they're used as a "user facing" UI element
as much as a logging system, they often don't map well to log
severities (ie, a log level 0 log may be an error, or may be
something we want the user to see, such as an important info).
In those cases, I tried to use the new macros. In other cases,
I left the existing macros in. When modifying logs, it is
probably best to switch to the new macros with explicit levels.

The --log-level options and set_log commands now also accept
category settings, in addition to the epee style log levels.
 2017-01-16 00:25:46 +00:00
Riccardo Spagni
e459d8604d
Merge pull request #1578 
ce866d1c macro to define core RPC version for avoiding future mistake (kenshi84)
 2017-01-15 19:13:45 -05:00
Riccardo Spagni
422a36ca2a
Merge pull request #1581 
6da9335a blockchain_import: fix build after tx_pool::add_tx changes (moneromooo-monero)
 2017-01-15 19:13:28 -05:00
Riccardo Spagni
ec323d8c3f
Merge pull request #1561 
d561f4ad enable clang checks that were disabled (Chris Vickio)
0aefb2f6 remove std::move from return statements (pessimizing-move warning) (Chris Vickio)
629d5b76 change counter from bool to int (deprecated-increment-bool warning) (Chris Vickio)
fb76d439 add extra braces around subobjects (missing-braces warning) (Chris Vickio)
3b6d5f25 make struct/class declarations consistent (mismatched-tags warning) (Chris Vickio)
fcf66925 remove unused fields from network_throttle (unused-private-field warning) (Chris Vickio)
296f8c16 inline unused function (for unused-function warning) (Chris Vickio)
 2017-01-15 19:01:08 -05:00
kenshi84
ce866d1cc6 macro to define core RPC version for avoiding future mistake 2017-01-16 07:55:43 +09:00
moneromooo-monero
6da9335a9e
blockchain_import: fix build after tx_pool::add_tx changes 2017-01-15 21:52:56 +00:00
Riccardo Spagni
b2e1568335
Merge pull request #1579 
f5f4109f mnemonics: fix language detection with checksum word (moneromooo-monero)
 2017-01-15 14:58:09 -05:00
Riccardo Spagni
99ffc49740
Merge pull request #1577 
feb499aa core: check block version for alt chains too (moneromooo-monero)
 2017-01-15 14:57:30 -05:00
Riccardo Spagni
1207d8ad0d
Merge pull request #1576 
ba3968f6 rct: split rct checks between semantics and other (moneromooo-monero)
 2017-01-15 14:56:39 -05:00
Riccardo Spagni
9cda94d0aa
Merge pull request #1574 
d276a165 wallet2: use at least two rct inputs if possible (moneromooo-monero)
 2017-01-15 14:55:40 -05:00
Riccardo Spagni
f00797a1f2
Merge pull request #1573 
dea53962 fix timeout in check_connection (Jaquee)
 2017-01-15 14:55:12 -05:00
Riccardo Spagni
10c6afd316
Merge pull request #1571 
81c384e4 fix do_not_relay not preventing relaying on a timer (moneromooo-monero)
 2017-01-15 14:50:10 -05:00
Riccardo Spagni
91083a43be
Merge pull request #1568 
5b5017e2 rpc: add a command to get info about the current blockchain (moneromooo-monero)
 2017-01-15 14:48:09 -05:00
Riccardo Spagni
31de98793f
Merge pull request #1567 
c9f13c5e wallet2: fix tx reroll not updating fee is going up a kB step (moneromooo-monero)
 2017-01-15 14:47:44 -05:00
Riccardo Spagni
51baab2112
Merge pull request #1565 
50b230d1 core: ensure block size limit is set from the start (moneromooo-monero)
 2017-01-15 14:47:17 -05:00
Riccardo Spagni
865f5bef34
Merge pull request #1564 
1d317981 Wallet API: add key image import/export functions (Jaquee)
 2017-01-15 14:46:52 -05:00
Riccardo Spagni
8bd2c2e551
Merge pull request #1563 
36ba311c Prioritize older transactions in the mempool (Miguel Herranz)
 2017-01-15 14:46:33 -05:00
Riccardo Spagni
935f50471c
Merge pull request #1560 
46550c0b Wallet API: add rescanSpent() (Jaquee)
 2017-01-15 14:44:49 -05:00
Riccardo Spagni
c23bd75df6
Merge pull request #1552 
4a017674 Wallet API: support integrated addresses in address book. (Jaquee)
 2017-01-15 14:44:28 -05:00
Riccardo Spagni
65e33b1bc5
Merge pull request #1506 
3ff54bdd Check for correct thread before ending batch transaction (Howard Chu)
eaf8470b Must wait for previous batch to finish before starting new one (Howard Chu)
c903c554 Don't cache block height, always get from DB (Howard Chu)
eb1fb601 Tweak default db-sync-mode to fast:async:1 (Howard Chu)
0693cff9 Use batch transactions when syncing (Howard Chu)
 2017-01-15 14:43:12 -05:00
Chris Vickio
0aefb2f60a remove std::move from return statements (pessimizing-move warning) 2017-01-15 19:23:33 +03:00
Chris Vickio
629d5b7689 change counter from bool to int (deprecated-increment-bool warning) 2017-01-15 19:23:33 +03:00
Howard Chu
3ff54bdd7a
Check for correct thread before ending batch transaction 2017-01-15 15:51:57 +00:00
moneromooo-monero
f5f4109f9a
mnemonics: fix language detection with checksum word 
If a checksum word is present, language detection would use
just the word prefixes. However, a set of word prefixes may
be found in more than one language, and so the wrong language
may be found first, which could then fail the checksum, since
the check may be done with a different unique prefix length
from the one it was created from.

We now make a checksum test when we we detect a language from
prefixes only, to make sure we have the correct one.
 2017-01-15 11:16:25 +00:00
Miguel Herranz
3f269e988c Limit incoming connections from the same IP 2017-01-15 12:11:27 +01:00
Howard Chu
eaf8470b29
Must wait for previous batch to finish before starting new one 2017-01-14 22:43:06 +00:00
Howard Chu
c903c5541e
Don't cache block height, always get from DB 2017-01-14 22:43:06 +00:00
Howard Chu
eb1fb6011a
Tweak default db-sync-mode to fast:async:1 
fsync the DB asynchronously, to allow block download/verification
to proceed while syncing. Sync after every batch. Note that
"fastest" still defaults to fastest:async:1000.
 2017-01-14 22:43:06 +00:00
Howard Chu
0693cff925
Use batch transactions when syncing 
Faster throughput while avoiding corruption. I.e., makes
running with --db-sync-mode safe more tolerable.
 2017-01-14 22:43:06 +00:00
moneromooo-monero
feb499aaae
core: check block version for alt chains too 
This is incompatible with block version voting
 2017-01-14 22:41:14 +00:00
moneromooo-monero
d276a16526
wallet2: use at least two rct inputs if possible 
If we'd make a rct tx with just one input, we try to add
a second one to match the 2/2 ideal. This means more txes
use that template (and are thus using a larger anonymity
set), and it coalesces outputs "for free". We use the
smallest amount outputs in priority for this, so we can
"clean" the wallet at the same time.
 2017-01-14 21:43:01 +00:00
moneromooo-monero
ba3968f6ce
rct: split rct checks between semantics and other 
Semantics can be checked early
 2017-01-14 21:17:32 +00:00
Jaquee
dea53962a3
fix timeout in check_connection 2017-01-14 14:45:30 +01:00
moneromooo-monero
81c384e408
fix do_not_relay not preventing relaying on a timer 
Also print its value when printing pool
 2017-01-14 13:07:05 +00:00
Chris Vickio
fb76d43980 add extra braces around subobjects (missing-braces warning) 2017-01-14 15:06:07 +03:00
Chris Vickio
3b6d5f255d make struct/class declarations consistent (mismatched-tags warning) 2017-01-14 15:06:07 +03:00
Chris Vickio
fcf66925c1 remove unused fields from network_throttle (unused-private-field warning) 2017-01-14 15:06:07 +03:00
moneromooo-monero
5b5017e267
rpc: add a command to get info about the current blockchain 
About the tip of the main chain, and the last N blocks
 2017-01-13 23:21:38 +00:00
moneromooo-monero
c9f13c5e54
wallet2: fix tx reroll not updating fee is going up a kB step 2017-01-13 22:28:19 +00:00
moneromooo-monero
176b70a0d4
account: fix build error involving std::max and different types 2017-01-13 22:12:27 +00:00
Jaquee
1d3179816b
Wallet API: add key image import/export functions 2017-01-13 23:02:20 +01:00
Jaquee
4a0176740d
Wallet API: support integrated addresses in address book. 2017-01-13 22:41:17 +01:00
moneromooo-monero
50b230d12c
core: ensure block size limit is set from the start 
It can now be queried by RPC, so it needs to be set before
it is otherwise needed for consensus, even if no blocks had
to be added (ie, exit and restart quickly).
 2017-01-13 21:06:14 +00:00
Jaquee
46550c0b4f
Wallet API: add rescanSpent() 2017-01-13 22:05:39 +01:00
Riccardo Spagni
2806842200
Merge pull request #1562 
a081b39c Move key image export/import functions to wallet2 (Jaquee)
 2017-01-13 14:38:29 -05:00
Riccardo Spagni
2a2f02e375
Merge pull request #1559 
db56a03f Wallet2 + API: Callbacks for unconfirmed transfers (Jaquee)
 2017-01-13 14:37:12 -05:00
Riccardo Spagni
cbb39b499b
Merge pull request #1558 
7961878e initialize timestamp to 0 and check for mktime() error (Chris Vickio)
 2017-01-13 14:36:42 -05:00
Riccardo Spagni
e75fd059dd
Merge pull request #1555 
758c0eb7 fix time stats mixin (luigi1111)
 2017-01-13 14:36:24 -05:00
Riccardo Spagni
433adee594
Merge pull request #1545 
5ae00f0f add msg for donate (luigi1111)
 2017-01-13 14:35:34 -05:00
Riccardo Spagni
0b6031adbf
Merge pull request #1543 
19be7225 Add start_time to get_info methods and show uptime (Miguel Herranz)
 2017-01-13 14:35:21 -05:00
Riccardo Spagni
faa33fc326
Merge pull request #1541 
0d3918e1 Wallet api: Update trustedDaemon when daemon is changed (Jaquee)
dbb838f4 GUI cold signing (Jaquee)
afb85a02 Wallet API: functions for supporting/creating view only wallets (Jaquee)
 2017-01-13 14:34:55 -05:00
Riccardo Spagni
e51afeb90f
Merge pull request #1540 
79b4e1f9 Cold signing: make sure short payment id isnt encrypted twice (Jaquee)
 2017-01-13 14:34:26 -05:00
Riccardo Spagni
006bb0e957
Merge pull request #1538 
aff28178 Remove db-auto-remove-logs (Miguel Herranz)
1229c685 Remove berkeley from db_type initialization (Miguel Herranz)
e3090558 Show available types for db-type command (Miguel Herranz)
046ab33d Remove berkeley from blockchain_db_types (Miguel Herranz)
 2017-01-13 14:33:59 -05:00
Riccardo Spagni
36b84ded95
Merge pull request #1526 
5eed5b05 Wallet API: functions for supporting/creating view only wallets (Jaquee)
 2017-01-13 14:32:26 -05:00
Riccardo Spagni
aeeb24991a
Merge pull request #1523 
d81cb087 Added (not yet enabled) HTTP client authentication (Lee Clagett)
 2017-01-13 14:32:08 -05:00
Riccardo Spagni
71c7577370
Merge pull request #1513 
a813ab50 wallet2_api: add solo mining API (moneromooo-monero)
 2017-01-13 13:24:45 -05:00
Riccardo Spagni
5738e07fba
Merge pull request #1492 
f1dde1a4 wallet cli: print originating block heights of mixin keys when making transfer (kenshi84)
 2017-01-13 13:22:13 -05:00
Miguel Herranz
36ba311cf4 Prioritize older transactions in the mempool 
The transactions are first prioritized by fee and in case the fees are
equal by receive_time.
 2017-01-13 16:08:37 +01:00
Jaquee
a081b39c01
Move key image export/import functions to wallet2 2017-01-13 12:49:10 +01:00
Jaquee
db56a03ff2
Wallet2 + API: Callbacks for unconfirmed transfers 2017-01-12 18:25:34 +01:00
Chris Vickio
7961878e81 initialize timestamp to 0 and check for mktime() error 2017-01-12 10:13:58 +03:00
Miguel Herranz
19be7225cc Add start_time to get_info methods and show uptime 2017-01-12 00:15:21 +01:00
Lee Clagett
d81cb08704 Added (not yet enabled) HTTP client authentication 2017-01-11 03:21:17 -05:00
Jaquee
0d3918e15b
Wallet api: Update trustedDaemon when daemon is changed 2017-01-10 22:49:30 +01:00
Jaquee
dbb838f4d0
GUI cold signing 
fix conflict
 2017-01-10 22:49:17 +01:00
Jaquee
afb85a028f
Wallet API: functions for supporting/creating view only wallets 2017-01-10 22:49:11 +01:00
Jaquee
5eed5b056b
Wallet API: functions for supporting/creating view only wallets 2017-01-10 22:34:46 +01:00
luigi1111
758c0eb79f
fix time stats mixin 
also add blobsize
 2017-01-10 10:15:15 -06:00
Miguel Herranz
aff28178e6 Remove db-auto-remove-logs 2017-01-10 11:49:45 +01:00
Miguel Herranz
1229c68587 Remove berkeley from db_type initialization 2017-01-10 11:46:12 +01:00
Miguel Herranz
e309055819 Show available types for db-type command 2017-01-10 11:44:01 +01:00
Miguel Herranz
046ab33d1b Remove berkeley from blockchain_db_types 2017-01-10 11:17:48 +01:00
moneromooo-monero
a813ab50fe
wallet2_api: add solo mining API 2017-01-09 10:12:55 +00:00
kenshi84
f1dde1a429 wallet cli: print originating block heights of mixin keys when making transfer 2017-01-09 15:10:34 +09:00
luigi1111
5ae00f0ff5 add msg for donate 
#1498
 2017-01-08 21:05:00 -06:00
luigi1111
db44a909ba Fix monero-wallet-cli compile 
Not 100$ sure this is the right fix, nor whether address book entries from URL should be stored as addresses or URLs (or both with a check for change on payment).
 2017-01-08 20:26:57 -06:00
Riccardo Spagni
c6ec939626
Merge pull request #1542 
60fe1b61 Add parse_uri to wallet2_api (MoroccanMalinois)
 2017-01-08 16:47:42 -08:00
Riccardo Spagni
59021496d8
Merge pull request #1537 
c2135082 simplewallet: add a show_transfer <txid> command (moneromooo-monero)
19c4041d wallet_rpc_server: new RPC call to get a transfer by txid (moneromooo-monero)
 2017-01-08 16:44:29 -08:00
Riccardo Spagni
15dcc5afd3
Merge pull request #1534 
1607cb7e tx_pool: better block template filling algorithm (moneromooo-monero)
9731b4e5 rpc: add block size to GET_BLOCK_HEADER RPC (moneromooo-monero)
9188b346 rpc: add current block size to the getinfo call (moneromooo-monero)
 2017-01-08 16:43:54 -08:00
Riccardo Spagni
6cbfe0f849
Merge pull request #1521 
21c5af5a wallet2_api: add an address book payment id lookup API (moneromooo-monero)
 2017-01-08 16:42:08 -08:00
Riccardo Spagni
ba9744d400
Merge pull request #1515 
ada7c7da portable serializer: tests added (kenshi84)
f390a0e2 portable serializer: make signerd/unsigned tx portable, ignore archive version checking (kenshi84)
 2017-01-08 16:41:44 -08:00
Riccardo Spagni
2a996f492f
Merge pull request #1510 
80abc3bc Build wallet with Android NDK (MoroccanMalinois)
 2017-01-08 16:40:02 -08:00
Riccardo Spagni
da05900524
Merge pull request #1509 
29333c41 wallet api: prevent setting refresh height too high (Jaquee)
 2017-01-08 16:39:23 -08:00
Riccardo Spagni
13c5da2aa3
Merge pull request #1508 
4585ada4 Wallet2: faster exit while refreshing (Jaquee)
 2017-01-08 16:39:07 -08:00
Riccardo Spagni
0ce4618bea
Merge pull request #1504 
5f4ac6b9 wallet2 bugfix: store watch_only flag properly with rewrite() (kenshi84)
 2017-01-08 16:38:19 -08:00
Riccardo Spagni
c284b0fff7
Merge pull request #1503 
542571f5 simplewallet: remove unnecessary local_args.erase(...) in set_variable() (kenshi84)
 2017-01-08 16:38:01 -08:00
Riccardo Spagni
fdb1cda965
Merge pull request #1502 
591d8368 core: invalidate difficulty cache when resetting blockchain (moneromooo-monero)
 2017-01-08 16:37:31 -08:00
Riccardo Spagni
06de09daf4
Merge pull request #1501 
cebae0c5 wallet2: check the node returned the real output when requested (moneromooo-monero)
 2017-01-08 16:37:11 -08:00
Riccardo Spagni
1736b7ef6b
Merge pull request #1500 
c0a0fcaf wallet2_api: some new APIs to access daemon state (moneromooo-monero)
 2017-01-08 16:36:46 -08:00
Riccardo Spagni
d655e88b44
Merge pull request #1499 
37ed96e6 tx_pool: fix uninitialized "last failed" fields (moneromooo-monero)
94b6feef rpc: fix mixup in tx_info serialization (moneromooo-monero)
 2017-01-08 16:35:49 -08:00
Riccardo Spagni
03497f0268
Merge pull request #1497 
50511677 wallet2: fix large reorgs failing (moneromooo-monero)
 2017-01-08 16:35:14 -08:00
Riccardo Spagni
209a633a3c
Merge pull request #1496 
adee1644 wallet cli: print unspent outputs with histogram (kenshi84)
 2017-01-08 16:34:51 -08:00
Riccardo Spagni
23cf963332
Merge pull request #1493 
0478ac68 blockchain: allow marking "tx not found" without an exception (moneromooo-monero)
 2017-01-08 16:33:41 -08:00
Riccardo Spagni
fc0a2b837b
Merge pull request #1490 
474c249c cleaner log calc algorithm (fireice-uk)
 2017-01-08 16:32:21 -08:00
Riccardo Spagni
f4b3989c61
Merge pull request #1482 
38f00d07 wallet cli: viewing and editing address book (kenshi84)
 2017-01-08 16:31:55 -08:00
Riccardo Spagni
ff1bb6bc68
Merge pull request #1460 
99580adf make openalias also available for solo miner; introduce namespace tools::dns_utils; support integrated address with dns lookup (kenshi84)
 2017-01-08 16:31:42 -08:00
MoroccanMalinois
60fe1b61e0 Add parse_uri to wallet2_api 2017-01-08 22:53:24 +00:00
Jaquee
79b4e1f997
Cold signing: make sure short payment id isnt encrypted twice 2017-01-08 21:04:53 +01:00
moneromooo-monero
c21350823f
simplewallet: add a show_transfer <txid> command 2017-01-08 13:57:24 +00:00
moneromooo-monero
19c4041df5
wallet_rpc_server: new RPC call to get a transfer by txid 2017-01-08 13:16:22 +00:00
moneromooo-monero
0478ac6848
blockchain: allow marking "tx not found" without an exception 
This is a normal occurence in many cases, and there is no need
to spam the log with those when it is.
 2017-01-07 20:52:17 +00:00
moneromooo-monero
1607cb7e0c
tx_pool: better block template filling algorithm 
Continue filling until we reach the block size limit, or the
resulting coinbase decreases.

Also remove old sanity check on block size, which is now not
wanted anymore.
 2017-01-07 12:36:22 +00:00
moneromooo-monero
9731b4e54f
rpc: add block size to GET_BLOCK_HEADER RPC 
and print it in print_bc
 2017-01-06 19:38:27 +00:00
moneromooo-monero
9188b3468c
rpc: add current block size to the getinfo call 2017-01-06 19:30:10 +00:00
MoroccanMalinois
80abc3bc4a Build wallet with Android NDK 2017-01-05 01:11:05 +00:00
kenshi84
ada7c7da8f portable serializer: tests added 2017-01-03 09:14:48 +09:00
kenshi84
f390a0e2dc portable serializer: make signerd/unsigned tx portable, ignore archive version checking 2017-01-02 20:04:58 +09:00
moneromooo-monero
21c5af5a8a
wallet2_api: add an address book payment id lookup API 2017-01-01 16:06:34 +00:00
Jaquee
29333c417e
wallet api: prevent setting refresh height too high 2016-12-27 19:38:05 +01:00
Jaquee
4585ada453
Wallet2: faster exit while refreshing 2016-12-27 19:12:18 +01:00
moneromooo-monero
cebae0c510
wallet2: check the node returned the real output when requested 2016-12-27 09:38:10 +00:00
kenshi84
5f4ac6b909 wallet2 bugfix: store watch_only flag properly with rewrite() 2016-12-26 18:33:24 +09:00
kenshi84
adee16440a wallet cli: print unspent outputs with histogram 2016-12-26 16:03:16 +09:00
kenshi84
542571f5cb simplewallet: remove unnecessary local_args.erase(...) in set_variable() 2016-12-26 08:50:37 +09:00
moneromooo-monero
591d83686e
core: invalidate difficulty cache when resetting blockchain 2016-12-25 20:38:11 +00:00
moneromooo-monero
c0a0fcaff0
wallet2_api: some new APIs to access daemon state 2016-12-25 12:31:50 +00:00
moneromooo-monero
37ed96e611
tx_pool: fix uninitialized "last failed" fields 2016-12-24 19:42:35 +00:00
moneromooo-monero
94b6feef24
rpc: fix mixup in tx_info serialization 2016-12-24 18:08:48 +00:00
moneromooo-monero
505116771e
wallet2: fix large reorgs failing 
If a reorg was large enough that a full 1000 block chunk
from the daemon was all known blocks, refresh would stop,
and no reorg would happen.
 2016-12-24 16:04:37 +00:00
fireice-uk
474c249c90 cleaner log calc algorithm 2016-12-22 20:29:41 +00:00
luigi1111
374762654e
add tx hash to time stats 
Also miner tx hash to log level 1 (have you ever tried to find a testnet miner tx hash?)
 2016-12-21 19:20:49 -06:00
kenshi84
99580adf66 make openalias also available for solo miner; introduce namespace tools::dns_utils; support integrated address with dns lookup 2016-12-21 23:12:15 +09:00
moneromooo-monero
12abe86ac0
core: fix recalculation of emission/fees 
It was counting things many, many times
 2016-12-21 11:19:04 +00:00
kenshi84
38f00d07f7 wallet cli: viewing and editing address book 2016-12-21 19:27:18 +09:00
Riccardo Spagni
4fe5c351cd
Merge pull request #1479 
c31e42e2 simplewallet: bump output file format version (moneromooo-monero)
 2016-12-20 23:01:39 +02:00
moneromooo-monero
c31e42e2bb
simplewallet: bump output file format version 
The serialization format changed, and while there is code
to load the older serialization format, an older monerod
will not be able to load a file saved by a new monerod,
even though both share the same version. This is not good,
and we prefer a version bump.
 2016-12-20 19:02:51 +00:00
moneromooo-monero
1976eddd89
common: add missing #include <system_error> for std::error_code 2016-12-20 18:53:58 +00:00
Riccardo Spagni
9777de1890
Merge pull request #1474 
fc40b3e7 Lower connection timeout in check_connection() (Jaquee)
 2016-12-20 17:47:58 +02:00
Riccardo Spagni
e170cbe013
Merge pull request #1473 
e3639f5c Removed unused functions (Lee Clagett)
 2016-12-20 17:47:16 +02:00
Riccardo Spagni
6847999fb8
Merge pull request #1472 
2bddb8eb Refactored password prompting for wallets (Lee Clagett)
 2016-12-20 17:46:58 +02:00
Riccardo Spagni
dca146f823
Merge pull request #1469 
9e4b3724 simplewallet: add pending/pool/failed in the show_transfers help (moneromooo-monero)
 2016-12-20 17:45:47 +02:00
Riccardo Spagni
233ba51ad9
Merge pull request #1468 
9a2cd722 wallet2_api: add an API to the OpenAlias resolver (moneromooo-monero)
 2016-12-20 17:45:13 +02:00
Riccardo Spagni
f5176cb6e8
Merge pull request #1467 
55fa0479 rpc: new function and RPC to get alternative chain info (moneromooo-monero)
 2016-12-20 17:44:47 +02:00
Riccardo Spagni
1551ce98f2
Merge pull request #1466 
c367d7df README: add note about the donate command (anonimal)
b9a28677 simplewallet: add return type for donate function (anonimal)
d36669fd simplewallet: hardcode Monero's donation address (anonimal)
 2016-12-20 17:43:38 +02:00
Riccardo Spagni
b9b9028e50
Merge pull request #1462 
07b9138c support importing unportable outputs (kenshi84)
2ac80075 also use portable serializer for boost_serialization_helper.h and net_node.inl, completely adandon boost/archive/binary_oarchive.hpp (kenshi84)
d1d6e27a moved boost cpp into hpp since they're supposed to be header only (kenshi84)
66e6af89 added experimental boost::archive::portable_binary_{i|o}archive (kenshi84)
 2016-12-20 17:40:11 +02:00
kenshi84
07b9138cad support importing unportable outputs 2016-12-20 13:26:39 +09:00
kenshi84
2ac8007544 also use portable serializer for boost_serialization_helper.h and net_node.inl, completely adandon boost/archive/binary_oarchive.hpp 2016-12-20 13:04:19 +09:00
kenshi84
d1d6e27ab6 moved boost cpp into hpp since they're supposed to be header only 2016-12-20 12:27:23 +09:00
Lee Clagett
2bddb8ebee Refactored password prompting for wallets 2016-12-19 20:00:43 -05:00
Jaquee
fc40b3e732
Lower connection timeout in check_connection() 2016-12-19 21:19:02 +01:00
Lee Clagett
e3639f5cc3 Removed unused functions 2016-12-19 14:47:26 -05:00
moneromooo-monero
9e4b3724c7
simplewallet: add pending/pool/failed in the show_transfers help 
reported by nioc
 2016-12-17 19:51:09 +00:00
moneromooo-monero
9a2cd72257
wallet2_api: add an API to the OpenAlias resolver 2016-12-17 13:05:17 +00:00
moneromooo-monero
55fa0479a0
rpc: new function and RPC to get alternative chain info 2016-12-17 11:28:49 +00:00
Lee Clagett
427054c3d5 Enabled HTTP auth support for monero-wallet-rpc 2016-12-16 23:59:46 -05:00
anonimal
b9a28677e2
simplewallet: add return type for donate function 
Resolves -Wreturn-type

References #1447 #1451
 2016-12-17 03:37:20 +00:00
anonimal
d36669fd75
simplewallet: hardcode Monero's donation address 
Closes #1447
References #1451
 2016-12-17 02:52:09 +00:00
kenshi84
66e6af89ce added experimental boost::archive::portable_binary_{i|o}archive 2016-12-16 23:46:24 +09:00
Riccardo Spagni
29735c8f8f
Merge pull request #1459 
b00da61e Preliminary support for DragonFly BSD (Antonio Huete Jimenez)
 2016-12-15 14:36:35 +02:00
Riccardo Spagni
73e50749e2
Merge pull request #1455 
4bb0bff2 AddressBook: use unsigned type for row ID's (anonimal)
 2016-12-15 14:35:47 +02:00
Riccardo Spagni
c6f26ecae2
Merge pull request #1449 
374b58d1 fix MGs json (moneroexamples)
 2016-12-15 14:29:40 +02:00
Riccardo Spagni
00898fe750
Merge pull request #1452 
944b6079 Wallet API: Do not refresh while daemon is syncing + fixed fast refresh when creating wallet offline + improved close wallet logic (make sure refresh thread is stopped) (Jaquee)
 2016-12-15 14:28:15 +02:00
Riccardo Spagni
5f5cfdfa77
Merge pull request #1451 
2506d51d wallet cli: donate command (Kenshi Takayama)
 2016-12-15 14:27:02 +02:00
Riccardo Spagni
aa47ea41a7
Merge pull request #1444 
bdc3d749 Adding HTTP Digest Auth (but not yet enabled) (Lee Clagett)
 2016-12-15 14:25:49 +02:00
Jaquee
944b6079d9
Wallet API: Do not refresh while daemon is syncing 
+ fixed fast refresh when creating wallet offline
+ improved close wallet logic (make sure refresh thread is stopped)
 2016-12-15 12:31:09 +01:00
Antonio Huete Jimenez
b00da61eab Preliminary support for DragonFly BSD 
- It builds but no further testing has been done.
 2016-12-15 02:27:53 -08:00
Kenshi Takayama
2506d51d60 wallet cli: donate command 2016-12-15 19:01:36 +09:00
anonimal
4bb0bff233
AddressBook: use unsigned type for row ID's 
Fixes build warnings and may also prevent future headaches.
 2016-12-14 21:37:49 +00:00
moneroexamples
374b58d131 fix MGs json 2016-12-14 09:27:37 +08:00
Riccardo Spagni
b97a2f72db
Merge pull request #1445 
95b9e85e rename cn_deserialize (Riccardo Spagni)
 2016-12-13 19:14:00 +02:00
Riccardo Spagni
183d3657f3
Merge pull request #1446 
b2adfa8c Bitmonero namespace renamed Monero. Bitmonero namespace alias added so that third party uses of the wallet api can transition. (Randi Joseph)
 2016-12-13 19:13:09 +02:00
Randi Joseph
b2adfa8c51 Bitmonero namespace renamed Monero. Bitmonero namespace alias added so that third party uses of the wallet api can transition. 2016-12-13 10:21:38 -05:00
Riccardo Spagni
95b9e85e2d
rename cn_deserialize 2016-12-13 16:39:43 +02:00
Riccardo Spagni
b1bdb4e529
Merge pull request #1437 
655eafd1 bump version (Riccardo Spagni)
117194a3 update checkpoints (Riccardo Spagni)
39a9db9e update checkpoints (Riccardo Spagni)
 2016-12-13 16:36:43 +02:00
Riccardo Spagni
2f2c6460ae
Merge pull request #1442 
dd144b14 blockchain: fix reorganizations past a hard fork boundary (moneromooo-monero)
 2016-12-13 10:24:25 +02:00
Riccardo Spagni
c03da2b2dd
Merge pull request #1441 
0fb5dc87 monero-wallet-cli wording changes 'n' stuff (luigi1111)
 2016-12-13 10:23:49 +02:00
Riccardo Spagni
c2a9229310
Merge pull request #1439 
4299bdf6 Improve language of 'node ahead by' message (NanoAkron)
 2016-12-13 10:23:22 +02:00
Lee Clagett
bdc3d7496f Adding HTTP Digest Auth (but not yet enabled) 2016-12-13 00:19:54 -05:00
moneromooo-monero
dd144b14bc
blockchain: fix reorganizations past a hard fork boundary 
After popping blocks from the old chain, the hard fork object's
notion of the current version was not in line with the new height,
causing the first blocks from the new chain to be rejected due
to a false expection of a newer version.
 2016-12-13 02:13:23 +00:00
luigi1111
0fb5dc870d
monero-wallet-cli wording changes 'n' stuff 
Possibly other pedantry. Pedants are people too.
 2016-12-12 19:53:28 -06:00
NanoAkron
4299bdf614
Improve language of 'node ahead by' message 2016-12-12 23:24:40 +00:00
luigi1111
9d906159c3
Tx verification failing is not an error 
And rangeProofs are on outputs...
 2016-12-12 17:01:20 -06:00
Riccardo Spagni
655eafd160
bump version 2016-12-13 00:29:29 +02:00
Riccardo Spagni
117194a397
update checkpoints 2016-12-13 00:26:25 +02:00
Riccardo Spagni
39a9db9eb1
update checkpoints 2016-12-13 00:24:48 +02:00
Jaquee
3b4539ee7e
addressbook updates 2016-12-12 21:50:50 +01:00
Riccardo Spagni
5b7f1fc8e4
Merge pull request #1424 
aeb13289 Update cryptonote_protocol_handler.inl (Gingeropolous)
 2016-12-12 22:40:41 +02:00
Riccardo Spagni
aa7a926681
Merge pull request #1434 
5df92877 GUI address book (Jaquee)
 2016-12-12 22:39:38 +02:00
Riccardo Spagni
84d3107600
Merge pull request #1431 
81c6bb9a thread_group: fix build on older GCC (moneromooo-monero)
 2016-12-12 22:38:27 +02:00
Riccardo Spagni
67844f826e
Merge pull request #1425 
c5c45ca6 wallet: bring forward use of the dynamic fee (moneromooo-monero)
 2016-12-12 22:38:05 +02:00
Jaquee
5df92877c7 GUI address book 2016-12-12 00:43:02 +01:00
moneromooo-monero
81c6bb9a40
thread_group: fix build on older GCC 
vtnerd (original author) confirmed this is the Right Way.
 2016-12-11 13:59:42 +00:00
moneromooo-monero
c5c45ca660
wallet: bring forward use of the dynamic fee 
It was 14 days after v4, it is now one day after it.

luigi1111's suggestion
 2016-12-10 15:39:26 +00:00
Gingeropolous
aeb13289bb Update cryptonote_protocol_handler.inl 
Per discussion of #1359, the wording has changed to indicate that no assessment of the blocks validity is made.
 2016-12-10 10:22:16 -05:00
moneromooo-monero
19585d4914
mnemonics: fix misc STL containers leak 
found by coverity
 2016-12-10 12:51:36 +00:00
moneromooo-monero
f6fcf0ef26
oaes_lib: fix a leak on OOM error path 
found by coverity
 2016-12-10 12:51:20 +00:00
Riccardo Spagni
2d0fbaf35b
Merge pull request #1422 
9b00d80f wallet2: pass by const ref where possible (moneromooo-monero)
 2016-12-10 14:49:34 +02:00
Riccardo Spagni
930aceb242
Merge pull request #1419 
f4a3ce15 Fix sending outputs from a tx with more than one pubkey (moneromooo-monero)
 2016-12-10 14:48:56 +02:00
Riccardo Spagni
0f99423080
Merge pull request #1418 
dfbb85b6 blockchain: fix setting non trovial alternate chain as invalid (moneromooo-monero)
 2016-12-10 14:48:39 +02:00
moneromooo-monero
9b00d80f85
wallet2: pass by const ref where possible 
Reported by kenshi84
 2016-12-10 11:43:44 +00:00
moneromooo-monero
f4a3ce15c1
Fix sending outputs from a tx with more than one pubkey 
A bug in cold signing caused a spurious pubkey to be included
in transactions, so we need to ensure we use the correct one
when sending outputs from one of those.
 2016-12-09 18:21:21 +00:00
moneromooo-monero
dfbb85b6fe
blockchain: fix setting non trovial alternate chain as invalid 
The wrong iterator was being used.
Also preincrement iterators to avoid possibly invalidating them,
I'm not sure this is necessary, but let's be safe.
 2016-12-08 22:26:27 +00:00
Riccardo Spagni
12b59460c2
Merge pull request #1417 
0b91d825 simplewallet: restore automatically setting trusted local daemon (moneromooo-monero)
 2016-12-08 23:45:04 +02:00
Riccardo Spagni
8e1a8c6adc
Merge pull request #1415 
6c44f5c6 wallet: send 0 change to a random address where necessary with rct (moneromooo-monero)
 2016-12-08 23:44:40 +02:00
Riccardo Spagni
e6b05ed95a
Merge pull request #1414 
3b005275 ringct: add sc_check calls in MLSAG_Ver for ss and cc (moneromooo-monero)
2f1732a7 ringct: guard against bad data exceptions in worker threads (moneromooo-monero)
 2016-12-08 23:44:09 +02:00
Riccardo Spagni
22e16e88e3
Merge pull request #1413 
648ea6be blockchain: bring the v4 fork height one block forward (luigi1111)
46a0dcc1 ringct: luigi1111's changes to fix and speedup Borromean sigs (luigi1111)
76958fc7 ringct: switch to Borromean signatures (Shen Noether)
 2016-12-08 23:43:41 +02:00
Riccardo Spagni
f9503d2789
Merge pull request #1405 
d1a75754 Remove infinite loop in refresh code (Jaquee)
 2016-12-08 23:43:19 +02:00
moneromooo-monero
0b91d82574
simplewallet: restore automatically setting trusted local daemon 2016-12-08 20:01:24 +00:00
moneromooo-monero
3b00527500
ringct: add sc_check calls in MLSAG_Ver for ss and cc 
luigi1111's recommendation
 2016-12-07 22:41:21 +00:00
moneromooo-monero
2f1732a7e5
ringct: guard against bad data exceptions in worker threads 
If purported pubkeys aren't actually valid pubkeys, exceptions
will fly. These will terminate if thrown in a worker thread.
Guard against this.
 2016-12-07 22:09:43 +00:00
moneromooo-monero
6c44f5c6eb
wallet: send 0 change to a random address where necessary with rct 
If a rct transaction would cause no change to be generated, a zero
change output is added, and sent to a randomly generated address.
This ensures that no transaction will be sent with just one output,
which could cause the receiver to be able to determine which of the
inputs in the sent rings is the real one.
This is very rare, since it requires the sum of outputs to be equal
to the sum of outputs plus the fee, which is now a function of the
last few blocks.
 2016-12-07 21:05:50 +00:00
luigi1111
648ea6bef1
blockchain: bring the v4 fork height one block forward 
This will ensure the early 0.10 daemons will barf at the fork
height, and not a bit later, which could be confusing.
 2016-12-06 21:59:08 +00:00
Lee Clagett
18462aa065 Added confirmation before binding wallet-rpc to external IP 2016-12-05 21:45:11 -05:00
Jaquee
d1a75754df
Remove infinite loop in refresh code 
This reverts commit fd181b03bb.
 2016-12-05 13:02:45 +01:00
luigi1111
46a0dcc1d2
ringct: luigi1111's changes to fix and speedup Borromean sigs 2016-12-04 21:54:16 +00:00
Shen Noether
76958fc75a
ringct: switch to Borromean signatures 2016-12-04 21:54:11 +00:00
Riccardo Spagni
b500a64524
Merge pull request #1399 
73ac3b8e wallet2: avoid possible undefined behavior on empty string (moneromooo-monero)
 2016-12-04 22:28:48 +02:00
Riccardo Spagni
f2ea2afb77
Merge pull request #1398 
f4772bae Fix a few minor typos (Pierre Boyer)
 2016-12-04 22:28:22 +02:00
Riccardo Spagni
8086379680
Merge pull request #1397 
3f7d6fb5 Fix delayed exit when syncing (moneromooo-monero)
 2016-12-04 22:27:41 +02:00
Riccardo Spagni
4a0be41dfe
Merge pull request #1396 
7c0dd5e4 net_node: drop connections from banned IPs after looping through connections (moneromooo-monero)
 2016-12-04 22:26:12 +02:00
Riccardo Spagni
d59dc59744
Merge pull request #1395 
59443bf9 ringct: fix MGs serialization to JSON (moneromooo-monero)
 2016-12-04 22:25:24 +02:00
Riccardo Spagni
daf5dbebb0
Merge pull request #1393 
0e18f465 db_lmdb: add info in an error message when we can't get an output (moneromooo-monero)
c96f9b02 db_lmdb: guard against going out of sync on unexpected db results (moneromooo-monero)
bef51e67 db_lmdb: minor pedantic tweaks (moneromooo-monero)
3465c4eb db_lmdb: set same packing format for output_data_t and pre_rct_output_data_t (moneromooo-monero)
 2016-12-04 22:23:34 +02:00
Riccardo Spagni
416f7fbd5f
Merge pull request #1392 
204b1bff blockchain: use high bound block reward on error where appropriate (moneromooo-monero)
 2016-12-04 22:23:03 +02:00
Riccardo Spagni
98150be7d8
Merge pull request #1389 
4adde042 p2p: possibly fix crash in relay_blocks (moneromooo-monero)
 2016-12-04 22:22:07 +02:00
Riccardo Spagni
977dd9b76c
Merge pull request #1385 
5783dd8c tests: add unit tests for uri parsing (moneromooo-monero)
82ba2108 wallet: add API and RPC to create/parse monero: URIs (moneromooo-monero)
d9001b43 epee: add functions to convert from URL format (ie, %XX values) (moneromooo-monero)
 2016-12-04 22:19:06 +02:00
Riccardo Spagni
836c748366
Merge pull request #1388 
fcd178ef wallet_api: add a few daemon related getters (moneromooo-monero)
 2016-12-04 22:17:48 +02:00
Riccardo Spagni
2fd43e25ee
Merge pull request #1386 
8f6ec90c blockchain: reject invalid pubkeys from v4 (moneromooo-monero)
 2016-12-04 22:15:36 +02:00
Riccardo Spagni
42d07e865f
Merge pull request #1383 
00592189 change 'invalid address format' loglevel (Jaquee)
 2016-12-04 22:02:58 +02:00
Riccardo Spagni
3d533d1037
Merge pull request #1380 
657a70e0 wallet: add a getter for the filename path (moneromooo-monero)
 2016-12-04 22:02:40 +02:00
Riccardo Spagni
fe89782512
Merge pull request #1379 
d6086f5b Improve daemon RPC version handling (moneromooo-monero)
 2016-12-04 22:01:49 +02:00
moneromooo-monero
73ac3b8e26
wallet2: avoid possible undefined behavior on empty string 2016-12-04 14:56:06 +00:00
Pierre Boyer
f4772bae81 Fix a few minor typos 2016-12-04 14:13:54 +01:00
moneromooo-monero
3f7d6fb57d
Fix delayed exit when syncing 2016-12-04 12:27:45 +00:00
moneromooo-monero
7c0dd5e46c
net_node: drop connections from banned IPs after looping through connections 
This keeps the connections lock just for the time of looping
and adding connectoins to a list, and the dropping happens
after it. This should avoid lengthy delays waiting for the
connections lock.
 2016-12-03 11:20:48 +00:00
moneromooo-monero
59443bf9df
ringct: fix MGs serialization to JSON 2016-12-02 13:16:19 +00:00
moneromooo-monero
4adde0423b
p2p: possibly fix crash in relay_blocks 2016-12-01 23:52:16 +00:00
moneromooo-monero
204b1bff62
blockchain: use high bound block reward on error where appropriate 
If the block reward to use for the fee calculation can't be
calculated (should not happen in practice), use a high bound,
so we use a fee overestimate that will be accepted by the network.
 2016-12-01 16:34:09 +00:00
moneromooo-monero
0e18f46522
db_lmdb: add info in an error message when we can't get an output 
Will be useful to debug
 2016-12-01 14:31:40 +00:00
moneromooo-monero
c96f9b0255
db_lmdb: guard against going out of sync on unexpected db results 
m_num_outputs keeps track of the number of outputs, which should
be the same as the size of both the output_txs and output_amounts
databases. If one goes out of sync, we need to throw to abort
whatever it is we were doing.
 2016-12-01 14:29:35 +00:00
moneromooo-monero
bef51e677e
db_lmdb: minor pedantic tweaks 
Add consts in a few places where it makes sense, avoid unnecessary
memory reallocation where we know the full size needed at the outset,
simplify and avoid memory copy.
 2016-12-01 14:28:09 +00:00
moneromooo-monero
3465c4ebc7
db_lmdb: set same packing format for output_data_t and pre_rct_output_data_t 
For safety, though it seems to have been the case already.

Also add a comment about the necessary layout identity.
 2016-12-01 14:26:18 +00:00
moneromooo-monero
fcd178ef33
wallet_api: add a few daemon related getters 
Blockchain height, version, Mining hash rate...
 2016-11-29 10:54:38 +00:00
moneromooo-monero
8f6ec90c83
blockchain: reject invalid pubkeys from v4 2016-11-28 22:32:58 +00:00
moneromooo-monero
82ba2108e9
wallet: add API and RPC to create/parse monero: URIs 2016-11-28 17:54:22 +00:00
Jaquee
0059218908
change 'invalid address format' loglevel 2016-11-27 14:44:19 +01:00
moneromooo-monero
657a70e004
wallet: add a getter for the filename path 2016-11-26 14:19:57 +00:00
moneromooo-monero
d6086f5b4e
Improve daemon RPC version handling 
Daemon RPC version is now composed of a major and minor number,
so that incompatible changes bump the major version, while
compatible changes can still bump the minor version without
causing clients to unnecessarily complain.
 2016-11-26 12:56:44 +00:00
Lee Clagett
91ffb61c25 Added command_line::is_yes 2016-11-25 21:57:27 -05:00
Riccardo Spagni
c36cb54340
Merge pull request #1372 
17b6bd6 Fix DNS failures in offline mode preventing daemon startup (moneromooo-monero)
 2016-11-24 13:01:35 +02:00
Riccardo Spagni
2497a2d547
Merge pull request #1369 
6d76072 simplewallet: remove double confirmation when submitting signed tx (moneromooo-monero)
92dea04 wallet2: fix wrong change being recorded for cold signed txes (moneromooo-monero)
 2016-11-24 13:00:32 +02:00
Riccardo Spagni
ce8a2315cf
Merge pull request #1364 
f025198 Added task_region - a fork/join task implementation (Lee Clagett)
 2016-11-24 12:58:09 +02:00
Riccardo Spagni
3fa1b6623a
Merge pull request #1361 
1d9e223 rpc: do not include output indices for pool txes (moneromooo-monero)
e227d6e rpc: bump version after RPC changes (moneromooo-monero)
2c0173c Add a get_outs (fully text based) version of get_outs.bin (moneromooo-monero)
e05907b rpc: add output indices to gettransactions (moneromooo-monero)
 2016-11-24 12:57:00 +02:00
Riccardo Spagni
a26b27f66e
Merge pull request #1358 
7abfc54 wallet: fix exporting outputs and key images with txes with two pubkeys (moneromooo-monero)
 2016-11-24 12:55:14 +02:00
Riccardo Spagni
25369df4d8
Merge pull request #1357 
5fc36f9 wallet2_api: fix history leak on destruction (moneromooo-monero)
 2016-11-24 12:54:25 +02:00
Riccardo Spagni
f801dc8567
Merge pull request #1356 
69b188c wallet2_api: fix payment ids from integrated addresses being ignored (moneromooo-monero)
 2016-11-24 12:53:59 +02:00
Riccardo Spagni
570acdc686
Merge pull request #1352 
d01f5c7 wallet2: fix illegal memory access removing newlines from password (moneromooo-monero)
 2016-11-24 12:53:14 +02:00
Riccardo Spagni
2121f3b2f0
Merge pull request #1351 
e6264a2 wallet2: fix decrypting a bit too much in authenticated mode (moneromooo-monero)
 2016-11-24 12:52:54 +02:00
moneromooo-monero
17b6bd6d35
Fix DNS failures in offline mode preventing daemon startup 2016-11-23 23:14:49 +00:00
moneromooo-monero
6d76072612
simplewallet: remove double confirmation when submitting signed tx 2016-11-23 20:45:03 +00:00
moneromooo-monero
92dea04929
wallet2: fix wrong change being recorded for cold signed txes 2016-11-23 20:27:22 +00:00
Lee Clagett
f025198f19 Added task_region - a fork/join task implementation 2016-11-23 14:41:25 -05:00
moneromooo-monero
1d9e223944
rpc: do not include output indices for pool txes 
Those aren't yet in the blockchain, so will not be found
(and aren't yet known, since it depends on where exactly the
tx will be mined in the next block or blocks)
 2016-11-23 18:56:54 +00:00
moneromooo-monero
e227d6e7ac
rpc: bump version after RPC changes 2016-11-22 20:01:20 +00:00
moneromooo-monero
2c0173c722
Add a get_outs (fully text based) version of get_outs.bin 2016-11-22 20:00:40 +00:00
moneromooo-monero
e05907b3e7
rpc: add output indices to gettransactions 
Someone apparently needs that to make a wallet but never asked.
If you read that and that's not what you wanted, the bugtracker
is at https://github.com/monero-project/monero/issues
 2016-11-22 20:00:23 +00:00
moneromooo-monero
7abfc5474c
wallet: fix exporting outputs and key images with txes with two pubkeys 
This also needs to make sure to pick the correct one, in the case
where cold signing caused to tx keys to be included.
 2016-11-19 09:36:40 +00:00
moneromooo-monero
5fc36f981c
wallet2_api: fix history leak on destruction 2016-11-18 21:42:08 +00:00
moneromooo-monero
69b188c4b2
wallet2_api: fix payment ids from integrated addresses being ignored 2016-11-18 19:13:43 +00:00
Dion Ahmetaj
fd181b03bb Clamp refresh from height to blockchain height. 2016-11-18 13:40:55 -05:00
moneromooo-monero
d01f5c7f1f
wallet2: fix illegal memory access removing newlines from password 2016-11-17 20:43:58 +00:00
moneromooo-monero
e6264a2c35
wallet2: fix decrypting a bit too much in authenticated mode 2016-11-17 20:31:00 +00:00
Riccardo Spagni
dbf2ab56c5
Merge pull request #1346 
4eb7347 wallet: return fee in transfer RPC (moneromooo-monero)
 2016-11-17 16:40:37 +02:00
Riccardo Spagni
5df6f0be80
Merge pull request #1318 
4fca34d Wallet2: calculate approximate blockchain height on offline creation (Jacob Brydolf)
 2016-11-17 16:37:30 +02:00
Riccardo Spagni
2988e1be8c
Merge pull request #1344 
a0131c8 wallet: auto sync outputs and key images in cold signing files (moneromooo-monero)
f806611 wallet2: fill key image and pubkey maps when importing outputs (moneromooo-monero)
5fe363c wallet: cast indices to string in logs to be nice to CLANG (moneromooo-monero)
11ae187 wallet2: try all tx keys when scanning a new transaction (moneromooo-monero)
072d646 wallet2: fill in key image map when importing key images (moneromooo-monero)
23d80b1 core: remove any tx pubkey from extra before adding one (moneromooo-monero)
d72376d simplewallet: add a verbose flag to incoming_transfers (moneromooo-monero)
47413a5 simplewallet: spell out change when signing a transfer (moneromooo-monero)
14cb088 simplewallet: print public keys too on spendkey/viewkey commands (moneromooo-monero)
a99ab49 wallet: fix serialization of new m_key_image_known member (moneromooo-monero)
 2016-11-17 16:36:12 +02:00
Riccardo Spagni
b7b54b6cff
Merge pull request #1336 
bd4da18 simplewallet: include amount sent in transfer confirmation (moneromooo-monero)
 2016-11-17 16:26:49 +02:00
moneromooo-monero
4eb7347fdd
wallet: return fee in transfer RPC 2016-11-16 18:56:45 +00:00
moneromooo-monero
a0131c8be3
wallet: auto sync outputs and key images in cold signing files 
When passing around unsigned and signed transactions, outputs
and key images are passed along (outputs are passed along unsigned
transactions from the hot wallet to the cold wallet, key images
are passed along with signed transations from the cold wallet
to the hot wallet), to allow more user friendly syncing between
hot and cold wallets.
 2016-11-16 09:22:24 +00:00
moneromooo-monero
f8066116dd
wallet2: fill key image and pubkey maps when importing outputs 2016-11-16 09:22:18 +00:00
moneromooo-monero
5fe363cd22
wallet: cast indices to string in logs to be nice to CLANG 2016-11-16 09:22:13 +00:00
moneromooo-monero
11ae1873f8
wallet2: try all tx keys when scanning a new transaction 
The vast majority of transactions will have just one tx pubkey,
but a bug with cold wallet signing caused two such keys to be
there, with the second one being the real one.
 2016-11-16 09:22:05 +00:00
moneromooo-monero
072d646a45
wallet2: fill in key image map when importing key images 2016-11-15 21:20:08 +00:00
moneromooo-monero
23d80b15fd
core: remove any tx pubkey from extra before adding one 
This will happen when signing a transaction from a cold wallet,
and we don't want the placeholder the hot wallet put in it.
 2016-11-15 21:20:02 +00:00
moneromooo-monero
d72376d467
simplewallet: add a verbose flag to incoming_transfers 
Prints pubkey and key image as well
 2016-11-13 18:20:46 +00:00
moneromooo-monero
47413a5626
simplewallet: spell out change when signing a transfer 
Also catch change to multiple addresses, this is unexpected
 2016-11-13 17:48:45 +00:00
moneromooo-monero
14cb088300
simplewallet: print public keys too on spendkey/viewkey commands 2016-11-13 17:24:53 +00:00
moneromooo-monero
a99ab49dd5
wallet: fix serialization of new m_key_image_known member 2016-11-13 16:38:29 +00:00
moneromooo-monero
bd4da18525
simplewallet: include amount sent in transfer confirmation 2016-11-13 12:12:22 +00:00
moneromooo-monero
d48f2e9bc6
wallet: fix serialization of new m_key_image_known member 2016-11-13 12:02:29 +00:00
Riccardo Spagni
9363b2ac19
Merge pull request #1334 
265e460 Fixed generate-from-json bug introduced in 358e068 (Lee Clagett)
 2016-11-13 11:32:43 +02:00
Lee Clagett
265e4605ec Fixed generate-from-json bug introduced in 358e068 2016-11-12 21:55:08 -05:00
Jacob Brydolf
4fca34ddb4
Wallet2: calculate approximate blockchain height on offline creation 
Wallet API: add approximateBlockChainHeight()
 2016-11-13 03:36:44 +01:00
iDunk5400
e1dd15b050
Don't build monero-wallet-rpc when building the GUI 2016-11-12 19:22:19 +01:00
moneromooo-monero
70d4915980
wallet: add version dependency to the wallet target 2016-11-12 12:55:19 +00:00
Riccardo Spagni
6a2bb62827
Merge pull request #1316 
358e068 Created monero-wallet-rpc, moving functionality from monero-wallet-cli (Lee Clagett)
 2016-11-11 12:48:39 +02:00
Riccardo Spagni
524ff61ad5
Merge pull request #1321 
0e418d2 rpc: bump RPC version (moneromooo-monero)
 2016-11-11 12:38:01 +02:00
Riccardo Spagni
a3cd7230f8
Merge pull request #1315 
9150a16 Wallet API: use stored refresh height when rebuilding cache (Jacob Brydolf)
 2016-11-11 12:35:47 +02:00
Riccardo Spagni
3fd13080b7
Merge pull request #1314 
63772e4 wallet: fix corner case of no recent outputs available (moneromooo-monero)
 2016-11-11 12:35:25 +02:00
Riccardo Spagni
0e0bf432a4
Merge pull request #1313 
1669621 wallet2_api: support for sweeping all (moneromooo-monero)
 2016-11-11 12:35:04 +02:00
Riccardo Spagni
5f568533aa
Merge pull request #1263 
d61bd81 add lightweight block propagation ("fluffy blocks") (Dion Ahmetaj)
 2016-11-11 12:34:43 +02:00
moneromooo-monero
0e418d2a58
rpc: bump RPC version 
I forgot to bump it previously when changing RPC, most notably
for the addition of the unlocked field in the histogram RPC.
This causes new wallets to not realize when they're talking to
an older daemon, and get confused trying to get outputs to use
as fake outs. This otherwise gratuitous bump ensures than old
daemons will be detected by wallets using this code.
 2016-11-10 23:00:24 +00:00
Lee Clagett
358e068e87 Created monero-wallet-rpc, moving functionality from monero-wallet-cli 2016-11-10 16:39:27 -05:00
moneromooo-monero
1669621937
wallet2_api: support for sweeping all 2016-11-09 19:32:37 +00:00
Dion Ahmetaj
d61bd8187e add lightweight block propagation ("fluffy blocks") 
Added a new command to the P2P protocol definitions to allow querying for support flags.

Implemented handling of new support flags command in net_node. Changed for_each callback template to include support flags. Updated print_connections command to show peer support flags.

Added p2p constant for signaling fluffy block support.

Added get_pool_transaction function to cryptnote_core.

Added new commands to cryptonote protocol for relaying fluffy blocks.

Implemented handling of fluffy block command in cryptonote protocol.

Enabled fluffy block support in node initial configuration.

Implemented get_testnet function in cryptonote_core.

Made it so that fluffy blocks only run on testnet.
 2016-11-09 14:24:27 -05:00
Jacob Brydolf
9150a16ed1
Wallet API: use stored refresh height when rebuilding cache 2016-11-09 18:46:03 +01:00
moneromooo-monero
63772e4048
wallet: fix corner case of no recent outputs available 
Also clarify related logs
 2016-11-09 14:01:54 +00:00
Riccardo Spagni
38727f7d2f
Merge pull request #1312 
acf908c thread_group: fix build with asserts enabled (moneromooo-monero)
 2016-11-09 14:13:35 +02:00
Riccardo Spagni
7931cb19ef
Merge pull request #1311 
5c4cb96 cryptonote_protocol: drop connection when find_blockchain_supplement fails (moneromooo-monero)
 2016-11-09 14:13:06 +02:00
Riccardo Spagni
dc5e0e45cd
Merge pull request #1310 
40a68e2 wallet2_api: add API for create_unmixable_sweep_transactions (moneromooo-monero)
 2016-11-09 14:11:57 +02:00
Riccardo Spagni
56c594a8fe
Merge pull request #1309 
c441a61 wallet2_api: API to sign and verify a message (moneromooo-monero)
 2016-11-09 14:10:39 +02:00
Riccardo Spagni
06ca304b06
Merge pull request #1307 
4dcb74f wallet_api: PendingTransaction::txCount - number of split transactions (Ilya Kitaev)
 2016-11-09 14:10:12 +02:00
Riccardo Spagni
144a7f090a
Merge pull request #1305 
c80f4d4 wallet: fix output collision detection for view wallets (moneromooo-monero)
 2016-11-09 14:08:34 +02:00
moneromooo-monero
acf908c834
thread_group: fix build with asserts enabled 
See https://github.com/monero-project/monero/pull/1291
 2016-11-09 11:29:06 +00:00
moneromooo-monero
5c4cb96cfb
cryptonote_protocol: drop connection when find_blockchain_supplement fails 
This will be when we can't find common ground between the peer's
short chain history and our blockchain.

This fixes bad peers claiming a higher blockchain height from never
dropped, and keeping the node in synchronizing state forever, since
we will never get blocks from that peer.
 2016-11-09 11:04:20 +00:00
moneromooo-monero
c441a61ef6
wallet2_api: API to sign and verify a message 2016-11-08 21:21:08 +00:00
Ilya Kitaev
4dcb74f97f wallet_api: PendingTransaction::txCount - number of split transactions 2016-11-09 00:13:18 +03:00
Riccardo Spagni
e8a55db29d
Merge pull request #1308 
0c530de Wallet API: Pause refresh while creating transaction (Jacob Brydolf)
 2016-11-08 22:57:04 +02:00
Riccardo Spagni
18fdd8116e
Merge pull request #1306 
8aba0d4 wallet: encrypt outputs and key images files with the view key (moneromooo-monero)
 2016-11-08 22:55:56 +02:00
Riccardo Spagni
7c7a6cf2f8
Merge pull request #1302 
63fe6fd wallet2_api: allow connection to return "yes, but wrong version" (moneromooo-monero)
 2016-11-08 22:53:13 +02:00
Riccardo Spagni
96e0138ebf
Merge pull request #1301 
35da3cb Wallet API: added getTxKey() (Jacob Brydolf)
 2016-11-08 22:50:13 +02:00
Jacob Brydolf
35da3cb074 Wallet API: added getTxKey() 2016-11-08 21:48:26 +01:00
Riccardo Spagni
c57ce06a97
Merge pull request #1300 
eb19492 wallet2_api: do not copy the whole pending tx when iterating (moneromooo-monero)
 2016-11-08 22:48:04 +02:00
Riccardo Spagni
af2ceb29fa
Merge pull request #1298 
97288a5 wallet2_api: add API for tx notes (moneromooo-monero)
 2016-11-08 22:45:54 +02:00
Riccardo Spagni
c05cecf036
Merge pull request #1297 
af8a260 wallet_api: txkey checking functions for the GUI (moneromooo.monero)
 2016-11-08 22:44:15 +02:00
Riccardo Spagni
dce47d52af
Merge pull request #1291 
64094e5 adding thread_group for managing async tasks (Lee Clagett)
 2016-11-08 22:37:43 +02:00
Riccardo Spagni
4c44d896d3
Merge pull request #1285 
a970a4e refresh speedup (luigi1111)
 2016-11-08 22:34:26 +02:00
Riccardo Spagni
0fa6cbef3f
Merge pull request #1276 
18f66f4 wallet: use the dynamic per kB fee (moneromooo-monero)
e6deb8a rpc: add a dynamic fee estimation RPC call (moneromooo-monero)
82dbba1 core: dynamic fee algorithm from ArticMine (moneromooo-monero)
 2016-11-08 22:33:13 +02:00
moneromooo-monero
40a68e22fa
wallet2_api: add API for create_unmixable_sweep_transactions 2016-11-08 20:03:07 +00:00
Jacob Brydolf
0c530de057
Wallet API: Pause refresh while creating transaction 2016-11-08 13:20:42 +01:00
moneromooo-monero
8aba0d4b4c
wallet: encrypt outputs and key images files with the view key 
This key is available to both cold and hot wallet.
Authenticated encryption will guard against interception and/or
modification of the file.
 2016-11-07 20:01:05 +00:00
moneromooo-monero
c80f4d416d
wallet: fix output collision detection for view wallets 
View wallets do not have the spend secret key, and are thus
unable to derive key images for incoming outputs. Moreover,
a previous patch set key images to zero as a means to mark
an output as having an unknown key image, so they could be
filled in when importing key images at a later time. That
later patch caused spurious collisions. We now use public
keys to detect duplicate outputs. Public keys obtained from
the blockchain are checked to be identical to the ones
derived locally, so can't be spoofed.
 2016-11-07 18:59:30 +00:00
moneromooo-monero
63fe6fd9ba
wallet2_api: allow connection to return "yes, but wrong version" 2016-11-07 12:00:29 +00:00
moneromooo-monero
eb194925ec
wallet2_api: do not copy the whole pending tx when iterating 2016-11-06 10:36:08 +00:00
moneromooo-monero
97288a5ce2
wallet2_api: add API for tx notes 2016-11-05 21:19:08 +00:00
moneromooo.monero
af8a2600aa
wallet_api: txkey checking functions for the GUI 2016-11-05 15:24:05 +00:00
Lee Clagett
64094e5f4e adding thread_group for managing async tasks 2016-11-02 19:21:55 -04:00
moneromooo-monero
b5d6faada3
wallet: fix bad amounts/fees again 
m_amount_out was sometimes getting initialized with the sum of
an transaction's outputs, and sometimes with the sum of outputs
that were not change. This caused confusion and bugs. We now
always set it to the sum of outputs. This reverts an earlier
fix for bad amounts as this used the other semantics. The wallet
data should be converted automatically in a percentage of cases
that I'm hesitant to estimate. In any case, restoring from seed
or keys or rebuilding the cache will get it right.
 2016-11-02 23:11:30 +00:00
Riccardo Spagni
d51f1af75f
Merge pull request #1272 
48b57d8 monero.supp: valgrind suppressions file (moneromooo-monero)
ffd8c41 ringct: check the size of amount_keys is the same as destinations (moneromooo-monero)
836669d ringct: always shutdown the boost io service (moneromooo-monero)
 2016-11-01 21:49:30 +02:00
luigi1111
a970a4e3cf
refresh speedup 
Compute derivation only once per tx, instead of once per output. Approx 33% faster while using 75% as much CPU on my machine. Note old functions in cryptonote_core (lookup_acc_outs and is_out_to_acc) are still used by tests.
 2016-11-01 11:24:04 -05:00
Riccardo Spagni
b06c1abaa6
Merge pull request #1278 
43ec2d0 Wallet API: added walletExists logic (Jacob Brydolf)
 2016-11-01 15:29:44 +02:00
Riccardo Spagni
6f85b20d92
Merge pull request #1283 
4869db7 adding static_assert to pod functions in string tools (Lee Clagett)
 2016-11-01 15:13:10 +02:00
Riccardo Spagni
f189fe51ac
Merge pull request #1282 
f5ccfa4 core: fix removal of extra nonce using wrong type (moneromooo-monero)
3c2cad2 Revert "remove cn_deserialize" (moneromooo-monero)
 2016-11-01 15:12:30 +02:00
Riccardo Spagni
d53bc2eddf
Merge pull request #1281 
bb560dd wallet: new import_outputs/export_outputs commands (moneromooo-monero)
 2016-11-01 15:12:03 +02:00
Riccardo Spagni
95e0010fbb
Merge pull request #1277 
7e6d3cf wallet: set incoming outputs' key image to 0 on view wallets (moneromooo-monero)
1f9e6a4 wallet: print tx overview on submit_transfer too (moneromooo-monero)
 2016-11-01 15:06:51 +02:00
Riccardo Spagni
77284c026f
Merge pull request #1275 
4bfb81a simplewallet: remove destinations with zero amount in sign_transfer (moneromooo-monero)
 2016-11-01 15:03:08 +02:00
Lee Clagett
4869db702a adding static_assert to pod functions in string tools 2016-10-31 13:22:21 -04:00
moneromooo-monero
18f66f44ef
wallet: use the dynamic per kB fee 2016-10-31 08:38:06 +00:00
moneromooo-monero
e6deb8abda
rpc: add a dynamic fee estimation RPC call 2016-10-31 08:38:00 +00:00
moneromooo-monero
82dbba10d4
core: dynamic fee algorithm from ArticMine 
The fee will vary based on the base reward and the current
block size limit:

fee = (R/R0) * (M0/M) * F0

R: base reward
R0: reference base reward (10 monero)
M: block size limit
M0: minimum block size limit (60000)
F0: 0.002 monero

Starts applying at v4
 2016-10-31 08:37:08 +00:00
moneromooo-monero
f5ccfa4001
core: fix removal of extra nonce using wrong type 2016-10-30 20:44:45 +00:00
moneromooo-monero
3c2cad2d46
Revert "remove cn_deserialize" 
This is useful (to me).

This reverts commit f968ccb9d3.
 2016-10-30 20:34:48 +00:00
moneromooo-monero
bb560dd814
wallet: new import_outputs/export_outputs commands 
The intended use is to export outputs from a hot wallet, which
can scan incoming transfers from the network, and import them
in the cold wallet, which can't. The cold wallet can then compute
key images for those outputs, which can then be exported with
export_key_images, etc.
 2016-10-30 19:37:09 +00:00
Jacob Brydolf
43ec2d002a
Wallet API: added walletExists logic 2016-10-30 15:34:50 +01:00
moneromooo-monero
7e6d3cf441
wallet: set incoming outputs' key image to 0 on view wallets 
This allows rescan_spent to know the daemon response to those
is not valid.
 2016-10-30 12:14:33 +00:00
moneromooo-monero
1f9e6a46d8
wallet: print tx overview on submit_transfer too 
This is on the potentially compromised wallet, but still guards
against stupid mistakes.
 2016-10-30 10:49:22 +00:00
moneromooo-monero
4bfb81a7f5
simplewallet: remove destinations with zero amount in sign_transfer 
This will happen when sending to another address, after removing
the fee.
 2016-10-30 09:15:04 +00:00
NanoAkron
f71b06770b
Changed to ..._HASHBITS everywhere for consistency 2016-10-29 14:59:06 +01:00
moneromooo-monero
ffd8c41f36
ringct: check the size of amount_keys is the same as destinations 2016-10-29 13:33:48 +01:00
moneromooo-monero
836669d276
ringct: always shutdown the boost io service 
Even if no worker threads were started, it needs shutting down
or it will cause an invalid access in the io service thread
 2016-10-29 13:31:53 +01:00
Riccardo Spagni
83b0511731
Merge pull request #1270 
fdef09f Wallet API: make sure path exists before searching for wallets (Jacob Brydolf)
 2016-10-29 11:35:48 +02:00
Riccardo Spagni
3365f770dd
Merge pull request #1261 
069d688 simplewallet: log transactions to submit in submit_transfer (moneromooo-monero)
31abac4 wallet: fix pre-rct cold wallet signing not splitting change (moneromooo-monero)
 2016-10-29 11:30:21 +02:00
Riccardo Spagni
6a303b9a3a
Merge pull request #1254 
eb4ecd4 daemon: fix min/max tracking using the wrong size (moneromooo-monero)
 2016-10-29 11:23:08 +02:00
Riccardo Spagni
971f3ae031
Merge pull request #1251 
59f0d4b ringct: some more small optimizations (moneromooo-monero)
 2016-10-29 11:22:27 +02:00
Jacob Brydolf
fdef09f11c Wallet API: make sure path exists before searching for wallets 2016-10-28 22:29:33 +02:00
moneromooo-monero
069d688cf7
simplewallet: log transactions to submit in submit_transfer 
Not as trustworthy as this is in the view wallet, the one
that's considered compromised.
 2016-10-26 13:17:29 +01:00
moneromooo-monero
31abac4daf
wallet: fix pre-rct cold wallet signing not splitting change 
Re-creating the transaction on the cold wallet was not splitting
the change, causing the transaction to be rejected by the network.
This worked on testnet since amounts do not have to be split.

Also add selected_transfers, which can now be saved since they're
size_t rather than iterators. This allows the view wallet to
properly set the sent outputs as spent and update balance.

Bump transfer file version numbers to match.
 2016-10-25 21:44:31 +01:00
moneromooo-monero
eb4ecd442d
daemon: fix min/max tracking using the wrong size 
Reported by iDunk
 2016-10-23 23:18:34 +01:00
moneromooo-monero
30946700a3
daemon: even when switching branches, compile the damn thing ffs 2016-10-23 20:21:00 +01:00
moneromooo-monero
2f4f6c7c26
daemon: do not divide by 0 when the pool is empty 2016-10-23 20:05:13 +01:00
Riccardo Spagni
6a2157b610
Merge pull request #1245 
ff88252 simplewallet: factor locked_transfer, and fix a few rough edges (moneromooo-monero)
 2016-10-23 19:27:09 +02:00
Riccardo Spagni
a0975e59ed
Merge pull request #1250 
839280d daemon: add a print_pool_stats daemon command (moneromooo-monero)
 2016-10-23 19:25:33 +02:00
moneromooo-monero
ff8825210d
simplewallet: factor locked_transfer, and fix a few rough edges 
Factor locked_transfer into transfer_main, which brings various
improvements for free (multiple addresses, proper detection of
multiple payment ids, obeying the prompt settings).

Also fix a few things, such as using uint64_t instead of int
for block heights, actually checking whether getting blockchain
height succeeded, etc.
 2016-10-23 18:21:30 +01:00
Riccardo Spagni
854abeb3bb
Merge pull request #1247 
10a79ea daemon: report transaction relay status in print_pool* commands (moneromooo-monero)
1e16366 core: notify the txpool when transactions are relayed (moneromooo-monero)
f3c374f tx_pool: set relayed flag on relay (moneromooo-monero)
 2016-10-23 19:16:30 +02:00
Riccardo Spagni
4e98d2958c
Merge pull request #1246 
372f338 wallet: sanity check on selected transfer indices in signed ptx (moneromooo-monero)
 2016-10-23 19:09:18 +02:00
Riccardo Spagni
31ceb830e5
Merge pull request #1239 
12d8616 perf_timer: format string fix for 32 bits (moneromooo-monero)
 2016-10-23 19:05:44 +02:00
Riccardo Spagni
92095104fe
Merge pull request #1230 
06b642d wallet_api: add address validation functions (moneromooo-monero)
 2016-10-23 19:04:01 +02:00
moneromooo-monero
839280d5fc
daemon: add a print_pool_stats daemon command 
Helps see what's going on now that Monero is getting used
 2016-10-23 16:11:20 +01:00
moneromooo-monero
59f0d4b574
ringct: some more small optimizations 2016-10-23 16:10:17 +01:00
moneromooo-monero
10a79eae24
daemon: report transaction relay status in print_pool* commands 2016-10-23 00:32:55 +01:00
moneromooo-monero
1e163666f3
core: notify the txpool when transactions are relayed 2016-10-23 00:32:49 +01:00
Riccardo Spagni
4f6ea2eb6a
Merge pull request #1229 
b6b86ab wallet2_api: recognize full size payment ids as valid (moneromooo-monero)
 2016-10-22 22:19:43 +02:00
Riccardo Spagni
b3d4505ae1
Merge pull request #1228 
2bf65df wallet_api: do not override invalid payment id (moneromooo-monero)
 2016-10-22 22:18:36 +02:00
Riccardo Spagni
09f62ed33e
Merge pull request #1225 
04da979 Always confirm transfers defaults to ON/YES (NanoAkron)
 2016-10-22 22:16:39 +02:00
Riccardo Spagni
f800390ccc
Merge pull request #1224 
8231997 simplewallet: fix sweep_all misreporting sweeped amount for rct outputs (moneromooo-monero)
985f61a wallet: force 0 mixin transactions to use pre-rct txes (moneromooo-monero)
 2016-10-22 22:15:50 +02:00
Riccardo Spagni
7c5431624e
Merge pull request #1223 
0950be9 wallet: speed up output selection, and fix bug with relatedness calculation (moneromooo-monero)
0eba133 wallet: fix mixup between mixin 2 and 4 before/after v5 (moneromooo-monero)
 2016-10-22 22:15:16 +02:00
Riccardo Spagni
b9f31bbc10
Merge pull request #1222 
5e10fb0 rpc: add blockchain cumulative difficulty to getinfo call (moneromooo-monero)
 2016-10-22 22:14:35 +02:00
Riccardo Spagni
7426b5374f
Merge pull request #1221 
094f4c8 rpc: add missing top block hash to json getinfo call (moneromooo-monero)
 2016-10-22 22:13:24 +02:00
Riccardo Spagni
9feb358e46
Merge pull request #1220 
e76dcdd wallet: improve error messages when not enough money for transfer (moneromooo-monero)
 2016-10-22 22:12:17 +02:00
Riccardo Spagni
e48ef1684c
Merge pull request #1219 
2d7083c wallet_api: fix wrong amount in tx history (moneromooo-monero)
b5f2001 simplewallet: fix wrong amount in show_transfers (moneromooo-monero)
 2016-10-22 22:11:12 +02:00
Riccardo Spagni
2bb0bdc8b8
Merge pull request #1218 
3429bfb ringct: thread verRct and verRctSimple (moneromooo-monero)
e06a4da ringct: remove unneeded type conversions (moneromooo-monero)
afc70df ringct: reserve space in vectors to avoid excessive reallocation (moneromooo-monero)
9ebf7b6 ringct: avoid unnecessary memcpy (moneromooo-monero)
1fe75c1 ringct: add a few consts where possible (moneromooo-monero)
ab002a1 ringct: pass vectors by const ref where possible (moneromooo-monero)
 2016-10-22 22:10:01 +02:00
Riccardo Spagni
af2b1ec606
Merge pull request #1216 
9c73128 Change default dust threshold to equal fee per kb (AwfulCrawler)
 2016-10-22 22:08:31 +02:00
Riccardo Spagni
b53c9e5549
Merge pull request #1200 
a3748f4 Rewrote add_wallet_create_if_needed for clearer flow and behaviour (NanoAkron)
 2016-10-22 22:07:38 +02:00
moneromooo-monero
f3c374fe08
tx_pool: set relayed flag on relay 2016-10-22 20:46:19 +01:00
moneromooo-monero
372f338682
wallet: sanity check on selected transfer indices in signed ptx 2016-10-22 18:07:26 +01:00
moneromooo-monero
12d861694d
perf_timer: format string fix for 32 bits 2016-10-20 18:43:33 +01:00
Riccardo Spagni
d63fabdc62
Merge pull request #1215 
a6bc110 patched parameter type bug that was causing failure on 32 bit (Dion Ahmetaj)
 2016-10-18 12:22:22 +02:00
moneromooo-monero
06b642dfe4
wallet_api: add address validation functions 
The payment id from integrated addresses is also parsed
 2016-10-16 16:52:45 +01:00
moneromooo-monero
b6b86ab347
wallet2_api: recognize full size payment ids as valid 2016-10-16 13:54:53 +01:00
moneromooo-monero
2bf65dfb8d
wallet_api: do not override invalid payment id 
Instead, return an empty string to mark the error
 2016-10-16 13:17:29 +01:00
NanoAkron
a3748f40ea
Rewrote add_wallet_create_if_needed for clearer flow and behaviour 2016-10-15 22:29:28 +01:00
NanoAkron
04da979f46
Always confirm transfers defaults to ON/YES 2016-10-15 20:38:07 +01:00
moneromooo-monero
8231997b66
simplewallet: fix sweep_all misreporting sweeped amount for rct outputs 
RingCT outputs will be 0 in the vin, so we need to get the actual
amount from elsewhere.
 2016-10-15 19:18:52 +01:00
moneromooo-monero
985f61a4ec
wallet: force 0 mixin transactions to use pre-rct txes 
rct transactions does not support 0 mixin, and those are
now typically dust sweep transactions, for which a lower
fee is a must.
 2016-10-15 18:42:04 +01:00
moneromooo-monero
88faec75fe
wallet: select part of the fake outs from recent outputs 
25% of the outputs are selected from the last 5 days (if possible),
in order to avoid the common case of sending recently received
outputs again. 25% and 5 days are subject to review later, since
it's just a wallet level change.
 2016-10-15 18:17:16 +01:00
moneromooo-monero
0950be9e34
wallet: speed up output selection, and fix bug with relatedness calculation 2016-10-15 16:32:08 +01:00
moneromooo-monero
0eba1335be
wallet: fix mixup between mixin 2 and 4 before/after v5 2016-10-15 16:07:18 +01:00
moneromooo-monero
5e10fb042d
rpc: add blockchain cumulative difficulty to getinfo call 2016-10-15 15:00:21 +01:00
moneromooo-monero
094f4c8cc6
rpc: add missing top block hash to json getinfo call 2016-10-15 14:35:29 +01:00
moneromooo-monero
e76dcdd810
wallet: improve error messages when not enough money for transfer 2016-10-15 14:31:40 +01:00
moneromooo-monero
2d7083ca56
wallet_api: fix wrong amount in tx history 2016-10-15 13:56:25 +01:00
moneromooo-monero
b5f20012d3
simplewallet: fix wrong amount in show_transfers 2016-10-15 13:56:09 +01:00
moneromooo-monero
3429bfb71d
ringct: thread verRct and verRctSimple 2016-10-15 13:32:13 +01:00
moneromooo-monero
e06a4daf33
ringct: remove unneeded type conversions 2016-10-15 11:58:39 +01:00
moneromooo-monero
afc70df7ea
ringct: reserve space in vectors to avoid excessive reallocation 2016-10-15 11:58:34 +01:00
moneromooo-monero
9ebf7b6dcf
ringct: avoid unnecessary memcpy 2016-10-15 11:58:29 +01:00
moneromooo-monero
1fe75c1ea7
ringct: add a few consts where possible 2016-10-15 11:58:24 +01:00
moneromooo-monero
ab002a1d97
ringct: pass vectors by const ref where possible 2016-10-15 11:58:18 +01:00
Dion Ahmetaj
a6bc1103fd patched parameter type bug that was causing failure on 32 bit 2016-10-14 10:37:10 -04:00
AwfulCrawler
9c73128835 Change default dust threshold to equal fee per kb 2016-10-12 14:04:26 +13:00
Riccardo Spagni
34fcfcd7cc
Merge pull request #1203 
4038e86 Add performance timers for ringct tx verification (moneromooo-monero)
74dfdb0 perf_timer: new class and macros to make performance logs easier (moneromooo-monero)
 2016-10-11 10:31:26 +02:00
Riccardo Spagni
3db0ebafe5
Merge pull request #1204 
7db29d6 print_coinbase_tx_sum now breaks output into fee and emission components (Dion Ahmetaj)
dd6c443 changed params from start/end index to height/count (Dion Ahmetaj)
e95d3f3 attempted to remove whitespace spam (Dion Ahmetaj)
412da63 added print_coinbase_tx_sum option (Dion Ahmetaj)
 2016-10-11 10:30:53 +02:00
Dion Ahmetaj
7db29d6903 print_coinbase_tx_sum now breaks output into fee and emission components 2016-10-10 19:55:18 -04:00
Dion Ahmetaj
dd6c44327b changed params from start/end index to height/count 2016-10-10 17:19:36 -04:00