Riccardo Spagni
35299644b2
Merge pull request #3650
...
5bd7f760
2018-04-28 16:54:37 +02:00
stoffu
3880bf396a
cryptonote_protocol_handler.inl: remove span read just now that failed to pass some basic tests
2018-04-28 11:10:59 +09:00
stoffu
da249fd5ba
cryptonote_protocol_handler.inl: fix return type mismatches (int vs bool)
2018-04-28 11:07:51 +09:00
Gene Peters
82b05d5054
Adding required library (dependency of boost::this_thread::sleep_for)
2018-04-25 21:02:54 -07:00
rbrunner7
f9d0827bba
Fix broken interactive daemon 'limit' commands plus RPC calls
2018-04-25 21:37:10 +02:00
naughtyfox
b21bc00704
Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api)
2018-04-25 17:55:54 +03:00
moneromooo-monero
3ca267b546
cn_deserialize: dump additional tx pubkeys
2018-04-25 14:28:39 +01:00
moneromooo-monero
efcecb42f3
mnemonics: add some logs to help debug failures
2018-04-25 14:27:24 +01:00
aivve
b1a9e97b2d
slow-hash: fix memory leak for Windows /karbowanec#41
2018-04-24 20:47:29 +09:00
moneromooo-monero
6b13976330
blockchain: log in DEBUG when a block is found, and where
...
Eases up debugging
2018-04-23 11:43:12 +01:00
moneromooo-monero
ffeeefde60
speedup get_output_histogram for all amounts when min_count > 0
...
This skips the vast majority of "dust" output amounts with just
one instance on the chain. Clocks in at 0.15% of the original
time on testnet.
2018-04-23 10:54:28 +01:00
moneromooo-monero
2dae0f203a
wallet2: add missing parameters to get_output_histogram
2018-04-23 10:54:25 +01:00
Thaer Khawaja
dad1077577
Only log an error if fork version is higher AND is not known.
2018-04-22 17:26:44 -07:00
stoffu
f36132a837
wallet cli/rpc: terminate execution with code 0 when --help or --version is given
2018-04-22 11:48:44 +09:00
Mikhail Mitkevichl
5bd7f760e9
import_multisig_info: fix sanity check crash in detach_blockchain
2018-04-21 23:25:01 +03:00
Riccardo Spagni
8fdf645397
Merge pull request #3670
...
19e013786b853980859db52ff21df05c10685648
2018-04-21 22:01:54 +02:00
Riccardo Spagni
a429f06b18
Merge pull request #3579
...
0b88fff3
2018-04-21 21:58:52 +02:00
Riccardo Spagni
a3a617f35f
Merge pull request #3576
...
f82c10dc
2018-04-21 21:58:10 +02:00
Riccardo Spagni
6189a775b0
Merge pull request #3636
...
998c1461
2018-04-21 21:57:31 +02:00
Riccardo Spagni
bcb71797c8
Merge pull request #3633
...
f914df84
2018-04-21 21:55:44 +02:00
Riccardo Spagni
7e98e9d7ce
Merge pull request #3630
...
51b511be35d1269f
2018-04-21 21:55:28 +02:00
Riccardo Spagni
e6cf9c06fc
Merge pull request #3624
...
d8584fc8
2018-04-21 21:55:02 +02:00
Riccardo Spagni
03ff3be10e
Merge pull request #3672
...
875c1cab70f232178c7363fb
2018-04-21 21:54:08 +02:00
anonimal
6b85398031
Build: update CMake and p2p for in-tree miniupnp
...
(cherry picked from commit a7366b5feeffaeb65b217b2d6f138e0ab1c90192)
2018-04-21 09:43:23 +00:00
moneromooo-monero
875c1cabb9
wallet2: increase rpc timeout for get_output_distribution
2018-04-19 16:06:26 +01:00
moneromooo-monero
70f2321763
add top height to get_output_distribution, and cache it for rct
...
This should cache the vast majority of calls for long running wallets
2018-04-19 16:06:22 +01:00
moneromooo-monero
8c7363fbef
rpc: add missing perf timer for get_output_distribution
2018-04-19 16:06:20 +01:00
anonimal
859db52fda
CMake: update new location of in-tree miniupnpc
...
(cherry picked from commit b16a282f97d8f6c967e8a0b1ecfd75110f095182)
2018-04-19 10:56:09 +00:00
Ryan Ronnander
6f36cf02e7
Improve 'show_transfers' date formatting
...
Change the wallet's 'show_transfers' command to always output the transaction date with timestamp (24 hour UTC).
2018-04-15 19:23:15 -07:00
cryptochangements34
e2b75586fb
handle improper log levels
2018-04-15 11:33:22 -04:00
stoffu
998c1461c3
daemon: read config file before reading any other args
2018-04-14 22:05:24 +09:00
moneromooo-monero
c1bda097c1
wallet_rpc_server: add a get_version RPC
2018-04-14 13:34:05 +01:00
moneromooo-monero
f914df8494
device: add a one off override keyword where appropriate
2018-04-14 10:59:38 +01:00
moneromooo-monero
51b511be4c
simplewallet: add version command
2018-04-13 18:47:33 +01:00
moneromooo-monero
35d1269fac
daemon: add a version command
2018-04-13 18:47:30 +01:00
naughtyfox
8787fd899b
WalletApi: publicMultisigSignerKey method
2018-04-13 13:15:20 +03:00
moneromooo-monero
d8584fc8d7
util: log stack trace on crash
2018-04-12 20:36:16 +01:00
stoffu
b5d6c723e9
wallet2: store subaddress lookahead settings
2018-04-12 22:23:53 +09:00
Riccardo Spagni
1f96755ddc
Merge pull request #3618
...
3367ed86
2018-04-12 15:10:21 +02:00
moneromooo-monero
3367ed863c
blockchain_blackball: fix build with CLANG 5
...
It doesn't like the explicit NULL dereference (which is fine, honest)
2018-04-12 13:51:26 +01:00
cslashm
94b899db26
Use 'boost' mutex instead of 'std' mutex
2018-04-12 13:58:57 +02:00
cslashm
2c274e05fe
Fix sub-address tx scan.
...
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.
Moreover this patch avoid perf decreasing when not using HW device.
2018-04-12 13:58:57 +02:00
Riccardo Spagni
5e08fd89ea
Merge pull request #3549
...
73951cbd25fe67e4
2018-04-12 13:49:33 +02:00
Riccardo Spagni
a95461e76d
Merge pull request #3609
...
08343aba
2018-04-12 13:48:44 +02:00
Riccardo Spagni
1e9cc3e43e
Merge pull request #3602
...
a9cc88ee
2018-04-12 13:48:12 +02:00
Riccardo Spagni
14c870ee5f
Merge pull request #3615
...
24acb66e
2018-04-12 13:47:54 +02:00
Riccardo Spagni
3b8704b0fa
Merge pull request #3555
...
0b26c4d5
2018-04-12 13:47:39 +02:00
Riccardo Spagni
5d8439e310
Merge pull request #3534
...
eecfb57d
2018-04-12 13:47:20 +02:00
Riccardo Spagni
f6094bb225
Merge pull request #3532
...
aa5c2e01
2018-04-12 13:46:50 +02:00
Riccardo Spagni
226de8e928
Merge pull request #3530
...
eb59f7c5
2018-04-12 13:46:34 +02:00
Riccardo Spagni
8703f1d80e
Merge pull request #3516
...
1e0958c0
2018-04-12 13:46:18 +02:00
moneromooo-monero
24acb66eac
wallet2: fix misc issues when the ringdb can't be initialized
2018-04-12 11:07:07 +01:00
Riccardo Spagni
3a9290ba6f
Merge pull request #3511
...
0beb94f3
2018-04-12 11:15:27 +02:00
Riccardo Spagni
5053f8f40b
Merge pull request #3502
...
11c933e1
2018-04-12 11:14:43 +02:00
Riccardo Spagni
96b2fee721
Merge pull request #3536
...
c77d2bfa100b7bc1641dfc99
2018-04-12 11:12:33 +02:00
Riccardo Spagni
60b18cdd1f
Merge pull request #3492
...
dac3895a
2018-04-12 11:07:16 +02:00
Riccardo Spagni
93047ce762
Merge pull request #3485
...
1834127c
2018-04-12 11:06:26 +02:00
Riccardo Spagni
1b4dc46129
Merge pull request #3473
...
eaa8bfe70a619f78
2018-04-12 11:05:31 +02:00
Riccardo Spagni
3d6636e79c
Merge pull request #3471
...
5f664793
2018-04-12 11:02:46 +02:00
Riccardo Spagni
ebb55f797b
Merge pull request #3468
...
0098ed33
2018-04-12 11:00:47 +02:00
Riccardo Spagni
959f6ed9a5
Merge pull request #3461
...
57300491
2018-04-12 10:57:50 +02:00
moneromooo-monero
08343abaf4
tx_pool: fix loading with colliding key images
...
A key image may be present more than once if all but one of the
txes spending that key image are coming from blocks. When loading
a txpool from storage, we must load the one that's not from a
block first to avoid rejection
2018-04-11 15:27:56 +01:00
moneromooo-monero
6a61f520e2
unit_tests: add ringdb unit tests
2018-04-11 11:43:39 +01:00
moneromooo-monero
a9cc88ee76
common: make this build with unbound 1.4.20
...
Common on currently used distros
2018-04-10 23:46:18 +01:00
moneromooo-monero
90a16b119f
crypto: fix initialization order issue with random mutex
2018-04-10 12:30:48 +01:00
cryptochangements34
372ffeba21
Add a space in mining to testnet/stagenet string
2018-04-08 00:23:59 -04:00
stoffu
0b88fff3a5
simplewallet: fix help message of sign_transfer
2018-04-07 22:51:03 +09:00
moneromooo-monero
73951cbd39
wallet2: request transactions in slices when scanning for known rings
...
This avoid massive memory consumption for huge wallets
2018-04-07 08:31:46 +01:00
moneromooo-monero
25fe67e4cf
rpc: allow getting pruned blocks from gettransactions
...
and get them pruned in find_and_save_rings, since it does not need
the pruned data in the first place.
Also set decode_to_json to false where missing, we don't need this
either.
2018-04-07 08:29:11 +01:00
stoffu
f82c10dc96
WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time
2018-04-07 14:06:29 +09:00
stoffu
353e9c0c90
Core RPC: optionally add POW hash to block_header_response
2018-04-05 23:15:15 +09:00
moneromooo-monero
0b26c4d57c
wallet2: move segregation height to v7
...
since people seem to really want to use things the wrong way.
2018-04-05 12:49:38 +01:00
moneromooo-monero
6fc97c97eb
blockchain_usage: don't divide by 0 when there is nothing to process
...
Coverity 184942
2018-04-03 11:16:38 +01:00
cslashm
c77d2bfaa0
Add the possibility to export private view key for fast scan.
...
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
2018-03-31 18:00:33 +02:00
cslashm
100b7bc10d
Change mutex lock model to avoid dead lock and ensure locks are always released.
...
Additional cosmetic fixes:
move 'name' as protected
remove unnecessary local var
Fix debug log
2018-03-31 18:00:33 +02:00
cslashm
641dfc991f
Automatic height setup when creating/restoring hw device.
...
When creating/restoring wallet, if --restore-height option is not used the current estimate
height is used for starting the scan. In other words it is assume we are creating a new account.
2018-03-31 18:00:33 +02:00
moneromooo-monero
eecfb57df9
wallet: warn if not using the default ring size
2018-03-31 15:47:02 +01:00
moneromooo-monero
aa5c2e01e7
simplewallet: warn about key reuse on startup
2018-03-31 10:52:10 +01:00
stoffu
eb59f7c563
cryptonote_tx_util: make destinations properly shuffled
2018-03-31 18:37:46 +09:00
stoffu
66a659bb03
blockchain: add scope guard to waiter for threaded txv1 verification
2018-03-30 19:22:32 +09:00
sneurlax
1e0958c083
wallet: fix default mixin (4 -> 6)
2018-03-28 09:30:11 -07:00
naughtyfox
5a96056600
WalletApi: getMultisigInfo entry for gui wallets
...
WalletApi: makeMultisig call introduced
WalletApi: finalizeMultisig call introduced
WalletApi: new calls exportMultisigImages and importMultisigImages
WalletApi: method to return multisig wallet creation state
WalletApi: create multisig transaction, sign multisig transaction, commit transaction and get multisig data are added
WalletApi: identation and style fixes
2018-03-28 18:22:13 +03:00
naughtyfox
47fdb74273
Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings
...
WalletApi: added method statusWithErrorString to atomically retrieve error with error string
2018-03-28 16:11:16 +03:00
moneromooo-monero
0beb94f323
device: fix endianess dependence on subaddress secret key generation
...
We now force little endianness
2018-03-28 11:14:25 +01:00
moneromooo-monero
11c933e137
fix lambda compile error on openbsd
2018-03-27 14:48:36 +01:00
cryptochangements34
c8cb5fca5e
exit if specified wallet file doesn't exist
2018-03-24 11:13:21 -04:00
Riccardo Spagni
dac3895ac1
update block hashes for checkpoints.dat
2018-03-24 08:36:10 +02:00
moneromooo-monero
1834127c82
rpc: make get_output_distribution a non-restricted RPC
...
so that those nodes can still be used for sending transactions
2018-03-23 10:56:55 +00:00
moneromooo-monero
3f5fb6fe6d
simplewallet: add --untrusted-daemon option
2018-03-22 14:20:55 +00:00
stoffu
eaa8bfe7c0
wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly
...
The previous expression
req_t.from_height = X ? Y >= Z : 0;
forces the parameter to take the value of either 0 or 1.
2018-03-22 20:02:25 +09:00
stoffu
0a619f789b
wallet2: enable the mitigation only after the fork height
2018-03-22 20:02:14 +09:00
stoffu
5f6647934b
p2p: correct port number for seed nodes
2018-03-22 14:56:35 +09:00
stoffu
0098ed338c
wallet2: fix for loading settings of key reuse mitigation
2018-03-22 12:10:46 +09:00
cryptochangements34
ad19f8679e
don't show error twice when starting simplewallet
2018-03-21 22:56:04 -04:00
moneromooo-monero
5730049178
wallet: catch exceptions dealing with ringdb and warn
2018-03-21 14:29:49 +00:00
stoffu
3b941befae
core: add get_earliest_ideal_height_for_version()
2018-03-21 01:53:24 +09:00
moneromooo-monero
a6a54fa883
blockchain: cache difficulty for next block
...
Takes about 10 ms, which takes pretty much all of the get_info
RPC, which is called pretty often from wallets.
Also add a new lock so we don't need to lock the blockchain lock,
which will avoid blocking for a long time when calling the getinfo
RPC while syncing. Users of get_difficulty_for_next_block who need
the lock will have locked it already.
2018-03-19 09:05:40 +00:00
moneromooo-monero
b1398fff40
core: fix use of uninitialised data
2018-03-18 23:37:00 +00:00
Riccardo Spagni
428fb45f68
update checkpoints
2018-03-18 16:44:36 +02:00
Riccardo Spagni
3fedd51d26
update checkpoints.dat to block 1532400
2018-03-18 16:42:20 +02:00
Riccardo Spagni
83dbc5be76
update version to 0.12 Lithium Luna
2018-03-18 16:15:50 +02:00
Riccardo Spagni
df91d7bcbd
Merge pull request #3426
...
8ea3c4d5
2018-03-18 15:58:12 +02:00
Riccardo Spagni
b8ccd47b9f
Merge pull request #3419
...
1e393f4b
2018-03-18 15:57:58 +02:00
moneromooo-monero
bb20f104ba
Move v7 fork to 1546000 to give more update time
2018-03-18 09:29:31 +00:00
moneromooo-monero
8ea3c4d544
simplewallet: new --use-english-language-names flag
...
On some Windows systems, displaying language names in their own
languages freezes the display.
2018-03-17 22:46:41 +00:00
moneromooo-monero
1e393f4bb7
wallet: make the segregation height settable
...
via user setting first, then DNS TXT record, hardcoded fallback
2018-03-17 14:56:31 +00:00
Riccardo Spagni
5cd36e48bf
Merge pull request #3421
...
9732a37e
2018-03-17 16:52:46 +02:00
Riccardo Spagni
83651630bc
Merge pull request #3418
...
20a00266
2018-03-17 16:51:47 +02:00
moneromooo-monero
9732a37e9a
wallet_rpc_server: add sweep_unmixable as alias for sweep_dust
2018-03-17 11:22:58 +00:00
moneromooo-monero
20a002667c
blockchain: forbid bulletproof types before v8
...
They were already forbidden implicitely, but let's make that
explicit for robustness
2018-03-16 18:18:34 +00:00
stoffu
b86f1e5dad
Add command line option allowing to restrict the default sub-address lookahead in order to avoid
...
so looooong time of set-up when creating a HW based wallet.
2018-03-16 18:00:28 +01:00
Riccardo Spagni
a14eabc043
Merge pull request #3416
...
6f54c910#3175 (stoffu)
2018-03-16 18:10:20 +02:00
Riccardo Spagni
432480fa42
Merge pull request #3414
...
524cbdc1
2018-03-16 18:09:34 +02:00
Riccardo Spagni
2a9839cc3e
Merge pull request #3376
...
833f9fcf
2018-03-16 18:08:52 +02:00
Riccardo Spagni
0f27fc57ac
Merge pull request #3336
...
57c0b1ed
2018-03-16 18:08:07 +02:00
moneromooo-monero
eac3a11ed3
wallet: more user friendly print_ring
...
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
2018-03-16 12:07:45 +00:00
moneromooo-monero
798535149d
wallet2_api: add key reuse mitigations API
2018-03-16 12:07:42 +00:00
moneromooo-monero
b057a21d56
wallet2_api: add ring api
2018-03-16 10:33:05 +00:00
moneromooo-monero
d32ef7b0f2
ringdb: factor ring addition code
2018-03-16 10:33:02 +00:00
moneromooo-monero
a7da8208f5
wallet2_api: add blackball api
2018-03-16 10:32:59 +00:00
moneromooo-monero
504428ab4a
ringdb: use the genesis block as a db name
...
This will avoid careless forkers polluting the shared database
even if they make their own chain. They'll then automatically
start using another subdb, and any key-reusing fork of those
forks will reuse their subdbs.
2018-03-16 10:32:54 +00:00
moneromooo-monero
b09e5181cc
wallet: add a set_ring command
...
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
2018-03-16 10:32:51 +00:00
moneromooo-monero
0590f62ab6
new blockchain_usage tool, reports on output usage
2018-03-16 10:32:46 +00:00
moneromooo-monero
db10dd6d83
wallet: make ringdb an object with database state
2018-03-16 10:32:42 +00:00
moneromooo-monero
df6fad4c62
blockchain_utilities: new blockchain_blackball tool
...
It scans for known spent outputs and stores their public keys
in a database which can then be read by the wallet, which can
then avoid using those as fake outs in new transactions.
Usage: monero-blockchain-blackball db1 db2...
This uses the shared database in ~/.shared-ringdb
2018-03-16 10:32:39 +00:00
moneromooo-monero
d29ea0455a
wallet: add an output blackball list to avoid using those in rings
2018-03-16 10:32:37 +00:00
moneromooo-monero
18eaf19489
wallet: key reuse mitigation options
...
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.
The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.
This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).
If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.
If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
2018-03-16 10:32:34 +00:00
moneromooo-monero
5f146873c5
wallet: add shared ring database
...
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
2018-03-16 10:32:29 +00:00
moneromooo-monero
41f727ce42
add RPC to get a histogram of outputs of a given amount
2018-03-16 10:32:26 +00:00
cryptochangements34
833f9fcfe9
show '<Not set>' for empty wallet description
2018-03-15 23:22:45 -04:00
stoffu
6f54c910f7
simplewallet: fix restore height prompt that got disabled by #3175
2018-03-16 11:55:31 +09:00
stoffu
524cbdc1e2
blockchain: fix log message about per-kB fee
2018-03-16 10:43:19 +09:00
Dimitris Apostolou
57c0b1ed9f
Fix typos in various files
2018-03-15 18:25:38 +02:00
Riccardo Spagni
51bb7fafac
Merge pull request #3410
...
c5024c5b
2018-03-15 17:10:01 +02:00
Riccardo Spagni
60af9d689b
Merge pull request #3408
...
e1b526b3
2018-03-15 17:09:13 +02:00
moneromooo-monero
c5024c5b73
simplewallet: add a warning when getting a daemon error in transfer
...
A malicious daemon (or MITM) could attempt to add spurious errors
so the wallet tries again, sending another set of fake outs.
2018-03-15 13:33:19 +00:00
stoffu
a7266d6d7b
wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate calls to wallet2
2018-03-15 22:01:51 +09:00
Jean Pierre Dudey
e1b526b371
Remove the Blockchain::get_all_known_block_ids function.
...
This function isn't used in the codebase.
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2018-03-14 21:56:19 -04:00
Leon Klingele
80d2f8007c
wallet2: Update function parameter documentation
...
This completes and fixes various parameters docs
2018-03-14 16:41:24 +01:00
stoffu
71d186566e
replace invoke_http_json("/json_rpc",...) with invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate
2018-03-14 23:23:59 +09:00
Riccardo Spagni
a69c713f8e
Merge pull request #3398
...
c577abab
2018-03-14 16:18:15 +02:00
Riccardo Spagni
2fe1504c03
Merge pull request #3399
...
1d39b265
2018-03-14 16:17:59 +02:00
Riccardo Spagni
f9f2d182da
Merge pull request #3395
...
523371c0
2018-03-14 16:10:42 +02:00
Riccardo Spagni
8b90e3141a
Merge pull request #3386
...
9abeff59
2018-03-14 16:10:00 +02:00
Riccardo Spagni
7a44301675
Merge pull request #3385
...
ec41006c
2018-03-14 16:09:40 +02:00
Riccardo Spagni
534369eece
Merge pull request #3384
...
b63ea060
2018-03-14 16:08:14 +02:00
Riccardo Spagni
cb72b85bbf
Merge pull request #3372
...
c3e23b2d
2018-03-14 16:06:16 +02:00
stoffu
4405e4fc73
wallet2: check_tx_key() shouldn't require hardware encryption
2018-03-14 21:00:18 +09:00
stoffu
7dfa5e9e6e
chacha: call prehashed version explicitly as generate_chacha_key_prehashed
...
hash: add prehashed version cn_slow_hash_prehashed
slow-hash: let cn_slow_hash take 4th parameter for deciding prehashed or not
slow-hash: add support for prehashed version for the other 3 platforms
2018-03-14 21:00:17 +09:00
stoffu
b2d23b189e
crypto: revert odd namespace changes made in #3303
2018-03-14 21:00:17 +09:00
stoffu
8705beaf51
keypair::generate: always require hw::device to avoid possible mistake
2018-03-14 21:00:16 +09:00
stoffu
27a196b126
device: untangle cyclic depenency
...
When #3303 was merged, a cyclic dependency chain was generated:
libdevice <- libcncrypto <- libringct <- libdevice
This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:
libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct
This eliminates the need for crypto_device.cpp and rctOps_device.cpp.
Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
2018-03-14 21:00:15 +09:00
stoffu
c9b38b4765
device: made function prototypes consistent with pre-#3303 codebase
2018-03-14 21:00:06 +09:00
Riccardo Spagni
f2e8e8d23c
Merge pull request #3377
...
aa8bef0c
2018-03-14 13:38:50 +02:00
Riccardo Spagni
9a63fbcf83
Merge pull request #3371
...
84decbea
2018-03-14 13:37:25 +02:00
Riccardo Spagni
3bc2537f5a
Merge pull request #3369
...
1979d53d
2018-03-14 13:37:14 +02:00
Riccardo Spagni
0f2d6d40b4
Merge pull request #3360
...
1ff35fda
2018-03-14 13:37:00 +02:00
Riccardo Spagni
2e074e2ae7
Merge pull request #3358
...
978663d4
2018-03-14 13:36:47 +02:00
Riccardo Spagni
117cf12509
Merge pull request #3355
...
0bbd521f
2018-03-14 13:36:36 +02:00
Riccardo Spagni
33158f089d
Merge pull request #3354
...
ffe70b8f
2018-03-14 13:36:25 +02:00
Riccardo Spagni
2dfb4f098e
Merge pull request #3353
...
73dd883d
2018-03-14 13:36:14 +02:00
Riccardo Spagni
cfc5a3d4d4
Merge pull request #3345
...
e0cda74a
2018-03-14 13:35:53 +02:00
Riccardo Spagni
67978b78ce
Merge pull request #3337
...
91d97dd45f85cc7e
2018-03-14 13:35:41 +02:00
Riccardo Spagni
3fed788603
Merge pull request #3315
...
649a1b7a
2018-03-14 13:35:11 +02:00
moneromooo-monero
5f85cc7e3d
wallet2: guard against overflowing of subaddress indices
2018-03-14 11:34:06 +00:00
stoffu
1d39b26556
wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet
2018-03-14 19:02:21 +09:00
stoffu
c577abab61
wallet: fix auto low priority so that it takes effect only when saved default is 0
2018-03-14 18:33:43 +09:00
moneromooo-monero
523371c042
p2p: fix network ID being uninitialised when using exclusive peers
2018-03-13 11:20:49 +00:00
Cédric
73dd883d51
Ledger HW Bug fixes
...
Fix the way the REAL mode is handle:
Let create_transactions_2 and create_transactions_from construct the vector of transactions.
Then iterate on it and resign.
We just need to add 'outs' list in the TX struct for that.
Fix default secret keys value when DEBUG_HWDEVICE mode is off
The magic value (00...00 for view key and FF..FF for spend key) was not correctly set
when DEBUG_HWDEVICE was off. Both was set to 00...00.
Add sub-address info in ABP map in order to correctly display destination sub-address on device
Fix DEBUG_HWDEVICE mode:
- Fix compilation errors.
- Fix control device init in ledger device.
- Add more log.
Fix sub addr control
Fix debug Info
2018-03-12 10:43:06 +01:00
moneromooo-monero
9abeff5911
wallet2: handle no blocks returned in refresh to mean no new blocks
...
This is not a possible return from the daemon, but I want this in
now so all wallets handle this when the daemon starts doing so.
2018-03-11 21:16:15 +00:00
moneromooo-monero
ec41006cad
node_rpc_proxy: fix target height caching
2018-03-11 13:11:49 +00:00
moneromooo-monero
b63ea060de
simplewallet: do not call a RPC when displaying the prompt
...
Speeds up refresh when you have a lot of in/out transactions
2018-03-11 10:23:45 +00:00
Leon Klingele
649a1b7ae6
wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets
...
Previously, a file containing the unencrypted Monero address was
created by default in the wallet's directory. This file might pose
as a privacy risk. The creation of this file is now opt-in and can
be enabled by providing
--create-address-file
2018-03-10 16:28:23 +01:00
cryptochangements34
aa8bef0cb3
fix error message typo in wallet2.cpp
2018-03-09 17:22:26 -05:00
stoffu
978663d461
Stagenet: successive forks up to v7
2018-03-09 13:59:11 +09:00
Riccardo Spagni
e9f41e405f
Merge pull request #3368
...
38657fd0
2018-03-08 18:47:41 +02:00
Riccardo Spagni
546e380cab
Merge pull request #3370
...
04a0cc89
2018-03-08 18:44:47 +02:00
Riccardo Spagni
3a12f2588a
Merge pull request #3365
...
55a65f32
2018-03-08 18:44:18 +02:00
Riccardo Spagni
f4cf613e34
Merge pull request #3362
...
49c70962
2018-03-08 18:43:37 +02:00
Riccardo Spagni
220cb62ca4
Merge pull request #3357
...
557a6fb6
2018-03-08 18:43:20 +02:00
Riccardo Spagni
60c8544e77
Merge pull request #3347
...
9a6be3da
2018-03-08 18:42:24 +02:00
moneromooo-monero
c3e23b2dce
ringct: 17% improvement in Borromean signature verification
2018-03-08 00:41:54 +00:00
moneromooo-monero
84decbea48
core: add v7 for 1539500 on mainnet
2018-03-07 17:19:50 +00:00
moneromooo-monero
1979d53d78
wallet: fixes and tweaks to the save_watch_only command
...
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly
- catch any exception (eg, I/O errors) and error out
- print the new keys filename in simplewallet
2018-03-07 14:24:14 +00:00
moneromooo-monero
38657fd0e9
Bump min ring size from 5 to 7 from v7
2018-03-07 13:19:04 +00:00
moneromooo-monero
04a0cc89cf
slow-hash: fix uint64 type typo
2018-03-07 09:48:58 +00:00
stoffu
55a65f3269
Wallet API: corrected testnet/mainnet ordering
2018-03-07 13:56:17 +09:00
stoffu
49c70962ee
device: remove dependency on readline
2018-03-07 07:42:28 +09:00
stoffu
1ff35fda7c
Wallet API: make nettype non-defaulted to disambiguate from deprecated versions (and make libwallet_api_tests compilable)
2018-03-06 21:14:52 +09:00
moneromooo-monero
557a6fb6ea
cn_deserialize: link with device and ringct
2018-03-05 20:52:18 +00:00
Lee Clagett
e136bc6b8a
tweaks to the monerov1 cryptonight algorithm
2018-03-05 18:18:45 +00:00
SChernykh
d58c9ec99c
slow-hash: optimized version
2018-03-05 18:18:43 +00:00
moneromooo-monero
608fd6f14a
Monero Cryptonight variants, and add one for v7
...
This is the first variant of many, with the intent to improve
Monero's resistance to ASICs and encourage mining decentralization.
2018-03-05 18:18:39 +00:00
stoffu
0bbd521fa2
libwallet_merged: added missing libdevice
2018-03-06 02:36:37 +09:00
cryptochangements34
ffe70b8f61
Make mixin optional with default for rpc transfer
2018-03-05 12:27:22 -05:00
Riccardo Spagni
a21c927d7d
Merge pull request #3298
...
f2bb8085Fix #3297 use the password_prompter helper (Howard Chu)
2018-03-05 19:17:51 +02:00
Riccardo Spagni
0c2b25204e
Merge pull request #3312
...
399120dd
2018-03-05 19:16:52 +02:00
Riccardo Spagni
237f0179b7
Merge pull request #3313
...
43026822
2018-03-05 19:15:54 +02:00
Riccardo Spagni
baf640887d
Merge pull request #3343
...
3d452367
2018-03-05 19:14:03 +02:00
Riccardo Spagni
98acbe83fc
Merge pull request #3348
...
c95dddd2
2018-03-05 19:13:52 +02:00
