monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-27 05:59:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
11142 commits 9 branches 69 tags 324 MiB
Commit graph

7521 commits

Author SHA1 Message Date
SChernykh
e52802baef Wallet2: fix optimize-coinbase for p2pool payouts 
RefreshOptimizeCoinbase was an optimization to speed up scanning of coinbase transactions before RingCT (tx version 2) where they split miner reward into multiple denominations, all to the same wallet.

When RingCT was introduced, all coinbase transactions became 1 output only, so this optimization does nothing now.

With p2pool, this optimization will skip scanning p2pool payouts because they use more than 1 output in coinbase transaction.

Fix it by applying this optimization only to pre-RingCT transactions (version < 2).
 2021-08-26 11:50:15 +02:00
luigi1111
0061da9e63
Merge pull request #7878 
a9aaa47 wallet_api: add make_uri (tobtoht)
 2021-08-20 16:50:24 -04:00
luigi1111
8b9eea92f1
Merge pull request #7849 
6f15a0c Make sure node returns to wallet that real output is unlocked (j-berman)
 2021-08-20 16:49:59 -04:00
luigi1111
1b079e5195
Merge pull request #7845 
e1af8dc Protect client from divide by 0 caused by integer truncation (j-berman)
 2021-08-20 16:45:15 -04:00
luigi1111
5812b757e0
Merge pull request #7821 
da2955f Apply gamma distr from chain tip when selecting decoys (j-berman)
 2021-08-20 16:33:53 -04:00
anon
4ced092aae daemon: allow proxy configuration 
Co-authored-by: selsta <selsta@sent.at>
Co-authored-by: tobtoht <thotbot@protonmail.com>
 2021-08-20 21:24:29 +02:00
Kermit Alexander II
24d3d65d42 monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir 2021-08-20 08:54:41 -05:00
j-berman
e1af8dc02c Protect client from divide by 0 caused by integer truncation 2021-08-19 14:56:36 -07:00
j-berman
da2955feae Apply gamma distr from chain tip when selecting decoys 
- matches the paper by Miller et al to apply the gamma from chain tip, rather than after unlock time
- if the gamma produces an output more recent than the unlock time, the algo packs that output into one of the first 50 spendable blocks, respecting the block density factor
 2021-08-19 14:51:20 -07:00
selsta
d749e0d97c
ringct: silence unused variable warning 2021-08-19 22:00:44 +02:00
mj-xmr
15936bfa0f
Device: remove unused and incorrect non-default constructor 2021-08-19 21:56:12 +02:00
tobtoht
a9aaa47abb
wallet_api: add make_uri 2021-08-19 15:35:37 +02:00
luigi1111
89664fcee5
Merge pull request #7811 
3d3a671 Daemon: Update average block size table (rbrunner7)
 2021-08-11 22:37:56 -04:00
luigi1111
521b4d9ded
Merge pull request #7809 
7354ffb p2p: remove blocked addresses/hosts from peerlist (moneromooo-monero)
 2021-08-11 22:35:15 -04:00
luigi1111
cb08466394
Merge pull request #7802 
a3d2b71 wallet_api: expose offline mode status (rating89us)
 2021-08-11 22:33:38 -04:00
luigi1111
5cebb8edc0
Merge pull request #7800 
b48074f Fixed json serialization of rct::RCTTypeNull (SChernykh)
 2021-08-11 22:32:39 -04:00
luigi1111
1bb8ec1b97
Merge pull request #7795 
87a0928 rpc: source file extensions must be explicit (cmake warning) (selsta)
 2021-08-11 22:31:34 -04:00
luigi1111
62844a776d
Merge pull request #7786 
9c6e094 fix #7784 - deinit wallet in wallet dtor (Dusan Klinec)
 2021-08-11 22:30:11 -04:00
j-berman
6f15a0c8d3 Make sure node returns to wallet that real output is unlocked 2021-08-11 07:28:10 -07:00
moneromooo-monero
7354ffb8a7
p2p: remove blocked addresses/hosts from peerlist 2021-08-05 17:29:25 +00:00
Dusan Klinec
13a8a576ed
trezor: try empty passphrase first 
- Try empty passphrase first when opening a wallet, as all Trezors will have passphrase enabled by default by Trezor Suite by default.
  This feature enables easier access to all users using disabled passphrase (or empty passhprase)
- If wallet address differs from device address with empty passphrase, another opening attempt is made, without passphrase suppression,
  so user can enter his passhprase if using some. In this scenario, nothing changes to user, wallet opening just consumes one more call
  to Trezor (get wallet address with empty passphrase)
- also change how m_passphrase is used. Previous version did not work well with recent passphrase entry mechanism change (made in Trezor),
  thus this commit fixes the behaviour).
 2021-08-03 13:54:04 +02:00
luigi1111
ed506006d2
Merge pull request #7796 
0c6e1d3 wallet2: chunk get_outs.bin calls to avoid sanity limits (moneromooo-monero)
 2021-08-02 18:54:46 -04:00
luigi1111
eeda76570c
Merge pull request #7790 
bc8d764 wallet: rephrase error message on invalid device address (Dusan Klinec)
 2021-08-02 18:53:05 -04:00
luigi1111
8c41d14ad5
Merge pull request #7788 
f5eb2ce wallet2: Don't auto lock device on process parsed blocks (tobtoht)
 2021-08-02 18:50:25 -04:00
luigi1111
894e5b2794
Merge pull request #7767 
5fa1c90 Fix describe_transfer for multiple txes in a txset (Alex Opie)
 2021-08-02 18:47:05 -04:00
luigi1111
0cdb8d02e8
Merge pull request #7757 
d689b94 protocol: fix delayed 'you are now synchronized...' message (moneromooo-monero)
 2021-08-02 18:43:44 -04:00
luigi1111
9aa2d4c16e
Merge pull request #7747 
8cf95c8 wallet2: refresh: check error and throw before potentially breaking out of loop (tobtoht)
 2021-08-02 18:42:32 -04:00
Alex Opie
5fa1c90102
Fix describe_transfer for multiple txes in a txset 
This ensures each list of recipients is only the recipients
for one transaction. It also adds a new field "summary"
that describes the txset as a whole.

Fixes #7344
 2021-08-02 20:39:49 +02:00
Lee *!* Clagett
2a8a51129f Quicker resource cleanup on p2p socks timeout 2021-07-29 08:54:13 +00:00
selsta
979d121ed7
blocks: fix cmake syntax 2021-07-28 00:39:48 +02:00
luigi1111
960376b960
Merge pull request #7782 
a48db50 device_trezor_base: fix typo (anon)
 2021-07-27 17:04:14 -04:00
luigi1111
d9c9a11c54
Merge pull request #7772 
eda5c30 Doc: Update blockchain stats with review comments (mj-xmr)
 2021-07-27 17:01:42 -04:00
luigi1111
69e714c749
Merge pull request #7745 
d52d21b ledger: don't lock for software device (tobtoht)
 2021-07-27 16:56:37 -04:00
luigi1111
62bcdc1d3c
Merge pull request #7744 
ce40c33 ledger: use software device if we have view key (tobtoht)
 2021-07-27 16:56:09 -04:00
luigi1111
2d5b8a6ff7
Merge pull request #7740 
8cea9d8 wallet: Reset RPC Pay ID on node switch (tobtoht)
 2021-07-27 16:55:14 -04:00
luigi1111
ca4de5f96d
Merge pull request #7698 
7359d51 cmake: fix non portable code (selsta)
 2021-07-27 16:53:55 -04:00
rbrunner7
3d3a67142c Daemon: Update average block size table 2021-07-27 13:45:55 +02:00
rating89us
a3d2b71ee9 wallet_api: expose offline mode status 2021-07-19 00:30:36 +02:00
SChernykh
b48074fb8d Fixed json serialization of rct::RCTTypeNull 
rct::RCTTypeNull doesn't have these fields (ecdhInfo, outPk, txnFee).
 2021-07-18 10:52:14 +02:00
moneromooo-monero
0c6e1d343e
wallet2: chunk get_outs.bin calls to avoid sanity limits 2021-07-15 17:25:07 +00:00
selsta
87a092811d
rpc: source file extensions must be explicit (cmake warning) 2021-07-15 09:42:57 +02:00
tobtoht
f5eb2ce968 wallet2: Don't auto lock device on process parsed blocks 2021-07-14 13:02:54 +02:00
Dusan Klinec
bc8d7644d2
wallet: rephrase error message on invalid device address 2021-07-14 11:02:29 +02:00
Dusan Klinec
9c6e0941cb
fix #7784 - deinit wallet in wallet dtor 2021-07-14 10:46:16 +02:00
anon
fe76d7dee7
cmake: fix undefined symbols and multiple definitions 2021-07-13 08:00:20 +02:00
anon
a48db50b1c
device_trezor_base: fix typo 2021-07-10 23:52:15 +00:00
luigi1111
de3456e127
Merge pull request #7764 
e24875e simplewallet: don't truncate integ. address in export_transfers (selsta)
 2021-07-10 18:01:35 -04:00
luigi1111
1e8cbc995f
Merge pull request #7762 
8ae6c85 trezor: add #if for ByteSizeLong (selsta)
 2021-07-10 18:00:45 -04:00
luigi1111
3c8c8e5a5b
Merge pull request #7761 
8ef51dc wallet_api: fix typo in exportKeyImages (selsta)
 2021-07-10 17:59:56 -04:00
luigi1111
9903b35345
Merge pull request #7754 
8ff21e1 doc: update IRC references to Libera (fdov)
 2021-07-10 17:59:23 -04:00
luigi1111
6043c85afe
Merge pull request #7753 
f0df726 add singapore.node.xmr.pm to seed nodes (lza_menace)
 2021-07-10 17:58:22 -04:00
luigi1111
c53e22c40a
Merge pull request #7748 
bbeb555 wallet_api: getPassword (tobtoht)
 2021-07-10 17:57:39 -04:00
mj-xmr
eda5c303cd
Doc: Update blockchain stats with review comments 2021-07-06 07:12:33 +02:00
tobtoht
bbeb555f00 wallet_api: getPassword 2021-07-05 02:49:27 +02:00
selsta
8ae6c85efd
trezor: add #if for ByteSizeLong 
Turns out Ubuntu 18.04 ships with an old protobuf version.
 2021-06-27 23:43:36 +02:00
tobtoht
8a67724218
wallet_api: get bytes sent/received 2021-06-24 21:32:03 +02:00
selsta
e24875e572
simplewallet: don't truncate integ. address in export_transfers 2021-06-24 21:21:26 +02:00
luigi1111
14a1b89122
Merge pull request #7752 
4251cc0 unit_tests: check for ge_frombytes_vartime failure (moneromooo-monero)
67b97a5 easylogging++: do not delete uninitialized objects (moneromooo-monero)
7b6d959 trezor: fix potential use of uninitialized memory (moneromooo-monero)
 2021-06-24 14:13:19 -05:00
luigi1111
4f08d52dfa
Merge pull request #7750 
8e0b8dd wallet/api: remove Bitmonero namespace alias (selsta)
 2021-06-24 14:12:37 -05:00
luigi1111
0a9d218044
Merge pull request #7749 
e63c110 wallet_api: address_book: don't lose pid on setDescription (tobtoht)
 2021-06-24 14:11:45 -05:00
luigi1111
99aa45fd34
Merge pull request #7746 
1aa1850 wallet_api: signMessage: add sign with subaddress (tobtoht)
 2021-06-24 14:06:13 -05:00
luigi1111
7c3629a5ee
Merge pull request #7742 
f174a8f wallet_api: reconnectDevice (tobtoht)
 2021-06-24 14:05:35 -05:00
luigi1111
ce129599d0
Merge pull request #7739 
6914d5b wallet_api: move adjust_mixin call within try block (tobtoht)
 2021-06-24 14:04:42 -05:00
luigi1111
48e59b8064
Merge pull request #7672 
5bf91fc add documentation for monero-blockchain-stats (donkeydonkey)
 2021-06-24 14:03:03 -05:00
luigi1111
ad9956d987
Merge pull request #7634 
5a2edea db_lmdb: catch exceptions testing for mmap support (moneromooo-monero)
 2021-06-24 14:01:42 -05:00
luigi1111
f8abb225fc
Merge pull request #7633 
f6e2636 blockchain_db: harden code against invalid input types (moneromooo-monero)
 2021-06-24 14:00:59 -05:00
luigi1111
3366bd81eb
Merge pull request #7612 
254a133 core: speed up print_coinbase_tx_sum (moneromooo-monero)
 2021-06-24 13:59:44 -05:00
luigi1111
1796b44c67
Merge pull request #7611 
71741a1 blockchain_import: fix wrong reported block/tx hashes on error (moneromooo-monero)
 2021-06-24 13:59:12 -05:00
selsta
8ef51dc546
wallet_api: fix typo in exportKeyImages 2021-06-23 20:44:13 +02:00
moneromooo-monero
d689b946f9
protocol: fix delayed "you are now synchronized..." message 2021-06-21 15:37:40 +00:00
fdov
8ff21e1e84
doc: update IRC references to Libera 2021-06-20 21:44:45 +02:00
lza_menace
f0df72688f add singapore.node.xmr.pm to seed nodes 2021-06-18 11:14:03 -07:00
luigi1111
b63442da21
Merge pull request #7730 
e761577 provide key images of spent outputs in wallet rpc (woodser)
 2021-06-16 14:38:06 -05:00
woodser
e7615772fa provide key images of spent outputs in wallet rpc 2021-06-15 15:54:39 -04:00
mj-xmr
41297c10f0
CMake: strip targets (optional) with -D STRIP_TARGETS=ON 2021-06-11 21:19:37 +02:00
moneromooo-monero
7b6d959596
trezor: fix potential use of uninitialized memory 
CID 1446575
 2021-06-11 07:11:23 +00:00
luigi1111
7499837a6f
Merge pull request #7661 
08e4497 Improve cryptonote (block and tx) binary read performance (Lee Clagett)
 2021-06-10 12:00:54 -05:00
luigi1111
ca73284951
Merge pull request #7729 
b2e1558 support freeze, thaw, and frozen in wallet rpc (woodser)
 2021-06-10 11:47:05 -05:00
luigi1111
667d3dd4c2
Merge pull request #7684 
ed6f053 blockchain: speed up repeated pops (mostly in tests) (moneromooo-monero)
 2021-06-10 11:46:27 -05:00
luigi1111
a1a3e970f7
Merge pull request #7662 
4da1112 rpc: send confirmations in get_transactions result (moneromooo-monero)
 2021-06-10 11:34:20 -05:00
luigi1111
25bbb26f63
Merge pull request #7416 
b4fe7c2 epee linkage dynamic; move monero_add_library to main CMakeLists.txt (mj-xmr)
 2021-06-10 11:18:26 -05:00
selsta
8e0b8ddb96
wallet/api: remove Bitmonero namespace alias 2021-06-08 23:29:41 +02:00
tobtoht
e63c1107c0 wallet_api: address_book: don't lose pid on setDescription 2021-06-08 15:20:48 +02:00
tobtoht
8cf95c8f29 wallet2: refresh: check error and throw before potentially breaking out of loop 2021-06-04 18:37:06 +02:00
tobtoht
1aa1850ba5 wallet_api: signMessage: add sign with subaddress 2021-06-04 18:16:10 +02:00
tobtoht
d52d21bd46 ledger: don't lock for software device 2021-06-04 17:41:42 +02:00
tobtoht
f174a8f05f wallet_api: reconnectDevice 2021-06-04 15:24:53 +02:00
tobtoht
ce40c33a33 ledger: use software device if we have view key 2021-06-04 15:02:06 +02:00
tobtoht
8cea9d8605
wallet: Reset RPC Pay ID on node switch 
RPC pay client ID is sent with each RPC request, set a new secret every time we switch nodes to mitigate trivial correlation
 2021-06-04 13:58:09 +02:00
tobtoht
6914d5b914 wallet_api: move adjust_mixin call within try block 2021-06-04 13:41:10 +02:00
luigi1111
e31182918c
Merge pull request #7724 
44e8395 CMake: glob missing headers for wallet2 (mj-xmr)
 2021-06-01 22:10:19 -05:00
luigi1111
97436399eb
Merge pull request #7719 
da45d3f trezor: deprecated ByteSize -> ByteSizeLong (selsta)
 2021-06-01 22:09:26 -05:00
luigi1111
381f8f5e24
Merge pull request #7709 
a1c4307 Warnings: unused variable in core/blockchain.cpp (mj-xmr)
 2021-06-01 22:06:54 -05:00
luigi1111
d845a5a0c3
Merge pull request #7705 
581c3af Warnings: unused var at cryptonote_tx_utils.cpp (mj-xmr)
 2021-06-01 22:06:27 -05:00
woodser
b2e1558bde support freeze, thaw, and frozen in wallet rpc 2021-05-18 20:35:48 -04:00
mj-xmr
44e8395d2a
CMake: glob missing headers for wallet2 2021-05-14 14:22:29 +02:00
selsta
da45d3f5b3
trezor: deprecated ByteSize -> ByteSizeLong 2021-05-13 03:51:31 +02:00
luigi1111
fadc112aee
Merge pull request #7696 
0794811 cmake: set xcode file type (selsta)
 2021-05-12 17:02:34 -05:00
luigi1111
4fcbc584f0
Merge pull request #7694 
004b167 cmake: wallet_api doesn't need wallet_merged (selsta)
 2021-05-12 17:00:04 -05:00
luigi1111
b7ee587ddb
Merge pull request #7691 
cbd54ea cmake: set 3.5 as minimum version (selsta)
 2021-05-12 16:59:17 -05:00
luigi1111
c1a1f2a6ea
Merge pull request #7688 
451b5a5 clang: fix -Wrange-loop-analysis warnings (selsta)
 2021-05-12 16:57:32 -05:00
luigi1111
e505ffef5f
Merge pull request #7677 
445a9d8 wallet_api: import / export output function (tobtoht)
 2021-05-12 16:53:27 -05:00
luigi1111
628c04499b
Merge pull request #7682 
bbdb612 Wallet2: Update 'approximate_testnet_rolled_back_blocks' (rbrunner7)
 2021-05-12 15:30:34 -05:00
luigi1111
7d0927f8ad
Merge pull request #7681 
c57ef7f wallet2: Fix rescan_bc keep_ki option (Nathan Dorfman)
 2021-05-12 15:30:05 -05:00
luigi1111
a88e115c09
Merge pull request #7668 
2b91806 protocol: remove unreachable code (moneromooo-monero)
 2021-05-12 15:21:27 -05:00
luigi1111
066309cddb
Merge pull request #7664 
5871e7a net_node: add seed node (selsta)
 2021-05-11 18:04:49 -05:00
mj-xmr
a1c4307128
Warnings: unused variable in core/blockchain.cpp 2021-05-08 12:04:19 +02:00
mj-xmr
581c3af03a
Warnings: unused var at cryptonote_tx_utils.cpp 2021-05-02 18:00:29 +02:00
selsta
7359d51d56
cmake: fix non portable code 2021-04-28 17:05:59 +02:00
selsta
0794811b40
cmake: set xcode file type 2021-04-28 14:49:13 +02:00
selsta
004b167095
cmake: wallet_api doesn't need wallet_merged 2021-04-27 14:36:56 +02:00
selsta
cbd54ea524
cmake: set 3.5 as minimum version 2021-04-27 11:02:05 +02:00
selsta
451b5a510e
clang: fix -Wrange-loop-analysis warnings 2021-04-27 05:30:27 +02:00
moneromooo-monero
ed6f05357c
blockchain: speed up repeated pops (mostly in tests) 
The heavy rolling median reset only has to be performed after
all blocks are popped
 2021-04-26 14:07:35 +00:00
rbrunner7
bbdb612b51 Wallet2: Update 'approximate_testnet_rolled_back_blocks' 2021-04-25 10:20:39 +02:00
mj-xmr
b4fe7c2401 epee linkage dynamic; move monero_add_library to main CMakeLists.txt 2021-04-24 09:45:51 +02:00
Nathan Dorfman
c57ef7f807 wallet2: Fix rescan_bc keep_ki option 2021-04-23 09:11:45 -06:00
luigi1111
0a1ddc2eff
Merge pull request #7669 
679d055 Remove payload copy in all outgoing p2p messages (Lee Clagett)
 2021-04-22 01:51:01 -04:00
luigi1111
9bba3f4767
Merge pull request #7651 
c8ff1d4 monero-wallet-cli: improve error message when tx amount is zero (Elliot Wirrick)
 2021-04-22 01:35:20 -04:00
tobtoht
445a9d8ba3
wallet_api: import / export output function 2021-04-22 04:26:17 +02:00
donkeydonkey
5bf91fc894
add documentation for monero-blockchain-stats 2021-04-19 20:54:44 +02:00
moneromooo-monero
2b918068cc
protocol: remove unreachable code 2021-04-17 15:22:26 +00:00
mj-xmr
dc81e23e60 Split epee/string_tools.h and encapsulate boost::lexical_cast 2021-04-16 20:54:20 +02:00
luigi1111
e45619e61e Revert "Merge pull request #7136" 
This reverts commit 63c7ca07fb, reversing
changes made to 2218e23e84.
 2021-04-16 13:52:44 -05:00
luigi1111
13418dbb98
Merge pull request #7648 
25e8254 expose set_offline to wallet api (benevanoff)
 2021-04-16 12:51:22 -05:00
luigi1111
288e5ec350
Merge pull request #7384 
494f2e1 rpc: fix some error return codes/status (moneromooo-monero)
 2021-04-16 12:48:05 -05:00
luigi1111
7cf47d754c
Merge pull request #7258 
1d1c430 p2p: fix cubic selection in filtered peer list (moneromooo)
 2021-04-16 12:46:34 -05:00
luigi1111
63c7ca07fb
Merge pull request #7136 
23aae55 Remove payload copy in all outgoing p2p messages (Lee Clagett)
 2021-04-16 12:45:30 -05:00
luigi1111
2218e23e84
Merge pull request #7002 
673c6d2 Reduce compilation time of epee/portable_storage_template_helper.h (mj-xmr)
 2021-04-16 12:43:42 -05:00
selsta
5871e7ab19
net_node: add seed node 2021-04-16 03:22:16 +02:00
moneromooo-monero
4da1112967
rpc: send confirmations in get_transactions result 
if the wallet does it, it would get a wrong result (possibly even
negative) if its local chain is not synced up to the daemon's yet
 2021-04-15 15:31:52 +00:00
Elliot Wirrick
c8ff1d4d23 monero-wallet-cli: improve error message when tx amount is zero 2021-04-07 10:10:16 -04:00
luigi1111
2098941ca0
Merge pull request #7635 
447bfae wallet2: fix unlocked mixup in light wallet mode (moneromooo-monero)
 2021-04-06 12:23:45 -05:00
luigi1111
3c69596bc9
Merge pull request #7321 
f9b5b52 fix serialization being different on mac (moneromooo-monero)
 2021-04-06 12:20:15 -05:00
benevanoff
25e82545f3 expose set_offline to wallet api 2021-04-05 13:41:04 -05:00
moneromooo-monero
57edfd78fd
p2p: allow CIDR notation in DNS blocklist 2021-03-30 08:57:04 +00:00
luigi1111
e1d987aa66
Merge pull request #7430 
064eeb2 wallet_rpc_server: set seed language in generate_from_keys (moneromooo-monero)
 2021-03-29 22:37:19 -04:00
luigi1111
b12e195fba
Merge pull request #7620 
fe63256 cryptonote_protocol_handler: fix race condition (anon)
ded2f3a cryptonote_protocol_handler: add race condition demo (anon)
 2021-03-29 21:55:11 -04:00
luigi1111
1a8b6ba8c0
Merge pull request #7542 
7c4e4c7 wallet_api: add isDeterministic() (tobtoht)
 2021-03-29 21:50:53 -04:00
luigi1111
0607a10696
Merge pull request #7538 
1851f26 wallet_api: add seed_offset param to seed() (tobtoht)
 2021-03-29 21:47:40 -04:00
luigi1111
247db4e304
Merge pull request #7373 
86263b3 Honor LARGE_PAGES flag in randomx umask (Howard Chu)
 2021-03-29 21:41:56 -04:00
luigi1111
ac091fb539
Merge pull request #7358 
f346e3e wallet_rpc_payments: implement multithreading (gdmojo)
 2021-03-29 21:10:48 -04:00
luigi1111
c2bc829cca
Merge pull request #7326 
cf266d6 bootstrap_daemon: proxy configuration support (xiphon)
 2021-03-29 21:08:36 -04:00
luigi1111
8c8197463f
Merge pull request #7310 
76fe73b Revert 'fix accessing an network address in a deleted context' (selsta)
 2021-03-29 21:08:03 -04:00
luigi1111
1cd1206332
Merge pull request #7238 
aa3e89a p2p: fix set_peer_just_seen ignoring last_seen (moneromooo)
 2021-03-29 21:06:03 -04:00
luigi1111
cf1a95b67d
Merge pull request #7088 
386ef03 Add TLSA support to DNSSEC fetching (Lee Clagett)
 2021-03-29 21:05:00 -04:00
mj-xmr
673c6d2d11 Reduce compilation time of epee/portable_storage_template_helper.h 2021-03-28 15:41:48 +02:00
moneromooo-monero
447bfae2a4
wallet2: fix unlocked mixup in light wallet mode 2021-03-25 09:33:40 +00:00
moneromooo-monero
5a2edea16b
db_lmdb: catch exceptions testing for mmap support 
Turns out at least one arch (armel based) does not have unique_path
implemented and throws
 2021-03-25 09:24:45 +00:00
moneromooo-monero
f6e2636493
blockchain_db: harden code against invalid input types 
If an invalid input type were to get to this, the code could
remove key images that might be present already in the chain,
which could allow a double spend, even if this is impossible
with the current code.

Reported by KeyboardWarrior.
 2021-03-24 21:43:57 +00:00
anon
fe632560f4
cryptonote_protocol_handler: fix race condition 2021-03-22 19:42:46 +00:00
luigi1111
5b8d714a4b
Merge pull request #7422 
d46d90c return output key for incoming transfers (benevanoff)
 2021-03-20 01:57:44 -04:00
luigi1111
42987f93f4
Merge pull request #7418 
68f1ca6 trezor: simplify recognition of integrated addresses (Dusan Klinec)
 2021-03-20 01:53:03 -04:00
luigi1111
e04e208141
Merge pull request #7412 
6477b47 wallet_rpc: add scan_tx (tobtoht)
 2021-03-20 01:47:44 -04:00
luigi1111
602926fe9d
Merge pull request #7366 
9867a91 Store RPC SSL key/cert for consistent authentication between runs (Lee Clagett)
 2021-03-20 01:38:03 -04:00
luigi1111
8d7c1135b8
Merge pull request #6810 
19b2283 New add_aux_pow RPC to support merge mining (moneromooo-monero)
 2021-03-20 01:33:10 -04:00
moneromooo-monero
71741a1ed6
blockchain_import: fix wrong reported block/tx hashes on error 2021-03-19 11:04:24 +00:00
moneromooo-monero
254a1338ad
core: speed up print_coinbase_tx_sum 
It only needs to parse the tx headers, not the full tx data
 2021-03-18 11:16:08 +00:00
tobtoht
7c4e4c7603
wallet_api: add isDeterministic() 2021-03-12 23:43:58 +01:00
tobtoht
1851f2645a
wallet_api: add seed_offset param to seed() 2021-03-12 19:45:29 +01:00
moneromooo-monero
064eeb2861
wallet_rpc_server: set seed language in generate_from_keys 
Also sanity check language name
 2021-03-06 10:26:15 +00:00
moneromooo-monero
f9b5b521e8
fix serialization being different on mac 
On Mac, size_t is a distinct type from uint64_t, and some
types (in wallet cache as well as cold/hot wallet transfer
data) use pairs/containers with size_t as fields. Mac would
save those as full size, while other platforms would save
them as varints. Might apply to other platforms where the
types are distinct.

There's a nasty hack for backward compatibility, which can
go after a couple forks.
 2021-03-05 23:42:33 +00:00
luigi1111
e01894672b
Merge pull request #7335 
8d03bb6 device_trezor: add redundant check (anon)
34f9428 device_trezor: wipe string fields properly (anon)
 2021-03-05 13:52:01 -05:00
benevanoff
d46d90c436 return output key for incoming transfers 2021-03-04 11:09:15 -06:00
Dusan Klinec
68f1ca65e6
trezor: simplify recognition of integrated addresses 
now it is possible to simplify integrated addresses recognition using transaction destination info directly
fixes https://github.com/monero-project/monero-gui/issues/3346
 2021-03-03 14:51:04 +01:00
tobtoht
6477b47ac7 wallet_rpc: add scan_tx 2021-03-01 23:02:43 +01:00
gdmojo
f346e3ec0e wallet_rpc_payments: implement multithreading 2021-02-20 18:23:06 +00:00
luigi1111
6556c33f13
Merge pull request #7355 
bd12984 Remove copies from foreach loops (thanks to Clang) (Lee Clagett)
1572df9 Removing unused namespace alias (Lee Clagett)
 2021-02-18 14:06:47 -05:00
luigi1111
ce5800a225
Merge pull request #7346 
85db173 Remove unused variables in monero codebase (Kevin Barbour)
 2021-02-18 14:03:31 -05:00
luigi1111
0e35d46f5e
Merge pull request #7341 
b587ffa Stop adding more outputs than bulletproof allows (Alex Opie)
 2021-02-18 14:02:13 -05:00
luigi1111
98cb68e5a7
Merge pull request #7340 
ccd0f2b Simplewallet.cpp: Add export_outputs help (SomaticFanatic)
 2021-02-18 14:01:29 -05:00
luigi1111
3f55f7df31
Merge pull request #7312 
186271e monero-wallet-cli: Added command scan_tx (Horia Mihai David)
 2021-02-18 14:00:35 -05:00
Horia Mihai David
186271e5d1 monero-wallet-cli: Added command scan_tx 
To implement this feature, the wallet2::scan_tx API was implemented.
 2021-02-17 20:25:55 +01:00
luigi1111
3328938d4e
Merge pull request #7319 
993e9be simplewallet: allow setting --restore-height 0 (selsta)
 2021-02-16 11:42:14 -05:00
luigi1111
2222d90491
Merge pull request #7294 
f10c9a1 remove obsolete pruning debug code (moneromooo-monero)
 2021-02-15 21:51:12 -05:00
luigi1111
bf53f55366
Merge pull request #7288 
015da03 wallet_rpc_server: don't abort on initial refresh failure (xiphon)
 2021-02-15 21:50:34 -05:00
luigi1111
0bbaa9df81
Merge pull request #7275 
f815740 p2p: make REQUEST_SUPPORT_FLAGS optional, pass flags in node data (moneromooo-monero)
 2021-02-15 21:48:48 -05:00
luigi1111
080358ebef
Merge pull request #7273 
e7f5845 Only INFO log for short seed words with ALLOW_SHORT_WORDS active (rbrunner7)
 2021-02-15 21:47:55 -05:00
luigi1111
f11e434ae6
Merge pull request #7265 
bdabcd0 wallet_api: store fee for incoming txs in history (Ben Evanoff)
 2021-02-15 21:46:22 -05:00
luigi1111
7c6db2fed1
Merge pull request #7252 
f208d98 p2p: ignore empty IP from DNS block list (moneromooo-monero)
 2021-02-15 21:45:46 -05:00
luigi1111
7439d891bf
Merge pull request #7242 
021a281 simplewallet: Add input file parameter to sign_transfer (Steff Richards)
 2021-02-15 21:44:53 -05:00
luigi1111
ba76a4d26e
Merge pull request #7185 
50ff106 wallet api: allow wallet to fetch all key images via api (benevanoff)
 2021-02-15 21:42:30 -05:00
luigi1111
4c410a1e3a
Merge pull request #7000 
dc48de7 Reduce compilation time of epee/portable_storage.h (mj-xmr)
 2021-02-15 21:39:05 -05:00
luigi1111
4ee301c687
Merge pull request #6986 
ee58f4f Balance includes unconfirmed payments (woodser)
 2021-02-15 21:36:48 -05:00
moneromooo-monero
d643a865f3
p2p: add --max-connections-per-ip daemon option 
Helps daemons behind a proxy get more than one connection.
Defaults to 1 (no change)
 2021-02-15 19:08:07 +00:00
moneromooo-monero
494f2e1c21
rpc: fix some error return codes/status 
Some RPC return an error string in status, and the code must return
true on error (with a status string).
 2021-02-15 12:27:19 +00:00
luigi1111
c41e087d46
Merge pull request #6900 
aaa3289 add more updates domains and make the voting generic, not just 2/3 (moneromooo-monero)
 2021-02-14 18:58:37 -05:00
Lee Clagett
9867a913dc Store RPC SSL key/cert for consistent authentication between runs 2021-02-13 20:26:26 +00:00
Howard Chu
86263b386c
Honor LARGE_PAGES flag in randomx umask 2021-02-11 14:42:49 +00:00
moneromooo-monero
19b228393f
New add_aux_pow RPC to support merge mining 2021-02-09 11:58:21 +00:00
Kevin Barbour
85db1734e7
Remove unused variables in monero codebase 
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.

In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
 2021-02-09 08:05:05 +01:00
mj-xmr
dc48de74e8 Reduce compilation time of epee/portable_storage.h 2021-02-06 08:18:42 +01:00
Lee Clagett
bd129849f0 Remove copies from foreach loops (thanks to Clang) 2021-01-28 23:42:40 -05:00
Lee Clagett
1572df9e26 Removing unused namespace alias 2021-01-28 23:40:57 -05:00
Lee Clagett
2a20434705 Fix monerod --rpc-ssl disabled 2021-01-28 17:53:47 +00:00
Alex Opie
520ce1ca81 Attempt to carve the fee from a partial payment early 
Do this for both the estimate and actual fee.

#7337
 2021-01-25 12:01:27 +13:00
Alex Opie
b587ffa1fd Stop adding more outputs than bulletproof allows 
If more outputs are requested, they are split across
multiple transactions.

#7322
 2021-01-25 10:01:38 +13:00
Lee Clagett
08e4497c6e Improve cryptonote (block and tx) binary read performance 2021-01-23 06:23:39 +00:00
SomaticFanatic
ccd0f2bdc2 Simplewallet.cpp: Add export_outputs help 
See #6547
 2021-01-21 18:39:43 -05:00
xiphon
cf266d66dd bootstrap_daemon: proxy configuration support 2021-01-21 13:45:44 +00:00
anon
8d03bb688e device_trezor: add redundant check 2021-01-20 22:06:51 +01:00
anon
34f942867f device_trezor: wipe string fields properly 2021-01-20 22:06:51 +01:00
Lee Clagett
679d05567d Remove payload copy in all outgoing p2p messages 2021-01-19 02:22:32 +00:00
Lee Clagett
23aae5571b Remove payload copy in all outgoing p2p messages 2021-01-16 22:53:28 +00:00
luigi1111
cb70ae9450
Merge pull request #7260 
c5c278c p2p: only log to global when a blocked IP is not already blocked (moneromooo-monero)
 2021-01-15 23:52:05 -05:00
luigi1111
8cb9f3cd80
Merge pull request #7240 
46cc4a2 Header row for peer list in sync_info (Denis Goddard)
 2021-01-15 23:50:28 -05:00
luigi1111
1f3f07d0e7
Merge pull request #7236 
ab5e185 protocol: fix wrong command in logs (moneromooo-monero)
 2021-01-15 23:49:34 -05:00
luigi1111
d259ed0740
Merge pull request #7119 
dd5e689 protocol: add calls to reserve where appropriate (moneromooo-monero)
 2021-01-15 23:45:25 -05:00
luigi1111
d01f31460e
Merge pull request #7113 
7f30c49 simplewallet: don't complain about connecting to the daemon when offline (moneromooo-monero)
 2021-01-15 23:44:32 -05:00
luigi1111
5c497ed22f
Merge pull request #7112 
47590fc rpc: report target height as 0 when synced (moneromooo-monero)
 2021-01-15 23:43:46 -05:00
selsta
993e9be669
simplewallet: allow setting --restore-height 0 2021-01-13 12:36:58 +01:00
selsta
76fe73b8bd
Revert "fix accessing an network address in a deleted context" 
This reverts commit 4e74385a1a.
 2021-01-12 12:18:23 +01:00
moneromooo-monero
f10c9a16c4
remove obsolete pruning debug code 2021-01-08 15:41:59 +00:00
Alexander Blair
747699541e
Merge pull request #7285 
927141bcc Command max_bytes moved from dynamic map to static switch (Lee Clagett)
 2021-01-07 17:54:02 -08:00
xiphon
015da03a6f wallet_rpc_server: don't abort on initial refresh failure 2021-01-07 13:38:15 +00:00
luigi1111
69e4a2c62d
Merge pull request #7266 
38a6e6e protocol: handle receiving a block hash we've not added yet (moneromooo-monero)
 2021-01-06 21:09:03 -05:00
moneromooo-monero
f815740403
p2p: make REQUEST_SUPPORT_FLAGS optional, pass flags in node data 
removes a back and forth on connect, and the RPC can be removed
once all peers have updated
 2021-01-04 13:33:34 +00:00
Alexander Blair
dbaf95ac77
Merge pull request #7271 
4e74385a1 fix accessing an network address in a deleted context (moneromooo-monero)
 2021-01-03 18:24:50 -08:00
Alexander Blair
71f7d4e71e
Merge pull request #7268 
1e27f7101 blockchain: lock access to m_blocks_hash_of_hashes (moneromooo-monero)
 2021-01-03 18:24:22 -08:00
moneromooo-monero
b652d598d1
add a max levin packet size by command type 2021-01-03 14:07:45 +00:00
moneromooo-monero
4e74385a1a
fix accessing an network address in a deleted context 
Both drop_connection and add_host_fail can drop the connection,
which invalidates the context, and thus the address it contains.

Thanks to wfaressuissia[m] for lots of help and prodding when
debugging this
 2021-01-03 13:04:55 +00:00
rbrunner7
e7f5845ce8 Only INFO log for short seed words with ALLOW_SHORT_WORDS active 2021-01-03 11:04:53 +01:00
moneromooo-monero
1e27f7101e
blockchain: lock access to m_blocks_hash_of_hashes 
it is accessed both when adding and when prevalidating a set
of new hashes from a peer
 2021-01-02 22:19:54 +00:00
moneromooo-monero
38a6e6eb26
protocol: handle receiving a block hash we've not added yet 2021-01-02 22:10:31 +00:00
Ben Evanoff
bdabcd01b7
wallet_api: store fee for incoming txs in history 2021-01-02 13:56:57 -06:00
Alexander Blair
16c780d568
Merge pull request #7250 
61b6e4cc6 Add aggressive restrictions to pre-handshake p2p buffer limit (Lee Clagett)
 2021-01-01 22:35:59 -08:00
Alexander Blair
3bf0721ae6
Merge pull request #7246 
0aa541b36 protocol: more sanity checks in new chain block hashes (moneromooo-monero)
 2021-01-01 22:33:27 -08:00
Alexander Blair
2d60232355
Merge pull request #7237 
656b2f7ce p2p: fix deadlock banning while updating peer lists (moneromooo)
 2021-01-01 22:32:34 -08:00
moneromooo-monero
c5c278c339
p2p: only log to global when a blocked IP is not already blocked 2021-01-01 19:54:51 +00:00
moneromooo
1d1c430b1f
p2p: fix cubic selection in filtered peer list 
Integer quantization biased the picks a lot (leading some indices
to never be selected)
 2021-01-01 15:44:36 +00:00
moneromooo-monero
f208d98492
p2p: ignore empty IP from DNS block list 
ie, if the list ends in ;
 2021-01-01 12:30:45 +00:00
Denis Goddard
46cc4a253b Header row for peer list in sync_info 2020-12-31 20:09:35 -05:00
moneromooo-monero
0aa541b361
protocol: more sanity checks in new chain block hashes 2020-12-31 23:33:18 +00:00
Steff Richards
021a28137d simplewallet: Add input file parameter to sign_transfer 2020-12-31 16:54:01 +01:00
moneromooo
aa3e89a2ba
p2p: fix set_peer_just_seen ignoring last_seen 2020-12-31 03:10:10 +00:00
moneromooo
656b2f7ce1
p2p: fix deadlock banning while updating peer lists 2020-12-31 03:09:37 +00:00
moneromooo-monero
ab5e185140
protocol: fix wrong command in logs 
this is not a levin packet, this is just its payload
 2020-12-30 21:08:28 +00:00
moneromooo-monero
31c69923ba
protocol: don't reset last request time on an idle timer 
this prevents losing time of "idle time" for a peer, which could
otherwise be reset by another timed sync command from the peer
 2020-12-30 14:22:10 +00:00
moneromooo-monero
1eb14af1a3
rpc: limit the number of txes for get_blocks.bin 2020-12-29 04:31:58 +00:00
Alexander Blair
2bccbeecb3
Merge pull request #7205 
bcdc6c62b protocol: fix false positives dropping peers (moneromooo-monero)
 2020-12-28 11:39:01 -08:00
Alexander Blair
faaec08fa4
Merge pull request #7196 
4310780c0 cryptonote_basic: guess what got lost porting patches to branches again (moneromooo-monero)
 2020-12-28 11:38:07 -08:00
moneromooo-monero
bcdc6c62b7
protocol: fix false positives dropping peers 
it'd trigger on reorgs
 2020-12-27 14:41:19 +00:00
luigi1111
025db3d2b4
Revert "Reject existing claimed blocks in sync mode" 2020-12-27 00:18:05 -05:00
moneromooo-monero
4310780c08
cryptonote_basic: guess what got lost porting patches to branches again 2020-12-26 23:43:59 +00:00
Alexander Blair
d61fdebaac
Merge pull request #7188 
efe83982d protocol: drop nodes if they claim new data but only give stale data (moneromooo-monero)
 2020-12-26 13:43:13 -08:00
Alexander Blair
5402121323
Merge pull request #7180 
56748e1d7 ban lists may now include subnets (moneromooo-monero)
 2020-12-26 13:42:37 -08:00
Alexander Blair
d06bae56b3
Merge pull request #7173 
d2fda6c25 restrict public node checks a little (moneromooo-monero)
 2020-12-26 13:41:42 -08:00
Alexander Blair
609dbe6b92
Merge pull request #7154 
cf7e1571d protocol: reject claimed block hashes that already are in the chain (moneromooo-monero)
af0a25544 protocol: drop peers we can't download anything from in sync mode (moneromooo-monero)
 2020-12-26 13:40:36 -08:00
Alexander Blair
cb712bf4f8
Merge pull request #7145 
68637bca3 p2p: remove peers from grey and anchors lists when blocked (moneromooo-monero)
 2020-12-26 13:40:19 -08:00
Alexander Blair
69ed0e0001
Merge pull request #7138 
e9abfea16 Optional DNS based blocklist (moneromooo-monero)
 2020-12-26 13:38:50 -08:00
Alexander Blair
b9e444da5e
Merge pull request #7098 
c0c75ac19 Fixed issues found by static analysis (SChernykh)
 2020-12-26 13:36:01 -08:00
Alexander Blair
133056f625
Merge pull request #7086 
14bc5c095 db_lmdb: move spammy "not found in db" message to TRACE (moneromooo-monero)
 2020-12-26 13:35:42 -08:00
Alexander Blair
d365f2409a
Merge pull request #6931 
fbb03ef2a simplewallet: add "address mnew" command (codesoap)
 2020-12-26 13:35:24 -08:00
codesoap
fbb03ef2a0 simplewallet: add "address mnew" command 2020-12-26 19:33:11 +01:00
moneromooo-monero
efe83982d3
protocol: drop nodes if they claim new data but only give stale data 
Some joker is spending time actually doing this
 2020-12-25 20:30:39 +00:00
benevanoff
50ff1066f5 wallet api: allow wallet to fetch all key images via api 2020-12-25 00:40:50 -06:00
moneromooo-monero
d2fda6c25f
restrict public node checks a little 
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
 2020-12-22 23:39:07 +00:00
Lee Clagett
927141bcc4 Command max_bytes moved from dynamic map to static switch 2020-12-22 20:54:16 +00:00
moneromooo-monero
56748e1d74
ban lists may now include subnets 2020-12-22 02:12:41 +00:00
moneromooo-monero
e9abfea165
Optional DNS based blocklist 
If enabled, pulls IPs to block on blocklist.moneropulse.*, and
blocks then for 8 days (so IPs dropping from the list will
eventually get unblocked, and DNS failures don't result in
instant clearing of the blocklist).

Enable with --enable-dns-blocklist
 2020-12-20 02:09:58 +00:00
luigi1111
0dac64afb3
Merge pull request #7143 
58651d1 p2p: ignore incoming peer list entries when we have them blocked (moneromooo-monero)
 2020-12-19 17:24:21 -06:00
luigi1111
e0d8af253e
Merge pull request #7141 
9de3787 daemon: the ban command can now load IPs from a file (ban @filename) (moneromooo-monero)
 2020-12-19 17:22:01 -06:00
luigi1111
7ee37e4b38
Merge pull request #7075 
f3c0d4f protocol: remove unused (and cunningly uninitialized) field (moneromooo-monero)
8e62362 p2p: ifx getting seed nodes for uncommon cases (moneromooo-monero)
 2020-12-19 17:20:29 -06:00
moneromooo-monero
5a1ac9c0ef
rpc: add a busy_syncing field to get_info 
true if and pretty much only if new blocks are being added
 2020-12-17 18:03:11 +00:00
moneromooo-monero
cf7e1571d3
protocol: reject claimed block hashes that already are in the chain 2020-12-17 02:54:02 +00:00
Lee Clagett
61b6e4cc67 Add aggressive restrictions to pre-handshake p2p buffer limit 2020-12-17 00:36:10 +00:00
moneromooo-monero
af0a25544e
protocol: drop peers we can't download anything from in sync mode 
instead of the (incorrect) check for whether we think we might have
a user for it at some point in the near future. We can reconnect.
 2020-12-16 20:19:52 +00:00
moneromooo-monero
f3c0d4f9df
protocol: remove unused (and cunningly uninitialized) field 2020-12-15 01:32:18 +00:00
moneromooo-monero
8e62362cd3
p2p: ifx getting seed nodes for uncommon cases 
The code is technically correct, but liable to easily become incorrect with changes
 2020-12-15 01:32:15 +00:00
moneromooo-monero
9de3787c47
daemon: the ban command can now load IPs from a file (ban @filename) 2020-12-14 12:26:23 +00:00
moneromooo-monero
68637bca3f
p2p: remove peers from grey and anchors lists when blocked 2020-12-13 23:27:44 +00:00
moneromooo-monero
58651d16c0
p2p: ignore incoming peer list entries when we have them blocked 2020-12-13 23:14:05 +00:00
luigi1111
e5decd0cde
Merge pull request #7130 
543733d protocol: include first new block in chain entry response (moneromooo-monero)
 2020-12-12 22:05:02 -06:00
luigi1111
a57c95b2f1
Merge pull request #7127 
5d1849a protocol: stricter checks on received chain hash list (moneromooo)
 2020-12-12 22:03:12 -06:00
moneromooo-monero
543733d42c
protocol: include first new block in chain entry response 2020-12-12 01:36:35 +00:00
moneromooo
5d1849a9eb
protocol: stricter checks on received chain hash list 2020-12-11 18:47:40 +00:00
moneromooo-monero
62e8ca5eaf
protocol: revert incoming chain height check against local chain 
We can actually request a chain that's further away from what we
have as we buffer more and more
 2020-12-11 02:37:15 +00:00
Alexander Blair
0f67569279
Merge pull request #7121 
cd7e9769d protocol: one more sanity check on usable data from a peer (moneromooo-monero)
 2020-12-10 17:44:54 -08:00
Alexander Blair
bdaadf85dc
Merge pull request #7117 
5dee031b2 protocol: add a sanity check to the number of block hashes sent (moneromooo-monero)
 2020-12-10 17:43:41 -08:00
Alexander Blair
bb6d2d4b05
Merge pull request #7114 
eb77790df protocol: fix asking for pruned blocks for v10 (moneromooo-monero)
 2020-12-10 17:42:48 -08:00
Alexander Blair
28e5e42986
Merge pull request #7110 
d660f22ed protocol: drop origin IP if a block fails to verify in sync mode (moneromooo-monero)
 2020-12-10 17:41:59 -08:00
Alexander Blair
5b62a6f316
Merge pull request #7106 
0f34cabb9 protocol: more restrictive checks on chain entry response (moneromooo-monero)
 2020-12-10 17:40:46 -08:00
Alexander Blair
1e9483a2d5
Merge pull request #7009 
7414e2bac Change epee binary output from std::stringstream to byte_stream (Lee Clagett)
 2020-12-10 17:34:50 -08:00
moneromooo-monero
cd7e9769d8
protocol: one more sanity check on usable data from a peer 2020-12-10 23:02:06 +00:00
moneromooo-monero
d660f22ed1
protocol: drop origin IP if a block fails to verify in sync mode 
It would otherwise be possible for a peer to send bad blocks,
then disconnect and reconnect again, escaping bans
 2020-12-10 21:59:18 +00:00
moneromooo-monero
dd5e689533
protocol: add calls to reserve where appropriate 2020-12-10 20:47:35 +00:00
moneromooo-monero
5dee031b25
protocol: add a sanity check to the number of block hashes sent 2020-12-10 19:26:12 +00:00
moneromooo-monero
eb77790dfb
protocol: fix asking for pruned blocks for v10 
Old format is still alloewd there, this is a two fork update
 2020-12-10 18:10:45 +00:00
moneromooo-monero
7f30c49731
simplewallet: don't complain about connecting to the daemon when offline 2020-12-10 17:57:13 +00:00
moneromooo-monero
0f34cabb98
protocol: more restrictive checks on chain entry response 2020-12-10 17:23:50 +00:00
moneromooo-monero
47590fc80b
rpc: report target height as 0 when synced 
since it only makes sense when syncing, and it confuses people
 2020-12-10 17:05:34 +00:00
moneromooo-monero
19f77578e0
protocol: fix switchting to adding blocks if noone's adding the next span 2020-12-10 15:46:48 +00:00
SChernykh
c0c75ac19d Fixed issues found by static analysis 
- rolling_median: tried to free uninitialized pointer in a constructor
- net_node.inl: erase-remove idiom was used incorrectly. remove_if doesn't actually remove elements, see http://cpp.sh/6fcjv
- bulletproofs.cc: call to sizeof() instead of vector.size(), luckily it only impacts performance and not code logic there
 2020-12-08 18:43:44 +01:00
luigi1111
b7425c14c8
Merge pull request #7072 
bc7cd78 p2p: drop peers that spam peer lists (moneromooo-monero)
 2020-12-07 10:24:30 -06:00
luigi1111
fb73f2b2be
Merge pull request #7070 
281b42a p2p: fix race condition accessing a deleted context (moneromooo-monero)
 2020-12-07 10:23:24 -06:00
luigi1111
3d2a50a5c0
Merge pull request #7055 
ff7fdf6 protocol: drop peers that don't reply to queries (moneromooo-monero)
89e984d keep only the last seen node on a given host in the white list (moneromooo-monero)
c74d8ff protocol: drop peers that decrease claimed height (moneromooo-monero)
61f5001 protocol: add scoring system to drop peers that don't behave (moneromooo-monero)
 2020-12-07 10:07:33 -06:00
moneromooo
ff7fdf6db2
protocol: drop peers that don't reply to queries 2020-12-06 15:57:40 +00:00
moneromooo-monero
281b42a281
p2p: fix race condition accessing a deleted context 2020-12-06 12:40:07 +00:00
moneromooo-monero
14bc5c095c
db_lmdb: move spammy "not found in db" message to TRACE 
These are functions that check whether a tx is in the db, so whether
it is there or not is really not interesting, and it seems to scare
people from time to time
 2020-12-06 01:46:21 +00:00
moneromooo-monero
bc7cd78870
p2p: drop peers that spam peer lists 
There's always some people who just want to abuse things
 2020-12-05 13:12:58 +00:00
Alexander Blair
7ca4ef0d74
Merge pull request #7068 
2395e0e67 p2p: add a tor seed node (moneromooo-monero)
 2020-12-04 13:28:02 -08:00
Alexander Blair
42aa1a6aca
Merge pull request #7062 
5ed604fe5 crypto: fix non zero scalar being 0 after reducing (moneromooo-monero)
 2020-12-04 13:27:05 -08:00
Alexander Blair
6b8db83149
Merge pull request #7043 
17c537039 wallet2: check imported multisig curve points are in main subgroup (Crypto City)
 2020-12-04 13:25:01 -08:00
Alexander Blair
ce564e7ebf
Merge pull request #7030 
0363476ee rpc: get_info - add 'synchronized' field (xiphon)
 2020-12-04 13:21:36 -08:00
Alexander Blair
1eae7574b5
Merge pull request #7017 
13350f79d Do not use peer_id tracking method over i2p/tor (Lee Clagett)
 2020-12-04 13:21:13 -08:00
moneromooo
89e984d93b
keep only the last seen node on a given host in the white list 2020-12-04 01:55:22 +00:00
moneromooo
c74d8ffd63
protocol: drop peers that decrease claimed height 2020-12-04 01:55:22 +00:00
moneromooo
61f5001c3f
protocol: add scoring system to drop peers that don't behave 2020-12-04 01:55:21 +00:00
moneromooo-monero
5ed604fe5b
crypto: fix non zero scalar being 0 after reducing 2020-12-04 01:00:03 +00:00
moneromooo-monero
2395e0e678
p2p: add a tor seed node 2020-12-03 23:45:38 +00:00
Alexander Blair
f83203ecef
Merge pull request #7058 
89bbb802c wallet2: set propagation timeout to current max timeout (selsta)
 2020-12-03 12:19:39 -08:00
Alexander Blair
e78669257e
Merge pull request #7056 
c64b94bd1 p2p: fix endianness when checking IPv6 addresses mapping to IPv4 (moneromooo-monero)
67f2bec2d p2p: make this work with boost <= 1.65 (pffff) (moneromooo-monero)
ffdf1fb1d p2p: rewrite boost's make_address_v4 to cater for < 1.66 (moneromooo)
 2020-12-03 12:19:15 -08:00
Alexander Blair
84bae315f8
Merge pull request #6984 
7a5e11645 net_node: add tor / i2p seed nodes (selsta)
 2020-12-03 12:17:44 -08:00
selsta
89bbb802c0
wallet2: set propagation timeout to current max timeout 2020-12-03 02:18:58 +01:00
moneromooo-monero
c64b94bd14
p2p: fix endianness when checking IPv6 addresses mapping to IPv4 2020-12-03 00:31:32 +00:00
moneromooo-monero
67f2bec2df
p2p: make this work with boost <= 1.65 (pffff) 2020-12-03 00:31:32 +00:00
moneromooo
ffdf1fb1de
p2p: rewrite boost's make_address_v4 to cater for < 1.66 2020-12-03 00:31:29 +00:00
Alexander Blair
4f401f6fca
Merge pull request #7025 
b10878f10 Change Dandelion++ fluff probability to 20%, and embargo timeout to 39s (Lee Clagett)
 2020-12-01 14:23:49 -08:00
Alexander Blair
976fcb5985
Merge pull request #7024 
aaf837cf5 rpc: skip non-synced bootstrap daemons in --no-sync mode too (xiphon)
 2020-12-01 14:23:21 -08:00
Alexander Blair
f41dce49ac
Merge pull request #6954 
dff1d8067 Fix tx flush callback queueing (Lee Clagett)
 2020-12-01 14:22:16 -08:00
Alexander Blair
7cd0c64210
Merge pull request #6948 
65903d2cf Add rpc-restricted-bind-ip option (Howard Chu)
 2020-12-01 14:21:19 -08:00
Alexander Blair
431ec528bc
Merge pull request #6939 
6c9980a55 p2p: give all hosts the same chance of being picked for connecting (moneromooo)
 2020-12-01 14:20:02 -08:00
Alexander Blair
003a06f030
Merge pull request #6923 
cc034fe0c util: fix escaping more than one ?* in glob_to_regex (moneromooo-monero)
 2020-12-01 14:19:21 -08:00
Alexander Blair
d8f9472356
Merge pull request #6910 
b7dd8349f Allow setting start block on export (Howard Chu)
 2020-12-01 14:18:44 -08:00
Alexander Blair
438442ace0
Merge pull request #6890 
ec14e4b8c wallet2: skip reorgs exceeding max-reorg-depth wallet setting (xiphon)
 2020-12-01 14:18:22 -08:00
moneromooo
6c9980a55b
p2p: give all hosts the same chance of being picked for connecting 
even if some run more than one node
 2020-11-29 15:55:58 +00:00
selsta
7a5e11645f
net_node: add tor / i2p seed nodes 
Co-authored-by: Lee Clagett <code@leeclagett.com>
 2020-11-29 13:49:03 +01:00
luigi1111
850edfe419
Merge pull request #7021 
d73cb95 Fix timeout checks for forwarded and Dandelion++ stem txes (Lee Clagett)
 2020-11-29 01:59:35 -06:00
luigi1111
cf816e51ad
Merge pull request #7020 
2c66894 wallet_api: TransactionHistory - fill unconfirmed out payments dests (xiphon)
 2020-11-29 01:58:56 -06:00
luigi1111
36d31ba0be
Merge pull request #7018 
a9cd5d9 cryptonote_core: dandelion - use local height or median height if syncing (xiphon)
 2020-11-29 01:58:13 -06:00
luigi1111
ad843541d5
Merge pull request #7008 
3247f11 Silence stupid warnings (Howard Chu)
 2020-11-29 01:57:24 -06:00
luigi1111
c041550ffa
Merge pull request #6973 
be84f67 Switch to Dandelion++ fluff mode if no out connections for stem mode (Lee Clagett)
 2020-11-29 01:54:43 -06:00
luigi1111
a92b968e35
Merge pull request #6971 
f9527e6 protocol: reject empty incoming block messages (moneromooo-monero)
 2020-11-29 01:54:08 -06:00
luigi1111
9945ca7a62
Merge pull request #6960 
5569a8e rpc: on_send_raw_tx (bootstrap) - send to bootstrap daemon and P2P (xiphon)
 2020-11-29 01:53:12 -06:00
luigi1111
bb56248acd
Merge pull request #6949 
aad780b Fix CLI and unrestricted RPC relay_tx with stempool (Lee Clagett)
 2020-11-29 01:52:23 -06:00
luigi1111
9a4d813136
Merge pull request #6943 
cb069d0 p2p: remove banned peers from the white list (moneromooo-monero)
 2020-11-29 01:51:41 -06:00
luigi1111
7a0334742a
Merge pull request #6937 
8a282f6 Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr) Add monero_add_minimal_executable and use in tests (mj-xmr)
 2020-11-29 01:49:39 -06:00
luigi1111
2be7a4c04f
Merge pull request #6933 
1f04a31 p2p: use /16 filtering on IPv4-within-IPv6 addresses (moneromooo-monero)
 2020-11-29 01:46:46 -06:00
luigi1111
4d298d4f11
Merge pull request #6924 
874487f blockchain: remove some dead code (moneromooo-monero)
 2020-11-29 01:44:26 -06:00
luigi1111
999e797cea
Merge pull request #6922 
a25bc71 Make Blockchain::get_fee_quantization_mask() compile time (SChernykh)
 2020-11-29 01:40:59 -06:00
luigi1111
bab4495cfb
Merge pull request #6921 
f1836ac cryptonote_core: Fix missing override warnings (Nathan Dorfman)
 2020-11-29 01:39:17 -06:00
luigi1111
c5b3fd1fec
Merge pull request #6920 
aad2f87 net_node: add --ban-list option (selsta)
 2020-11-29 01:38:27 -06:00
luigi1111
84cdb5d914
Merge pull request #6915 
c67fa32 bump default number of connections from 8 to 12 (moneromooo-monero)
 2020-11-29 01:34:02 -06:00
luigi1111
4c2e77854d
Merge pull request #6913 
fc2f971 wallet2: wait for propagation timeout before marking tx as failed (xiphon)
 2020-11-29 01:32:01 -06:00
luigi1111
eebd86dc3e
Merge pull request #6898 
593ae2e device: Ledger - update status codes (xiphon)
 2020-11-29 00:44:27 -06:00
luigi1111
52006df9bb
Merge pull request #6897 
2abdbf6 Add support for i2p and tor seed nodes (vtnerd)
 2020-11-29 00:42:27 -06:00
luigi1111
7539d4ac74
Merge pull request #6895 
b49f489 fix next_seed_height regression in getblocktemplate rpc (xnbya)
 2020-11-29 00:41:42 -06:00
luigi1111
678237835f
Merge pull request #6892 
ad7ea2c core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check (xiphon)
 2020-11-29 00:40:03 -06:00
luigi1111
d45a4ba106
Merge pull request #6849 
f4b2382 rpc_private_headers declaration fix (malbit)
 2020-11-28 22:31:25 -06:00
luigi1111
7778384071
Merge pull request #6830 
64e9526 Extend TransactionInfo with coinbase and description attributes in wallet/api (dsc)
 2020-11-28 21:55:16 -06:00
dsc
d157196416 Allow tx note edits via TransactionHistory object in wallet/api 2020-11-28 21:48:57 -06:00
luigi1111
b37d6fe368
Merge pull request #6826 
83da867 Update error messages in daemon (tmoravec)
 2020-11-28 21:35:34 -06:00
xiphon
a9cd5d914e cryptonote_core: dandelion - use local height or median height if syncing 2020-11-25 01:27:42 +00:00
Crypto City
17c5370398
wallet2: check imported multisig curve points are in main subgroup 2020-11-24 16:25:35 +00:00
xiphon
0363476ee3 rpc: get_info - add 'synchronized' field 2020-11-19 12:51:31 +00:00
Lee Clagett
b10878f108 Change Dandelion++ fluff probability to 20%, and embargo timeout to 39s 
A 20% fluff probability increases the precision of a spy connected to
every node by 10% on average, compared to a network using 0% fluff
probability. The current value (10% fluff) should increase precision by
~5% compared to baseline.

This decreases the expected stem length from 10 to 5. The embargo
timeout was therefore lowered to 39s; the fifth node in a stem is
expected to have a 90% chance of being the first to timeout, which is
the same probability we currently have with an expected stem length of
10 nodes.
 2020-11-17 21:45:37 -05:00
xiphon
aaf837cf5f rpc: skip non-synced bootstrap daemons in --no-sync mode too 2020-11-17 23:15:36 +00:00
Howard Chu
91fd634768
Better log message for unusable anon networks 2020-11-16 12:36:37 +00:00
Lee Clagett
d73cb95dfa Fix timeout checks for forwarded and Dandelion++ stem txes 2020-11-15 00:08:10 -05:00
xiphon
5569a8e426 rpc: on_send_raw_tx (bootstrap) - send to bootstrap daemon and P2P 2020-11-15 03:13:07 +00:00
xiphon
2c668940cd wallet_api: TransactionHistory - fill unconfirmed out payments dests 2020-11-14 14:09:07 +00:00
Howard Chu
3247f11638
Silence stupid warnings 2020-11-11 02:34:14 +00:00
woodser
ee58f4f766 Balance includes unconfirmed payments 2020-11-06 15:08:43 -05:00
Lee Clagett
be84f678b9 Switch to Dandelion++ fluff mode if no out connections for stem mode 2020-11-03 13:58:14 -05:00
moneromooo-monero
f9527e608e
protocol: reject empty incoming block messages 2020-11-03 12:59:36 +00:00
moneromooo-monero
1f04a3186b
p2p: use /16 filtering on IPv4-within-IPv6 addresses 
IPv6 addresses include a range that can map IPv4 addresses,
which allowed those mapped addresses to bypass filtering.

This filter should be replaced by AS filtering at some point.
 2020-11-03 00:46:07 +00:00
Lee Clagett
aad780bcfa Fix CLI and unrestricted RPC relay_tx with stempool 2020-10-29 00:17:55 -04:00
Howard Chu
65903d2cfc
Add rpc-restricted-bind-ip option 
Fixes #6369
 2020-10-29 00:22:18 +00:00
mj-xmr
8a282f64c9 Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr) 
Add monero_add_minimal_executable and use in tests

This is done in order not to have to relink targets, when just an .so changed, but not its interface.
 2020-10-28 20:08:26 +01:00
moneromooo
cb069d0a42
p2p: remove banned peers from the white list 2020-10-27 22:35:14 +00:00
luigi1111
8b3b106ad1
Merge pull request #6902 
70eb0d1 wallet2_api: implement stop() to interrupt refresh() loop once (xiphon)
 2020-10-21 22:57:42 -05:00
selsta
aad2f87a53
net_node: add --ban-list option 2020-10-20 19:39:44 +02:00
moneromooo-monero
874487fed8
blockchain: remove some dead code 
This is already done
 2020-10-20 16:50:36 +00:00
moneromooo-monero
cc034fe0c3
util: fix escaping more than one ?* in glob_to_regex 2020-10-20 16:46:53 +00:00
SChernykh
a25bc71f3f Make Blockchain::get_fee_quantization_mask() compile time 
This also removes potential thread safety bug in that function.
 2020-10-20 14:16:09 +02:00
Nathan Dorfman
f1836ac28a cryptonote_core: Fix missing override warnings 2020-10-19 18:23:07 -06:00
Lee Clagett
2abdbf63cf Add support for i2p and tor seed nodes 2020-10-19 13:13:07 +00:00
Alexander Blair
faedcded39
Merge pull request #6891 
4cf3545a3 core_rpc_server: on_get_blocks - forward bootstrap daemon error (xiphon)
 2020-10-18 23:26:17 -07:00
Alexander Blair
8e3f46dd0a
Merge pull request #6881 
11b20229c tx_pool: silence spammy harmless warning till we fix the bug (moneromooo-monero)
 2020-10-18 23:25:54 -07:00
Alexander Blair
142489bd60
Merge pull request #6882 
fcbfb0a00 wallet2: fix missing m_state field in wallet serialization (moneromooo-monero)
 2020-10-18 23:25:32 -07:00
Alexander Blair
543d600042
Merge pull request #6875 
a12a8174e Dandelion++: skip desynced peers in stem phase (xiphon)
 2020-10-18 23:25:08 -07:00
xiphon
fc2f97177b wallet2: wait for propagation timeout before marking tx as failed 2020-10-18 14:00:56 +00:00
moneromooo-monero
c67fa32496
bump default number of connections from 8 to 12 2020-10-18 13:25:05 +00:00
Howard Chu
b7dd8349f4
Allow setting start block on export 
And make import honor the starting block# recorded in a bootstrap file
 2020-10-18 14:01:44 +01:00
Alexander Blair
519740a1d3
Merge pull request #6905 
88fde0309 blockchain: fix sync at v14 boundary (moneromooo-monero)
 2020-10-18 05:51:43 -07:00
moneromooo-monero
88fde0309a
blockchain: fix sync at v14 boundary 
Miners with MLSAG txes which they'd already verified included
a couple in that block, but the consensus rules had changed
in the meantime, so that block is technically invalid and any
node which did not already have those two txes in their txpool
could not sync. Grandfather them in, since it has no effect in
practice.
 2020-10-18 11:52:33 +00:00
xiphon
70eb0d1844 wallet2_api: implement stop() to interrupt refresh() loop once 2020-10-17 02:56:15 +00:00
Lee Clagett
13350f79df Do not use peer_id tracking method over i2p/tor 2020-10-15 16:47:59 +00:00
moneromooo-monero
aaa3289e22
add more updates domains and make the voting generic, not just 2/3 2020-10-15 14:06:44 +00:00
xiphon
593ae2e9f9 device: Ledger - update status codes 2020-10-13 22:53:19 +00:00
luigi1111
e503688a6b
Merge pull request #6828 
1b3f220 Allow AddressBook description edits via wallet/api interface (xmrdsc)
 2020-10-13 10:39:05 -05:00
xiphon
ec14e4b8cd wallet2: skip reorgs exceeding max-reorg-depth wallet setting 2020-10-13 15:23:35 +00:00
Alexis Enston
b49f48962b fix next_seed_height regression in getblocktemplate rpc 2020-10-13 11:07:59 +01:00
xiphon
4cf3545a31 core_rpc_server: on_get_blocks - forward bootstrap daemon error 2020-10-13 00:44:59 +00:00
xiphon
ad7ea2c60c core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check 2020-10-12 23:49:37 +00:00
moneromooo-monero
fcbfb0a00a
wallet2: fix missing m_state field in wallet serialization 2020-10-12 15:35:52 +00:00
moneromooo-monero
11b20229c9
tx_pool: silence spammy harmless warning till we fix the bug 2020-10-12 14:07:40 +00:00
xiphon
a12a8174e0 Dandelion++: skip desynced peers in stem phase 2020-10-12 13:44:06 +00:00
Lee Clagett
7414e2bac1 Change epee binary output from std::stringstream to byte_stream 2020-10-10 15:28:40 +00:00
Lee Clagett
386ef03be3 Add TLSA support to DNSSEC fetching 2020-10-07 15:43:31 +00:00