monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-22 19:49:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
11672 commits 9 branches 69 tags 319 MiB
Commit graph

2378 commits

Author SHA1 Message Date
luigi1111
27f1d43547
Merge pull request #8145 
fb5b2b3 support authentication in monero-wallet-rpc set_daemon (woodser)
 2022-03-02 18:53:34 -05:00
luigi1111
5eaa4434e8
Merge pull request #7877 
e08abaa multisig key exchange update and refactor (koe)
 2022-03-02 18:51:54 -05:00
selsta
3c829586be
wallet2: update stagenet rollback blocks 2022-03-01 00:25:41 +01:00
koe
e08abaa43f multisig key exchange update and refactor 2022-02-22 16:37:42 -06:00
woodser
e5000a9f0c Balance includes unconfirmed transfers to self 2022-01-31 07:52:38 -05:00
luigi1111
d94715fd71
Merge pull request #8123 
4446cc8 wallet inits cache if file and blob missing (woodser)
 2022-01-24 15:15:11 -05:00
luigi1111
5283cf51ef
Merge pull request #8044 
a02b342 Avoid unnecessary 'Invalid hashing blob' error message (rbrunner7)
 2022-01-24 15:10:55 -05:00
woodser
fb5b2b352a support authentication in monero-wallet-rpc set_daemon 2022-01-17 17:03:56 -05:00
woodser
4446cc88c3 wallet inits cache if file and blob missing 2021-12-24 09:22:57 -05:00
woodser
53be72c08a make_uri disallows standalone payment ids 2021-11-30 09:28:45 -05:00
rbrunner7
a02b342347 Avoid unnecessary 'Invalid hashing blob' error message 2021-11-05 14:19:21 +01:00
luigi1111
d573b3d76c
Merge pull request #8020 
47e7a43 wallet_api: enable set_strict_default_file_permissions (tobtoht)
 2021-11-01 12:31:32 -05:00
luigi1111
ff4ede9356
Merge pull request #8017 
a15466d wallet2: remove 2 unused variables (selsta)
 2021-11-01 12:29:22 -05:00
luigi1111
f405bf3d58
Merge pull request #8013 
2cad563 wallet2: fix key encryption when changing ask-password from 0/1 to 2 (moneromooo-monero)
 2021-11-01 12:25:20 -05:00
tobtoht
47e7a43270
wallet_api: enable set_strict_default_file_permissions 2021-10-22 05:40:23 +02:00
selsta
e106bdc1fc
epee: add missing header 2021-10-22 04:14:25 +02:00
selsta
a15466d850
wallet2: remove 2 unused variables 2021-10-20 22:19:15 +02:00
moneromooo-monero
2cad563060
wallet2: fix key encryption when changing ask-password from 0/1 to 2 
we reuse the wallet_keys_unlocker object, which does the right thing
in conjunction with other users of decrypt/encrypt (ie, refresh).
 2021-10-19 22:01:45 +00:00
luigi1111
99507da993
Merge pull request #7994 
84c5257 Decrease the 'recent spend window' in gamma re-select to 15 blocks (j-berman)
 2021-10-17 23:38:47 -05:00
luigi1111
19a6cc26fc
Merge pull request #7867 
eed7e79 UB: Not calling virtual method in destructor of WalletImpl (mj-xmr)
 2021-10-17 23:26:50 -05:00
luigi1111
308e601966
Merge pull request #7799 
76542ea Fix precision of average_output_time (j-berman)
 2021-10-17 23:23:15 -05:00
luigi1111
7f477c1902
Merge pull request #7793 
13a8a57 trezor: try empty passphrase first (Dusan Klinec)
 2021-10-11 12:54:17 -05:00
j-berman
84c52571ed Decrease the "recent spend window" in gamma re-select to 15 blocks 
- combined with patching integer truncation (#7798), this gets the algorithm marginally closer to mirroring empirically observed output ages
- 50 was originally chosen assuming integer truncation would remain in the client for that client release version. But patching integer truncation causes the client to select more outputs in the 10-100 block range, and therefore the benefit of choosing a larger recent spend window of 50 has less merit
- 15 seems well-suited to cover the somewhat sizable observable gap in the early window of blocks
 2021-10-04 20:12:42 -07:00
tobtoht
5770265a16
wallet2: keep around transaction prefix for confirmed transfers 2021-10-01 12:42:48 +02:00
j-berman
76542ea709 Fix precision of average_output_time 
The fix as suggested by <jberman> on IRC. Before the fix, it would truncate 1.9 to 1 skewing the output selection.
 2021-09-12 10:07:31 +02:00
luigi1111
a39b1d56c8
Merge pull request #7899 
cd76eb7 wallet: fix unused lambda capture warning (selsta)
 2021-09-09 15:21:10 -04:00
luigi1111
9273530bff
Merge pull request #7898 
f353c29 wallet_rpc_server: fix help text remaining bold (selsta)
 2021-09-09 15:20:43 -04:00
luigi1111
dfa6b58d4d
Merge pull request #7823 
24d3d65 monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir (Kermit Alexander II)
 2021-09-09 15:14:17 -04:00
luigi1111
b7315efc1c
Merge pull request #7342 
520ce1c Attempt to carve the fee from a partial payment early (lxop)
 2021-09-09 15:06:46 -04:00
mj-xmr
eed7e79c04
UB: Not calling virtual method in destructor of WalletImpl 2021-09-07 14:24:53 +02:00
selsta
cd76eb7b8c
wallet: fix unused lambda capture warning 2021-08-28 15:18:32 +02:00
selsta
f353c295f9
wallet_rpc_server: fix help text remaining bold 2021-08-27 02:59:36 +02:00
SChernykh
e52802baef Wallet2: fix optimize-coinbase for p2pool payouts 
RefreshOptimizeCoinbase was an optimization to speed up scanning of coinbase transactions before RingCT (tx version 2) where they split miner reward into multiple denominations, all to the same wallet.

When RingCT was introduced, all coinbase transactions became 1 output only, so this optimization does nothing now.

With p2pool, this optimization will skip scanning p2pool payouts because they use more than 1 output in coinbase transaction.

Fix it by applying this optimization only to pre-RingCT transactions (version < 2).
 2021-08-26 11:50:15 +02:00
luigi1111
0061da9e63
Merge pull request #7878 
a9aaa47 wallet_api: add make_uri (tobtoht)
 2021-08-20 16:50:24 -04:00
luigi1111
8b9eea92f1
Merge pull request #7849 
6f15a0c Make sure node returns to wallet that real output is unlocked (j-berman)
 2021-08-20 16:49:59 -04:00
luigi1111
1b079e5195
Merge pull request #7845 
e1af8dc Protect client from divide by 0 caused by integer truncation (j-berman)
 2021-08-20 16:45:15 -04:00
luigi1111
5812b757e0
Merge pull request #7821 
da2955f Apply gamma distr from chain tip when selecting decoys (j-berman)
 2021-08-20 16:33:53 -04:00
Kermit Alexander II
24d3d65d42 monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir 2021-08-20 08:54:41 -05:00
j-berman
e1af8dc02c Protect client from divide by 0 caused by integer truncation 2021-08-19 14:56:36 -07:00
j-berman
da2955feae Apply gamma distr from chain tip when selecting decoys 
- matches the paper by Miller et al to apply the gamma from chain tip, rather than after unlock time
- if the gamma produces an output more recent than the unlock time, the algo packs that output into one of the first 50 spendable blocks, respecting the block density factor
 2021-08-19 14:51:20 -07:00
tobtoht
a9aaa47abb
wallet_api: add make_uri 2021-08-19 15:35:37 +02:00
luigi1111
cb08466394
Merge pull request #7802 
a3d2b71 wallet_api: expose offline mode status (rating89us)
 2021-08-11 22:33:38 -04:00
luigi1111
62844a776d
Merge pull request #7786 
9c6e094 fix #7784 - deinit wallet in wallet dtor (Dusan Klinec)
 2021-08-11 22:30:11 -04:00
j-berman
6f15a0c8d3 Make sure node returns to wallet that real output is unlocked 2021-08-11 07:28:10 -07:00
Dusan Klinec
13a8a576ed
trezor: try empty passphrase first 
- Try empty passphrase first when opening a wallet, as all Trezors will have passphrase enabled by default by Trezor Suite by default.
  This feature enables easier access to all users using disabled passphrase (or empty passhprase)
- If wallet address differs from device address with empty passphrase, another opening attempt is made, without passphrase suppression,
  so user can enter his passhprase if using some. In this scenario, nothing changes to user, wallet opening just consumes one more call
  to Trezor (get wallet address with empty passphrase)
- also change how m_passphrase is used. Previous version did not work well with recent passphrase entry mechanism change (made in Trezor),
  thus this commit fixes the behaviour).
 2021-08-03 13:54:04 +02:00
luigi1111
ed506006d2
Merge pull request #7796 
0c6e1d3 wallet2: chunk get_outs.bin calls to avoid sanity limits (moneromooo-monero)
 2021-08-02 18:54:46 -04:00
luigi1111
eeda76570c
Merge pull request #7790 
bc8d764 wallet: rephrase error message on invalid device address (Dusan Klinec)
 2021-08-02 18:53:05 -04:00
luigi1111
8c41d14ad5
Merge pull request #7788 
f5eb2ce wallet2: Don't auto lock device on process parsed blocks (tobtoht)
 2021-08-02 18:50:25 -04:00
luigi1111
894e5b2794
Merge pull request #7767 
5fa1c90 Fix describe_transfer for multiple txes in a txset (Alex Opie)
 2021-08-02 18:47:05 -04:00
luigi1111
9aa2d4c16e
Merge pull request #7747 
8cf95c8 wallet2: refresh: check error and throw before potentially breaking out of loop (tobtoht)
 2021-08-02 18:42:32 -04:00
Alex Opie
5fa1c90102
Fix describe_transfer for multiple txes in a txset 
This ensures each list of recipients is only the recipients
for one transaction. It also adds a new field "summary"
that describes the txset as a whole.

Fixes #7344
 2021-08-02 20:39:49 +02:00
luigi1111
2d5b8a6ff7
Merge pull request #7740 
8cea9d8 wallet: Reset RPC Pay ID on node switch (tobtoht)
 2021-07-27 16:55:14 -04:00
rating89us
a3d2b71ee9 wallet_api: expose offline mode status 2021-07-19 00:30:36 +02:00
moneromooo-monero
0c6e1d343e
wallet2: chunk get_outs.bin calls to avoid sanity limits 2021-07-15 17:25:07 +00:00
tobtoht
f5eb2ce968 wallet2: Don't auto lock device on process parsed blocks 2021-07-14 13:02:54 +02:00
Dusan Klinec
bc8d7644d2
wallet: rephrase error message on invalid device address 2021-07-14 11:02:29 +02:00
Dusan Klinec
9c6e0941cb
fix #7784 - deinit wallet in wallet dtor 2021-07-14 10:46:16 +02:00
anon
fe76d7dee7
cmake: fix undefined symbols and multiple definitions 2021-07-13 08:00:20 +02:00
luigi1111
3c8c8e5a5b
Merge pull request #7761 
8ef51dc wallet_api: fix typo in exportKeyImages (selsta)
 2021-07-10 17:59:56 -04:00
luigi1111
c53e22c40a
Merge pull request #7748 
bbeb555 wallet_api: getPassword (tobtoht)
 2021-07-10 17:57:39 -04:00
tobtoht
bbeb555f00 wallet_api: getPassword 2021-07-05 02:49:27 +02:00
tobtoht
8a67724218
wallet_api: get bytes sent/received 2021-06-24 21:32:03 +02:00
luigi1111
4f08d52dfa
Merge pull request #7750 
8e0b8dd wallet/api: remove Bitmonero namespace alias (selsta)
 2021-06-24 14:12:37 -05:00
luigi1111
0a9d218044
Merge pull request #7749 
e63c110 wallet_api: address_book: don't lose pid on setDescription (tobtoht)
 2021-06-24 14:11:45 -05:00
luigi1111
99aa45fd34
Merge pull request #7746 
1aa1850 wallet_api: signMessage: add sign with subaddress (tobtoht)
 2021-06-24 14:06:13 -05:00
luigi1111
7c3629a5ee
Merge pull request #7742 
f174a8f wallet_api: reconnectDevice (tobtoht)
 2021-06-24 14:05:35 -05:00
luigi1111
ce129599d0
Merge pull request #7739 
6914d5b wallet_api: move adjust_mixin call within try block (tobtoht)
 2021-06-24 14:04:42 -05:00
selsta
8ef51dc546
wallet_api: fix typo in exportKeyImages 2021-06-23 20:44:13 +02:00
woodser
e7615772fa provide key images of spent outputs in wallet rpc 2021-06-15 15:54:39 -04:00
luigi1111
7499837a6f
Merge pull request #7661 
08e4497 Improve cryptonote (block and tx) binary read performance (Lee Clagett)
 2021-06-10 12:00:54 -05:00
luigi1111
ca73284951
Merge pull request #7729 
b2e1558 support freeze, thaw, and frozen in wallet rpc (woodser)
 2021-06-10 11:47:05 -05:00
luigi1111
a1a3e970f7
Merge pull request #7662 
4da1112 rpc: send confirmations in get_transactions result (moneromooo-monero)
 2021-06-10 11:34:20 -05:00
selsta
8e0b8ddb96
wallet/api: remove Bitmonero namespace alias 2021-06-08 23:29:41 +02:00
tobtoht
e63c1107c0 wallet_api: address_book: don't lose pid on setDescription 2021-06-08 15:20:48 +02:00
tobtoht
8cf95c8f29 wallet2: refresh: check error and throw before potentially breaking out of loop 2021-06-04 18:37:06 +02:00
tobtoht
1aa1850ba5 wallet_api: signMessage: add sign with subaddress 2021-06-04 18:16:10 +02:00
tobtoht
f174a8f05f wallet_api: reconnectDevice 2021-06-04 15:24:53 +02:00
tobtoht
8cea9d8605
wallet: Reset RPC Pay ID on node switch 
RPC pay client ID is sent with each RPC request, set a new secret every time we switch nodes to mitigate trivial correlation
 2021-06-04 13:58:09 +02:00
tobtoht
6914d5b914 wallet_api: move adjust_mixin call within try block 2021-06-04 13:41:10 +02:00
woodser
b2e1558bde support freeze, thaw, and frozen in wallet rpc 2021-05-18 20:35:48 -04:00
mj-xmr
44e8395d2a
CMake: glob missing headers for wallet2 2021-05-14 14:22:29 +02:00
luigi1111
4fcbc584f0
Merge pull request #7694 
004b167 cmake: wallet_api doesn't need wallet_merged (selsta)
 2021-05-12 17:00:04 -05:00
luigi1111
e505ffef5f
Merge pull request #7677 
445a9d8 wallet_api: import / export output function (tobtoht)
 2021-05-12 16:53:27 -05:00
luigi1111
628c04499b
Merge pull request #7682 
bbdb612 Wallet2: Update 'approximate_testnet_rolled_back_blocks' (rbrunner7)
 2021-05-12 15:30:34 -05:00
selsta
004b167095
cmake: wallet_api doesn't need wallet_merged 2021-04-27 14:36:56 +02:00
rbrunner7
bbdb612b51 Wallet2: Update 'approximate_testnet_rolled_back_blocks' 2021-04-25 10:20:39 +02:00
Nathan Dorfman
c57ef7f807 wallet2: Fix rescan_bc keep_ki option 2021-04-23 09:11:45 -06:00
luigi1111
9bba3f4767
Merge pull request #7651 
c8ff1d4 monero-wallet-cli: improve error message when tx amount is zero (Elliot Wirrick)
 2021-04-22 01:35:20 -04:00
tobtoht
445a9d8ba3
wallet_api: import / export output function 2021-04-22 04:26:17 +02:00
mj-xmr
dc81e23e60 Split epee/string_tools.h and encapsulate boost::lexical_cast 2021-04-16 20:54:20 +02:00
luigi1111
13418dbb98
Merge pull request #7648 
25e8254 expose set_offline to wallet api (benevanoff)
 2021-04-16 12:51:22 -05:00
luigi1111
2218e23e84
Merge pull request #7002 
673c6d2 Reduce compilation time of epee/portable_storage_template_helper.h (mj-xmr)
 2021-04-16 12:43:42 -05:00
moneromooo-monero
4da1112967
rpc: send confirmations in get_transactions result 
if the wallet does it, it would get a wrong result (possibly even
negative) if its local chain is not synced up to the daemon's yet
 2021-04-15 15:31:52 +00:00
Elliot Wirrick
c8ff1d4d23 monero-wallet-cli: improve error message when tx amount is zero 2021-04-07 10:10:16 -04:00
luigi1111
2098941ca0
Merge pull request #7635 
447bfae wallet2: fix unlocked mixup in light wallet mode (moneromooo-monero)
 2021-04-06 12:23:45 -05:00
luigi1111
3c69596bc9
Merge pull request #7321 
f9b5b52 fix serialization being different on mac (moneromooo-monero)
 2021-04-06 12:20:15 -05:00
benevanoff
25e82545f3 expose set_offline to wallet api 2021-04-05 13:41:04 -05:00
luigi1111
e1d987aa66
Merge pull request #7430 
064eeb2 wallet_rpc_server: set seed language in generate_from_keys (moneromooo-monero)
 2021-03-29 22:37:19 -04:00
luigi1111
1a8b6ba8c0
Merge pull request #7542 
7c4e4c7 wallet_api: add isDeterministic() (tobtoht)
 2021-03-29 21:50:53 -04:00
luigi1111
0607a10696
Merge pull request #7538 
1851f26 wallet_api: add seed_offset param to seed() (tobtoht)
 2021-03-29 21:47:40 -04:00
luigi1111
ac091fb539
Merge pull request #7358 
f346e3e wallet_rpc_payments: implement multithreading (gdmojo)
 2021-03-29 21:10:48 -04:00
mj-xmr
673c6d2d11 Reduce compilation time of epee/portable_storage_template_helper.h 2021-03-28 15:41:48 +02:00
moneromooo-monero
447bfae2a4
wallet2: fix unlocked mixup in light wallet mode 2021-03-25 09:33:40 +00:00
luigi1111
5b8d714a4b
Merge pull request #7422 
d46d90c return output key for incoming transfers (benevanoff)
 2021-03-20 01:57:44 -04:00
tobtoht
7c4e4c7603
wallet_api: add isDeterministic() 2021-03-12 23:43:58 +01:00
tobtoht
1851f2645a
wallet_api: add seed_offset param to seed() 2021-03-12 19:45:29 +01:00
moneromooo-monero
064eeb2861
wallet_rpc_server: set seed language in generate_from_keys 
Also sanity check language name
 2021-03-06 10:26:15 +00:00
moneromooo-monero
f9b5b521e8
fix serialization being different on mac 
On Mac, size_t is a distinct type from uint64_t, and some
types (in wallet cache as well as cold/hot wallet transfer
data) use pairs/containers with size_t as fields. Mac would
save those as full size, while other platforms would save
them as varints. Might apply to other platforms where the
types are distinct.

There's a nasty hack for backward compatibility, which can
go after a couple forks.
 2021-03-05 23:42:33 +00:00
benevanoff
d46d90c436 return output key for incoming transfers 2021-03-04 11:09:15 -06:00
tobtoht
6477b47ac7 wallet_rpc: add scan_tx 2021-03-01 23:02:43 +01:00
gdmojo
f346e3ec0e wallet_rpc_payments: implement multithreading 2021-02-20 18:23:06 +00:00
luigi1111
6556c33f13
Merge pull request #7355 
bd12984 Remove copies from foreach loops (thanks to Clang) (Lee Clagett)
1572df9 Removing unused namespace alias (Lee Clagett)
 2021-02-18 14:06:47 -05:00
luigi1111
ce5800a225
Merge pull request #7346 
85db173 Remove unused variables in monero codebase (Kevin Barbour)
 2021-02-18 14:03:31 -05:00
luigi1111
0e35d46f5e
Merge pull request #7341 
b587ffa Stop adding more outputs than bulletproof allows (Alex Opie)
 2021-02-18 14:02:13 -05:00
luigi1111
3f55f7df31
Merge pull request #7312 
186271e monero-wallet-cli: Added command scan_tx (Horia Mihai David)
 2021-02-18 14:00:35 -05:00
Horia Mihai David
186271e5d1 monero-wallet-cli: Added command scan_tx 
To implement this feature, the wallet2::scan_tx API was implemented.
 2021-02-17 20:25:55 +01:00
luigi1111
bf53f55366
Merge pull request #7288 
015da03 wallet_rpc_server: don't abort on initial refresh failure (xiphon)
 2021-02-15 21:50:34 -05:00
luigi1111
f11e434ae6
Merge pull request #7265 
bdabcd0 wallet_api: store fee for incoming txs in history (Ben Evanoff)
 2021-02-15 21:46:22 -05:00
luigi1111
ba76a4d26e
Merge pull request #7185 
50ff106 wallet api: allow wallet to fetch all key images via api (benevanoff)
 2021-02-15 21:42:30 -05:00
luigi1111
4c410a1e3a
Merge pull request #7000 
dc48de7 Reduce compilation time of epee/portable_storage.h (mj-xmr)
 2021-02-15 21:39:05 -05:00
luigi1111
4ee301c687
Merge pull request #6986 
ee58f4f Balance includes unconfirmed payments (woodser)
 2021-02-15 21:36:48 -05:00
Kevin Barbour
85db1734e7
Remove unused variables in monero codebase 
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.

In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
 2021-02-09 08:05:05 +01:00
mj-xmr
dc48de74e8 Reduce compilation time of epee/portable_storage.h 2021-02-06 08:18:42 +01:00
Lee Clagett
bd129849f0 Remove copies from foreach loops (thanks to Clang) 2021-01-28 23:42:40 -05:00
Lee Clagett
1572df9e26 Removing unused namespace alias 2021-01-28 23:40:57 -05:00
Alex Opie
520ce1ca81 Attempt to carve the fee from a partial payment early 
Do this for both the estimate and actual fee.

#7337
 2021-01-25 12:01:27 +13:00
Alex Opie
b587ffa1fd Stop adding more outputs than bulletproof allows 
If more outputs are requested, they are split across
multiple transactions.

#7322
 2021-01-25 10:01:38 +13:00
Lee Clagett
08e4497c6e Improve cryptonote (block and tx) binary read performance 2021-01-23 06:23:39 +00:00
luigi1111
d01f31460e
Merge pull request #7113 
7f30c49 simplewallet: don't complain about connecting to the daemon when offline (moneromooo-monero)
 2021-01-15 23:44:32 -05:00
xiphon
015da03a6f wallet_rpc_server: don't abort on initial refresh failure 2021-01-07 13:38:15 +00:00
Ben Evanoff
bdabcd01b7
wallet_api: store fee for incoming txs in history 2021-01-02 13:56:57 -06:00
benevanoff
50ff1066f5 wallet api: allow wallet to fetch all key images via api 2020-12-25 00:40:50 -06:00
moneromooo-monero
d2fda6c25f
restrict public node checks a little 
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
 2020-12-22 23:39:07 +00:00
moneromooo-monero
7f30c49731
simplewallet: don't complain about connecting to the daemon when offline 2020-12-10 17:57:13 +00:00
Alexander Blair
6b8db83149
Merge pull request #7043 
17c537039 wallet2: check imported multisig curve points are in main subgroup (Crypto City)
 2020-12-04 13:25:01 -08:00
selsta
89bbb802c0
wallet2: set propagation timeout to current max timeout 2020-12-03 02:18:58 +01:00
Alexander Blair
438442ace0
Merge pull request #6890 
ec14e4b8c wallet2: skip reorgs exceeding max-reorg-depth wallet setting (xiphon)
 2020-12-01 14:18:22 -08:00
luigi1111
cf816e51ad
Merge pull request #7020 
2c66894 wallet_api: TransactionHistory - fill unconfirmed out payments dests (xiphon)
 2020-11-29 01:58:56 -06:00
luigi1111
4c2e77854d
Merge pull request #6913 
fc2f971 wallet2: wait for propagation timeout before marking tx as failed (xiphon)
 2020-11-29 01:32:01 -06:00
luigi1111
7778384071
Merge pull request #6830 
64e9526 Extend TransactionInfo with coinbase and description attributes in wallet/api (dsc)
 2020-11-28 21:55:16 -06:00
dsc
d157196416 Allow tx note edits via TransactionHistory object in wallet/api 2020-11-28 21:48:57 -06:00
Crypto City
17c5370398
wallet2: check imported multisig curve points are in main subgroup 2020-11-24 16:25:35 +00:00
xiphon
2c668940cd wallet_api: TransactionHistory - fill unconfirmed out payments dests 2020-11-14 14:09:07 +00:00
woodser
ee58f4f766 Balance includes unconfirmed payments 2020-11-06 15:08:43 -05:00
luigi1111
8b3b106ad1
Merge pull request #6902 
70eb0d1 wallet2_api: implement stop() to interrupt refresh() loop once (xiphon)
 2020-10-21 22:57:42 -05:00
Alexander Blair
142489bd60
Merge pull request #6882 
fcbfb0a00 wallet2: fix missing m_state field in wallet serialization (moneromooo-monero)
 2020-10-18 23:25:32 -07:00
xiphon
fc2f97177b wallet2: wait for propagation timeout before marking tx as failed 2020-10-18 14:00:56 +00:00
xiphon
70eb0d1844 wallet2_api: implement stop() to interrupt refresh() loop once 2020-10-17 02:56:15 +00:00
luigi1111
e503688a6b
Merge pull request #6828 
1b3f220 Allow AddressBook description edits via wallet/api interface (xmrdsc)
 2020-10-13 10:39:05 -05:00
xiphon
ec14e4b8cd wallet2: skip reorgs exceeding max-reorg-depth wallet setting 2020-10-13 15:23:35 +00:00
moneromooo-monero
fcbfb0a00a
wallet2: fix missing m_state field in wallet serialization 2020-10-12 15:35:52 +00:00
Lee Clagett
7414e2bac1 Change epee binary output from std::stringstream to byte_stream 2020-10-10 15:28:40 +00:00
moneromooo-monero
b6c4f8cd54
fix a couple bugs found by OSS-fuzz 
- index out of bounds when importing outputs
- accessing invalid CLSAG data
 2020-09-24 15:30:38 +00:00
dsc
64e9526509 Extend TransactionInfo with coinbase and description attributes in wallet/api 2020-09-19 22:54:23 +02:00
dsc
1b3f220251 Allow AddressBook description edits via wallet/api interface 2020-09-19 18:29:46 +02:00
luigi1111
2b1488ef6f
Merge pull request #6793 
de9a9fb update error message 'No unlocked balance in the specified account' (woodser)
 2020-09-15 19:56:49 -05:00
TheCharlatan
80e535c95a
wallet2: adapt to deterministic unlock time 2020-09-15 11:40:31 +00:00
luigi1111
9bba1a24ea Merge pull request #6815 
ef4325f wallet2: fix tx sanity check triggering on pre-rct outputs (monermooo-monero)
 2020-09-14 11:47:06 -05:00
moneromooo-monero
ef4325fd41
wallet2: fix tx sanity check triggering on pre-rct outputs 2020-09-12 17:51:41 +00:00
Reinaldulin
a3844e257e
Fix typo in command line argument description 2020-09-09 10:18:32 -04:00
luigi1111
fd657c7706
Merge pull request #6798 
4e44306 enable CLSAG support for Trezor client (ph4r05)
 2020-09-07 14:30:41 -05:00
Dusan Klinec
4e4430603f
enable CLSAG support for Trezor client 2020-09-04 01:24:58 +02:00
luigi1111
ee0b02d0db
Merge pull request #6757 
6a37da8 threadpool: guard against exceptions in jobs, and armour plating (moneromooo-monero)
 2020-09-03 12:25:59 -05:00
woodser
de9a9fb340 update error message "No unlocked balance in the specified account" 2020-09-01 17:30:00 -04:00
moneromooo-monero
6a37da837e
threadpool: guard against exceptions in jobs, and armour plating 
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
 2020-09-01 14:33:33 +00:00
Sarang Noether
fa06c39d97 Bind signature to full address and signing mode 2020-08-28 19:38:00 -04:00
moneromooo-monero
743608ec16 wallet: allow signing a message with spend or view key 2020-08-28 19:25:17 -04:00
moneromooo-monero
82ee01699c
Integrate CLSAGs into monero 
They are allowed from v12, and MLSAGs are rejected from v13.
 2020-08-27 12:44:04 +00:00
Alexander Blair
0c101f1236
Merge pull request #6767 
07442a605 Fix build with Boost 1.74 (moneromooo-monero)
 2020-08-27 03:07:32 -07:00
Alexander Blair
4fe2858b4d
Merge pull request #6746 
20f603c6b Fix broken multisig pubkey sorting (Jason Rhinelander)
 2020-08-27 02:58:53 -07:00
Alexander Blair
a06c83db73
Merge pull request #6752 
85899230d simplewallet: allow setting tx keys when sending to a subaddress (moneromooo-monero)
e916201f1 wallet2: fix setting tx keys when another is already set (moneromooo-monero)
 2020-08-27 02:58:23 -07:00
Alexander Blair
42519b48a7
Merge pull request #6731 
db5d6e460 wallet2: fix wrong name when checking RPC cost (moneromooo-monero)
 2020-08-27 02:55:48 -07:00
Alexander Blair
bad5d8d6f0
Merge pull request #6690 
7175dcb10 replace most boost serialization with existing monero serialization (moneromooo-monero)
 2020-08-27 02:54:30 -07:00
luigi1111
765db1ae7a
Revert "Use domain-separated ChaCha20 for in-memory key encryption" 
This reverts commit 921dd8dde5.
 2020-08-17 14:08:59 -05:00
moneromooo-monero
7175dcb107
replace most boost serialization with existing monero serialization 
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.

For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.

Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.

Some tests and tools also do, this will stay as is for now.
 2020-08-17 16:23:58 +00:00
Alexander Blair
01b512f3a9
Merge pull request #6716 
76c16822d wallet2_api: implement runtime proxy configuration (xiphon)
 2020-08-16 12:52:21 -07:00
Alexander Blair
f40b9e34e0
Merge pull request #6715 
3d6bc0a68 wallet2: throw a error on wallet initialization failure (xiphon)
 2020-08-16 12:51:57 -07:00
Alexander Blair
8f02e7a7fc
Merge pull request #6632 
ef694d028 fix warning by removing std::move() on temporary http_client object (woodser)
 2020-08-16 12:44:59 -07:00
Alexander Blair
0f5eb0e70c
Merge pull request #6546 
eda167585 wallet_rpc_server: use unlock_time in suggested confirmations calc (moneromooo-monero)
 2020-08-16 12:40:51 -07:00
Alexander Blair
6d29ee6c52
Merge pull request #6493 
921dd8dde Use domain-separated ChaCha20 for in-memory key encryption (Sarang Noether)
 2020-08-16 12:39:59 -07:00
moneromooo-monero
07442a6059
Fix build with Boost 1.74 
Thanks iDunk for testing
 2020-08-16 16:23:26 +00:00
moneromooo-monero
85899230d1
simplewallet: allow setting tx keys when sending to a subaddress 
The tx key derivation is different then
 2020-08-10 21:25:51 +00:00
Sarang Noether
921dd8dde5 Use domain-separated ChaCha20 for in-memory key encryption 2020-08-09 19:11:54 -04:00
Sarang Noether
6bfcd31015 Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests. 2020-08-09 18:42:15 -04:00
moneromooo-monero
e916201f12
wallet2: fix setting tx keys when another is already set 
insert doesn't actually insert if another element with the
same key is already in the map
 2020-08-08 14:40:03 +00:00
Jason Rhinelander
20f603c6be Fix broken multisig pubkey sorting 
The sort predicate is a boolean ordered-before value, but these are
returning the memcmp value directly, and thus returns true whenever the
pubkeys aren't equal.  This means:

- it isn't actually sorting.

- it can (and does) segfault for some inputs.
 2020-08-05 12:42:27 -03:00
moneromooo-monero
db5d6e4602
wallet2: fix wrong name when checking RPC cost 2020-07-31 14:17:23 +00:00
xiphon
76c16822d0 wallet2_api: implement runtime proxy configuration 2020-07-20 13:45:12 +00:00
xiphon
3d6bc0a680 wallet2: throw a error on wallet initialization failure 2020-07-20 04:40:34 +00:00
Alexander Blair
3ba6c7fd30
Merge pull request #6516 
8656a8c9f remove double includes (sumogr)
 2020-07-19 03:34:28 -07:00
Alexander Blair
a0d179e528
Merge pull request #6512 
5ef0607da Update copyright year to 2020 (SomaticFanatic)
 2020-07-19 03:32:59 -07:00
luigi1111
340e1943ac
Merge pull request #6587 
94befec fix typo in pick_preferred_rct_inputs (Parean)
 2020-07-08 17:14:09 -05:00
luigi1111
c4f4091dd4
Merge pull request #6561 
c17fe81 wallet2: fix multisig data clearing stomping on a vector (moneromooo-monero)
 2020-06-08 14:21:33 -05:00
luigi1111
e17c864ba2
Merge pull request #6549 
82d21f5 easylogging++: sanitize log payload (moneromooo-monero)
7d0b7e8 [master] MMS: New 'config_checksum' subcommand (rbrunner7)
 2020-06-08 14:12:08 -05:00
luigi1111
3a577f1ce7
Merge pull request #6525 
86cf811 simplewallet: don't complain about incoming payment ids on change (moneromooo-monero)
 2020-06-08 14:07:45 -05:00
woodser
ef694d028f fix warning by removing std::move() on temporary http_client object 2020-06-06 11:38:32 -04:00
Lee Clagett
7aeb503547 Fix boost <1.60 compilation and fix boost 1.73+ warnings 2020-05-31 21:18:11 -04:00
Denis Smirnov
94befecb05 fix typo in pick_preferred_rct_inputs 2020-05-25 03:39:54 +07:00
rbrunner7
7d0b7e83ef [master] MMS: New 'config_checksum' subcommand 2020-05-24 10:23:55 +02:00
moneromooo-monero
c17fe815a2
wallet2: fix multisig data clearing stomping on a vector 2020-05-19 10:45:40 +00:00
moneromooo-monero
eda1675858
wallet_rpc_server: use unlock_time in suggested confirmations calc 2020-05-17 01:03:32 +00:00
moneromooo-monero
86cf811a39
simplewallet: don't complain about incoming payment ids on change 2020-05-13 23:28:31 +00:00
sumogr
8656a8c9ff remove double includes 2020-05-11 13:53:17 +00:00
luigi1111
4c2f78aeeb
Merge pull request #6506 
42e1484 wallet2: fix keys file deserialization exception handling (xiphon)
 2020-05-07 10:43:05 -05:00
SomaticFanatic
5ef0607da6 Update copyright year to 2020 
Update copyright year to 2020
 2020-05-06 22:36:54 -04:00
luigi1111
3de804f1e9
Merge pull request #6485 
7a8c1ee wallet2: fix subaddress expansion when receiving monero (moneromooo-monero)
 2020-05-06 00:31:51 -05:00
luigi1111
98e3802b26
Merge pull request #6484 
e7d0105 message_store: don't print an error when there is no mms file (moneromooo-monero)
 2020-05-06 00:30:39 -05:00
luigi1111
9e3f72c375
Merge pull request #6480 
4f489fa wallet2: check_connection return false on get_version status != OK (xiphon)
 2020-05-06 00:28:18 -05:00
luigi1111
6d1f3c9acd
Merge pull request #6467 
8b655de simplewallet: report timestamp based expected unlock time on balance (moneromooo-monero)
 2020-05-05 23:40:44 -05:00
luigi1111
b4023dcfc5
Merge pull request #6441 
613071f use memwipe on secret k/alpha values (moneromooo-monero)
 2020-05-05 23:39:32 -05:00
xiphon
42e14840fb wallet2: fix keys file deserialization exception handling 2020-05-05 16:34:50 +00:00
luigi1111
c9b800a787
Merge pull request #6446 
e509ede trezor: adapt to new passphrase mechanism (ph4r05)
 2020-05-01 15:32:52 -05:00
moneromooo-monero
7a8c1eece9
wallet2: fix subaddress expansion when receiving monero 2020-04-27 16:48:19 +00:00
Dusan Klinec
e509ede2aa
trezor: adapt to new passphrase mechanism 
- choice where to enter passphrase is now made on the host
- use wipeable string in the comm stack
- wipe passphrase memory
- protocol optimizations, prepare for new firmware version
- minor fixes and improvements
- tests fixes, HF12 support
 2020-04-27 18:17:56 +02:00
moneromooo-monero
e7d01056f4
message_store: don't print an error when there is no mms file 
It confuses people
 2020-04-27 15:44:29 +00:00
xiphon
4f489fa6a2 wallet2: check_connection return false on get_version status != OK 2020-04-26 13:08:17 +00:00
moneromooo-monero
8b655de8ed
simplewallet: report timestamp based expected unlock time on balance 2020-04-22 13:34:58 +00:00
luigi1111
cc91c0221d
Merge pull request #6415 
09abca7 wallet_api: checkUpdate - optional version and buildtag params (xiphon)
 2020-04-21 08:52:57 -05:00
woodser
87d75584e8 Allow wallet2.h to run in WebAssembly 
- Add abstract_http_client.h which http_client.h extends.
- Replace simple_http_client with abstract_http_client in wallet2,
message_store, message_transporter, and node_rpc_proxy.
- Import and export wallet data in wallet2.
- Use #if defined __EMSCRIPTEN__ directives to skip incompatible code.
 2020-04-15 13:22:46 -04:00
moneromooo-monero
613071f4fa
use memwipe on secret k/alpha values 
Reported by UkoeHB_ and sarang
 2020-04-15 01:16:31 +00:00
luigi1111
bce050ee78
Merge pull request #6394 
69b5992 simplewallet: new 'address one-off <major> <minor>' command (moneromooo-monero)
 2020-04-10 16:06:10 -05:00
moneromooo-monero
69b5992296
simplewallet: new "address one-off <major> <minor>" command 2020-04-07 16:25:01 +00:00
luigi1111
cfc0f4a7fa
Merge pull request #6351 
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd)
5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd)
3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
 2020-04-04 12:55:02 -05:00
luigi1111
081d49c59f
Merge pull request #6338 
80d5320 Hash domain separation (SarangNoether)
 2020-04-04 12:44:45 -05:00
luigi1111
6011064693
Merge pull request #6334 
cc18926 wallet2_api: wallet recovery - seed offset passphrase support (xiphon)
 2020-04-04 12:41:32 -05:00
luigi1111
ab802b4b80
Merge pull request #6321 
1a6e7bd wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg (xiphon)
 2020-04-04 12:37:26 -05:00
xiphon
09abca76ae wallet_api: checkUpdate - optional version and buildtag params 2020-04-02 00:31:43 +00:00
Sarang Noether
80d5320fff Hash domain separation 2020-04-01 08:31:00 -04:00
xiphon
6d6af701ec cryptonote_basic: drop unused verification_context::m_not_rct field 2020-03-31 21:58:25 +00:00
luigi1111
f9de65b546
Merge pull request #6304 
2e9d1e6 wallet2: fix store-tx-info loading (moneromooo-monero)
 2020-03-31 15:13:19 -05:00
luigi1111
d0065f3063
Merge pull request #6302 
dab604e wallet2_api: implement estimateTransactionFee (xiphon)
 2020-03-31 15:12:48 -05:00
Alexander Blair
72262b348a
Merge pull request #6299 
9c1f970b wallet2: remember daemon address overrides when loading a new wallet (moneromooo-monero)
 2020-03-27 12:33:15 -07:00
Alexander Blair
5780594202
Merge pull request #6296 
50e59cfa wallet2: reject zero keys in json input (moneromooo-monero)
 2020-03-27 12:31:59 -07:00
Alexander Blair
8cb005b39c
Merge pull request #6289 
ffe7165e wallet: reroll fake outs selection on local tx_sanity_check failure (xiphon)
 2020-03-27 12:28:29 -07:00
Alexander Blair
5ba6eef272
Merge pull request #6288 
0349347e ringdb: use a different iv for key and data in rings table (moneromooo-monero)
7b882087 simplewallet: reword mixin in user message in terms of ring size (moneromooo-monero)
f507a43a wallet2: do not remove known rings when a tx fails (moneromooo-monero)
 2020-03-27 12:23:59 -07:00
Alexander Blair
d500bbe68f
Merge pull request #6268 
a6c24412 wallet: fix exceptions getting the hash of a pruned tx (moneromooo-monero)
 2020-03-12 01:02:31 -07:00
Lee Clagett
5fcc23ae0a Move hex->bin conversion to monero copyright files and with less includes 2020-03-09 05:23:59 +00:00
moneromooo-monero
9c1f970b82
wallet2: remember daemon address overrides when loading a new wallet 2020-03-07 18:09:31 +00:00
Alexander Blair
da617ac1b0
Merge pull request #6238 
f717d593 wallet2: guard against race with multiple decrypt_keys users (moneromooo-monero)
 2020-02-28 20:21:06 -08:00
Alexander Blair
5bd496e8ef
Merge pull request #6241 
ae84ec90 wallet-cli/rpc: allow sweep_all to use outputs in all subaddresses within an account (stoffu)
 2020-02-28 19:49:41 -08:00
Alexander Blair
a6cf4b09e7
Merge pull request #6235 
5cbb17b9 wallet2: fix hang in wallet refresh (moneromooo-monero)
 2020-02-28 19:48:41 -08:00
Alexander Blair
8606b1a14a
Merge pull request #6203 
ef95a76d remove unused variable 'ptx' from on_describe_transfer() (woodser)
 2020-02-28 19:34:41 -08:00
luigi1111
2de1137e60
Merge pull request #6194 
316ab7b wallet2: better error when restoring a wallet with the wrong keys (moneromooo-monero)
 2020-02-19 22:23:46 -05:00
luigi1111
22a0367398
Merge pull request #6190 
096a9db Wallet: Distingush amounts for a single subaddress (tmoravec)
 2020-02-19 22:22:36 -05:00
xiphon
cc18926eba wallet2_api: wallet recovery - seed offset passphrase support 2020-02-11 23:36:50 +00:00
xiphon
1a6e7bd40f wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg 2020-02-07 10:02:27 +00:00
Alexander Blair
995f34b538
Merge pull request #6103 
4b384003 wallet2: don't try to lock an empty filename (moneromooo-monero)
 2020-02-06 00:33:18 -08:00
Alexander Blair
756f06cd83
Merge pull request #6102 
b328de6b wallet_rpc_server: add tx weight in transfer commands responses (moneromooo-monero)
 2020-02-06 00:32:47 -08:00
Alexander Blair
3b224bb99d
Merge pull request #6069 
d64e5aa7 wallet: allow message sign/verify for subaddresses (moneromooo-monero)
 2020-02-06 00:29:32 -08:00
Alexander Blair
25c1bd4714
Merge pull request #6035 
b90c4bc3 rpc: error out from get_info if the proxied call errors out (moneromooo-monero)
fa16df99 make_test_signature: exit nicely on top level exception (moneromooo-monero)
054b2621 node_rpc_proxy: init some new rpc payment fields in invalidate (moneromooo-monero)
d0faae2a rpc: init a few missing client_info members (moneromooo-monero)
d56a483a rpc: do not propagate exceptions out of a dtor (moneromooo-monero)
3c849188 rpc: always set the update field in update on sucess (moneromooo-monero)
 2020-02-06 00:26:13 -08:00