monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-11-17 16:27:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

UB: Not calling virtual method in destructor of WalletImpl

Browse source
This commit is contained in:
mj-xmr 2021-08-16 10:11:05 +02:00
parent 8fde011dbe
commit eed7e79c04
No known key found for this signature in database
GPG key ID: C101BF94093451E0
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/wallet/api/wallet.cpp
View file

@ -450,7 +450,7 @@ WalletImpl::~WalletImpl()
LOG_PRINT_L1(__FUNCTION__); LOG_PRINT_L1(__FUNCTION__);
m_wallet->callback(NULL); m_wallet->callback(NULL);
// Pause refresh thread - prevents refresh from starting again // Pause refresh thread - prevents refresh from starting again
pauseRefresh(); WalletImpl::pauseRefresh(); // Call the method directly (not polymorphically) to protect against UB in destructor.
// Close wallet - stores cache and stops ongoing refresh operation // Close wallet - stores cache and stops ongoing refresh operation
close(false); // do not store wallet as part of the closing activities close(false); // do not store wallet as part of the closing activities
// Stop refresh thread // Stop refresh thread