monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-24 12:39:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

ringct: fix off by 1 in mixin usage

Browse source
This commit is contained in:
moneromooo-monero 2016-06-04 09:37:38 +01:00
parent 09c5ea43a2
commit e816a09292
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/ringct/rctSigs.cpp
View file

@ -439,14 +439,14 @@ namespace rct {
//These functions get keys from blockchain //These functions get keys from blockchain
//replace these when connecting blockchain //replace these when connecting blockchain
//getKeyFromBlockchain grabs a key from the blockchain at "reference_index" to mix with //getKeyFromBlockchain grabs a key from the blockchain at "reference_index" to mix with
//populateFromBlockchain creates a keymatrix with "mixin" columns and one of the columns is inPk //populateFromBlockchain creates a keymatrix with "mixin" + 1 columns and one of the columns is inPk
// the return value are the key matrix, and the index where inPk was put (random). // the return value are the key matrix, and the index where inPk was put (random).
tuple<ctkeyM, xmr_amount> populateFromBlockchain(ctkeyV inPk, int mixin) { tuple<ctkeyM, xmr_amount> populateFromBlockchain(ctkeyV inPk, int mixin) {
int rows = inPk.size(); int rows = inPk.size();
ctkeyM rv(mixin, inPk); ctkeyM rv(mixin + 1, inPk);
int index = randXmrAmount(mixin); int index = randXmrAmount(mixin);
int i = 0, j = 0; int i = 0, j = 0;
for (i = 0; i < mixin; i++) { for (i = 0; i <= mixin; i++) {
if (i != index) { if (i != index) {
for (j = 0; j < rows; j++) { for (j = 0; j < rows; j++) {
getKeyFromBlockchain(rv[i][j], (size_t)randXmrAmount); getKeyFromBlockchain(rv[i][j], (size_t)randXmrAmount);