monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-24 04:29:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

util: use fcntl instead of flock, for compatibility

Browse source 
in particular with NFS
This commit is contained in:
moneromooo-monero 2018-12-05 14:52:43 +00:00
parent 1505dd38c9
commit db5737413e
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
1 changed files with 26 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/common/util.cpp
View file

@ -84,6 +84,29 @@ using namespace epee;
#undef MONERO_DEFAULT_LOG_CATEGORY #undef MONERO_DEFAULT_LOG_CATEGORY
#define MONERO_DEFAULT_LOG_CATEGORY "util" #define MONERO_DEFAULT_LOG_CATEGORY "util"
namespace
{
#ifndef _WIN32
static int flock_exnb(int fd)
{
struct flock fl;
int ret;
memset(&fl, 0, sizeof(fl));
fl.l_type = F_WRLCK;
fl.l_whence = SEEK_SET;
fl.l_start = 0;
fl.l_len = 0;
ret = fcntl(fd, F_SETLK, &fl);
if (ret < 0)
MERROR("Error locking fd " << fd << ": " << errno << " (" << strerror(errno) << ")");
return ret;
}
#endif
}
namespace tools namespace tools
{ {
std::function<void(int)> signal_handler::m_handler; std::function<void(int)> signal_handler::m_handler;
@ -184,7 +207,7 @@ namespace tools
struct stat wstats = {}; struct stat wstats = {};
if (fstat(fdw, std::addressof(wstats)) == 0 && if (fstat(fdw, std::addressof(wstats)) == 0 &&
rstats.st_dev == wstats.st_dev && rstats.st_ino == wstats.st_ino && rstats.st_dev == wstats.st_dev && rstats.st_ino == wstats.st_ino &&
flock(fdw, (LOCK_EX | LOCK_NB)) == 0 && ftruncate(fdw, 0) == 0) flock_exnb(fdw) == 0 && ftruncate(fdw, 0) == 0)
{ {
std::FILE* file = fdopen(fdw, "w"); std::FILE* file = fdopen(fdw, "w");
if (file) return {file, std::move(name)}; if (file) return {file, std::move(name)};
@ -237,10 +260,10 @@ namespace tools
MERROR("Failed to open " << filename << ": " << std::error_code(GetLastError(), std::system_category())); MERROR("Failed to open " << filename << ": " << std::error_code(GetLastError(), std::system_category()));
} }
#else #else
m_fd = open(filename.c_str(), O_RDONLY | O_CREAT | O_CLOEXEC, 0666); m_fd = open(filename.c_str(), O_RDWR | O_CREAT | O_CLOEXEC, 0666);
if (m_fd != -1) if (m_fd != -1)
{ {
if (flock(m_fd, LOCK_EX | LOCK_NB) == -1) if (flock_exnb(m_fd) == -1)
{ {
MERROR("Failed to lock " << filename << ": " << std::strerror(errno)); MERROR("Failed to lock " << filename << ": " << std::strerror(errno));
close(m_fd); close(m_fd);