monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-11-18 00:37:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

wallet2: fix infinite loop on future refresh height

Browse source 
If the refresh height is in the future, the current code will
loop till the actual height reaches this. Fix it by bailing out
if we receive only three hashes, which is what we set in the
call parameters.
This commit is contained in:
moneromooo-monero 2017-06-26 06:56:44 +01:00
parent 32754784db
commit d3bb72fff1
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/wallet/wallet2.cpp
View file

@ -1601,7 +1601,7 @@ void wallet2::fast_refresh(uint64_t stop_height, uint64_t &blocks_start_height,
while(m_run.load(std::memory_order_relaxed) && current_index < stop_height) while(m_run.load(std::memory_order_relaxed) && current_index < stop_height)
{ {
pull_hashes(0, blocks_start_height, short_chain_history, hashes); pull_hashes(0, blocks_start_height, short_chain_history, hashes);
if (hashes.size() < 3) if (hashes.size() <= 3)
return; return;
if (hashes.size() + current_index < stop_height) { if (hashes.size() + current_index < stop_height) {
std::list<crypto::hash>::iterator right; std::list<crypto::hash>::iterator right;