monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-23 03:59:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

easylogging++: avoid buffer underflow

Browse source
This commit is contained in:
moneromooo-monero 2017-12-10 15:32:42 +00:00
parent 187a6ab2d2
commit c2ed8618e4
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
external/easylogging++/easylogging++.cc vendored
View file

@ -1016,8 +1016,9 @@ const std::string OS::getBashOutput(const char* command) {
char hBuff[4096]; char hBuff[4096];
if (fgets(hBuff, sizeof(hBuff), proc) != nullptr) { if (fgets(hBuff, sizeof(hBuff), proc) != nullptr) {
pclose(proc); pclose(proc);
if (hBuff[strlen(hBuff) - 1] == '\n') { const size_t len = strlen(hBuff);
hBuff[strlen(hBuff) - 1] = '\0'; if (len > 0 && hBuff[len - 1] == '\n') {
hBuff[len- 1] = '\0';
} }
return std::string(hBuff); return std::string(hBuff);
} }