monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-11-17 16:27:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

cryptonote_protocol: fix corner case looping asking for same block hashes

Browse source
This commit is contained in:
moneromooo-monero 2017-12-03 13:05:10 +00:00
parent 8512a83572
commit b927f0b17e
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/cryptonote_protocol/cryptonote_protocol_handler.inl
View file

@ -1414,6 +1414,10 @@ skip:
// take out blocks we already have // take out blocks we already have
while (!context.m_needed_objects.empty() && m_core.have_block(context.m_needed_objects.front())) while (!context.m_needed_objects.empty() && m_core.have_block(context.m_needed_objects.front()))
{ {
// if we're popping the last hash, record it so we can ask again from that hash,
// this prevents never being able to progress on peers we get old hash lists from
if (context.m_needed_objects.size() == 1)
context.m_last_known_hash = context.m_needed_objects.front();
context.m_needed_objects.pop_front(); context.m_needed_objects.pop_front();
} }
const uint64_t first_block_height = context.m_last_response_height - context.m_needed_objects.size() + 1; const uint64_t first_block_height = context.m_last_response_height - context.m_needed_objects.size() + 1;