monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-23 20:19:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Merge pull request #3726

Browse source 
b5cb1bc blockchain: avoid exception if asked for a block we do not have (moneromooo-monero)
This commit is contained in:
luigi1111 2018-06-16 14:02:56 -05:00
commit b3363e8e0a
No known key found for this signature in database
GPG key ID: F4ACA0183641E010
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/cryptonote_core/blockchain.cpp
View file

@ -2095,15 +2095,18 @@ bool Blockchain::get_blocks(const t_ids_container& block_ids, t_blocks_container
{ {
try try
{ {
blocks.push_back(std::make_pair(m_db->get_block_blob(block_hash), block())); uint64_t height = 0;
if (m_db->block_exists(block_hash, &height))
{
blocks.push_back(std::make_pair(m_db->get_block_blob_from_height(height), block()));
if (!parse_and_validate_block_from_blob(blocks.back().first, blocks.back().second)) if (!parse_and_validate_block_from_blob(blocks.back().first, blocks.back().second))
{ {
LOG_ERROR("Invalid block"); LOG_ERROR("Invalid block: " << block_hash);
return false; blocks.pop_back();
missed_bs.push_back(block_hash);
} }
} }
catch (const BLOCK_DNE& e) else
{
missed_bs.push_back(block_hash); missed_bs.push_back(block_hash);
} }
catch (const std::exception& e) catch (const std::exception& e)