monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-11-18 00:37:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

simplewallet: fix show_transfers colouring, and add red for failed

Browse source 
Also add the type back, as it was somehow weirdly split into
two different fields, one being a union...
This commit is contained in:
moneromooo-monero 2018-12-23 15:14:16 +00:00
parent ed54ac8fdf
commit 5e10dee3ea
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/simplewallet/simplewallet.cpp
View file

@ -7137,6 +7137,7 @@ bool simple_wallet::get_transfers(std::vector<std::string>& local_args, std::vec
const std::string type = pd.m_coinbase ? tr("block") : tr("in"); const std::string type = pd.m_coinbase ? tr("block") : tr("in");
const bool unlocked = m_wallet->is_transfer_unlocked(pd.m_unlock_time, pd.m_block_height); const bool unlocked = m_wallet->is_transfer_unlocked(pd.m_unlock_time, pd.m_block_height);
transfers.push_back({ transfers.push_back({
type,
pd.m_block_height, pd.m_block_height,
pd.m_timestamp, pd.m_timestamp,
type, type,
@ -7169,6 +7170,7 @@ bool simple_wallet::get_transfers(std::vector<std::string>& local_args, std::vec
payment_id = payment_id.substr(0,16); payment_id = payment_id.substr(0,16);
std::string note = m_wallet->get_tx_note(i->first); std::string note = m_wallet->get_tx_note(i->first);
transfers.push_back({ transfers.push_back({
"out",
pd.m_block_height, pd.m_block_height,
pd.m_timestamp, pd.m_timestamp,
"out", "out",
@ -7205,6 +7207,7 @@ bool simple_wallet::get_transfers(std::vector<std::string>& local_args, std::vec
if (i->second.m_double_spend_seen) if (i->second.m_double_spend_seen)
double_spend_note = tr("[Double spend seen on the network: this transaction may or may not end up being mined] "); double_spend_note = tr("[Double spend seen on the network: this transaction may or may not end up being mined] ");
transfers.push_back({ transfers.push_back({
"pool",
"pool", "pool",
pd.m_timestamp, pd.m_timestamp,
"in", "in",
@ -7245,6 +7248,7 @@ bool simple_wallet::get_transfers(std::vector<std::string>& local_args, std::vec
bool is_failed = pd.m_state == tools::wallet2::unconfirmed_transfer_details::failed; bool is_failed = pd.m_state == tools::wallet2::unconfirmed_transfer_details::failed;
if ((failed && is_failed) || (!is_failed && pending)) { if ((failed && is_failed) || (!is_failed && pending)) {
transfers.push_back({ transfers.push_back({
(is_failed ? "failed" : "pending"),
(is_failed ? "failed" : "pending"), (is_failed ? "failed" : "pending"),
pd.m_timestamp, pd.m_timestamp,
"out", "out",
@ -7293,7 +7297,7 @@ bool simple_wallet::show_transfers(const std::vector<std::string> &args_)
for (const auto& transfer : all_transfers) for (const auto& transfer : all_transfers)
{ {
const auto color = transfer.confirmed ? ((transfer.direction == "in" || transfer.direction == "block") ? console_color_green : console_color_magenta) : console_color_white; const auto color = transfer.type == "failed" ? console_color_red : transfer.confirmed ? ((transfer.direction == "in" || transfer.direction == "block") ? console_color_green : console_color_magenta) : console_color_default;
std::string destinations = "-"; std::string destinations = "-";
if (!transfer.outputs.empty()) if (!transfer.outputs.empty())

1
src/simplewallet/simplewallet.h
View file

@ -254,6 +254,7 @@ namespace cryptonote
struct transfer_view struct transfer_view
{ {
std::string type;
boost::variant<uint64_t, std::string> block; boost::variant<uint64_t, std::string> block;
uint64_t timestamp; uint64_t timestamp;
std::string direction; std::string direction;