monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-10-30 04:57:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

unit_tests: suppress memwipe unit warning

Browse source 
Fixes warning:
```
warning: ‘*(uint32_t*)quux’ may be used uninitialized [-Wmaybe-uninitialized]
   49 |     MDEBUG(std::hex << std::setw(8) << std::setfill('0') << *(uint32_t*)quux);
warning: ‘quux’ may be used uninitialized [-Wmaybe-uninitialized]
   50 |     if (wipe) { ASSERT_TRUE(memcmp(quux, "bar", 3)); }
```
This commit is contained in:
Jeffrey Ryan 2022-09-16 10:45:32 -05:00
parent 6402dbee69
commit 50b7492e67
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/unit_tests/memwipe.cpp
View file

@ -31,6 +31,7 @@
#include <stdint.h> #include <stdint.h>
#include "misc_log_ex.h" #include "misc_log_ex.h"
#include "memwipe.h" #include "memwipe.h"
#include "warnings.h"
// Probably won't catch the optimized out case, but at least we test // Probably won't catch the optimized out case, but at least we test
// it works in the normal case // it works in the normal case
@ -44,12 +45,15 @@ static void test(bool wipe)
ASSERT_EQ(foo, bar); ASSERT_EQ(foo, bar);
free(foo); free(foo);
char *quux = (char*)malloc(4); // same size, just after free, so we're likely to get the same, depending on the allocator char *quux = (char*)malloc(4); // same size, just after free, so we're likely to get the same, depending on the allocator
PUSH_WARNINGS
DISABLE_GCC_WARNING(maybe-uninitialized)
if ((intptr_t)quux == foop) if ((intptr_t)quux == foop)
{ {
MDEBUG(std::hex << std::setw(8) << std::setfill('0') << *(uint32_t*)quux); MDEBUG(std::hex << std::setw(8) << std::setfill('0') << *(uint32_t*)quux);
if (wipe) { ASSERT_TRUE(memcmp(quux, "bar", 3)); } if (wipe) { ASSERT_TRUE(memcmp(quux, "bar", 3)); }
} }
else MWARNING("We did not get the same location, cannot check"); else MWARNING("We did not get the same location, cannot check");
POP_WARNINGS
free(quux); free(quux);
} }