monero-project/monero
monero-project/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-11-17 16:27:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

wipeable_string: don't try to wipe an empty buffer

Browse source 
memset_s doesn't like it
This commit is contained in:
moneromooo-monero 2018-02-18 13:45:43 +00:00
parent 4f80c50730
commit 4789f8598f
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
contrib/epee/src/wipeable_string.cpp
View file

@ -76,6 +76,7 @@ wipeable_string::~wipeable_string()
void wipeable_string::wipe() void wipeable_string::wipe()
{ {
if (!buffer.empty())
memwipe(buffer.data(), buffer.size() * sizeof(char)); memwipe(buffer.data(), buffer.size() * sizeof(char));
} }
@ -93,10 +94,12 @@ void wipeable_string::grow(size_t sz, size_t reserved)
size_t old_sz = buffer.size(); size_t old_sz = buffer.size();
std::unique_ptr<char[]> tmp{new char[old_sz]}; std::unique_ptr<char[]> tmp{new char[old_sz]};
memcpy(tmp.get(), buffer.data(), old_sz * sizeof(char)); memcpy(tmp.get(), buffer.data(), old_sz * sizeof(char));
if (old_sz > 0)
memwipe(buffer.data(), old_sz * sizeof(char)); memwipe(buffer.data(), old_sz * sizeof(char));
buffer.reserve(reserved); buffer.reserve(reserved);
buffer.resize(sz); buffer.resize(sz);
memcpy(buffer.data(), tmp.get(), old_sz * sizeof(char)); memcpy(buffer.data(), tmp.get(), old_sz * sizeof(char));
if (old_sz > 0)
memwipe(tmp.get(), old_sz * sizeof(char)); memwipe(tmp.get(), old_sz * sizeof(char));
} }