--- layout: post title: Overview and Logs for the Dev Meeting Held on 2017-05-07 summary: Sub / disposable addresses, smart mining GUI, 0MQ, and MyMonero-in-tree discussion tags: [dev diaries, core, crypto] author: dEBRUYNE / fluffypony --- ### Overview An overview [can be found on MoneroBase](https://monerobase.com/wiki/DevMeeting_2017-05-07). ### Logs **\** 1. Greetings **\** 2. Brief review of what's been completed since the previous meeting **\** 3. Code + ticket discussion / Q & A **\** 4. MyMonero-in-tree discussion **\** 5. Any additional meeting items **\** 6. Confirm next meeting date/time **\** so let's start with 1. Greetings (aka roll call) **\** hi **\** hi **\** present **\** hello! **\** tewinget apologises, he'll be late **\** Sup **\** o/ **\** Yo **\** hyc / luigi1111 / ArticMine / othe / smooth / anonimal / binaryFate / dEBRUYNE / dnaleor / gingeropolous / iDunk / IPGlider / Jaquee / jwinterm / kenshi84 / knaccc / luigi1112 / luigi1115 / NoodleDoodle / papalazzarou / pigeons / RedLion[m] / redlion **\** hhelo **\** :) **\** also me **\** medusa **\** anyone I forgot **\** o/ **\** oh those are not present whoops **\** lol vtnerd **\** ok so **\** 2. Brief review of what's been completed since the previous meeting **\** merged a bunch PRs **\** kenshi84's GPG key changed **\** I've confirmed it via sidechannel **\** we have a new sweepbelow function in the CLI, which you may find useful **\** we also have a new heavier bias in output selection towards newer outputs **\** moneromooo can fill us in on that **\** Hi **\** oi **\** smart mining is enabled in the GUI **\** as in the selection box **\** Hmm, I just twiddled the settings for the recent output selection, really. To match some data in the Miller et al paper. **\** which is pretty cool **\** indeed **\** also Jaquee has done some work on getting iOS back on track after it borked (visually) **\** well iOS / mobile **\** which brings us to **\** 3. Code + ticket discussion / Q & A **\** yes. and there's some new translations added to gui **\** we have a number of open PRs **\** when tewinget is off his bus he can update us on 0MQ **\** which I'd REALLY like to move forward with ASAP **\** it's been sitting in a holding pattern for ages **\** Snipa: also if you're around maybe you can update us on the testing on that ? **\** I'd like it to be optional, so it can be merged (and thus tested), without causing massive breakage if it does break. **\** afaik that was the case **\** sounds like a good idea **\** also disposable addresses is still hanging around - I think that's pending a review from one of the luigis? **\** AFAIK yes. Also RandomRun had an idea to make it better. **\** I don't think there's a problem with that hanging around and being improved **\** as long as the parallel MRL write-up is there **\** I'd like to discuss 1998 **\** the PR, not the year **\** https://github.com/monero-project/monero/pull/1998 **\** at this point in time I'm still swaying towards prevent-user-stupidity-by-default **\** at the slight inconvenience for a power user / sysadmin who might go "omg really" and then add the flag **\** I know vtnerd feels the same way, which is why he added it in the first place **\** I'd be interested in strong arguments for removing the flag **\** wouldnt a text disclaimer be enough? **\** i don't have a strong opinion **\** Jaquee: if you try bind externally and start it without the --confirm-external-bind flag then it refuses to start **\** and it tells you why **\** ok. apparently hyc started the discussion. Are you around? **\** I know hyc doesn't like it **\** vtnerd: has anyone else expressed disdain for it? **\** AFAIK, just the people on that PR and the one referenced **\** and possibly one person in IRC, but they seemed to be questioning why it was necessary (I think) **\** its somewhat low effort to get around it, so most people just add the flag I thnk **\** no one has privately contacted me about it for any reason if that was the question **\** ok **\** unless hyc comes in I move to close the PR, we can always re-open it later **\** ok with me **\** ok next PR for discussion is 2011 **\** moneromooo had concerns that it was touching consensus critical issues **\** so/issues/part of the code **\** Yes, but it turns out it's actually bypassed when a tx comes from a block. The patch is fine. **\** I OK'd it since. **\** ah ok' **\** Well, wait. **\* fluffypony** stops...hammer time **\** It's really uneeded (only the wallet bit was wanted). But it's not forkworthy. That said... **\** Older wallets *might* create txes which aren't relayed by newer daemons. **\** That's fairly unlikely, since my code targets 2/3 of max size, but the size approximation is not very precise. **\** That said, I think it's fine to merge. **\** hey. just popped in. reading history **\** hi hyc ! **\** Re: 2011, perhaps it also should be dependent on the fee priority level used **\* fluffypony** plays elevator hold music **\** ok, if n0b0dy else cares about that external bind thing then whatever. to me it's redundant **\** ok **\** since you had to explicitly request a non-localhost address already **\** sure, but you'd be surprised how few people know that 0.0.0.0 exposes everything :-P **\** ^ **\** it d0esn't protect against typos/accidents. it only pisses off people who expect the computer to do as it's told **\** hyc: view it like a weak password warning **\** you can't just expect the computer to accept 1234 as a password **\** yeah, ok... **\** Well, I would... **\** lol **\** moneromooo is the exception to every rule :-P **\** now on the GUI side, the only thing I wanted to bounce around is 688 **\** tooltips are fine, but if we're going to do some sort of unified help then I would veer towards an overlay that shows once the first time you enter a screen, and can be re-called by clicking the [?] button on the taskbar **\** https://s-media-cache-ak0.pinimg.com/originals/c1/e1/bf/c1e1bfd7fb2770f6745d95af8bf89865.jpg **\** like that style **\** https://s-media-cache-ak0.pinimg.com/originals/43/6e/74/436e746b35142f41d5f9bb8e765963e4.jpg **\** http://eyeviewportal.com/filecache/b38/73d/85-cropped-w545-h409-of-1-FFFFFF-evappguiguidecontentimage002.jpg **\** like that **\** sounds good **\** :+1: **\** problem is [?] is not around if you use native title bar **\** Jaquee: where else could we add a help button? bottom left? **\** one suggestion i'd make for that is to make it c lear to the user they can recall it easily by doing "X" so that they don't fret about having to memorize everything before it's closed **\** recall it -> the help screen **\** i think ^ is good as a start **\** Where is it on the title bar then, since it's not a WM thing ? **\** endogenic: agreed **\** s/Where/Why/ **\** but some buttons could need longer desriptions **\** like sweepunmixable and paymentid for example **\** Jaquee: there's enough space in the help overlay, we can use a smaller font to explain them **\** how breadwallet on ios handles it when setting up is quite good **\** or move the help to somewhere where there's space **\** and use an arrow **\** yeah. we could find a place for that help button **\** ok - any other PRs that need discussion or can we move on? there's general Q&A shortly **\** I'd like to merge 261 on monero-site **\** sgp: there's a website meeting after the Kovri one **\** so we can discuss it then **\** ok **\** ok so **\** 4. MyMonero-in-tree discussion **\** so basically this is about nose-covering and making sure I'm not abusing my position as a maintainer and member of the Monero Core Team **\** currently MyMonero has a working API (largely unspecced to be sure), two client implementations (website and app), two server implementations (the live backend and OpenMonero), with a third one coming **\** I'd like to make sure there is general acceptance and buy-in that the API can be implemented as the general API for lightweight wallets (ie. wallet that use remote viewkey scanning) **\** is it carved in stone now **\** if we need to tweak it we can still do that? **\** is the license unrestricted? **\** and that MyMonero-written or MyMonero-derived code is generally acceptable to be merged into the source tree (ie. the open-source backend implementation that vtnerd is working on) **\** redlion: BSD 3-clause **\** hyc: as long as mWo12 changes it, and we match the changes in the live backend and the new backend then yse **\** yes **\** we can make any changes, and we WILL make changes to make it smarter **\** If it's beneficial to monero and it works fully by itself without needing proprietary gunk, then I'm OK with it. **\** eg. tx history comes in raw, instead of paginated **\** so that needs to change **\** +1 moneromooo **\** moneromooo: yeah the new backend will use LMDB instead of mysql **\** so it will be unencumbered in the source **\** As long as there are no proprietary dependencies I am fine **\** I like it even more now ;) **\** I think it beneficial too **\** Maybe a separate repo (similar to monero-core) might be best, but that's details. **\** \*its **\** it's **\** it's **\** can't wait to run a mymonero node myself! **\** also the current "primary" wrapper around the DB is actually C, so theres that for you guys **\** moneromooo: I thought about that, but it's a single daemon that *should* exist in the repo alongside the wallet RPC etc. **\** doesn't it supersede wallet-rpc? **\** now **\** hyc: no **\** wallet-rpc is good for integration, this isn't **\** there is obviously an element of centralisation, but it’s nearly impossible to avoid **\** also on this topic **\** Jaquee has begun working on client integration in the CLI and GUI **\** "client integration" ? **\** you mean for light-wallets? **\** that will mean that both CLI and GUI will be able to run in lightweight / remote-scanner / MyMonero mode **\** moneromooo: as opposed to implementing the server protocol **\** sounds good **\** Oh, mymonero client integration ? **\** moneromooo: let's call it something else **\** That went pretty damn fast :D **\** "lightweight wallet" **\** it's not really centralization if any `monerod` acts as a server **\** but I'm still missing why we need old wallet-rpc if this mymonero api exists **\** it's literally my monero :) **\** hyc: wallet-rpc is completely different **\** so the core GUI will be able to interact with MyMonero backend too? **\** for people that want to run VPS node but keep their viewkey ? **\** Yes, would be nice to see what bits are needed where, and the actual API (even if roughly). **\** it provides an API for integrators **\** @johnalan yes **\** so basically **\** is this needed with the MyMonero Desktop wallet? **\** With what as the backed / server **\** That can be posted later though, :49 now. **\** monerod? **\** lightweight wallets will have 3 server options: **\** 1. OpenMonero **\** 2. the new in-source backend that vtnerd is working on **\** 3. the live MyMonero backend **\** it will also have multiple client options: **\** afaik the main difference btw an ordinary wallet and mymomero is you tell mymonero your viewkey **\** 1. OpenMonero's web wallet (clone of the current MyMonero web wallet) **\** and the ordinary wallet has all your keys **\** 2. the MyMonero applications **\** 3. monero-wallet-cli **\** 4. monero-wallet-rpc **\** 5. the Monero GUI **\** hyc: monero-wallet-rpc can still use this on the backend **\** so it's unrelated **\** ok **\** ok **\** about #2011 - you could modify it to (median)+0.6% for it to be mine-worthy, or even have the wallet check for fee setting and then it would be matched like 1: +0.6%, 2: +2.4%, 3: +12%, 4:+100% **\** also this will mean that the GUI / CLI may end up supporting the MyMonero 13-word seed derivation by virtue of the integration effort **\** does anyone have a fundamental issue with that ? **\** no **\** I mean, I do, because I don't want to be abusing my position, but it is what it is :-P **\** didn't you deprecate 13-word? **\** Did you not say the 13 word seed was going to be obsoleted ? **\** jollymort: working on it **\** no **\** but client still needs to be able to read 'em **\** electrum/mycelium support a few different seed lengths iirc **\** works well **\** also luigi was playing around with an idea for 17-word, integrating creation height in it etc **\** moneromooo: it's import only **\** not create **\** https://github.com/mymonero/mymonero-app-js/issues/77 **\** doesn't it put a huge load on mymonero when someone asks it to scan the blockchain from zero with their view key? How long does mymonero take to scan the entire blockchain? **\** Anyway, I'm fine with that as presented. **\** that all sounds like a win to me. people have been whining about not being able to import their 13-word seed into regular CLI wallet **\** so monero-wallet-cli/monero GUI will not be able to create light-wallets? **\** knaccc: yes it does - about 10 minutes **\** yeah import only sounds lovely **\** If we are setting the stage for a competitive market based upon FLOSS then I am fine with it **\** I do have the ASM code working, so hopefully that will tighten up some too (altough there is something else blocking that) **\** shuannelson: yes they will **\** but with 25 word seed, not 13 **\** we have 7 minutes left - so I'd like to move on to the last item **\** awesome! **\** we can discuss MyMonero more after the meeting **\** @shaunnelson, I think it's just that the CLI/GUI won't create 13-word seeds, but will accept already created ones **\** yeah sounds fine **\** 5. Any additional meeting items **\** 10 mins is quite a speedup vs downloading the entire blockchain, so sounds awesome. **\** any thoughts on future of penalty/blocksize? i kind of left the research open-ended **\** ^^ get a faster CPU and it'll be quicker ') **\** Does anyone have a working monero-core or mymonero build on ios currently? I've been fiddling around and I can't seem to get either properly functional on the sim/device, though I may be missing something **\** lol hyc **\** redlion: pls come join #mymonero but yes i do :) **\** redlion: i have. it has some nasty bugs but it's running **\** ok thanks, I'll talk to you after this **\** btw iOS still limits process VM size to 4GB so we won't be running monerod native on iOS any time soon **\** @jollymort let's discuss it after the meeting, or maybe next week - there are 2 more meetings to go tonight :) **\** and that's a large topic **\** sure, another time **\** thanks jaquee, are there any build instructions or a (sort of) working build posted somewhere? **\** 6. Confirm next meeting date/time **\** May 21 **\** day before Consensus **\** cool **\** oh. this week I expect to have wolf miner fully ported to Android, with GPU support too **\** endogenic can come to my hotel and we can do the meeting together :-P **\** oooh **\** anyway, I have the daemon's side of the code rebased and *nearly* ready to PR and merge. I mean, it could be merged now, but I should clean it up a little/address a few more of the comments on the existing PR first. **\** the wallet side of things will be based on that, and won't take too long. I just thought it made sense to separate it into two PRs (and rebase while I'm at it because why not?) **\** suweet **\** just check the meeting logs for the bit from moneromooo about it **\** (the wallet stuff is still "done already", but as with the daemon side there are comments/suggestions to address as I rebase it as well.) **\** at any rate, I plan today to finish with the cleanup of the daemon side of things, close the existing PR, and open a new one for the daemon that should be mergeable. **\** great stuff **\** pigeons: did you see the 96boards thing? **\** fluffypony: sorry I didn't respond right away to your pinging on the github PR, but when I said it was already rebased I meant on a different branch, as I'm leaving that branch up (and separate) until I finish rebasing. **\** ok cool **\** tewinget: is the 0MQ stuff deselectable if needed (so if it somehow breaks, you can run the wallet with the existing JSON comms) ? **\** wallet/daemon **\** moneromooo: I'll make it so when I rebase the wallet side of things. **\** Excellent, thank you :)