--- layout: post title: Overview and Logs for the Dev Meeting Held on 2016-10-02 summary: Review and discussion of Open PRs, brief update on Ring CT, the official GUI, and Trezor for Monero tags: [dev diaries, core, crypto, 0mq] author: dEBRUYNE / fluffypony --- ### Overview An overview [can be found on Hello Monero](https://hellomonero.com/article/monero-and-kovri-dev-meeting-note-highlights-2016-10-02) ### Logs **\** Hi all **\** starting meeting bot **\** I'm none of them. **\** I am here **\** moneromooo: I know you're here :) **\** ok meeting bot is up **\** watching **\** so **\ [anonimal]** #kovri-dev too? **\** kovri-dev is roped in too **\** k **\ [i2p-relay] {-moneromooo}** o **\** this is our first post-0.10.0 meeting **\** the 0.10.0 release went fairly smoothly **\** apart from the boost oddities **\** on the Boost serialisation stuff **\** it's not really feasible to do a point release just for that just yet - in a few weeks I'll have local build infrastructure that will make releases a lot easier on me **\** since I can secure local machines far more easily than Internet-facing machines at a DC **\** in the interim, if anyone is struggling with it the easiest thing for them to do is recover their wallet from the seed / keys **\** And keep the old cache if they have tx keys they want to keep. **\** ^^ **\** I'd also like to welcome all the new contributors **\** even if it's just correcting a spelling error, all contributions are valuable **\** and very much appreciated **\** one thing I would like to encourage with the new contributors is to submit your GPG key via PR **\** and side-channel it to myself or moneromooo or someone so we can independently verify the correct key goes in **\** they live in utils/gpg_keys/ **\ [anonimal]** and if moneromooo says "ok" in your PR, that's a GOOD thing! **\** and then once you've done that you can GPG sign your commits with -S **\** eg. git commit -S -am "meaningful commit message" **\** Only if it's at the start. **\** Is there anything that needs to be made for iOS **\** lol anonimal **\** patthehuman: it's an open-source project, so if you want to build something for iOS then please do **\** no need to ask permission or anyway **\** I'd be interested to see if we could package a full node for iOS (without the wallet, lest it get removed from the app store) **\** sure, i guess i'm wondering more along the lines of what needs to be built **\** can you outline how that would work? **\** and then an old iPhone or iPod Touch would work as a full node on wifi **\** well we have native ARMv8 builds **\** and interacting with the daemon over RPC isn't hard **\** Why not just go with Cydia on jailbroken iOS? **\** but I have no idea if an iOS app would let you arbitrarily launch a process **\** ArticMine: too few jailbreak their devices, no? **\** ArticMine: absolutely - would be nice to be able to launch it as an app tho **\** generally apps get removed from the app store if they are simple "remotes" **\** fluffypony: iOS does not allow you to spawn processes... no NSTask etc equivalent **\** ah **\** ArcticMine: I think Cydia is a good plan B. Not many non tech people are going to have jail broken phones **\** right, they have a list of closed API's that will get you banned **\** does Objective-C let you also run native C / C++ code? **\** fluffypony: yep as long as you can compile for an ARM target **\** compile it* **\** ArticMine : A good idea and a lot of IOS devices have Jailbreak , Remember that XMR are used in the DNM as well **\** yeah we have ARMv8 support across the board **\** Objective-C is a strict superset of C, so any C is good, and C++ can be compiled too **\** Net applications Android 69.18% IOS 25.02% market share **\** anyway we're getting side-tracked a little - patthehuman feel free to play around with it, if you feel like it **\** sure **\** so **\** ringCT is live in testnet, and more testing would be appreciated **\** mWo12's testnet block explorer is helpful **\** but performance testing is also immensely useful **\** see what cracks under pressure **\** we have a short window until the January hard fork, so we need to hammer testnet as much as possible **\** is there a testnet faucet somewhere? or is mining or irc begging for testnet xmr recommended? **\** just ask me and I'll send testnet XMR your way **\** are there any automation processes that can hammer on testnet? **\** i have access to a lot of r510 servers that i could potentially mirror some script to hammer on it **\** patthehuman: you could pretty much just write a bash script to send to yourself once a second **\** and cycle it that way **\** cool **\** and then see how your testnet node(s) handle catch ups, and if they keep up with testnet when blocks are bigger **\** we also have our new buildbots ticking along nicely **\** so we'll be killing off Travis at some point in the coming weeks **\** build bot output has been relegated to #monero-bots **\** and that channel is relayed to irc2p **\ [anonimal]** Thanks pigeons **\ [anonimal]** monero-build.i2p is also online **\** yeah pigeons has done great work **\** at the moment we're building for a ton of platforms **\** including macOS 10.9, 10.10, 10.11 **\** so we should pick up PRs that break compilation more rapidly **\** how we handle testing is a bit harder **\** especially since some of the tests take several hours to run **\** my current leaning is towards nightly builds + tests **\** (of master) **\** that way we'll catch tests that are broken by any merged PRs **\** Daily core_tests would be useful. **\** performance_tests would also be useful **\** that way we can track anything that has a huge impact on performance **\** As long as the outcome can be seen without too many hoops (ie, javacrsipt) **\** moneromooo: we'll probably just grab the output, parse it, and shove it in a database **\** then we can create a profiler for the site without too many issues **\** on the PR side **\** has anyone looked at 1082? **\** no my apologies for being new but can you elaborate on what 1082 is **\** or actually moneromooo: can you give everyone a brief overview of what 1082 does **\** oh sorry patthehuman - PR = pull request **\** so PR 1082 = https://github.com/monero-project/monero/pull/1082 **\** yeah im familiar with PR's (worst part of my work day lol) **\** Ah, as the comment says, really. **\** It just tries to avoid the case where someone sends money just after receiving it. **\** That's a common enough case. **\** "25% of the outputs are selected from the last 5 days (if possible), in order to avoid the common case of sending recently received outputs again. 25% and 5 days are subject to review later, since it's just a wallet level change." **\** where did the 25% come from? 25% seems somewhat arbitrary. did MRL have input on this number? **\** They're aribtrary. **\** trustedsetup: the MRL is of the opinion that we're never going to find a "perfect" distribution, and that distribution should be re-evaluated regularly **\** Will look at it **\** 25% would only be a single output at minimum mixin **\** ok thanks **\** It's actually 25%, except if that gives 0, in which case it uses 1. **\** moneromooo: and it's 25% including the "real" output, right? **\** Yes. **\** See line 2744 in wallet2.cpp **\** kk **\** as to the other open PRs **\** most of them are not merged yet due to their being unreviewed **\** I try give PRs a little while before reviewing them myself, otherwise I end up being the only reviewer, which is bad for security obvs **\** bear in mind that a review is *not* in-depth line-by-line analysis **\** pr is just a quick overview **\** I'd hope the review does look at all lines. **\** yup **\** it's a sanity check, and a check for obvious screw-ups, and a check for snuck-in backdoors **\** moneromooo: the key there was in-depth, not line-by-line ;) **\** OK, that's fine. **\** medusa_: are you around? **\** ok in the absence of medusa_ being around, dEBRUYNE have you been following Ilya's progress on medusa_'s issues? **\** Yeah, he has fixed all issues opened by medusa_ as far as I know **\** ok great **\** yes im here **\** Except -> https://github.com/monero-project/monero-core/issues/29 **\** but that's more of a feature, which should be implemented later **\** oh cool - medusa_ how are you finding it now that most of the issues have been fixed? **\** could* **\** MK_ + Others who are wondering, the monero-core project that is being discussed now is the GUI **\** i think we need more feedback regarding the performance difference between gui wallet creation time and CLI wallet creation time **\** and i dont know of any major bugs that would be dangerous **\** medusa_: there's a PR that's supposed to fix that **\** I haven't merged it yet, but it's gone through review **\** Ilya merged jacquee's PR as well **\** he noticed a significant improvement **\** so my opinion is merge all to monero-core project master, test there again and if its good we build the bins **\** ^ +1 **\** Beta binaries will also bring more testers, who possibly could notice something we might have overlooked **\** ok **\** Im down to test once the Betas are out **\** we'll need a point release of 0.10 to go with it **\** so we should at least get through the current group of pending PRs before we do that **\** but we must communicate its for testing, since the seed is nowhere displayed after creation we dont want people to lose money **\** It creates a keys file, right ? **\** medusa_: well that's a pretty big issue :-P **\** yes **\** ah ok **\** so monero-wallet-cli could be shipped with it for recovery **\** Good idea **\** Well, you do need the daemon anyway, don't you. **\** yes **\** \ so monero-wallet-cli could be shipped with it for recovery <= It's able to recover seeds **\** It's just that only in the wizard the seed is shown once **\** oh wait, you mean restore with the .keys file? **\** yes I meant recovery as in "recover my seed from the .keys file" **\** Recovery from seed is the issue with the GUI? **\** ah gotcha **\** No ArticMine, there isn't a window yet to see your seed **\** after the initial wizard **\** ArticMine: no - it just doesn't display the seed again after the wizard **\** and given how many MyMonero support emails I get where people didn't write down their seed... **\** Should be fairly trivial to add though **\** ok so that's about it from my side - tewinget isn't around to give us a 0MQ update **\** hyc I don't think has started tinkering with the walletDB stuff **\** also the forum - I know, I'm working on it, moved all broken deps into monero-project repos to better manage them and am fixing the last few niggly issues **\** fluffypony: re: GUI, preferably we would have a tab that displays viewkey/seed/spendkey, the tab could be named Private Keys or something, with a big fat warning label :P **\** Like I said, should be fairly trivial to add **\** dEBRUYNE: good idea - open an issue for it and let Ilya do it asap :) **\** ok so we have 7 minutes before the Kovri meeting, any other things to discuss? **\** fluffypony: will do **\** NoodleDoodle isn't here right? **\** Who wants to volunteer to review some patches from time to time ? :) **\** moneromooo: Similiarly, would you be able to glance over / review the trezor XMR code? **\** Where is it ? **\** on NoodleDoodle's computer **\** https://github.com/NoodleDoodleNoodleDoodleNoodleDoodleNoo **\** ^ moneromooo **\** he has some commits in his monero repository and in trezor-xmr **\** :-P **\ {-anonimal}** moneromooo: I review many of them but I don't spend enough time with the codebase to ack/nack **\** anonimal, thanks :) **\** dEBRUYNE: Do you know which one of the three repos is the right one ? **\** xmr, common, mcu. xmr seems likely to be one at least. **\** oh trezor-xmr **\** and monero **\** So his commits here -> https://github.com/NoodleDoodleNoodleDoodleNoodleDoodleNoo/monero/commits/master?author=NoodleDoodleNoodleDoodleNoodleDoodleNoo **\** OK, I'll keep that in mind then. **\** & here -> https://github.com/NoodleDoodleNoodleDoodleNoodleDoodleNoo/trezor-xmr **\** i can not review the code, but i can test specific pull requests if you guys explain me what you changed **\** trezor-mcu / trezor-common has no commits from NoodleDoodle moneromooo **\** medusa_: 1082 and 1121 could do with some testing if you feel like it. **\** And 1140 :) **\** 1082 changes the way fake outs are selected **\** wow in this pace i see GUI by tonight lol **\** 1121 replaces the sweep_unmixable code to be more stable and, well, better **\** 1141 adds cold wallet signing **\** oh i can test 1141 **\** i still have the setip from the --offline thing **\** 1140, sorry. Off by one... **\** oh no off by one bug! **\** will have a look, thanks **\** Mac, Linux, and Plan9. **\** android please **\** lol **\** hokay **\** that's the end of that