From 9961305867014361e542e7a14632fc4ca3423ef3 Mon Sep 17 00:00:00 2001 From: rating89us <45968869+rating89us@users.noreply.github.com> Date: Fri, 19 Nov 2021 16:34:34 +0100 Subject: [PATCH] LabelSubheader: implement tooltip --- components/LabelSubheader.qml | 1 + components/Tooltip.qml | 3 ++- pages/SharedRingDB.qml | 20 ++++---------------- 3 files changed, 7 insertions(+), 17 deletions(-) diff --git a/components/LabelSubheader.qml b/components/LabelSubheader.qml index 585d0027..0e93daa4 100644 --- a/components/LabelSubheader.qml +++ b/components/LabelSubheader.qml @@ -34,6 +34,7 @@ import "../components/effects/" as MoneroEffects Label { id: item fontSize: 18 + tooltipIconVisible: true Rectangle { anchors.top: item.bottom diff --git a/components/Tooltip.qml b/components/Tooltip.qml index 4709837e..ac9a93d7 100644 --- a/components/Tooltip.qml +++ b/components/Tooltip.qml @@ -95,11 +95,12 @@ Rectangle { delay: 200 RowLayout { - Layout.maximumWidth: 350 + Layout.maximumWidth: 370 Text { id: tooltip width: contentWidth + Layout.maximumWidth: 370 color: MoneroComponents.Style.defaultFontColor font.family: MoneroComponents.Style.fontRegular.name font.pixelSize: 12 diff --git a/pages/SharedRingDB.qml b/pages/SharedRingDB.qml index 93d1f7c7..4235bad2 100644 --- a/pages/SharedRingDB.qml +++ b/pages/SharedRingDB.qml @@ -112,11 +112,8 @@ Rectangle { MoneroComponents.LabelSubheader { Layout.fillWidth: true textFormat: Text.RichText - text: "" + - qsTr("Outputs marked as spent") + " " + qsTr("Help") + "" + translationManager.emptyString - onLinkActivated: { - sharedRingDBDialog.title = qsTr("Outputs marked as spent") + translationManager.emptyString; - sharedRingDBDialog.text = qsTr( + text: qsTr("Outputs marked as spent") + translationManager.emptyString + tooltip: qsTr( "In order to obscure which inputs in a Monero transaction are being spent, a third party should not be able " + "to tell which inputs in a ring are already known to be spent. Being able to do so would weaken the protection " + "afforded by ring signatures. If all but one of the inputs are known to be already spent, then the input being " + @@ -128,9 +125,6 @@ Rectangle { "Alternatively, you can scan the blockchain (and the blockchain of key-reusing Monero clones) yourself " + "using the monero-blockchain-mark-spent-outputs tool to create a list of known spent outputs.
" ) + translationManager.emptyString - sharedRingDBDialog.icon = StandardIcon.Information - sharedRingDBDialog.open() - } } MoneroComponents.TextPlain { @@ -249,11 +243,8 @@ Rectangle { Layout.fillWidth: true Layout.topMargin: 24 textFormat: Text.RichText - text: "" + - qsTr("Rings") + " " + qsTr("Help") + "" + translationManager.emptyString - onLinkActivated: { - sharedRingDBDialog.title = qsTr("Rings") + translationManager.emptyString; - sharedRingDBDialog.text = qsTr( + text: qsTr("Rings") + translationManager.emptyString + tooltip: qsTr( "In order to avoid nullifying the protection afforded by Monero's ring signatures, an output should not " + "be spent with different rings on different blockchains. While this is normally not a concern, it can become one " + "when a key-reusing Monero clone allows you to spend existing outputs. In this case, you need to ensure this " + @@ -266,9 +257,6 @@ Rectangle { "If you do not use a key-reusing Monero clone without these safety features, then you do not need to do anything " + "as it is all automated.
" ) + translationManager.emptyString - sharedRingDBDialog.icon = StandardIcon.Information - sharedRingDBDialog.open() - } } MoneroComponents.TextPlain {