Merge pull request #2315

1e64ebe QML: warning fixes (selsta)

pages/Keys.qml

@@ -251,7 +251,7 @@ Rectangle {
                 onClicked: {
                     loadPage("Settings")
                 }
-                anchors.horizontalCenter: parent.horizontalCenter
+                Layout.alignment: Qt.AlignCenter
                 width: 135
             }
         }

pages/merchant/MerchantCheckbox.qml

@@ -4,19 +4,25 @@ import QtGraphicalEffects 1.0
 
 import "../../components" as MoneroComponents
 
-RowLayout {
+Item {
     id: root
-    spacing: 10
     property bool checked: false;
     property alias text: content.text
     signal changed;
 
+    width: checkBoxLayout.width
+    height: 22
+
+    RowLayout {
+        id: checkBoxLayout
+        spacing: 10
+
+        Item {
+            height: root.height
+            width: root.height
             Rectangle {
                 id: checkbox
-        anchors.left: parent.left
+                anchors.fill: parent
-        anchors.top: parent.top
-        implicitHeight: 22
-        width: 22
                 radius: 5
 
                 Image {
@@ -26,27 +32,6 @@ RowLayout {
                     source: "qrc:///images/uncheckedIcon.png"
                 }
             }
-
-    MoneroComponents.TextPlain {
-        id: content
-        font.pixelSize: 14
-        font.bold: false
-        color: "white"
-        text: ""
-        themeTransition: false
-    }
-
-    MouseArea {
-        anchors.fill: parent
-        hoverEnabled: true
-
-        cursorShape: Qt.PointingHandCursor
-        onClicked: {
-            root.checked = !root.checked;
-            changed();
-        }
-    }
-
             DropShadow {
                 anchors.fill: source
                 cached: true
@@ -59,3 +44,23 @@ RowLayout {
                 source: checkbox
             }
         }
+        MoneroComponents.TextPlain {
+            id: content
+            font.pixelSize: 14
+            font.bold: false
+            color: "white"
+            text: ""
+            themeTransition: false
+        }
+    }
+    MouseArea {
+        anchors.fill: parent
+        hoverEnabled: true
+
+        cursorShape: Qt.PointingHandCursor
+        onClicked: {
+            root.checked = !root.checked;
+            changed();
+        }
+    }
+}

src/libwalletqt/WalletManager.cpp

@@ -376,7 +376,7 @@ bool WalletManager::localDaemonSynced() const
 
 bool WalletManager::isDaemonLocal(const QString &daemon_address) const
 {
-    return Monero::Utils::isAddressLocal(daemon_address.toStdString());
+    return daemon_address.isEmpty() ? false : Monero::Utils::isAddressLocal(daemon_address.toStdString());
 }
 
 QString WalletManager::resolveOpenAlias(const QString &address) const