mirror of
https://github.com/boldsuck/haveno.git
synced 2024-12-22 20:19:21 +00:00
clarify instructions to open pull requests
This commit is contained in:
parent
abd6b36589
commit
523d7788e5
1 changed files with 2 additions and 2 deletions
|
@ -31,8 +31,8 @@ Follow [instructions](https://github.com/haveno-dex/haveno-ui-poc#run-tests) to
|
||||||
6. Update the gRPC client in haveno-ui-poc: `npm install`
|
6. Update the gRPC client in haveno-ui-poc: `npm install`
|
||||||
7. Add the corresponding typescript method(s) to [HavenoDaemon.ts](https://github.com/haveno-dex/haveno-ui-poc/blob/master/src/HavenoDaemon.ts) with clear and concise documentation.
|
7. Add the corresponding typescript method(s) to [HavenoDaemon.ts](https://github.com/haveno-dex/haveno-ui-poc/blob/master/src/HavenoDaemon.ts) with clear and concise documentation.
|
||||||
8. Add clean and comprehensive tests to [HavenoDaemon.test.ts](https://github.com/haveno-dex/haveno-ui-poc/blob/master/src/HavenoDaemon.test.ts), following existing patterns.
|
8. Add clean and comprehensive tests to [HavenoDaemon.test.ts](https://github.com/haveno-dex/haveno-ui-poc/blob/master/src/HavenoDaemon.test.ts), following existing patterns.
|
||||||
9. Verify the tests with `npm run test -- -t 'my test'` to run tests by name and `npm test` to run all tests together.
|
9. Run the tests with `npm run test -- -t 'my test'` to run tests by name and `npm test` to run all tests together. Ensure all tests pass and there are no exception stacktraces in the terminals of Alice, Bob, or the arbitrator.
|
||||||
10. Open a pull request for review.
|
10. Open pull requests to the haveno and haveno-ui-poc projects for the backend and frontend implementations.
|
||||||
|
|
||||||
## Trade Protocol
|
## Trade Protocol
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue