From 1ae775a31b0c8485d4e8e0e93641ec77fa353a6e Mon Sep 17 00:00:00 2001
From: boldsuck <git@boldsuck.de>
Date: Wed, 15 Jan 2025 01:11:18 +0100
Subject: [PATCH] Update build workflow upload-artifact@v3 to v4

---
 .github/workflows/build-for-me.yml         |  2 +-
 .github/workflows/build.yml                | 17 +++++++------
 .github/workflows/codacy-code-reporter.yml | 29 ----------------------
 .github/workflows/codeql-analysis.yml      |  2 +-
 .github/workflows/label.yml                | 25 -------------------
 5 files changed, 11 insertions(+), 64 deletions(-)
 delete mode 100644 .github/workflows/codacy-code-reporter.yml
 delete mode 100644 .github/workflows/label.yml

diff --git a/.github/workflows/build-for-me.yml b/.github/workflows/build-for-me.yml
index c367852a..6ae07be0 100644
--- a/.github/workflows/build-for-me.yml
+++ b/.github/workflows/build-for-me.yml
@@ -39,7 +39,7 @@ jobs:
           include-hidden-files: true
           name: cached-localnet
           path: .localnet
-      - name: save seednode JARs
+      - name: Save seednode JARs
         uses: actions/upload-artifact@v4
         with:
           name: haveno-seednode-tar
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index ee2c9e6a..8fc6b6a4 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -26,17 +26,18 @@ jobs:
           cache: gradle
       - name: Build with Gradle
         run: ./gradlew build --stacktrace --scan
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: error-reports-${{ matrix.os }}
           path: ${{ github.workspace }}/desktop/build/reports
       - name: cache nodes dependencies
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           include-hidden-files: true
           name: cached-localnet
           path: .localnet
+          overwrite: true
       - name: Install dependencies
         if: ${{ matrix.os == 'ubuntu-22.04' }}
         run: |
@@ -99,41 +100,41 @@ jobs:
         shell: powershell
 
       # win
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         name: "Windows artifacts"
         if: ${{ matrix.os == 'windows-latest'}}
         with:
           name: haveno-windows
           path: ${{ github.workspace }}/release-windows
       # macos
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         name: "macOS artifacts"
         if: ${{ matrix.os == 'macos-13'  }}
         with:
           name: haveno-macos
           path: ${{ github.workspace }}/release-macos
       # linux
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         name: "Linux - deb artifact"
         if: ${{ matrix.os == 'ubuntu-22.04' }}
         with:
           name: haveno-linux-deb
           path: ${{ github.workspace }}/release-linux-deb
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         name: "Linux - rpm artifact"
         if: ${{ matrix.os == 'ubuntu-22.04' }}
         with:
           name: haveno-linux-rpm
           path: ${{ github.workspace }}/release-linux-rpm
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         name: "Linux - AppImage artifact"
         if: ${{ matrix.os == 'ubuntu-22.04' }}
         with:
           name: haveno-linux-appimage
           path: ${{ github.workspace }}/release-linux-appimage
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         name: "Linux - flatpak artifact"
         if: ${{ matrix.os == 'ubuntu-22.04' }}
         with:
diff --git a/.github/workflows/codacy-code-reporter.yml b/.github/workflows/codacy-code-reporter.yml
deleted file mode 100644
index 1bf5b3ce..00000000
--- a/.github/workflows/codacy-code-reporter.yml
+++ /dev/null
@@ -1,29 +0,0 @@
-name: Codacy Coverage Reporter
-
-on: ["push"]
-
-permissions:
-  contents: read
-
-jobs:
-  build:
-    if: github.repository == 'haveno-dex/haveno'
-    name: Publish coverage
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Set up JDK 21
-        uses: actions/setup-java@v4
-        with:
-          java-version: '21'
-          distribution: 'adopt'
-
-      - name: Build with Gradle
-        run: ./gradlew clean build -x checkstyleMain -x checkstyleTest -x shadowJar
-
-      - name: Run codacy coverage reporter
-        uses: codacy/codacy-coverage-reporter-action@v1.3.0
-        with:
-          project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
-          coverage-reports: ${{ github.workspace }}/build/reports/jacoco/testCodeCoverageReport/testCodeCoverageReport.xml
diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
index 7e0fefe9..ae17cb90 100644
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -18,7 +18,7 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     permissions:
       actions: read
       contents: read
diff --git a/.github/workflows/label.yml b/.github/workflows/label.yml
deleted file mode 100644
index d29b0e28..00000000
--- a/.github/workflows/label.yml
+++ /dev/null
@@ -1,25 +0,0 @@
-name: Comment to label
-
-on:
-  issues:
-    types: [labeled]
-  workflow_call:
-
-jobs:
-  issueLabeled:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Bounty explanation
-        uses: peter-evans/create-or-update-comment@v3
-        if: github.event.label.name == '💰bounty'
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-          issue-number: ${{ github.event.issue.number }}
-          body: >
-            There is a bounty on this issue. The amount is in the title. The reward will be awarded to the first person or group of people whose solution is accepted and merged.
-
-
-            In some cases, we may assign the issue to specific contributors. We expect contributors to provide a PR in a reasonable time frame or, in case of an extensive work, updates on their progress. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.
-
-
-            Read the [full conditions and details](https://github.com/haveno-dex/haveno/blob/master/docs/bounties.md) of our bounty system.