p2p/p2p-core: enable workspace lints (#288)

* p2p-core: enable workspace lints

* fmt

* fix tests

* fixes

* fixes

* fixes

* expect reason

Cargo.lock

@@ -776,6 +776,7 @@ version = "0.1.0"
 dependencies = [
  "async-trait",
  "borsh",
+ "cfg-if",
  "cuprate-helper",
  "cuprate-pruning",
  "cuprate-test-utils",
@@ -790,7 +791,6 @@ dependencies = [
  "tokio-util",
  "tower",
  "tracing",
- "tracing-subscriber",
 ]
 
 [[package]]

p2p/p2p-core/Cargo.toml

@@ -14,13 +14,14 @@ cuprate-helper = { path = "../../helper", features = ["asynch"], default-feature
 cuprate-wire = { path = "../../net/wire", features = ["tracing"] }
 cuprate-pruning = { path = "../../pruning" }
 
-tokio = { workspace = true, features = ["net", "sync", "macros", "time"]}
+tokio = { workspace = true, features = ["net", "sync", "macros", "time", "rt", "rt-multi-thread"]}
 tokio-util = { workspace = true, features = ["codec"] }
 tokio-stream = { workspace = true, features = ["sync"]}
 futures = { workspace = true, features = ["std"] }
 async-trait = { workspace = true }
 tower = { workspace = true, features = ["util", "tracing"] }
 
+cfg-if = { workspace = true }
 thiserror = { workspace = true }
 tracing = { workspace = true, features = ["std", "attributes"] }
 hex-literal = { workspace = true }
@@ -28,9 +29,10 @@ hex-literal = { workspace = true }
 borsh = { workspace = true, features = ["derive", "std"], optional = true }
 
 [dev-dependencies]
-cuprate-test-utils = {path = "../../test-utils"}
+cuprate-test-utils = { path = "../../test-utils" }
 
 hex = { workspace = true, features = ["std"] }
-tokio = { workspace = true, features = ["net", "rt-multi-thread", "rt", "macros"]}
 tokio-test = { workspace = true }
-tracing-subscriber = { workspace = true }
+
+[lints]
+workspace = true

p2p/p2p-core/src/client.rs

@@ -43,8 +43,8 @@ pub enum InternalPeerID<A> {
 impl<A: Display> Display for InternalPeerID<A> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         match self {
-            InternalPeerID::KnownAddr(addr) => addr.fmt(f),
+            Self::KnownAddr(addr) => addr.fmt(f),
-            InternalPeerID::Unknown(id) => f.write_str(&format!("Unknown, ID: {id}")),
+            Self::Unknown(id) => f.write_str(&format!("Unknown, ID: {id}")),
         }
     }
 }
@@ -113,7 +113,7 @@ impl<Z: NetworkZone> Client<Z> {
     fn set_err(&self, err: PeerError) -> tower::BoxError {
         let err_str = err.to_string();
         match self.error.try_insert_err(err) {
-            Ok(_) => err_str,
+            Ok(()) => err_str,
             Err(e) => e.to_string(),
         }
         .into()
@@ -169,9 +169,8 @@ impl<Z: NetworkZone> Service<PeerRequest> for Client<Z> {
                 TrySendError::Closed(req) | TrySendError::Full(req) => {
                     self.set_err(PeerError::ClientChannelClosed);
 
-                    let _ = req
+                    let resp = Err(PeerError::ClientChannelClosed.into());
-                        .response_channel
+                    drop(req.response_channel.send(resp));
-                        .send(Err(PeerError::ClientChannelClosed.into()));
                 }
             }
         }
@@ -216,7 +215,7 @@ where
 
                 tracing::debug!("Sending back response");
 
-                let _ = req.response_channel.send(Ok(res));
+                drop(req.response_channel.send(Ok(res)));
             }
         }
         .instrument(task_span),

p2p/p2p-core/src/client/connection.rs

@@ -26,7 +26,7 @@ use crate::{
 };
 
 /// A request to the connection task from a [`Client`](crate::client::Client).
-pub struct ConnectionTaskRequest {
+pub(crate) struct ConnectionTaskRequest {
     /// The request.
     pub request: PeerRequest,
     /// The response channel.
@@ -36,7 +36,7 @@ pub struct ConnectionTaskRequest {
 }
 
 /// The connection state.
-pub enum State {
+pub(crate) enum State {
     /// Waiting for a request from Cuprate or the connected peer.
     WaitingForRequest,
     /// Waiting for a response from the peer.
@@ -53,7 +53,7 @@ pub enum State {
 /// Returns if the [`LevinCommand`] is the correct response message for our request.
 ///
 /// e.g. that we didn't get a block for a txs request.
-fn levin_command_response(message_id: &MessageID, command: LevinCommand) -> bool {
+const fn levin_command_response(message_id: MessageID, command: LevinCommand) -> bool {
     matches!(
         (message_id, command),
         (MessageID::Handshake, LevinCommand::Handshake)
@@ -71,7 +71,7 @@ fn levin_command_response(message_id: &MessageID, command: LevinCommand) -> bool
 }
 
 /// This represents a connection to a peer.
-pub struct Connection<Z: NetworkZone, A, CS, PS, PR, BrdcstStrm> {
+pub(crate) struct Connection<Z: NetworkZone, A, CS, PS, PR, BrdcstStrm> {
     /// The peer sink - where we send messages to the peer.
     peer_sink: Z::Sink,
 
@@ -104,15 +104,15 @@ where
     BrdcstStrm: Stream<Item = BroadcastMessage> + Send + 'static,
 {
     /// Create a new connection struct.
-    pub fn new(
+    pub(crate) fn new(
         peer_sink: Z::Sink,
         client_rx: mpsc::Receiver<ConnectionTaskRequest>,
         broadcast_stream: BrdcstStrm,
         peer_request_handler: PeerRequestHandler<Z, A, CS, PS, PR>,
         connection_guard: ConnectionGuard,
         error: SharedError<PeerError>,
-    ) -> Connection<Z, A, CS, PS, PR, BrdcstStrm> {
+    ) -> Self {
-        Connection {
+        Self {
             peer_sink,
             state: State::WaitingForRequest,
             request_timeout: None,
@@ -174,15 +174,14 @@ where
         if let Err(e) = res {
             // can't clone the error so turn it to a string first, hacky but oh well.
             let err_str = e.to_string();
-            let _ = req.response_channel.send(Err(err_str.clone().into()));
+            drop(req.response_channel.send(Err(err_str.into())));
             return Err(e);
-        } else {
-            // We still need to respond even if the response is this.
-            let _ = req
-                .response_channel
-                .send(Ok(PeerResponse::Protocol(ProtocolResponse::NA)));
         }
 
+        // We still need to respond even if the response is this.
+        let resp = Ok(PeerResponse::Protocol(ProtocolResponse::NA));
+        drop(req.response_channel.send(resp));
+
         Ok(())
     }
 
@@ -215,7 +214,7 @@ where
         };
 
         // Check if the message is a response to our request.
-        if levin_command_response(request_id, mes.command()) {
+        if levin_command_response(*request_id, mes.command()) {
             // TODO: Do more checks before returning response.
 
             let State::WaitingForResponse { tx, .. } =
@@ -224,9 +223,11 @@ where
                 panic!("Not in correct state, can't receive response!")
             };
 
-            let _ = tx.send(Ok(mes
+            let resp = Ok(mes
                 .try_into()
-                .map_err(|_| PeerError::PeerSentInvalidMessage)?));
+                .map_err(|_| PeerError::PeerSentInvalidMessage)?);
+
+            drop(tx.send(resp));
 
             self.request_timeout = None;
 
@@ -282,7 +283,7 @@ where
 
         tokio::select! {
             biased;
-            _ = self.request_timeout.as_mut().expect("Request timeout was not set!") => {
+            () = self.request_timeout.as_mut().expect("Request timeout was not set!") => {
                 Err(PeerError::ClientChannelClosed)
             }
             broadcast_req = self.broadcast_stream.next() => {
@@ -306,8 +307,11 @@ where
     /// Runs the Connection handler logic, this should be put in a separate task.
     ///
     /// `eager_protocol_messages` are protocol messages that we received during a handshake.
-    pub async fn run<Str>(mut self, mut stream: Str, eager_protocol_messages: Vec<ProtocolMessage>)
+    pub(crate) async fn run<Str>(
-    where
+        mut self,
+        mut stream: Str,
+        eager_protocol_messages: Vec<ProtocolMessage>,
+    ) where
         Str: FusedStream<Item = Result<Message, cuprate_wire::BucketError>> + Unpin,
     {
         tracing::debug!(
@@ -348,6 +352,7 @@ where
 
     /// Shutdowns the connection, flushing pending requests and setting the error slot, if it hasn't been
     /// set already.
+    #[expect(clippy::significant_drop_tightening)]
     fn shutdown(mut self, err: PeerError) {
         tracing::debug!("Connection task shutting down: {}", err);
 
@@ -362,11 +367,11 @@ where
         if let State::WaitingForResponse { tx, .. } =
             std::mem::replace(&mut self.state, State::WaitingForRequest)
         {
-            let _ = tx.send(Err(err_str.clone().into()));
+            drop(tx.send(Err(err_str.clone().into())));
         }
 
         while let Ok(req) = client_rx.try_recv() {
-            let _ = req.response_channel.send(Err(err_str.clone().into()));
+            drop(req.response_channel.send(Err(err_str.clone().into())));
         }
 
         self.connection_guard.connection_closed();

p2p/p2p-core/src/client/connector.rs

@@ -40,7 +40,9 @@ impl<Z: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
     Connector<Z, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
 {
     /// Create a new connector from a handshaker.
-    pub fn new(handshaker: HandShaker<Z, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>) -> Self {
+    pub const fn new(
+        handshaker: HandShaker<Z, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>,
+    ) -> Self {
         Self { handshaker }
     }
 }

p2p/p2p-core/src/client/handshaker.rs

@@ -113,7 +113,7 @@ impl<Z: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
     HandShaker<Z, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
 {
     /// Creates a new handshaker.
-    fn new(
+    const fn new(
         address_book: AdrBook,
         peer_sync_svc: PSync,
         core_sync_svc: CSync,
@@ -226,11 +226,12 @@ pub async fn ping<N: NetworkZone>(addr: N::Addr) -> Result<u64, HandshakeError>
     Err(BucketError::IO(std::io::Error::new(
         std::io::ErrorKind::ConnectionAborted,
         "The peer stream returned None",
-    )))?
+    ))
+    .into())
 }
 
 /// This function completes a handshake with the requested peer.
-#[allow(clippy::too_many_arguments)]
+#[expect(clippy::too_many_arguments)]
 async fn handshake<Z: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr, BrdcstStrm>(
     req: DoHandshakeRequest<Z>,
 
@@ -403,7 +404,10 @@ where
                         break 'check_out_addr None;
                     };
 
-                    // u32 does not make sense as a port so just truncate it.
+                    #[expect(
+                        clippy::cast_possible_truncation,
+                        reason = "u32 does not make sense as a port so just truncate it."
+                    )]
                     outbound_address.set_port(peer_node_data.my_port as u16);
 
                     let Ok(Ok(ping_peer_id)) = timeout(
@@ -508,7 +512,7 @@ where
         info.id,
         info.handle.clone(),
         connection_tx.clone(),
-        semaphore.clone(),
+        Arc::clone(&semaphore),
         address_book,
         core_sync_svc,
         peer_sync_svc,
@@ -671,7 +675,7 @@ async fn wait_for_message<Z: NetworkZone>(
                     _ => {
                         return Err(HandshakeError::PeerSentInvalidMessage(
                             "Peer sent an admin request before responding to the handshake",
-                        ))
+                        ));
                     }
                 }
             }
@@ -686,16 +690,17 @@ async fn wait_for_message<Z: NetworkZone>(
                 ));
             }
 
-            _ => Err(HandshakeError::PeerSentInvalidMessage(
+            Message::Response(_) => Err(HandshakeError::PeerSentInvalidMessage(
                 "Peer sent an incorrect message",
             )),
-        }?
+        }?;
     }
 
     Err(BucketError::IO(std::io::Error::new(
         std::io::ErrorKind::ConnectionAborted,
         "The peer stream returned None",
-    )))?
+    ))
+    .into())
 }
 
 /// Sends a [`AdminResponseMessage::SupportFlags`] down the peer sink.

p2p/p2p-core/src/client/handshaker/builder.rs

@@ -87,14 +87,13 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
     where
         NAdrBook: AddressBook<N> + Clone,
     {
-        let HandshakerBuilder {
+        let Self {
             core_sync_svc,
             peer_sync_svc,
             protocol_request_svc,
             our_basic_node_data,
             broadcast_stream_maker,
             connection_parent_span,
-            _zone,
             ..
         } = self;
 
@@ -106,7 +105,7 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
             our_basic_node_data,
             broadcast_stream_maker,
             connection_parent_span,
-            _zone,
+            _zone: PhantomData,
         }
     }
 
@@ -130,14 +129,13 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
     where
         NCSync: CoreSyncSvc + Clone,
     {
-        let HandshakerBuilder {
+        let Self {
             address_book,
             peer_sync_svc,
             protocol_request_svc,
             our_basic_node_data,
             broadcast_stream_maker,
             connection_parent_span,
-            _zone,
             ..
         } = self;
 
@@ -149,7 +147,7 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
             our_basic_node_data,
             broadcast_stream_maker,
             connection_parent_span,
-            _zone,
+            _zone: PhantomData,
         }
     }
 
@@ -167,14 +165,13 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
     where
         NPSync: PeerSyncSvc<N> + Clone,
     {
-        let HandshakerBuilder {
+        let Self {
             address_book,
             core_sync_svc,
             protocol_request_svc,
             our_basic_node_data,
             broadcast_stream_maker,
             connection_parent_span,
-            _zone,
             ..
         } = self;
 
@@ -186,7 +183,7 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
             our_basic_node_data,
             broadcast_stream_maker,
             connection_parent_span,
-            _zone,
+            _zone: PhantomData,
         }
     }
 
@@ -204,14 +201,13 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
     where
         NProtoHdlr: ProtocolRequestHandler + Clone,
     {
-        let HandshakerBuilder {
+        let Self {
             address_book,
             core_sync_svc,
             peer_sync_svc,
             our_basic_node_data,
             broadcast_stream_maker,
             connection_parent_span,
-            _zone,
             ..
         } = self;
 
@@ -223,7 +219,7 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
             our_basic_node_data,
             broadcast_stream_maker,
             connection_parent_span,
-            _zone,
+            _zone: PhantomData,
         }
     }
 
@@ -242,14 +238,13 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
         BrdcstStrm: Stream<Item = BroadcastMessage> + Send + 'static,
         NBrdcstStrmMkr: Fn(InternalPeerID<N::Addr>) -> BrdcstStrm + Clone + Send + 'static,
     {
-        let HandshakerBuilder {
+        let Self {
             address_book,
             core_sync_svc,
             peer_sync_svc,
             protocol_request_svc,
             our_basic_node_data,
             connection_parent_span,
-            _zone,
             ..
         } = self;
 
@@ -261,7 +256,7 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
             our_basic_node_data,
             broadcast_stream_maker: new_broadcast_stream_maker,
             connection_parent_span,
-            _zone,
+            _zone: PhantomData,
         }
     }
 
@@ -270,6 +265,7 @@ impl<N: NetworkZone, AdrBook, CSync, PSync, ProtoHdlr, BrdcstStrmMkr>
     /// ## Default Connection Parent Span
     ///
     /// The default connection span will be [`Span::none`].
+    #[must_use]
     pub fn with_connection_parent_span(self, connection_parent_span: Span) -> Self {
         Self {
             connection_parent_span: Some(connection_parent_span),

p2p/p2p-core/src/client/handshaker/builder/dummy.rs

@@ -42,8 +42,8 @@ pub struct DummyCoreSyncSvc(CoreSyncData);
 
 impl DummyCoreSyncSvc {
     /// Returns a [`DummyCoreSyncSvc`] that will just return the mainnet genesis [`CoreSyncData`].
-    pub fn static_mainnet_genesis() -> DummyCoreSyncSvc {
+    pub const fn static_mainnet_genesis() -> Self {
-        DummyCoreSyncSvc(CoreSyncData {
+        Self(CoreSyncData {
             cumulative_difficulty: 1,
             cumulative_difficulty_top64: 0,
             current_height: 1,
@@ -56,8 +56,8 @@ impl DummyCoreSyncSvc {
     }
 
     /// Returns a [`DummyCoreSyncSvc`] that will just return the testnet genesis [`CoreSyncData`].
-    pub fn static_testnet_genesis() -> DummyCoreSyncSvc {
+    pub const fn static_testnet_genesis() -> Self {
-        DummyCoreSyncSvc(CoreSyncData {
+        Self(CoreSyncData {
             cumulative_difficulty: 1,
             cumulative_difficulty_top64: 0,
             current_height: 1,
@@ -70,8 +70,8 @@ impl DummyCoreSyncSvc {
     }
 
     /// Returns a [`DummyCoreSyncSvc`] that will just return the stagenet genesis [`CoreSyncData`].
-    pub fn static_stagenet_genesis() -> DummyCoreSyncSvc {
+    pub const fn static_stagenet_genesis() -> Self {
-        DummyCoreSyncSvc(CoreSyncData {
+        Self(CoreSyncData {
             cumulative_difficulty: 1,
             cumulative_difficulty_top64: 0,
             current_height: 1,
@@ -84,8 +84,8 @@ impl DummyCoreSyncSvc {
     }
 
     /// Returns a [`DummyCoreSyncSvc`] that will return the provided [`CoreSyncData`].
-    pub fn static_custom(data: CoreSyncData) -> DummyCoreSyncSvc {
+    pub const fn static_custom(data: CoreSyncData) -> Self {
-        DummyCoreSyncSvc(data)
+        Self(data)
     }
 }
 

p2p/p2p-core/src/client/request_handler.rs

@@ -46,7 +46,7 @@ pub(crate) struct PeerRequestHandler<Z: NetworkZone, A, CS, PS, PR> {
     pub peer_info: PeerInformation<Z::Addr>,
 }
 
-impl<Z: NetworkZone, A, CS, PS, PR> PeerRequestHandler<Z, A, CS, PS, PR>
+impl<Z, A, CS, PS, PR> PeerRequestHandler<Z, A, CS, PS, PR>
 where
     Z: NetworkZone,
     A: AddressBook<Z>,
@@ -55,7 +55,7 @@ where
     PR: ProtocolRequestHandler,
 {
     /// Handles an incoming [`PeerRequest`] to our node.
-    pub async fn handle_peer_request(
+    pub(crate) async fn handle_peer_request(
         &mut self,
         req: PeerRequest,
     ) -> Result<PeerResponse, tower::BoxError> {

p2p/p2p-core/src/client/timeout_monitor.rs

@@ -1,6 +1,6 @@
 //! Timeout Monitor
 //!
-//! This module holds the task that sends periodic [TimedSync](PeerRequest::TimedSync) requests to a peer to make
+//! This module holds the task that sends periodic [`TimedSync`](PeerRequest::TimedSync) requests to a peer to make
 //! sure the connection is still active.
 use std::sync::Arc;
 
@@ -64,7 +64,7 @@ where
             return Ok(());
         }
 
-        let Ok(permit) = semaphore.clone().try_acquire_owned() else {
+        let Ok(permit) = Arc::clone(&semaphore).try_acquire_owned() else {
             // If we can't get a permit the connection is currently waiting for a response, so no need to
             // do a timed sync.
             continue;

p2p/p2p-core/src/error.rs

@@ -4,7 +4,7 @@ pub struct SharedError<T>(Arc<OnceLock<T>>);
 
 impl<T> Clone for SharedError<T> {
     fn clone(&self) -> Self {
-        Self(self.0.clone())
+        Self(Arc::clone(&self.0))
     }
 }
 

p2p/p2p-core/src/handles.rs

@@ -18,11 +18,12 @@ pub struct HandleBuilder {
 
 impl HandleBuilder {
     /// Create a new builder.
-    pub fn new() -> Self {
+    pub const fn new() -> Self {
         Self { permit: None }
     }
 
     /// Sets the permit for this connection.
+    #[must_use]
     pub fn with_permit(mut self, permit: Option<OwnedSemaphorePermit>) -> Self {
         self.permit = permit;
         self
@@ -40,7 +41,7 @@ impl HandleBuilder {
                 _permit: self.permit,
             },
             ConnectionHandle {
-                token: token.clone(),
+                token,
                 ban: Arc::new(OnceLock::new()),
             },
         )
@@ -66,13 +67,13 @@ impl ConnectionGuard {
     ///
     /// This will be called on [`Drop::drop`].
     pub fn connection_closed(&self) {
-        self.token.cancel()
+        self.token.cancel();
     }
 }
 
 impl Drop for ConnectionGuard {
     fn drop(&mut self) {
-        self.token.cancel()
+        self.token.cancel();
     }
 }
 
@@ -90,6 +91,10 @@ impl ConnectionHandle {
     }
     /// Bans the peer for the given `duration`.
     pub fn ban_peer(&self, duration: Duration) {
+        #[expect(
+            clippy::let_underscore_must_use,
+            reason = "error means peer is already banned; fine to ignore"
+        )]
         let _ = self.ban.set(BanPeer(duration));
         self.token.cancel();
     }
@@ -103,6 +108,6 @@ impl ConnectionHandle {
     }
     /// Sends the signal to the connection task to disconnect.
     pub fn send_close_signal(&self) {
-        self.token.cancel()
+        self.token.cancel();
     }
 }

p2p/p2p-core/src/lib.rs

@@ -6,7 +6,7 @@
 //!
 //! # Network Zones
 //!
-//! This crate abstracts over network zones, Tor/I2p/clearnet with the [NetworkZone] trait. Currently only clearnet is implemented: [ClearNet].
+//! This crate abstracts over network zones, Tor/I2p/clearnet with the [`NetworkZone`] trait. Currently only clearnet is implemented: [`ClearNet`].
 //!
 //! # Usage
 //!
@@ -56,6 +56,16 @@
 //!     .unwrap();
 //! # });
 //! ```
+
+cfg_if::cfg_if! {
+    // Used in `tests/`
+    if #[cfg(test)] {
+        use cuprate_test_utils as _;
+        use tokio_test as _;
+        use hex as _;
+    }
+}
+
 use std::{fmt::Debug, future::Future, hash::Hash};
 
 use futures::{Sink, Stream};
@@ -102,7 +112,7 @@ pub trait NetZoneAddress:
     + Unpin
     + 'static
 {
-    /// Cuprate needs to be able to ban peers by IP addresses and not just by SocketAddr as
+    /// Cuprate needs to be able to ban peers by IP addresses and not just by `SocketAddr` as
     /// that include the port, to be able to facilitate this network addresses must have a ban ID
     /// which for hidden services could just be the address it self but for clear net addresses will
     /// be the IP address.

p2p/p2p-core/src/network_zones/clear.rs

@@ -19,7 +19,7 @@ impl NetZoneAddress for SocketAddr {
     type BanID = IpAddr;
 
     fn set_port(&mut self, port: u16) {
-        SocketAddr::set_port(self, port)
+        Self::set_port(self, port);
     }
 
     fn ban_id(&self) -> Self::BanID {

p2p/p2p-core/src/protocol.rs

@@ -8,7 +8,7 @@
 //!
 //! Here is every P2P request/response.
 //!
-//! *note admin messages are already request/response so "Handshake" is actually made of a HandshakeRequest & HandshakeResponse
+//! *note admin messages are already request/response so "Handshake" is actually made of a `HandshakeRequest` & `HandshakeResponse`
 //!
 //! ```md
 //! Admin:
@@ -78,15 +78,15 @@ pub enum PeerRequest {
 }
 
 impl PeerRequest {
-    pub fn id(&self) -> MessageID {
+    pub const fn id(&self) -> MessageID {
         match self {
-            PeerRequest::Admin(admin_req) => match admin_req {
+            Self::Admin(admin_req) => match admin_req {
                 AdminRequestMessage::Handshake(_) => MessageID::Handshake,
                 AdminRequestMessage::TimedSync(_) => MessageID::TimedSync,
                 AdminRequestMessage::Ping => MessageID::Ping,
                 AdminRequestMessage::SupportFlags => MessageID::SupportFlags,
             },
-            PeerRequest::Protocol(protocol_request) => match protocol_request {
+            Self::Protocol(protocol_request) => match protocol_request {
                 ProtocolRequest::GetObjects(_) => MessageID::GetObjects,
                 ProtocolRequest::GetChain(_) => MessageID::GetChain,
                 ProtocolRequest::FluffyMissingTxs(_) => MessageID::FluffyMissingTxs,
@@ -98,10 +98,10 @@ impl PeerRequest {
         }
     }
 
-    pub fn needs_response(&self) -> bool {
+    pub const fn needs_response(&self) -> bool {
         !matches!(
             self,
-            PeerRequest::Protocol(
+            Self::Protocol(
                 ProtocolRequest::NewBlock(_)
                     | ProtocolRequest::NewFluffyBlock(_)
                     | ProtocolRequest::NewTransactions(_)
@@ -126,15 +126,15 @@ pub enum PeerResponse {
 }
 
 impl PeerResponse {
-    pub fn id(&self) -> Option<MessageID> {
+    pub const fn id(&self) -> Option<MessageID> {
         Some(match self {
-            PeerResponse::Admin(admin_res) => match admin_res {
+            Self::Admin(admin_res) => match admin_res {
                 AdminResponseMessage::Handshake(_) => MessageID::Handshake,
                 AdminResponseMessage::TimedSync(_) => MessageID::TimedSync,
                 AdminResponseMessage::Ping(_) => MessageID::Ping,
                 AdminResponseMessage::SupportFlags(_) => MessageID::SupportFlags,
             },
-            PeerResponse::Protocol(protocol_res) => match protocol_res {
+            Self::Protocol(protocol_res) => match protocol_res {
                 ProtocolResponse::GetObjects(_) => MessageID::GetObjects,
                 ProtocolResponse::GetChain(_) => MessageID::GetChain,
                 ProtocolResponse::NewFluffyBlock(_) => MessageID::NewBlock,

p2p/p2p-core/src/protocol/try_from.rs

@@ -11,15 +11,13 @@ pub struct MessageConversionError;
 impl From<ProtocolRequest> for ProtocolMessage {
     fn from(value: ProtocolRequest) -> Self {
         match value {
-            ProtocolRequest::GetObjects(val) => ProtocolMessage::GetObjectsRequest(val),
+            ProtocolRequest::GetObjects(val) => Self::GetObjectsRequest(val),
-            ProtocolRequest::GetChain(val) => ProtocolMessage::ChainRequest(val),
+            ProtocolRequest::GetChain(val) => Self::ChainRequest(val),
-            ProtocolRequest::FluffyMissingTxs(val) => {
+            ProtocolRequest::FluffyMissingTxs(val) => Self::FluffyMissingTransactionsRequest(val),
-                ProtocolMessage::FluffyMissingTransactionsRequest(val)
+            ProtocolRequest::GetTxPoolCompliment(val) => Self::GetTxPoolCompliment(val),
-            }
+            ProtocolRequest::NewBlock(val) => Self::NewBlock(val),
-            ProtocolRequest::GetTxPoolCompliment(val) => ProtocolMessage::GetTxPoolCompliment(val),
+            ProtocolRequest::NewFluffyBlock(val) => Self::NewFluffyBlock(val),
-            ProtocolRequest::NewBlock(val) => ProtocolMessage::NewBlock(val),
+            ProtocolRequest::NewTransactions(val) => Self::NewTransactions(val),
-            ProtocolRequest::NewFluffyBlock(val) => ProtocolMessage::NewFluffyBlock(val),
-            ProtocolRequest::NewTransactions(val) => ProtocolMessage::NewTransactions(val),
         }
     }
 }
@@ -29,15 +27,13 @@ impl TryFrom<ProtocolMessage> for ProtocolRequest {
 
     fn try_from(value: ProtocolMessage) -> Result<Self, Self::Error> {
         Ok(match value {
-            ProtocolMessage::GetObjectsRequest(val) => ProtocolRequest::GetObjects(val),
+            ProtocolMessage::GetObjectsRequest(val) => Self::GetObjects(val),
-            ProtocolMessage::ChainRequest(val) => ProtocolRequest::GetChain(val),
+            ProtocolMessage::ChainRequest(val) => Self::GetChain(val),
-            ProtocolMessage::FluffyMissingTransactionsRequest(val) => {
+            ProtocolMessage::FluffyMissingTransactionsRequest(val) => Self::FluffyMissingTxs(val),
-                ProtocolRequest::FluffyMissingTxs(val)
+            ProtocolMessage::GetTxPoolCompliment(val) => Self::GetTxPoolCompliment(val),
-            }
+            ProtocolMessage::NewBlock(val) => Self::NewBlock(val),
-            ProtocolMessage::GetTxPoolCompliment(val) => ProtocolRequest::GetTxPoolCompliment(val),
+            ProtocolMessage::NewFluffyBlock(val) => Self::NewFluffyBlock(val),
-            ProtocolMessage::NewBlock(val) => ProtocolRequest::NewBlock(val),
+            ProtocolMessage::NewTransactions(val) => Self::NewTransactions(val),
-            ProtocolMessage::NewFluffyBlock(val) => ProtocolRequest::NewFluffyBlock(val),
-            ProtocolMessage::NewTransactions(val) => ProtocolRequest::NewTransactions(val),
             ProtocolMessage::GetObjectsResponse(_) | ProtocolMessage::ChainEntryResponse(_) => {
                 return Err(MessageConversionError)
             }
@@ -48,8 +44,8 @@ impl TryFrom<ProtocolMessage> for ProtocolRequest {
 impl From<PeerRequest> for Message {
     fn from(value: PeerRequest) -> Self {
         match value {
-            PeerRequest::Admin(val) => Message::Request(val),
+            PeerRequest::Admin(val) => Self::Request(val),
-            PeerRequest::Protocol(val) => Message::Protocol(val.into()),
+            PeerRequest::Protocol(val) => Self::Protocol(val.into()),
         }
     }
 }
@@ -59,8 +55,8 @@ impl TryFrom<Message> for PeerRequest {
 
     fn try_from(value: Message) -> Result<Self, Self::Error> {
         match value {
-            Message::Request(req) => Ok(PeerRequest::Admin(req)),
+            Message::Request(req) => Ok(Self::Admin(req)),
-            Message::Protocol(pro) => Ok(PeerRequest::Protocol(pro.try_into()?)),
+            Message::Protocol(pro) => Ok(Self::Protocol(pro.try_into()?)),
             Message::Response(_) => Err(MessageConversionError),
         }
     }
@@ -71,10 +67,10 @@ impl TryFrom<ProtocolResponse> for ProtocolMessage {
 
     fn try_from(value: ProtocolResponse) -> Result<Self, Self::Error> {
         Ok(match value {
-            ProtocolResponse::NewTransactions(val) => ProtocolMessage::NewTransactions(val),
+            ProtocolResponse::NewTransactions(val) => Self::NewTransactions(val),
-            ProtocolResponse::NewFluffyBlock(val) => ProtocolMessage::NewFluffyBlock(val),
+            ProtocolResponse::NewFluffyBlock(val) => Self::NewFluffyBlock(val),
-            ProtocolResponse::GetChain(val) => ProtocolMessage::ChainEntryResponse(val),
+            ProtocolResponse::GetChain(val) => Self::ChainEntryResponse(val),
-            ProtocolResponse::GetObjects(val) => ProtocolMessage::GetObjectsResponse(val),
+            ProtocolResponse::GetObjects(val) => Self::GetObjectsResponse(val),
             ProtocolResponse::NA => return Err(MessageConversionError),
         })
     }
@@ -85,10 +81,10 @@ impl TryFrom<ProtocolMessage> for ProtocolResponse {
 
     fn try_from(value: ProtocolMessage) -> Result<Self, Self::Error> {
         Ok(match value {
-            ProtocolMessage::NewTransactions(val) => ProtocolResponse::NewTransactions(val),
+            ProtocolMessage::NewTransactions(val) => Self::NewTransactions(val),
-            ProtocolMessage::NewFluffyBlock(val) => ProtocolResponse::NewFluffyBlock(val),
+            ProtocolMessage::NewFluffyBlock(val) => Self::NewFluffyBlock(val),
-            ProtocolMessage::ChainEntryResponse(val) => ProtocolResponse::GetChain(val),
+            ProtocolMessage::ChainEntryResponse(val) => Self::GetChain(val),
-            ProtocolMessage::GetObjectsResponse(val) => ProtocolResponse::GetObjects(val),
+            ProtocolMessage::GetObjectsResponse(val) => Self::GetObjects(val),
             ProtocolMessage::ChainRequest(_)
             | ProtocolMessage::FluffyMissingTransactionsRequest(_)
             | ProtocolMessage::GetObjectsRequest(_)
@@ -103,8 +99,8 @@ impl TryFrom<Message> for PeerResponse {
 
     fn try_from(value: Message) -> Result<Self, Self::Error> {
         match value {
-            Message::Response(res) => Ok(PeerResponse::Admin(res)),
+            Message::Response(res) => Ok(Self::Admin(res)),
-            Message::Protocol(pro) => Ok(PeerResponse::Protocol(pro.try_into()?)),
+            Message::Protocol(pro) => Ok(Self::Protocol(pro.try_into()?)),
             Message::Request(_) => Err(MessageConversionError),
         }
     }
@@ -115,8 +111,8 @@ impl TryFrom<PeerResponse> for Message {
 
     fn try_from(value: PeerResponse) -> Result<Self, Self::Error> {
         Ok(match value {
-            PeerResponse::Admin(val) => Message::Response(val),
+            PeerResponse::Admin(val) => Self::Response(val),
-            PeerResponse::Protocol(val) => Message::Protocol(val.try_into()?),
+            PeerResponse::Protocol(val) => Self::Protocol(val.try_into()?),
         })
     }
 }

p2p/p2p-core/src/services.rs

@@ -52,7 +52,7 @@ pub struct ZoneSpecificPeerListEntryBase<A: NetZoneAddress> {
     pub rpc_credits_per_hash: u32,
 }
 
-impl<A: NetZoneAddress> From<ZoneSpecificPeerListEntryBase<A>> for cuprate_wire::PeerListEntryBase {
+impl<A: NetZoneAddress> From<ZoneSpecificPeerListEntryBase<A>> for PeerListEntryBase {
     fn from(value: ZoneSpecificPeerListEntryBase<A>) -> Self {
         Self {
             adr: value.adr.into(),
@@ -74,9 +74,7 @@ pub enum PeerListConversionError {
     PruningSeed(#[from] PruningError),
 }
 
-impl<A: NetZoneAddress> TryFrom<cuprate_wire::PeerListEntryBase>
+impl<A: NetZoneAddress> TryFrom<PeerListEntryBase> for ZoneSpecificPeerListEntryBase<A> {
-    for ZoneSpecificPeerListEntryBase<A>
-{
     type Error = PeerListConversionError;
 
     fn try_from(value: PeerListEntryBase) -> Result<Self, Self::Error> {

p2p/p2p-core/tests/fragmented_handshake.rs

@@ -1,4 +1,7 @@
 //! This file contains a test for a handshake with monerod but uses fragmented messages.
+
+#![expect(unused_crate_dependencies, reason = "external test module")]
+
 use std::{
     net::SocketAddr,
     pin::Pin,
@@ -21,6 +24,13 @@ use tokio_util::{
 use tower::{Service, ServiceExt};
 
 use cuprate_helper::network::Network;
+use cuprate_test_utils::monerod::monerod;
+use cuprate_wire::{
+    common::PeerSupportFlags,
+    levin::{message::make_fragmented_messages, LevinMessage, Protocol},
+    BasicNodeData, Message, MoneroWireCodec,
+};
+
 use cuprate_p2p_core::{
     client::{
         handshaker::HandshakerBuilder, ConnectRequest, Connector, DoHandshakeRequest,
@@ -28,13 +38,6 @@ use cuprate_p2p_core::{
     },
     ClearNetServerCfg, ConnectionDirection, NetworkZone,
 };
-use cuprate_wire::{
-    common::PeerSupportFlags,
-    levin::{message::make_fragmented_messages, LevinMessage, Protocol},
-    BasicNodeData, Message, MoneroWireCodec,
-};
-
-use cuprate_test_utils::monerod::monerod;
 
 /// A network zone equal to clear net where every message sent is turned into a fragmented message.
 /// Does not support sending fragmented or dummy messages manually.
@@ -184,7 +187,7 @@ async fn fragmented_handshake_monerod_to_cuprate() {
     let next_connection_fut = timeout(Duration::from_secs(30), listener.next());
 
     if let Some(Ok((addr, stream, sink))) = next_connection_fut.await.unwrap() {
-        let _ = handshaker
+        handshaker
             .ready()
             .await
             .unwrap()

p2p/p2p-core/tests/handles.rs

@@ -1,3 +1,5 @@
+#![expect(unused_crate_dependencies, reason = "external test module")]
+
 use std::{sync::Arc, time::Duration};
 
 use tokio::sync::Semaphore;

p2p/p2p-core/tests/handshake.rs

@@ -1,3 +1,5 @@
+#![expect(unused_crate_dependencies, reason = "external test module")]
+
 use std::time::Duration;
 
 use futures::StreamExt;
@@ -9,6 +11,10 @@ use tokio_util::codec::{FramedRead, FramedWrite};
 use tower::{Service, ServiceExt};
 
 use cuprate_helper::network::Network;
+use cuprate_test_utils::{
+    monerod::monerod,
+    test_netzone::{TestNetZone, TestNetZoneAddr},
+};
 use cuprate_wire::{common::PeerSupportFlags, BasicNodeData, MoneroWireCodec};
 
 use cuprate_p2p_core::{
@@ -19,12 +25,8 @@ use cuprate_p2p_core::{
     ClearNet, ClearNetServerCfg, ConnectionDirection, NetworkZone,
 };
 
-use cuprate_test_utils::{
-    monerod::monerod,
-    test_netzone::{TestNetZone, TestNetZoneAddr},
-};
-
 #[tokio::test]
+#[expect(clippy::significant_drop_tightening)]
 async fn handshake_cuprate_to_cuprate() {
     // Tests a Cuprate <-> Cuprate handshake by making 2 handshake services and making them talk to
     // each other.
@@ -147,7 +149,7 @@ async fn handshake_monerod_to_cuprate() {
     let next_connection_fut = timeout(Duration::from_secs(30), listener.next());
 
     if let Some(Ok((addr, stream, sink))) = next_connection_fut.await.unwrap() {
-        let _ = handshaker
+        handshaker
             .ready()
             .await
             .unwrap()

p2p/p2p-core/tests/sending_receiving.rs

@@ -1,6 +1,9 @@
+#![expect(unused_crate_dependencies, reason = "external test module")]
+
 use tower::{Service, ServiceExt};
 
 use cuprate_helper::network::Network;
+use cuprate_test_utils::monerod::monerod;
 use cuprate_wire::{common::PeerSupportFlags, protocol::GetObjectsRequest, BasicNodeData};
 
 use cuprate_p2p_core::{
@@ -9,8 +12,6 @@ use cuprate_p2p_core::{
     ClearNet, ProtocolRequest, ProtocolResponse,
 };
 
-use cuprate_test_utils::monerod::monerod;
-
 #[tokio::test]
 async fn get_single_block_from_monerod() {
     let monerod = monerod(["--out-peers=0"]).await;