#2207 Fixed regression in HTTP parser.

src/base/net/http/HttpClient.cpp

@@ -119,7 +119,7 @@ void xmrig::HttpClient::handshake()
 
 void xmrig::HttpClient::read(const char *data, size_t size)
 {
-    if (parse(data, size) < size) {
+    if (!parse(data, size)) {
         close(UV_EPROTO);
     }
 }

src/base/net/http/HttpContext.cpp

@@ -118,13 +118,13 @@ bool xmrig::HttpContext::isRequest() const
 }
 
 
-size_t xmrig::HttpContext::parse(const char *data, size_t size)
+bool xmrig::HttpContext::parse(const char *data, size_t size)
 {
     if (size == 0) {
-        return size;
+        return true;
     }
 
-    return llhttp_execute(m_parser, data, size);
+    return llhttp_execute(m_parser, data, size) == HPE_OK;
 }
 
 

src/base/net/http/HttpContext.h

@@ -62,7 +62,7 @@ public:
     void write(std::string &&data, bool close) override;
 
     bool isRequest() const override;
-    size_t parse(const char *data, size_t size);
+    bool parse(const char *data, size_t size);
     std::string ip() const override;
     uint64_t elapsed() const;
     void close(int status = 0);

src/base/net/http/HttpServer.cpp

@@ -50,14 +50,7 @@ void xmrig::HttpServer::onConnection(uv_stream_t *stream, uint16_t)
         {
             auto ctx = static_cast<HttpContext*>(tcp->data);
 
-            if (nread >= 0) {
+            if (nread < 0 || !ctx->parse(buf->base, static_cast<size_t>(nread))) {
-                const auto size   = static_cast<size_t>(nread);
-                const auto parsed = ctx->parse(buf->base, size);
-
-                if (parsed < size) {
-                    ctx->close();
-                }
-            } else {
                 ctx->close();
             }
 

src/base/net/https/HttpsContext.cpp

@@ -74,7 +74,7 @@ bool xmrig::HttpsContext::write(BIO *bio)
 
 void xmrig::HttpsContext::parse(char *data, size_t size)
 {
-    if (HttpContext::parse(data, size) < size) {
+    if (!HttpContext::parse(data, size)) {
         close();
     }
 }