Ecosystem/stack_wallet
1
0
Fork 0
mirror of https://github.com/cypherstack/stack_wallet.git synced 2024-12-23 11:59:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

do not freeze notification tx change outputs

Browse source
This commit is contained in:
julian 2023-03-20 09:23:33 -06:00
parent f580a2af78
commit ea933e0474
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/services/coins/bitcoin/bitcoin_wallet.dart
View file

@ -1842,6 +1842,7 @@ class BitcoinWallet extends CoinServiceAPI
bool shouldBlock = false;
String? blockReason;
String? label;
if (storedTx?.subType ==
isar_models.TransactionSubType.bip47Notification) {
@ -1849,10 +1850,11 @@ class BitcoinWallet extends CoinServiceAPI
shouldBlock = true;
blockReason = "Incoming paynym notification transaction.";
} else if (storedTx?.type == isar_models.TransactionType.outgoing) {
shouldBlock = true;
shouldBlock = false;
blockReason = "Paynym notification change output. Incautious "
"handling of change outputs from notification transactions "
"may cause unintended loss of privacy.";
label = blockReason;
}
}
@ -1875,7 +1877,7 @@ class BitcoinWallet extends CoinServiceAPI
txid: txn["txid"] as String,
vout: vout,
value: jsonUTXO["value"] as int,
name: "",
name: label ?? "",
isBlocked: shouldBlock,
blockedReason: blockReason,
isCoinbase: txn["is_coinbase"] as bool? ?? false,

6
lib/services/coins/dogecoin/dogecoin_wallet.dart
View file

@ -1587,6 +1587,7 @@ class DogecoinWallet extends CoinServiceAPI
bool shouldBlock = false;
String? blockReason;
String? label;
if (storedTx?.subType ==
isar_models.TransactionSubType.bip47Notification) {
@ -1594,10 +1595,11 @@ class DogecoinWallet extends CoinServiceAPI
shouldBlock = true;
blockReason = "Incoming paynym notification transaction.";
} else if (storedTx?.type == isar_models.TransactionType.outgoing) {
shouldBlock = true;
shouldBlock = false;
blockReason = "Paynym notification change output. Incautious "
"handling of change outputs from notification transactions "
"may cause unintended loss of privacy.";
label = blockReason;
}
}
@ -1620,7 +1622,7 @@ class DogecoinWallet extends CoinServiceAPI
txid: txn["txid"] as String,
vout: vout,
value: jsonUTXO["value"] as int,
name: "",
name: label ?? "",
isBlocked: shouldBlock,
blockedReason: blockReason,
isCoinbase: txn["is_coinbase"] as bool? ?? false,