From c3054ca753d314ad5eab3752a76804a4e105d1ab Mon Sep 17 00:00:00 2001
From: julian <julian@cypherstack.com>
Date: Tue, 25 Jul 2023 20:28:27 -0600
Subject: [PATCH] fix broken used serials call and optimize cache a bit

---
 lib/electrumx_rpc/cached_electrumx.dart | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/lib/electrumx_rpc/cached_electrumx.dart b/lib/electrumx_rpc/cached_electrumx.dart
index 67f170bb4..91b7d1bc8 100644
--- a/lib/electrumx_rpc/cached_electrumx.dart
+++ b/lib/electrumx_rpc/cached_electrumx.dart
@@ -164,14 +164,16 @@ class CachedElectrumX {
 
       final _list = box.get("serials") as List?;
 
-      List<String> cachedSerials =
-          _list == null ? [] : List<String>.from(_list);
+      Set<String> cachedSerials =
+          _list == null ? {} : List<String>.from(_list).toSet();
 
-      final startNumber = cachedSerials.length;
+      // startNumber is broken currently
+      final startNumber = 0; // cachedSerials.length;
 
-      final serials =
-          await electrumXClient.getUsedCoinSerials(startNumber: startNumber);
-      List<String> newSerials = [];
+      final serials = await electrumXClient.getUsedCoinSerials(
+        startNumber: startNumber,
+      );
+      Set<String> newSerials = {};
 
       for (final element in (serials["serials"] as List)) {
         if (!isHexadecimal(element as String)) {
@@ -182,12 +184,14 @@ class CachedElectrumX {
       }
       cachedSerials.addAll(newSerials);
 
+      final resultingList = cachedSerials.toList();
+
       await box.put(
         "serials",
-        cachedSerials,
+        resultingList,
       );
 
-      return cachedSerials;
+      return resultingList;
     } catch (e, s) {
       Logging.instance.log(
           "Failed to process CachedElectrumX.getTransaction(): $e\n$s",