WIP: fix electrumx failovers, add some "default" firo nodes, and tweak firo pings

lib/electrumx_rpc/electrumx_client.dart

@@ -108,7 +108,7 @@ class ElectrumXClient {
   late Prefs _prefs;
   late TorService _torService;
 
-  List<ElectrumXNode>? failovers;
+  late final List<ElectrumXNode> _failovers;
   int currentFailoverIndex = -1;
 
   final Duration connectionTimeoutForSpecialCaseJsonRPCClients;
@@ -145,6 +145,7 @@ class ElectrumXClient {
     _host = host;
     _port = port;
     _useSSL = useSSL;
+    _failovers = failovers;
 
     final bus = globalEventBusForTesting ?? GlobalEventBus.instance;
 
@@ -284,9 +285,11 @@ class ElectrumXClient {
       usePort = port;
       useUseSSL = useSSL;
     } else {
-      useHost = failovers![currentFailoverIndex].address;
+      _electrumAdapterChannel = null;
-      usePort = failovers![currentFailoverIndex].port;
+      await ClientManager.sharedInstance.remove(cryptoCurrency: cryptoCurrency);
-      useUseSSL = failovers![currentFailoverIndex].useSSL;
+      useHost = _failovers[currentFailoverIndex].address;
+      usePort = _failovers[currentFailoverIndex].port;
+      useUseSSL = _failovers[currentFailoverIndex].useSSL;
     }
 
     _electrumAdapterChannel ??= await electrum_adapter.connect(
@@ -402,7 +405,7 @@ class ElectrumXClient {
         rethrow;
       }
     } catch (e) {
-      if (failovers != null && currentFailoverIndex < failovers!.length - 1) {
+      if (currentFailoverIndex < _failovers.length - 1) {
         currentFailoverIndex++;
         return request(
           command: command,
@@ -495,7 +498,7 @@ class ElectrumXClient {
         rethrow;
       }
     } catch (e) {
-      if (failovers != null && currentFailoverIndex < failovers!.length - 1) {
+      if (currentFailoverIndex < _failovers.length - 1) {
         currentFailoverIndex++;
         return batchRequest(
           command: command,

lib/services/node_service.dart

@@ -32,6 +32,49 @@ class NodeService extends ChangeNotifier {
   });
 
   Future<void> updateDefaults() async {
+    // hack
+    if (AppConfig.coins.where((e) => e.identifier == "firo").isNotEmpty) {
+      final others = [
+        "electrumx01.firo.org",
+        "electrumx02.firo.org",
+        "electrumx03.firo.org",
+        "electrumx.firo.org",
+      ];
+      const port = 50002;
+      const idPrefix = "not_a_real_default_but_temp";
+
+      for (final host in others) {
+        final _id = "${idPrefix}_$host";
+
+        NodeModel? node = DB.instance.get<NodeModel>(
+          boxName: DB.boxNameNodeModels,
+          key: _id,
+        );
+
+        if (node == null) {
+          node = NodeModel(
+            host: host,
+            port: port,
+            name: host,
+            id: _id,
+            useSSL: true,
+            enabled: true,
+            coinName: "firo",
+            isFailover: true,
+            isDown: false,
+            torEnabled: true,
+            clearnetEnabled: true,
+          );
+
+          await DB.instance.put<NodeModel>(
+            boxName: DB.boxNameNodeModels,
+            key: _id,
+            value: node,
+          );
+        }
+      }
+    }
+
     for (final defaultNode in AppConfig.coins.map(
       (e) => e.defaultNode,
     )) {

lib/wallets/wallet/wallet.dart

@@ -569,7 +569,9 @@ abstract class Wallet<T extends CryptoCurrency> {
     final start = DateTime.now();
 
     bool tAlive = true;
-    final t = Timer.periodic(const Duration(seconds: 1), (timer) async {
+    Timer? t;
+    if (this is! SparkInterface) {
+      t = Timer.periodic(const Duration(seconds: 1), (timer) async {
         if (tAlive) {
           final pingSuccess = await pingCheck();
           if (!pingSuccess) {
@@ -579,6 +581,7 @@ abstract class Wallet<T extends CryptoCurrency> {
           timer.cancel();
         }
       });
+    }
 
     void _checkAlive() {
       if (!tAlive) throw Exception("refresh alive ping failure");
@@ -717,13 +720,15 @@ abstract class Wallet<T extends CryptoCurrency> {
       _checkAlive();
       GlobalEventBus.instance.fire(RefreshPercentChangedEvent(1.0, walletId));
 
+      if (this is! SparkInterface) {
         tAlive = false; // interrupt timer as its not needed anymore
+      }
 
       completer.complete();
     } catch (error, strace) {
       completer.completeError(error, strace);
     } finally {
-      t.cancel();
+      t?.cancel();
       refreshMutex.release();
       if (!completer.isCompleted) {
         completer.completeError(

test/cached_electrumx_test.mocks.dart

@@ -90,15 +90,6 @@ class MockElectrumXClient extends _i1.Mock implements _i5.ElectrumXClient {
         ),
       ) as _i2.CryptoCurrency);
 
-  @override
-  set failovers(List<_i5.ElectrumXNode>? _failovers) => super.noSuchMethod(
-        Invocation.setter(
-          #failovers,
-          _failovers,
-        ),
-        returnValueForMissingStub: null,
-      );
-
   @override
   int get currentFailoverIndex => (super.noSuchMethod(
         Invocation.getter(#currentFailoverIndex),

test/services/coins/bitcoin/bitcoin_wallet_test.mocks.dart

@@ -87,15 +87,6 @@ class MockElectrumXClient extends _i1.Mock implements _i4.ElectrumXClient {
         ),
       ) as _i2.CryptoCurrency);
 
-  @override
-  set failovers(List<_i4.ElectrumXNode>? _failovers) => super.noSuchMethod(
-        Invocation.setter(
-          #failovers,
-          _failovers,
-        ),
-        returnValueForMissingStub: null,
-      );
-
   @override
   int get currentFailoverIndex => (super.noSuchMethod(
         Invocation.getter(#currentFailoverIndex),

test/services/coins/bitcoincash/bitcoincash_wallet_test.mocks.dart

@@ -87,15 +87,6 @@ class MockElectrumXClient extends _i1.Mock implements _i4.ElectrumXClient {
         ),
       ) as _i2.CryptoCurrency);
 
-  @override
-  set failovers(List<_i4.ElectrumXNode>? _failovers) => super.noSuchMethod(
-        Invocation.setter(
-          #failovers,
-          _failovers,
-        ),
-        returnValueForMissingStub: null,
-      );
-
   @override
   int get currentFailoverIndex => (super.noSuchMethod(
         Invocation.getter(#currentFailoverIndex),

test/services/coins/dogecoin/dogecoin_wallet_test.mocks.dart

@@ -87,15 +87,6 @@ class MockElectrumXClient extends _i1.Mock implements _i4.ElectrumXClient {
         ),
       ) as _i2.CryptoCurrency);
 
-  @override
-  set failovers(List<_i4.ElectrumXNode>? _failovers) => super.noSuchMethod(
-        Invocation.setter(
-          #failovers,
-          _failovers,
-        ),
-        returnValueForMissingStub: null,
-      );
-
   @override
   int get currentFailoverIndex => (super.noSuchMethod(
         Invocation.getter(#currentFailoverIndex),

test/services/coins/namecoin/namecoin_wallet_test.mocks.dart

@@ -87,15 +87,6 @@ class MockElectrumXClient extends _i1.Mock implements _i4.ElectrumXClient {
         ),
       ) as _i2.CryptoCurrency);
 
-  @override
-  set failovers(List<_i4.ElectrumXNode>? _failovers) => super.noSuchMethod(
-        Invocation.setter(
-          #failovers,
-          _failovers,
-        ),
-        returnValueForMissingStub: null,
-      );
-
   @override
   int get currentFailoverIndex => (super.noSuchMethod(
         Invocation.getter(#currentFailoverIndex),

test/services/coins/particl/particl_wallet_test.mocks.dart

@@ -87,15 +87,6 @@ class MockElectrumXClient extends _i1.Mock implements _i4.ElectrumXClient {
         ),
       ) as _i2.CryptoCurrency);
 
-  @override
-  set failovers(List<_i4.ElectrumXNode>? _failovers) => super.noSuchMethod(
-        Invocation.setter(
-          #failovers,
-          _failovers,
-        ),
-        returnValueForMissingStub: null,
-      );
-
   @override
   int get currentFailoverIndex => (super.noSuchMethod(
         Invocation.getter(#currentFailoverIndex),