bch tweaks

lib/wallets/crypto_currency/coins/bitcoincash.dart

@@ -28,6 +28,10 @@ class Bitcoincash extends Bip39HDCurrency {
   @override
   int get maxNumberOfIndexesToCheck => 10000000;
 
+  @override
+  // change this to change the number of confirms a tx needs in order to show as confirmed
+  int get minConfirms => 0; // bch zeroconf
+
   @override
   List<DerivePathType> get supportedDerivationPathTypes => [
         DerivePathType.bip44,
@@ -80,6 +84,23 @@ class Bitcoincash extends Bip39HDCurrency {
     }
   }
 
+  @override
+  String addressToScriptHash({required String address}) {
+    try {
+      if (bitbox.Address.detectFormat(address) ==
+              bitbox.Address.formatCashAddr &&
+          _validateCashAddr(address)) {
+        address = bitbox.Address.toLegacyAddress(address);
+      }
+
+      final addr = coinlib.Address.fromString(address, networkParams);
+      return Bip39HDCurrency.convertBytesToScriptHash(
+          addr.program.script.compiled);
+    } catch (e) {
+      rethrow;
+    }
+  }
+
   @override
   String constructDerivePath({
     required DerivePathType derivePathType,
@@ -143,10 +164,6 @@ class Bitcoincash extends Bip39HDCurrency {
     }
   }
 
-  @override
-  // change this to change the number of confirms a tx needs in order to show as confirmed
-  int get minConfirms => 0; // bch zeroconf
-
   // TODO: [prio=med] bch p2sh addresses (complaints regarding sending to)
   @override
   bool validateAddress(String address) {

lib/wallets/wallet/impl/bitcoincash_wallet.dart

@@ -28,11 +28,14 @@ class BitcoincashWallet extends Bip39HDWallet with ElectrumX {
         [
           ...standardChangeAddressFilters,
           FilterGroup.not(
-            const FilterCondition.startsWith(
+            const ObjectFilter(
               property: "derivationPath",
+              filter: FilterCondition.startsWith(
+                property: "value",
                 value: "m/44'/0'",
               ),
             ),
+          ),
         ],
       );
 
@@ -41,11 +44,14 @@ class BitcoincashWallet extends Bip39HDWallet with ElectrumX {
         [
           ...standardReceivingAddressFilters,
           FilterGroup.not(
-            const FilterCondition.startsWith(
+            const ObjectFilter(
               property: "derivationPath",
+              filter: FilterCondition.startsWith(
+                property: "value",
                 value: "m/44'/0'",
               ),
             ),
+          ),
         ],
       );