serai/coins/monero
Luke Parker b54548b13a
Only deserialize RctSignatures where's there at least one input
This is only enforced by the Monero protocol due to a single check the mixRing
isn't empty in get_pre_mlsag_hash. The value in ensuring there's a least one
input is to ensure the safety of our rct_type functions, which determines the
RctType based off structural analysis (specifically, input data if
MlsagBorromean).

rct_type was technically safe without this. A 0-input transaction would be
mis-classified as RctFull/MlsagAggregate, which would then make the
RctSignatures invalid for being RctFull (requiring exactly one input) yet not
having inputs, meaning an invalid RctSignatures would be mis-classified yet
still invalid.

This just removes the risk of mis-classification in the first place, tightening
the library's safety.
2023-07-09 00:44:23 -04:00
..
generators Monero: support for legacy transactions (#308) 2023-07-04 17:18:05 -04:00
src Only deserialize RctSignatures where's there at least one input 2023-07-09 00:44:23 -04:00
tests Meaningful changes from aggressive-clippy 2023-07-08 11:29:07 -04:00
build.rs Replace lazy_static with OnceLock inside monero-serai 2023-06-28 21:45:57 -04:00
Cargo.toml Add a bin to download a chain, over RPC, reserializing and hashing every item 2023-07-05 18:59:22 -04:00
LICENSE Update licenses 2023-01-11 23:05:31 -05:00
README.md Update Monero README 2023-03-31 07:02:57 -04:00

monero-serai

A modern Monero transaction library intended for usage in wallets. It prides itself on accuracy, correctness, and removing common pit falls developers may face.

monero-serai also offers the following features:

  • Featured Addresses
  • A FROST-based multisig orders of magnitude more performant than Monero's

Purpose and support

monero-serai was written for Serai, a decentralized exchange aiming to support Monero. Despite this, monero-serai is intended to be a widely usable library, accurate to Monero. monero-serai guarantees the functionality needed for Serai, yet will not deprive functionality from other users.

Various legacy transaction formats are not currently implemented, yet we are willing to add support for them. There aren't active development efforts around them however.

Caveats

This library DOES attempt to do the following:

  • Create on-chain transactions identical to how wallet2 would (unless told not to)
  • Not be detectable as monero-serai when scanning outputs
  • Not reveal spent outputs to the connected RPC node

This library DOES NOT attempt to do the following:

  • Have identical RPC behavior when creating transactions
  • Be a wallet

This means that monero-serai shouldn't be fingerprintable on-chain. It also shouldn't be fingerprintable if a targeted attack occurs to detect if the receiving wallet is monero-serai or wallet2. It also should be generally safe for usage with remote nodes.

It won't hide from remote nodes it's monero-serai however, potentially allowing a remote node to profile you. The implications of this are left to the user to consider.

It also won't act as a wallet, just as a transaction library. wallet2 has several non-transaction-level policies, such as always attempting to use two inputs to create transactions. These are considered out of scope to monero-serai.