Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-01-05 10:29:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Document usage of latest_decided in AuthorityDiscoveryApi

Browse source
This commit is contained in:
Luke Parker 2023-12-23 21:28:50 -05:00
parent 2b23252b4c
commit fff8dcb827
No known key found for this signature in database
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
substrate/runtime/src/lib.rs
View file

@ -579,6 +579,12 @@ sp_api::impl_runtime_apis! {
if network == NetworkId::Serai { if network == NetworkId::Serai {
continue; continue;
} }
// Returning the latest-decided, not latest and active, means the active set
// may fail to peer find if there isn't sufficient overlap. If a large amount reboot,
// forcing some validators to successfully peer find in order for the threshold to become
// online again, this may cause a liveness failure.
//
// This is assumed not to matter in real life, yet an interesting note.
let participants = let participants =
ValidatorSets::participants_for_latest_decided_set(network) ValidatorSets::participants_for_latest_decided_set(network)
.map_or(vec![], BoundedVec::into_inner); .map_or(vec![], BoundedVec::into_inner);