Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-02-02 03:06:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Document an accepted false positive

Browse source
This commit is contained in:
Luke Parker 2023-11-09 12:41:15 -05:00
parent ce4091695f
commit ec51fa233a
No known key found for this signature in database
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
processor/src/multisigs/mod.rs
View file

@ -728,6 +728,9 @@ impl<D: Db, N: Network> MultisigManager<D, N> {
running_operating_costs, running_operating_costs,
); );
// This will false positive on a transaction being refunded which meets these conditions
// That doesn't impact any of the following code at this time yet shows consideration
// is needed here in the future
let to_be_forwarded = { let to_be_forwarded = {
let output = &plan.inputs[0]; let output = &plan.inputs[0];
(step == RotationStep::ForwardFromExisting) && (step == RotationStep::ForwardFromExisting) &&
@ -749,7 +752,7 @@ impl<D: Db, N: Network> MultisigManager<D, N> {
// Restore running_operating_costs to operating_costs // Restore running_operating_costs to operating_costs
if to_be_forwarded { if to_be_forwarded {
// If we're forwarding this output, operating_costs should still be 0 // If we're forwarding (or refunding) this output, operating_costs should still be 0
// Either this TX wasn't created, causing no operating costs, or it was yet it'd be // Either this TX wasn't created, causing no operating costs, or it was yet it'd be
// amortized // amortized
assert_eq!(operating_costs, 0); assert_eq!(operating_costs, 0);