Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2024-12-23 03:59:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Use big endian throughout FROST

Browse source 
Slightly changes serialization of keys to be t-n-i instead of n-t-i.
This commit is contained in:
Luke Parker 2022-06-03 00:55:41 -04:00
parent dfd2f624ee
commit de9710413a
No known key found for this signature in database
GPG key ID: F9F1386DB1E119B6
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
crypto/frost/src/lib.rs
View file

@ -312,9 +312,9 @@ impl<C: Curve> MultisigKeys<C> {
); );
serialized.push(C::id_len()); serialized.push(C::id_len());
serialized.extend(C::id().as_bytes()); serialized.extend(C::id().as_bytes());
serialized.extend(&self.params.n.to_le_bytes()); serialized.extend(&self.params.t.to_be_bytes());
serialized.extend(&self.params.t.to_le_bytes()); serialized.extend(&self.params.n.to_be_bytes());
serialized.extend(&self.params.i.to_le_bytes()); serialized.extend(&self.params.i.to_be_bytes());
serialized.extend(&C::F_to_bytes(&self.secret_share)); serialized.extend(&C::F_to_bytes(&self.secret_share));
serialized.extend(&C::G_to_bytes(&self.group_key)); serialized.extend(&C::G_to_bytes(&self.group_key));
for l in 1 ..= self.params.n.into() { for l in 1 ..= self.params.n.into() {
@ -346,19 +346,20 @@ impl<C: Curve> MultisigKeys<C> {
} }
cursor += id_len; cursor += id_len;
if serialized.len() < (cursor + 8) { if serialized.len() < (cursor + 4) {
Err(FrostError::InternalError("participant quantity wasn't included".to_string()))?; Err(FrostError::InternalError("participant quantities weren't included".to_string()))?;
} }
let n = u16::from_le_bytes(serialized[cursor .. (cursor + 2)].try_into().unwrap()); let t = u16::from_be_bytes(serialized[cursor .. (cursor + 2)].try_into().unwrap());
cursor += 2;
let n = u16::from_be_bytes(serialized[cursor .. (cursor + 2)].try_into().unwrap());
cursor += 2; cursor += 2;
if serialized.len() != MultisigKeys::<C>::serialized_len(n) { if serialized.len() != MultisigKeys::<C>::serialized_len(n) {
Err(FrostError::InternalError("incorrect serialization length".to_string()))?; Err(FrostError::InternalError("incorrect serialization length".to_string()))?;
} }
let t = u16::from_le_bytes(serialized[cursor .. (cursor + 2)].try_into().unwrap()); let i = u16::from_be_bytes(serialized[cursor .. (cursor + 2)].try_into().unwrap());
cursor += 2;
let i = u16::from_le_bytes(serialized[cursor .. (cursor + 2)].try_into().unwrap());
cursor += 2; cursor += 2;
let secret_share = C::F_from_slice(&serialized[cursor .. (cursor + C::F_len())]) let secret_share = C::F_from_slice(&serialized[cursor .. (cursor + C::F_len())])