Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2024-12-23 03:59:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix the processor's Monero time monotonicity

Browse source 
Monero doesn't assert the time increases with each block, solely that it
doesn't decrease. Now, the block number is added to the time to ensure it
increases.
This commit is contained in:
Luke Parker 2023-11-25 04:07:31 -05:00
parent d60e007126
commit de14687a0d
No known key found for this signature in database
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
processor/src/networks/monero.rs
View file

@ -207,10 +207,12 @@ impl BlockTrait<Monero> for Block {
let b = timestamps[n]; let b = timestamps[n];
#[rustfmt::skip] // Enables Ctrl+F'ing for everything after the `= ` #[rustfmt::skip] // Enables Ctrl+F'ing for everything after the `= `
let res = (a/2) + (b/2) + ((a - 2*(a/2)) + (b - 2*(b/2)))/2; let res = (a/2) + (b/2) + ((a - 2*(a/2)) + (b - 2*(b/2)))/2;
// Techniaslly, res may be 1 if all prior blocks had a timestamp by 0, which would break // Technically, res may be 1 if all prior blocks had a timestamp by 0, which would break
// monotonicity with our above definition of height as time // monotonicity with our above definition of height as time
// Ensure monotonicity by increasing this value by the window size // Monero also solely requires the block's time not be less than the median, it doesn't ensure
res + BLOCKCHAIN_TIMESTAMP_CHECK_WINDOW // it advances the median forward
// Ensure monotonicity despite both these issues by adding the block number to the median time
res + u64::try_from(self.number()).unwrap()
} }
} }
@ -692,7 +694,7 @@ impl Network for Monero {
// https://github.com/serai-dex/serai/issues/198 // https://github.com/serai-dex/serai/issues/198
sleep(std::time::Duration::from_millis(100)).await; sleep(std::time::Duration::from_millis(100)).await;
#[derive(serde::Deserialize, Debug)] #[derive(Debug, serde::Deserialize)]
struct EmptyResponse {} struct EmptyResponse {}
let _: EmptyResponse = self let _: EmptyResponse = self
.rpc .rpc