Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2024-12-22 11:39:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

add missing prevotes (#590)
Some checks failed
Full Stack Tests / build (push) Waiting to run
Details
Lint / clippy (macos-14) (push) Waiting to run
Details
Lint / clippy (ubuntu-latest) (push) Waiting to run
Details
Lint / clippy (windows-latest) (push) Waiting to run
Details
Lint / deny (push) Waiting to run
Details
Lint / fmt (push) Waiting to run
Details
Lint / machete (push) Waiting to run
Details
Lint / clippy (macos-13) (push) Waiting to run
Details
Tests / test-infra (push) Waiting to run
Details
Tests / test-substrate (push) Waiting to run
Details
Tests / test-serai-client (push) Waiting to run
Details
Coordinator Tests / build (push) Has been cancelled
Details

Browse source 
* add missing prevotes

* remove the TODO

* add missing current step checks

---------

Co-authored-by: akildemir <aeg_asd@hotmail.com>
This commit is contained in:
akildemir 2024-08-14 22:00:48 +03:00 committed by GitHub
parent 3de1e4dee2
commit bf1c493d9a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
coordinator/tributary/tendermint/src/lib.rs
View file

@ -708,9 +708,17 @@ impl<N: Network + 'static> TendermintMachine<N> {
if let Data::Proposal(_, block) = &msg.data {
match self.network.validate(block).await {
Ok(()) => {}
Err(BlockError::Temporal) => return Err(TendermintError::Temporal),
Err(BlockError::Temporal) => {
if self.block.round().step == Step::Propose {
self.broadcast(Data::Prevote(None));
}
Err(TendermintError::Temporal)?;
}
Err(BlockError::Fatal) => {
log::warn!(target: "tendermint", "validator proposed a fatally invalid block");
if self.block.round().step == Step::Propose {
self.broadcast(Data::Prevote(None));
}
self
.slash(
msg.sender,
@ -729,6 +737,9 @@ impl<N: Network + 'static> TendermintMachine<N> {
target: "tendermint",
"proposed proposed with a syntactically invalid valid round",
);
if self.block.round().step == Step::Propose {
self.broadcast(Data::Prevote(None));
}
self
.slash(msg.sender, SlashEvent::WithEvidence(Evidence::InvalidValidRound(msg.encode())))
.await;