Lint a couple TODOs in the processor

This commit is contained in:
Luke Parker 2023-07-17 18:11:21 -04:00
parent acc9495429
commit a05961974a
No known key found for this signature in database

View file

@ -301,12 +301,11 @@ async fn handle_coordinator_msg<D: Db, C: Coin, Co: Coordinator>(
} }
// TODO: Shouldn't we create a txn here and pass it around as needed? // TODO: Shouldn't we create a txn here and pass it around as needed?
// The txn would ack this message ID. If we detect this mesage ID as handled in the DB, // The txn would ack this message ID. If we detect this message ID as handled in the DB,
// we'd move on here. Only after committing the TX would we report it as acked. // we'd move on here. Only after committing the TX would we report it as acked.
match msg.msg.clone() { match msg.msg.clone() {
CoordinatorMessage::KeyGen(msg) => { CoordinatorMessage::KeyGen(msg) => {
// TODO: This may be fired multiple times. What's our plan for that?
coordinator coordinator
.send(ProcessorMessage::KeyGen(tributary_mutable.key_gen.handle(txn, msg).await)) .send(ProcessorMessage::KeyGen(tributary_mutable.key_gen.handle(txn, msg).await))
.await; .await;
@ -393,6 +392,8 @@ async fn handle_coordinator_msg<D: Db, C: Coin, Co: Coordinator>(
key: key_vec, key: key_vec,
burns, burns,
} => { } => {
assert_eq!(network, C::NETWORK);
let mut block_id = <C::Block as Block<C>>::Id::default(); let mut block_id = <C::Block as Block<C>>::Id::default();
block_id.as_mut().copy_from_slice(&context.coin_latest_finalized_block.0); block_id.as_mut().copy_from_slice(&context.coin_latest_finalized_block.0);
@ -414,8 +415,7 @@ async fn handle_coordinator_msg<D: Db, C: Coin, Co: Coordinator>(
instruction: OutInstruction { address, data }, instruction: OutInstruction { address, data },
balance, balance,
} = out; } = out;
// TODO: Check network is this coin's network assert_eq!(balance.coin.network(), C::NETWORK);
assert_eq!(balance.coin.network(), network);
if let Ok(address) = C::Address::try_from(address.consume()) { if let Ok(address) = C::Address::try_from(address.consume()) {
// TODO: Add coin to payment // TODO: Add coin to payment