mirror of
https://github.com/serai-dex/serai.git
synced 2024-12-23 03:59:22 +00:00
Have included return a reference instead of a cloned Vec
This commit is contained in:
parent
2b042015b5
commit
9c65518dc3
3 changed files with 5 additions and 5 deletions
|
@ -229,7 +229,7 @@ impl Algorithm<Ed25519> for ClsagMultisig {
|
|||
&mut self.image,
|
||||
self.H,
|
||||
view.offset().0,
|
||||
&view.included(),
|
||||
view.included(),
|
||||
l,
|
||||
addendum.key_image.0,
|
||||
);
|
||||
|
|
|
@ -376,8 +376,8 @@ impl<C: Ciphersuite> ThresholdView<C> {
|
|||
self.group_key
|
||||
}
|
||||
|
||||
pub fn included(&self) -> Vec<u16> {
|
||||
self.included.clone()
|
||||
pub fn included(&self) -> &[u16] {
|
||||
&self.included
|
||||
}
|
||||
|
||||
pub fn secret_share(&self) -> &Zeroizing<C::F> {
|
||||
|
|
|
@ -461,7 +461,7 @@ impl<C: Curve, A: Algorithm<C>> SignatureMachine<A::Signature> for AlgorithmSign
|
|||
mut shares: HashMap<u16, SignatureShare<C>>,
|
||||
) -> Result<A::Signature, FrostError> {
|
||||
let params = self.params.multisig_params();
|
||||
validate_map(&shares, &self.view.included(), params.i())?;
|
||||
validate_map(&shares, self.view.included(), params.i())?;
|
||||
|
||||
let mut responses = HashMap::new();
|
||||
responses.insert(params.i(), self.share);
|
||||
|
@ -481,7 +481,7 @@ impl<C: Curve, A: Algorithm<C>> SignatureMachine<A::Signature> for AlgorithmSign
|
|||
// Find out who misbehaved
|
||||
// Randomly sorts the included participants to discover the answer on average within n/2 tries
|
||||
// If we didn't randomly sort them, it would be gameable to n by a malicious participant
|
||||
let mut rand_included = self.view.included();
|
||||
let mut rand_included = self.view.included().to_vec();
|
||||
// It is unfortunate we have to construct a ChaCha RNG here, yet it's due to the lack of a
|
||||
// provided RNG. Its hashing is cheaper than abused ECC ops
|
||||
rand_included.shuffle(&mut ChaCha8Rng::from_seed(self.blame_entropy));
|
||||
|
|
Loading…
Reference in a new issue