Consolidate FROST testing code

coins/monero/tests/clsag.rs

@@ -5,18 +5,10 @@ use curve25519_dalek::{constants::ED25519_BASEPOINT_TABLE, scalar::Scalar};
 
 use monero_serai::{random_scalar, Commitment, frost::MultisigError, key_image, clsag};
 
-#[cfg(feature = "multisig")]
-use ::frost::sign;
-
 #[cfg(feature = "multisig")]
 mod frost;
 #[cfg(feature = "multisig")]
-use crate::frost::generate_keys;
+use crate::frost::{THRESHOLD, PARTICIPANTS, generate_keys, sign};
-
-#[cfg(feature = "multisig")]
-const THRESHOLD: usize = 5;
-#[cfg(feature = "multisig")]
-const PARTICIPANTS: usize = 8;
 
 const RING_INDEX: u8 = 3;
 const RING_LEN: u64 = 11;
@@ -62,7 +54,7 @@ fn test_single() {
 #[cfg(feature = "multisig")]
 #[test]
 fn test_multisig() -> Result<(), MultisigError> {
-  let (keys, group_private) = generate_keys(THRESHOLD, PARTICIPANTS);
+  let (keys, group_private) = generate_keys();
   let t = keys[0].params().t();
 
   let mut images = vec![];
@@ -102,59 +94,26 @@ fn test_multisig() -> Result<(), MultisigError> {
     ring.push([&dest * &ED25519_BASEPOINT_TABLE, Commitment::new(mask, amount).calculate()]);
   }
 
-  let mut machines = vec![];
+  let mut algorithms = Vec::with_capacity(t);
-  let mut commitments = Vec::with_capacity(PARTICIPANTS + 1);
+  for _ in 1 ..= t {
-  commitments.resize(PARTICIPANTS + 1, None);
+    algorithms.push(
-  for i in 1 ..= t {
-    machines.push(
-      sign::StateMachine::new(
-        sign::Params::new(
       clsag::Multisig::new(
         &mut ChaCha12Rng::seed_from_u64(1),
         msg,
         clsag::Input::new(image, ring.clone(), RING_INDEX, Commitment::new(randomness, AMOUNT)).unwrap()
-          ).unwrap(),
-          keys[i - 1].clone(),
-          &(1 ..= t).collect::<Vec<usize>>()
-        ).unwrap()
-      )
-    );
-    commitments[i] = Some(machines[i - 1].preprocess(&mut OsRng).unwrap());
-  }
-
-  let mut shares = Vec::with_capacity(PARTICIPANTS + 1);
-  shares.resize(PARTICIPANTS + 1, None);
-  for i in 1 ..= t {
-    shares[i] = Some(
-      machines[i - 1].sign(
-        &commitments
-          .iter()
-          .enumerate()
-          .map(|(idx, value)| if idx == i { None } else { value.to_owned() })
-          .collect::<Vec<Option<Vec<u8>>>>(),
-        &vec![]
       ).unwrap()
     );
   }
 
-  let mut signature = None;
+  let mut signatures = sign(algorithms, keys);
-  for i in 1 ..= t {
+  let signature = signatures.swap_remove(0);
-    // Multisig does call verify to ensure integrity upon complete, before checking individual key
+  for s in 0 .. (t - 1) {
-    // shares. For FROST Schnorr, it's cheaper. For CLSAG, it may be more expensive? Yet it ensures
+    // Verify the commitments and the non-decoy s scalar are identical to every other signature
-    // we have usable signatures, not just signatures we think are usable
+    // FROST will already have called verify on the produced signature, before checking individual
-    let sig = machines[i - 1].complete(
+    // key shares. For FROST Schnorr, it's cheaper. For CLSAG, it may be more expensive? Yet it
-      &shares
+    // ensures we have usable signatures, not just signatures we think are usable
-        .iter()
+    assert_eq!(signatures[s].1, signature.1);
-        .enumerate()
+    assert_eq!(signatures[s].0.s[RING_INDEX as usize], signature.0.s[RING_INDEX as usize]);
-        .map(|(idx, value)| if idx == i { None } else { value.to_owned() })
-        .collect::<Vec<Option<Vec<u8>>>>()
-    ).unwrap();
-    if signature.is_none() {
-      signature = Some(sig.clone());
-    }
-    // Check the commitment out and the non-decoy s scalar are identical to every other signature
-    assert_eq!(sig.1, signature.as_ref().unwrap().1);
-    assert_eq!(sig.0.s[RING_INDEX as usize], signature.as_ref().unwrap().0.s[RING_INDEX as usize]);
   }
 
   Ok(())

coins/monero/tests/frost.rs

@@ -9,19 +9,21 @@ use dalek_ff_group::{ED25519_BASEPOINT_TABLE, Scalar};
 
 use frost::{
   MultisigParams, MultisigKeys,
-  key_gen,
+  key_gen, algorithm::Algorithm, sign::{self, lagrange}
-  sign::lagrange
 };
 
 use monero_serai::frost::Ed25519;
 
-pub fn generate_keys(t: usize, n: usize) -> (Vec<Rc<MultisigKeys<Ed25519>>>, Scalar) {
+pub const THRESHOLD: usize = 5;
+pub const PARTICIPANTS: usize = 8;
+
+pub fn generate_keys() -> (Vec<Rc<MultisigKeys<Ed25519>>>, Scalar) {
   let mut params = vec![];
   let mut machines = vec![];
   let mut commitments = vec![vec![]];
-  for i in 1 ..= n {
+  for i in 1 ..= PARTICIPANTS {
     params.push(
-      MultisigParams::new(t, n, i).unwrap()
+      MultisigParams::new(THRESHOLD, PARTICIPANTS, i).unwrap()
     );
     machines.push(
       key_gen::StateMachine::<Ed25519>::new(
@@ -33,7 +35,7 @@ pub fn generate_keys(t: usize, n: usize) -> (Vec<Rc<MultisigKeys<Ed25519>>>, Sca
   }
 
   let mut secret_shares = vec![];
-  for i in 1 ..= n {
+  for i in 1 ..= PARTICIPANTS {
     secret_shares.push(
       machines[i - 1].generate_secret_shares(
         &mut OsRng,
@@ -47,7 +49,7 @@ pub fn generate_keys(t: usize, n: usize) -> (Vec<Rc<MultisigKeys<Ed25519>>>, Sca
   }
 
   let mut keys = vec![];
-  for i in 1 ..= n {
+  for i in 1 ..= PARTICIPANTS {
     let mut our_secret_shares = vec![vec![]];
     our_secret_shares.extend(
       secret_shares.iter().map(|shares| shares[i].clone()).collect::<Vec<Vec<u8>>>()
@@ -56,10 +58,67 @@ pub fn generate_keys(t: usize, n: usize) -> (Vec<Rc<MultisigKeys<Ed25519>>>, Sca
   }
 
   let mut group_private = Scalar::zero();
-  for i in 0 .. t {
+  for i in 1 ..= THRESHOLD {
-    group_private += keys[i].secret_share() * lagrange::<Scalar>(i + 1, &(1 ..= t).collect::<Vec<usize>>());
+    group_private += keys[i - 1].secret_share() * lagrange::<Scalar>(
+      i,
+      &(1 ..= THRESHOLD).collect::<Vec<usize>>()
+    );
   }
   assert_eq!(&ED25519_BASEPOINT_TABLE * group_private, keys[0].group_key());
 
   (keys, group_private)
 }
+
+#[allow(dead_code)] // Currently has some false positive
+pub fn sign<S, A: Algorithm<Ed25519, Signature = S>>(
+  algorithms: Vec<A>,
+  keys: Vec<Rc<MultisigKeys<Ed25519>>>
+) -> Vec<S> {
+  assert!(algorithms.len() >= THRESHOLD);
+  assert!(keys.len() >= algorithms.len());
+
+  let mut machines = vec![];
+  let mut commitments = Vec::with_capacity(PARTICIPANTS + 1);
+  commitments.resize(PARTICIPANTS + 1, None);
+  for i in 1 ..= THRESHOLD {
+    machines.push(
+      sign::StateMachine::new(
+        sign::Params::new(
+          algorithms[i - 1].clone(),
+          keys[i - 1].clone(),
+          &(1 ..= THRESHOLD).collect::<Vec<usize>>()
+        ).unwrap()
+      )
+    );
+    commitments[i] = Some(machines[i - 1].preprocess(&mut OsRng).unwrap());
+  }
+
+  let mut shares = Vec::with_capacity(PARTICIPANTS + 1);
+  shares.resize(PARTICIPANTS + 1, None);
+  for i in 1 ..= THRESHOLD {
+    shares[i] = Some(
+      machines[i - 1].sign(
+        &commitments
+          .iter()
+          .enumerate()
+          .map(|(idx, value)| if idx == i { None } else { value.to_owned() })
+          .collect::<Vec<Option<Vec<u8>>>>(),
+        &vec![]
+      ).unwrap()
+    );
+  }
+
+  let mut res = Vec::with_capacity(THRESHOLD);
+  for i in 1 ..= THRESHOLD {
+    res.push(
+      machines[i - 1].complete(
+        &shares
+          .iter()
+          .enumerate()
+          .map(|(idx, value)| if idx == i { None } else { value.to_owned() })
+          .collect::<Vec<Option<Vec<u8>>>>()
+      ).unwrap()
+    );
+  }
+  res
+}

coins/monero/tests/key_image.rs

@@ -1,20 +1,25 @@
 #![cfg(feature = "multisig")]
 
-use rand::rngs::OsRng;
+use rand::{RngCore, rngs::OsRng};
 
 use monero_serai::{frost::MultisigError, key_image};
 
 mod frost;
-use crate::frost::generate_keys;
+use crate::frost::{THRESHOLD, PARTICIPANTS, generate_keys};
 
 #[test]
 fn test() -> Result<(), MultisigError> {
-  let (keys, group_private) = generate_keys(3, 5);
+  let (keys, group_private) = generate_keys();
   let image = key_image::generate(&group_private);
 
+  let mut included = (1 ..= PARTICIPANTS).into_iter().collect::<Vec<usize>>();
+  while included.len() > THRESHOLD {
+    included.swap_remove((OsRng.next_u64() as usize) % included.len());
+  }
+  included.sort();
+
   let mut packages = vec![];
-  packages.resize(5 + 1, None);
+  packages.resize(PARTICIPANTS + 1, None);
-  let included = vec![1, 3, 4];
   for i in &included {
     let i = *i;
     packages[i] = Some(