Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-01-03 17:40:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Comment the previous commit

Browse source 
Despite the intentions of https://github.com/serai-dex/serai/issues/85, 
it failed to be practically faster :/

Updates a DLEq test to be better as well.
This commit is contained in:
Luke Parker 2022-08-13 19:43:18 -04:00
parent 062cd77a98
commit 75c3cdc5af
No known key found for this signature in database
GPG key ID: F9F1386DB1E119B6
2 changed files with 21 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crypto/dleq/src/tests/cross_group/schnorr.rs
View file

@ -16,10 +16,11 @@ fn test_schnorr<G: PrimeGroup + Zeroize>()
where
G::Scalar: PrimeFieldBits + Zeroize,
{
let private = G::Scalar::random(&mut OsRng);
let transcript = RecommendedTranscript::new(b"Schnorr Test");
let mut batch = BatchVerifier::new(3);
let mut batch = BatchVerifier::new(10);
for _ in 0 .. 10 {
let private = G::Scalar::random(&mut OsRng);
SchnorrPoK::prove(&mut OsRng, &mut transcript.clone(), G::generator(), private).verify(
&mut OsRng,
&mut transcript.clone(),
@ -27,6 +28,8 @@ where
G::generator() * private,
&mut batch,
);
}
assert!(batch.verify_vartime());
}

9
crypto/multiexp/src/batch.rs
View file

@ -2,7 +2,7 @@ use rand_core::{RngCore, CryptoRng};
use zeroize::Zeroize;
use ff::{Field, PrimeField, PrimeFieldBits};
use ff::{Field, PrimeFieldBits};
use group::Group;
use crate::{multiexp, multiexp_vartime};
@ -32,6 +32,12 @@ where
} else {
let mut weight;
while {
// Generate a random scalar
weight = G::Scalar::random(&mut *rng);
// Clears half the bits, maintaining security, to minimize scalar additions
// Is not practically faster for whatever reason
/*
// Generate a random scalar
let mut repr = G::Scalar::random(&mut *rng).to_repr();
@ -55,6 +61,7 @@ where
repr.as_mut().reverse();
weight = G::Scalar::from_repr(repr).unwrap();
}
*/
// Ensure it's non-zero, as a zero scalar would cause this item to pass no matter what
weight.is_zero().into()