Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-01-12 22:04:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add note to signers on reducing disk IO

Browse source
This commit is contained in:
Luke Parker 2024-09-11 06:39:44 -04:00
parent 4054e44471
commit 73af09effb
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
processor/signers/src/db.rs
View file

@ -22,6 +22,19 @@ db_channel! {
SlashReport: (session: Session) -> Vec<Slash>, SlashReport: (session: Session) -> Vec<Slash>,
SlashReportSignature: (session: Session) -> Vec<u8>, SlashReportSignature: (session: Session) -> Vec<u8>,
/*
TODO: Most of these are pointless? We drop all active signing sessions on reboot. It's
accordingly not valuable to use a DB-backed channel to communicate messages for signing
sessions (Preprocess/Shares).
Transactions, Batches, Slash Reports, and Cosigns all have their own mechanisms/DB entries
and don't use the following channels. The only questions are:
1) If it's safe to drop Reattempt? Or if we need tweaks to enable that
2) If we reboot with a pending Reattempt, we'll participate on reboot. If we drop that
Reattempt, we won't. Accordingly, we have degraded performance in that edge case in
exchange for less disk IO in the majority of cases. Is that work it?
*/
CoordinatorToCosignerMessages: (session: Session) -> CoordinatorMessage, CoordinatorToCosignerMessages: (session: Session) -> CoordinatorMessage,
CosignerToCoordinatorMessages: (session: Session) -> ProcessorMessage, CosignerToCoordinatorMessages: (session: Session) -> ProcessorMessage,