Latest clippy

coins/monero/src/bin/reserialize_chain.rs

@@ -95,7 +95,7 @@ async fn check_block(rpc: Arc<Rpc<HttpRpc>>, block_i: usize) {
     }
 
     let mut batch = BatchVerifier::new(block.txs.len());
-    for (tx_hash, tx_res) in block.txs.into_iter().zip(all_txs.into_iter()) {
+    for (tx_hash, tx_res) in block.txs.into_iter().zip(all_txs) {
       assert_eq!(
         tx_res.tx_hash,
         hex::encode(tx_hash),

coins/monero/src/ringct/bulletproofs/scalar_vector.rs

@@ -12,6 +12,7 @@ use multiexp::multiexp;
 pub(crate) struct ScalarVector(pub(crate) Vec<Scalar>);
 macro_rules! math_op {
   ($Op: ident, $op: ident, $f: expr) => {
+    #[allow(clippy::redundant_closure_call)]
     impl $Op<Scalar> for ScalarVector {
       type Output = ScalarVector;
       fn $op(self, b: Scalar) -> ScalarVector {
@@ -19,6 +20,7 @@ macro_rules! math_op {
       }
     }
 
+    #[allow(clippy::redundant_closure_call)]
     impl $Op<Scalar> for &ScalarVector {
       type Output = ScalarVector;
       fn $op(self, b: Scalar) -> ScalarVector {
@@ -26,6 +28,7 @@ macro_rules! math_op {
       }
     }
 
+    #[allow(clippy::redundant_closure_call)]
     impl $Op<ScalarVector> for ScalarVector {
       type Output = ScalarVector;
       fn $op(self, b: ScalarVector) -> ScalarVector {
@@ -34,6 +37,7 @@ macro_rules! math_op {
       }
     }
 
+    #[allow(clippy::redundant_closure_call)]
     impl $Op<&ScalarVector> for &ScalarVector {
       type Output = ScalarVector;
       fn $op(self, b: &ScalarVector) -> ScalarVector {

coins/monero/tests/send.rs

@@ -34,7 +34,7 @@ async fn add_inputs(
   .await
   .unwrap();
 
-  let inputs = spendable_outputs.into_iter().zip(decoys.into_iter()).collect::<Vec<_>>();
+  let inputs = spendable_outputs.into_iter().zip(decoys).collect::<Vec<_>>();
 
   builder.add_inputs(&inputs);
 }

coordinator/src/substrate/mod.rs

@@ -84,8 +84,7 @@ async fn handle_new_set<
   Ok(())
 }
 
-async fn handle_key_gen<D: Db, Pro: Processors>(
+async fn handle_key_gen<Pro: Processors>(
-  db: &mut D,
   key: &Zeroizing<<Ristretto as Ciphersuite>::F>,
   processors: &Pro,
   serai: &Serai,
@@ -215,6 +214,7 @@ async fn handle_batch_and_burns<Pro: Processors>(
 
 // Handle a specific Substrate block, returning an error when it fails to get data
 // (not blocking / holding)
+#[allow(clippy::needless_pass_by_ref_mut)] // False positive?
 async fn handle_block<
   D: Db,
   Fut: Future<Output = ()>,
@@ -265,7 +265,7 @@ async fn handle_block<
   for key_gen in serai.get_key_gen_events(hash).await? {
     if !SubstrateDb::<D>::handled_event(&db.0, hash, event_id) {
       if let ValidatorSetsEvent::KeyGen { set, key_pair } = key_gen {
-        handle_key_gen(&mut db.0, key, processors, serai, &block, set, key_pair).await?;
+        handle_key_gen(key, processors, serai, &block, set, key_pair).await?;
       } else {
         panic!("KeyGen event wasn't KeyGen: {key_gen:?}");
       }

coordinator/src/tributary/scanner.rs

@@ -30,6 +30,7 @@ pub enum RecognizedIdType {
 }
 
 // Handle a specific Tributary block
+#[allow(clippy::needless_pass_by_ref_mut)] // False positive?
 async fn handle_block<D: Db, Pro: Processors>(
   db: &mut TributaryDb<D>,
   key: &Zeroizing<<Ristretto as Ciphersuite>::F>,

crypto/dalek-ff-group/src/lib.rs

@@ -2,6 +2,8 @@
 #![no_std] // Prevents writing new code, in what should be a simple wrapper, which requires std
 #![doc = include_str!("../README.md")]
 
+#![allow(clippy::redundant_closure_call)]
+
 use core::{
   borrow::Borrow,
   ops::{Deref, Add, AddAssign, Sub, SubAssign, Neg, Mul, MulAssign},

crypto/ed448/src/lib.rs

@@ -2,6 +2,8 @@
 #![doc = include_str!("../README.md")]
 #![no_std]
 
+#![allow(clippy::redundant_closure_call)]
+
 #[macro_use]
 mod backend;
 

crypto/frost/src/nonce.rs

@@ -255,7 +255,7 @@ impl<C: Curve> BindingFactor<C> {
     self.0.insert(i, IndividualBinding { commitments, binding_factors: None });
   }
 
-  pub(crate) fn calculate_binding_factors<T: Clone + Transcript>(&mut self, transcript: &mut T) {
+  pub(crate) fn calculate_binding_factors<T: Clone + Transcript>(&mut self, transcript: &T) {
     for (l, binding) in self.0.iter_mut() {
       let mut transcript = transcript.clone();
       transcript.append_message(b"participant", C::F::from(u64::from(u16::from(*l))).to_repr());

crypto/frost/src/sign.rs

@@ -388,7 +388,7 @@ impl<C: Curve, A: Algorithm<C>> SignMachine<A::Signature> for AlgorithmSignMachi
       );
 
       // Generate the per-signer binding factors
-      B.calculate_binding_factors(&mut rho_transcript);
+      B.calculate_binding_factors(&rho_transcript);
 
       // Merge the rho transcript back into the global one to ensure its advanced, while
       // simultaneously committing to everything

crypto/transcript/src/lib.rs

@@ -159,7 +159,7 @@ where
     // Attempt to get them marked as read
 
     #[rustversion::since(1.66)]
-    fn mark_read<D: Send + Clone + SecureDigest>(transcript: &mut DigestTranscript<D>) {
+    fn mark_read<D: Send + Clone + SecureDigest>(transcript: &DigestTranscript<D>) {
       // Just get a challenge from the state
       let mut challenge = core::hint::black_box(transcript.0.clone().finalize());
       challenge.as_mut().zeroize();

processor/src/networks/bitcoin.rs

@@ -410,7 +410,7 @@ impl Network for Bitcoin {
     }
 
     let this_block_hash = block.id();
-    let this_block_num = (|| async {
+    let this_block_num = (async {
       loop {
         match self.rpc.get_block_number(&this_block_hash).await {
           Ok(number) => return number,
@@ -420,8 +420,7 @@ impl Network for Bitcoin {
         }
         sleep(Duration::from_secs(60)).await;
       }
-    })()
+    }).await;
-    .await;
 
     for block_num in (eventualities.block_number + 1) .. this_block_num {
       let block = {

processor/src/networks/monero.rs

@@ -419,7 +419,7 @@ impl Network for Monero {
     .map_err(|_| NetworkError::ConnectionError)
     .unwrap();
 
-    let inputs = spendable_outputs.into_iter().zip(decoys.into_iter()).collect::<Vec<_>>();
+    let inputs = spendable_outputs.into_iter().zip(decoys).collect::<Vec<_>>();
 
     let signable = |mut plan: Plan<Self>, tx_fee: Option<_>| {
       // Monero requires at least two outputs
@@ -617,7 +617,7 @@ impl Network for Monero {
     .await
     .unwrap();
 
-    let inputs = outputs.into_iter().zip(decoys.into_iter()).collect::<Vec<_>>();
+    let inputs = outputs.into_iter().zip(decoys).collect::<Vec<_>>();
 
     let tx = MSignableTransaction::new(
       protocol,