From 43ae6794db6b8a395073b1735e738144ea348346 Mon Sep 17 00:00:00 2001 From: Luke Parker Date: Thu, 9 Nov 2023 03:46:47 -0500 Subject: [PATCH] Remove invalid TODOs from processor signers --- processor/src/signer.rs | 4 ---- processor/src/substrate_signer.rs | 8 -------- 2 files changed, 12 deletions(-) diff --git a/processor/src/signer.rs b/processor/src/signer.rs index d2bf6391..adb59062 100644 --- a/processor/src/signer.rs +++ b/processor/src/signer.rs @@ -428,10 +428,6 @@ impl Signer { Ok(machine) => machine, }; - // TODO: Use a seeded RNG here so we don't produce distinct messages with the same intent - // This is also needed so we don't preprocess, send preprocess, reboot before ack'ing the - // message, send distinct preprocess, and then attempt a signing session premised on the - // former with the latter let (machine, preprocess) = machine.preprocess(&mut OsRng); machines.push(machine); serialized_preprocesses.push(preprocess.serialize()); diff --git a/processor/src/substrate_signer.rs b/processor/src/substrate_signer.rs index d64bfe3a..baa154c9 100644 --- a/processor/src/substrate_signer.rs +++ b/processor/src/substrate_signer.rs @@ -209,10 +209,6 @@ impl SubstrateSigner { // b"substrate" is a literal from sp-core let machine = AlgorithmMachine::new(Schnorrkel::new(b"substrate"), keys.clone()); - // TODO: Use a seeded RNG here so we don't produce distinct messages with the same intent - // This is also needed so we don't preprocess, send preprocess, reboot before ack'ing the - // message, send distinct preprocess, and then attempt a signing session premised on the - // former with the latter let (machine, preprocess) = machine.preprocess(&mut OsRng); machines.push(machine); serialized_preprocesses.push(preprocess.serialize()); @@ -389,10 +385,6 @@ impl SubstrateSigner { } pub fn batch_signed(&mut self, txn: &mut D::Transaction<'_>, id: u32) { - // Safe since SubstrateSigner won't be told of the completion until the Scanner recognizes the - // block behind it, which will trigger starting the Batch - // TODO: There is a race condition between the Scanner recognizing the block and the Batch - // having signing started let sign_id = batch_sign_id(self.network, id); // Stop trying to sign for this batch