From 3c5a82e915980f226453aab3e567db8ab7b77b2f Mon Sep 17 00:00:00 2001 From: j-berman Date: Thu, 4 Jan 2024 21:18:51 -0800 Subject: [PATCH] monero: investigated TODO and can remove it The behavior appears to match monero core. monero core isn't throwing an exception in the linked code, it's returning boost::none (and logging an error) which is the same functional behavior as finding that the output does not belong to the user. --- coins/monero/src/wallet/scan.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/coins/monero/src/wallet/scan.rs b/coins/monero/src/wallet/scan.rs index db8a2ae5..df73cb8a 100644 --- a/coins/monero/src/wallet/scan.rs +++ b/coins/monero/src/wallet/scan.rs @@ -363,7 +363,6 @@ impl Scanner { // https://github.com/monero-project/monero/ // blob/04a1e2875d6e35e27bb21497988a6c822d319c28/ // src/cryptonote_basic/cryptonote_format_utils.cpp#L1062 - // TODO: Should this return? Where does Monero set the trap handler for this exception? continue; } None => {