Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-04-22 22:18:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions1

Use clearer identity check in equality

Browse source
This commit is contained in:
Luke Parker 2025-01-30 00:13:55 -05:00
parent 315d4fb356
commit 3655dc723f
No known key found for this signature in database
2 changed files with 4 additions and 2 deletions
crypto/evrf
embedwards25519/src
point.rs
secq256k1/src
point.rs

3
crypto/evrf/embedwards25519/src/point.rs
View file

@ -46,7 +46,8 @@ impl ConstantTimeEq for Point {
let y1 = self.y * other.z;
let y2 = other.y * self.z;
(self.x.is_zero() & other.x.is_zero()) | (x1.ct_eq(&x2) & y1.ct_eq(&y2))
// Both identity or equivalent over their denominators
(self.z.is_zero() & other.z.is_zero()) | (x1.ct_eq(&x2) & y1.ct_eq(&y2))
}
}

3
crypto/evrf/secq256k1/src/point.rs
View file

@ -40,7 +40,8 @@ impl ConstantTimeEq for Point {
let y1 = self.y * other.z;
let y2 = other.y * self.z;
(self.x.is_zero() & other.x.is_zero()) | (x1.ct_eq(&x2) & y1.ct_eq(&y2))
// Identity or equivalent
(self.z.is_zero() & other.z.is_zero()) | (x1.ct_eq(&x2) & y1.ct_eq(&y2))
}
}