Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-03-24 08:08:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

3.8.1 Document RFC 8032 compatibility

Browse source
This commit is contained in:
Luke Parker 2023-03-02 08:45:09 -05:00
parent 1d2ebdca62
commit 35043d2889
No known key found for this signature in database
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crypto/schnorr/src/lib.rs
View file

@ -20,6 +20,13 @@ pub mod aggregate;
mod tests; mod tests;
/// A Schnorr signature of the form (R, s) where s = r + cx. /// A Schnorr signature of the form (R, s) where s = r + cx.
///
/// These are intended to be strict. It is generic over Ciphersuite which is for PrimeGroups,
/// and mandates canonical encodings in its read function.
///
/// RFC 8032 has an alternative verification formula, 8R = 8s - 8cX, which is intended to handle
/// torsioned nonces/public keys. Due to this library's strict requirements, such signatures will
/// not be verifiable with this library.
#[allow(non_snake_case)] #[allow(non_snake_case)]
#[derive(Clone, Copy, PartialEq, Eq, Debug, Zeroize)] #[derive(Clone, Copy, PartialEq, Eq, Debug, Zeroize)]
pub struct SchnorrSignature<C: Ciphersuite> { pub struct SchnorrSignature<C: Ciphersuite> {

4
crypto/schnorr/src/tests.rs
View file

@ -54,7 +54,7 @@ pub(crate) fn batch_verify<C: Ciphersuite>() {
for (i, sig) in sigs.iter().enumerate() { for (i, sig) in sigs.iter().enumerate() {
sig.batch_verify(&mut OsRng, &mut batch, i, C::generator() * keys[i].deref(), challenges[i]); sig.batch_verify(&mut OsRng, &mut batch, i, C::generator() * keys[i].deref(), challenges[i]);
} }
batch.verify_with_vartime_blame().unwrap(); batch.verify_vartime_with_vartime_blame().unwrap();
} }
// Shift 1 from s from one to another and verify it fails // Shift 1 from s from one to another and verify it fails
@ -70,7 +70,7 @@ pub(crate) fn batch_verify<C: Ciphersuite>() {
} }
sig.batch_verify(&mut OsRng, &mut batch, i, C::generator() * keys[i].deref(), challenges[i]); sig.batch_verify(&mut OsRng, &mut batch, i, C::generator() * keys[i].deref(), challenges[i]);
} }
if let Err(blame) = batch.verify_with_vartime_blame() { if let Err(blame) = batch.verify_vartime_with_vartime_blame() {
assert!((blame == 1) || (blame == 2)); assert!((blame == 1) || (blame == 2));
} else { } else {
panic!("Batch verification considered malleated signatures valid"); panic!("Batch verification considered malleated signatures valid");